[GitHub] codecov-io commented on issue #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470

2018-05-16 Thread GitBox
codecov-io commented on issue #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470 URL: https://github.com/apache/incubator-dubbo/pull/1808#issuecomment-389414180 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1808?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #1809: [Dubbo-1684] add unit test for dubbo spring config

2018-05-16 Thread GitBox
codecov-io commented on issue #1809: [Dubbo-1684] add unit test for dubbo spring config URL: https://github.com/apache/incubator-dubbo/pull/1809#issuecomment-389455105 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1809?src=pr=h1) Report > Merging

[GitHub] codecov-io commented on issue #1810: [Dubbo-199] Remove duplicate call to setProvider/setConsumer. #199

2018-05-16 Thread GitBox
codecov-io commented on issue #1810: [Dubbo-199] Remove duplicate call to setProvider/setConsumer. #199 URL: https://github.com/apache/incubator-dubbo/pull/1810#issuecomment-389458117 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1810?src=pr=h1) Report > Merging

[GitHub] ralf0131 closed issue #200: ScriptRouter脚本路由规则执行存在问题

2018-05-16 Thread GitBox
ralf0131 closed issue #200: ScriptRouter脚本路由规则执行存在问题 URL: https://github.com/apache/incubator-dubbo/issues/200 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] ralf0131 closed issue #201: dubbo provider和consumer传输对象用什么协议比较好,需要序列化吗

2018-05-16 Thread GitBox
ralf0131 closed issue #201: dubbo provider和consumer传输对象用什么协议比较好,需要序列化吗 URL: https://github.com/apache/incubator-dubbo/issues/201 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] ralf0131 commented on issue #189: dubbo-admin启动报错

2018-05-16 Thread GitBox
ralf0131 commented on issue #189: dubbo-admin启动报错 URL: https://github.com/apache/incubator-dubbo/issues/189#issuecomment-389445400 This is because you compiled the code under Java 8 but run it under Java 7 or lower. This is

[GitHub] ralf0131 closed issue #210: dubbo调用报错HessianFieldException

2018-05-16 Thread GitBox
ralf0131 closed issue #210: dubbo调用报错HessianFieldException URL: https://github.com/apache/incubator-dubbo/issues/210 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] ralf0131 closed issue #179: 你好,有关nodejs调用dubbo服务的问题

2018-05-16 Thread GitBox
ralf0131 closed issue #179: 你好,有关nodejs调用dubbo服务的问题 URL: https://github.com/apache/incubator-dubbo/issues/179 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] ralf0131 commented on issue #179: 你好,有关nodejs调用dubbo服务的问题

2018-05-16 Thread GitBox
ralf0131 commented on issue #179: 你好,有关nodejs调用dubbo服务的问题 URL: https://github.com/apache/incubator-dubbo/issues/179#issuecomment-389444649 Please check out this awesome project: https://github.com/dubbo/dubbo2.js This is an

[GitHub] YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service

2018-05-16 Thread GitBox
YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service URL: https://github.com/apache/incubator-dubbo/issues/1624#issuecomment-389413272 But that is not a fully solution, I just resolved the group problem not the version. In my onion, we should a

[GitHub] ralf0131 closed issue #206: 使用注解定义Service,结果自定义的Aop用不了,根本启动不起来,怎么搞?

2018-05-16 Thread GitBox
ralf0131 closed issue #206: 使用注解定义Service,结果自定义的Aop用不了,根本启动不起来,怎么搞? URL: https://github.com/apache/incubator-dubbo/issues/206 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ralf0131 closed issue #189: dubbo-admin启动报错

2018-05-16 Thread GitBox
ralf0131 closed issue #189: dubbo-admin启动报错 URL: https://github.com/apache/incubator-dubbo/issues/189 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] ralf0131 commented on issue #212: dubbo-2.5.3,com.alibaba.dubbo.config.spring.AnnotationBean,serviceConfig.setProtocols报错

2018-05-16 Thread GitBox
ralf0131 commented on issue #212: dubbo-2.5.3,com.alibaba.dubbo.config.spring.AnnotationBean,serviceConfig.setProtocols报错 URL: https://github.com/apache/incubator-dubbo/issues/212#issuecomment-389452354 This issue has been fixed. Please try using the latest version.

[GitHub] ralf0131 closed issue #212: dubbo-2.5.3,com.alibaba.dubbo.config.spring.AnnotationBean,serviceConfig.setProtocols报错

2018-05-16 Thread GitBox
ralf0131 closed issue #212: dubbo-2.5.3,com.alibaba.dubbo.config.spring.AnnotationBean,serviceConfig.setProtocols报错 URL: https://github.com/apache/incubator-dubbo/issues/212 This is an automated message from the Apache Git

[GitHub] vangoleo opened a new pull request #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470

2018-05-16 Thread GitBox
vangoleo opened a new pull request #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470 URL: https://github.com/apache/incubator-dubbo/pull/1808 ## What is the purpose of the change Fix an error in URL class -- can not get username or password correctly while

[GitHub] htynkn opened a new pull request #1809: add unit test for dubbo spring config

2018-05-16 Thread GitBox
htynkn opened a new pull request #1809: add unit test for dubbo spring config URL: https://github.com/apache/incubator-dubbo/pull/1809 ## What is the purpose of the change Add test for dubbo spring config module Close #1684 ## Brief changelog + ignore AnnotationBean

[GitHub] ralf0131 commented on issue #200: ScriptRouter脚本路由规则执行存在问题

2018-05-16 Thread GitBox
ralf0131 commented on issue #200: ScriptRouter脚本路由规则执行存在问题 URL: https://github.com/apache/incubator-dubbo/issues/200#issuecomment-389450760 It has been fixed in the latest documentation: http://dubbo.apache.org/books/dubbo-user-book/demos/routing-rule.html

[GitHub] ralf0131 commented on issue #199: 为什么AnnotationBean中postProcessAfterInitialization方法和refer方法中的serviceConfig.setProvider方法和referenceConfig.setConsumer方法要重复执行一次呢?

2018-05-16 Thread GitBox
ralf0131 commented on issue #199: 为什么AnnotationBean中postProcessAfterInitialization方法和refer方法中的serviceConfig.setProvider方法和referenceConfig.setConsumer方法要重复执行一次呢? URL: https://github.com/apache/incubator-dubbo/issues/199#issuecomment-389522876 Yes, I have send a pull request to address this

[GitHub] codecov-io commented on issue #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667

2018-05-16 Thread GitBox
codecov-io commented on issue #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667 URL: https://github.com/apache/incubator-dubbo/pull/1811#issuecomment-389574602 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=h1) Report > Merging

[GitHub] ralf0131 closed issue #241: miss dependecy 'jetty-maven-plugin'

2018-05-16 Thread GitBox
ralf0131 closed issue #241: miss dependecy 'jetty-maven-plugin' URL: https://github.com/apache/incubator-dubbo/issues/241 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] ralf0131 commented on issue #236: dubbo分组校验不起作用的原因

2018-05-16 Thread GitBox
ralf0131 commented on issue #236: dubbo分组校验不起作用的原因 URL: https://github.com/apache/incubator-dubbo/issues/236#issuecomment-389529988 Hi, would you please send a pull request? This is an automated message from the Apache Git

[GitHub] ralf0131 opened a new pull request #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667

2018-05-16 Thread GitBox
ralf0131 opened a new pull request #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667 URL: https://github.com/apache/incubator-dubbo/pull/1811 ## What is the purpose of the change Fix unstable hessian protocol unit test ## Brief changelog Add

[GitHub] ralf0131 commented on issue #1667: com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest fails occasionally

2018-05-16 Thread GitBox
ralf0131 commented on issue #1667: com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest fails occasionally URL: https://github.com/apache/incubator-dubbo/issues/1667#issuecomment-389567440 @htynkn I think you are right. The two failing ut ```

[GitHub] ralf0131 commented on issue #272: Linux 环境 dubbo-admin无法启动,显示一直启动中。。。

2018-05-16 Thread GitBox
ralf0131 commented on issue #272: Linux 环境 dubbo-admin无法启动,显示一直启动中。。。 URL: https://github.com/apache/incubator-dubbo/issues/272#issuecomment-389528781 If you are running under Tomcat, please use jstack to check what the thread 'catalina-start-stop-xxx' is doing.

[GitHub] ralf0131 commented on issue #1136: com.caucho.hessian.io.HessianProtocolException: '￿' is an unknown code

2018-05-16 Thread GitBox
ralf0131 commented on issue #1136: com.caucho.hessian.io.HessianProtocolException: '�' is an unknown code URL: https://github.com/apache/incubator-dubbo/issues/1136#issuecomment-389568342 Please try adding `hessian.overload.method` to the url. e.g.

[GitHub] vangoleo commented on issue #1431: here is a StackOverflow bug? dubbo version 2.5.9, FailsafeLogger.appendContextMessage() > NetUtils.getLocalAddress()

2018-05-16 Thread GitBox
vangoleo commented on issue #1431: here is a StackOverflow bug? dubbo version 2.5.9, FailsafeLogger.appendContextMessage() > NetUtils.getLocalAddress() URL: https://github.com/apache/incubator-dubbo/issues/1431#issuecomment-389487358 It's a bug. when NetUtils.getLocalHost() raise an

[GitHub] zhangzhxb520 commented on issue #1713: Support log4j2

2018-05-16 Thread GitBox
zhangzhxb520 commented on issue #1713: Support log4j2 URL: https://github.com/apache/incubator-dubbo/issues/1713#issuecomment-389692957 I found code in *LoggerFactory*,Why use log4j as default logger when system property "dubbo.application.logger" not set. ```java static {

[GitHub] vangoleo commented on issue #1593: getIp(hostname) blocks - seems to be a bug in Dubbo2.6.1

2018-05-16 Thread GitBox
vangoleo commented on issue #1593: getIp(hostname) blocks - seems to be a bug in Dubbo2.6.1 URL: https://github.com/apache/incubator-dubbo/issues/1593#issuecomment-389433496 Can not reproduce this issue. Can set the hostname=xx.xx.xx.xx in /etc/hosts file to specify the ip to be

[GitHub] ralf0131 commented on issue #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470

2018-05-16 Thread GitBox
ralf0131 commented on issue #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470 URL: https://github.com/apache/incubator-dubbo/pull/1808#issuecomment-389718803 Hi, please follow the pull request title naming convention, which is described in the checklist.

[GitHub] chickenlj commented on issue #1763: [Dubbo-1665] Elegant shutdown under tomcat #1665

2018-05-16 Thread GitBox
chickenlj commented on issue #1763: [Dubbo-1665] Elegant shutdown under tomcat #1665 URL: https://github.com/apache/incubator-dubbo/pull/1763#issuecomment-389734122 I think this is a very good idea refactoring the startup and stop phase of dubbo process. At present, we need a place to

[GitHub] duguyixiaono1 commented on issue #869: dubbo基于zookeeper注册服务的疑问

2018-05-16 Thread GitBox
duguyixiaono1 commented on issue #869: dubbo基于zookeeper注册服务的疑问 URL: https://github.com/apache/incubator-dubbo/issues/869#issuecomment-389737298 @chickenlj

[GitHub] chickenlj closed pull request #1369: [Dubbo-unsubscribe failed] fixed zookeeper unsubscribe failed.

2018-05-16 Thread GitBox
chickenlj closed pull request #1369: [Dubbo-unsubscribe failed] fixed zookeeper unsubscribe failed. URL: https://github.com/apache/incubator-dubbo/pull/1369 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] chickenlj closed issue #1422: Consumer cannot get the list of providers when use ZK as registry(sometimes it happens).

2018-05-16 Thread GitBox
chickenlj closed issue #1422: Consumer cannot get the list of providers when use ZK as registry(sometimes it happens). URL: https://github.com/apache/incubator-dubbo/issues/1422 This is an automated message from the Apache

[GitHub] chickenlj commented on issue #1369: [Dubbo-unsubscribe failed] fixed zookeeper unsubscribe failed.

2018-05-16 Thread GitBox
chickenlj commented on issue #1369: [Dubbo-unsubscribe failed] fixed zookeeper unsubscribe failed. URL: https://github.com/apache/incubator-dubbo/pull/1369#issuecomment-389736164 Fixed in #1792 This is an automated message

[GitHub] chickenlj closed pull request #1792: zk Unsubscribe issue

2018-05-16 Thread GitBox
chickenlj closed pull request #1792: zk Unsubscribe issue URL: https://github.com/apache/incubator-dubbo/pull/1792 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] ralf0131 commented on a change in pull request #1763: [Dubbo-1665] Elegant shutdown under tomcat #1665

2018-05-16 Thread GitBox
ralf0131 commented on a change in pull request #1763: [Dubbo-1665] Elegant shutdown under tomcat #1665 URL: https://github.com/apache/incubator-dubbo/pull/1763#discussion_r188840621 ## File path:

[GitHub] ralf0131 commented on issue #27: Enable rest and serialization documentation

2018-05-16 Thread GitBox
ralf0131 commented on issue #27: Enable rest and serialization documentation URL: https://github.com/apache/incubator-dubbo-docs/issues/27#issuecomment-389752042 Now it is available: http://incubator.apache.org/ip-clearance/dubbo-dubbox.html. I will call a vote later.