[GitHub] [incubator-dubbo] tswstarplanet commented on pull request #2597: 【Code Optimization】Optimize the doSelect method of RandomLoadBalance

I think it is not necessary to check because the select method of AbstractLoadBalance that invoke the method has check the null pointer and the size of the invoker list. If the size of the list is 0, it will not reach here. [ Full content available at:

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2637: AbstractInterfaceConfigTest failed

please check this PR https://github.com/apache/incubator-dubbo/pull/2607 时无两丶 于2018年10月11日周四 下午5:51写道： > Reopened #2637 . > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub >

[GitHub] [incubator-dubbo] chickenlj commented on issue #2636: [Dubbo] move the classes of model from config to rpc-api for reusing

If it prevents reuse when staying in the config module, then let's move these classes to the rpc module. This migration will have no effect on other functionalities but for telnet, please make sure telnet still works fine when doing this. [ Full content available at:

[GitHub] [incubator-dubbo] beiwei30 closed issue #2635: 不看pojo类或代码，能否通过telnet等命令查看pojo类的属性信息?

[ issue closed by beiwei30 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2635 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2635: 不看pojo类或代码，能否通过telnet等命令查看pojo类的属性信息?

可以使用 [Arthas](https://github.com/alibaba/arthas) 中的 [jad](https://alibaba.github.io/arthas/jad.html) 来查看。这个功能不适合放在 telnet 中。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2635 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] yuhui0531 opened pull request #2638: sync with original

sync with original ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] [incubator-dubbo] cvictory commented on issue #2301: [BUG] @Reference#parameters() does not work

@mercyblitz I saw you have a commit to this issue. Maybe you should commit a dependent pr and related to this issue. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2301 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

It is not recommended like this "import io.protostuff.*;" as the checkstyle will report error "Using the '.*' form of import should be avoided" [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

I found a quote from [stackoverflow ](https://stackoverflow.com/questions/38245281/protobuf-payload-bigger-than-json) I found the using of protobufIOUtil instead of ProtostuffIoUtil, but still confusing is there any good support protocol buffer for the Protostuff with popular using? `

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

I found a quote from [stackoverflow ](https://stackoverflow.com/questions/38245281/protobuf-payload-bigger-than-json) I found the using of protobufIOUtil instead of ProtostuffIoUtil, but still confusing is there any good support protocol buffer for the Protostuff with popular using? >

[GitHub] [incubator-dubbo] cvictory commented on issue #2297: [Enhancement] Resolve the placeholders for sub-properties

@mercyblitz My be you should commit a pr for this issue. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2297 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] chickenlj closed pull request #2636: [Dubbo] move the classes of model from config to rpc-api for reusing

[ pull request closed by chickenlj ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] codecov-io commented on issue #2638: sync with original

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2638?src=pr=h1) Report > Merging > [#2638](https://codecov.io/gh/apache/incubator-dubbo/pull/2638?src=pr=desc) > into >

[GitHub] [incubator-dubbo] Veryfirefly commented on issue #2179: Kryo serialization fails when the service is both a provider and a consumer（Help Help!!!!）

When serializing kryo in my project, the consumer call will also report an error. No provider available for the service com.lewanwuxian.service.AccountService:1.0 from registry 192.168.1.3:2181 on the consumer 192.168.1.29 using the dubbo version 2.6.3. Please check if the providers have been

[GitHub] [incubator-dubbo] SKYhuangjing commented on issue #2570: dubbo无法在 【非spring + tomcat】环境下运行

> @diecui1202 > > > I think he uses com.alibaba:dubbo, all in one jar, so can not exclude this > > dependency. > > Why we need to shade all the dependency into one jar? This make it difficult > to customize the dependency. > I think this is something worth discussion. provide

[GitHub] [incubator-dubbo] rhwayfun opened issue #2639: Custom router does not support configuration on Provider side

I have a requirement： According to the client's request, the specified machine is called for the qualified request, and the other machine is called for the unqualified request. So I customize a route, but I find that the route can only take effect on the client. The server（Provider） does not

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

advice to refactor here by method extraction because here is a lot of replicated codes. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

The buffer's mainly purpose is for performance with caching. Here is created everytime. The following is a good sample. ` // Re-use (manage) this buffer to avoid allocating on every serialization LinkedBuffer buffer = LinkedBuffer.allocate(512); // ser final byte[] protostuff;

[GitHub] [incubator-dubbo] rhwayfun commented on issue #2639: Custom router does not support configuration on Provider side

yes, the provider can only handle legal request(eg: specific city request, other city request will be handled on another provider) > 在 2018年10月12日，12:39，时无两丶 写道： > > Hi, > Sorry, I still don't fully understand what you mean. > You are hoping to route on the provider side. If the provider finds

[GitHub] [incubator-dubbo] carryxyh commented on issue #2638: sync with original

Nothing changed. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2638 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh closed pull request #2638: sync with original

[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2638 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] carryxyh commented on issue #2637: AbstractInterfaceConfigTest failed

Hi, @Jeff-Lv I have seen this pr. I think there is no problem with modifying the part of this issue. But there are other parts of your pr, I am not very familiar, and may need someone to review. Maybe he can help u : @chickenlj . :) [ Full content available at:

[GitHub] [incubator-dubbo] dugenkui03 commented on issue #2629: CacheFilter performance optimization

需要修改，详情PR评论。注意缓存的基础数据结构 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2629 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2639: Custom router does not support configuration on Provider side

Hi, Sorry, I still don't fully understand what you mean. You are hoping to route on the provider side. If the provider finds that the request is illegal, as you said, do you want the current provider to send the request to another provider? [ Full content available at:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2632: Optimize ut for serialization model.

> I'm happy to have a issue to investigate configuration issue for coverage > stuff. I agree. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2632 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Alibner commented on issue #2633: zookeeper集群中有一个节点宕掉，注册中心连接失败

@356082462 您好，我想问下，我们的这个版本是啥版本呢。 我看release最高才到2.6... [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2633 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org -

[GitHub] [incubator-dubbo] carryxyh commented on issue #2633: zookeeper集群中有一个节点宕掉，注册中心连接失败

Maybe it is dubbox. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2633 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] lovepoem closed pull request #2632: Optimize ut for serialization model.

[ pull request closed by lovepoem ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2632 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] lovepoem commented on issue #2632: Optimize ut for serialization model.

I think we should find the reason why the coverage is decreased. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2632 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2632: Optimize ut for serialization model.

@lovepoem @htynkn I will send an email to ask other people in the community. Maybe someone else has had a similar experience? [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2632 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2632: Optimize ut for serialization model.

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2632?src=pr=h1) Report > Merging > [#2632](https://codecov.io/gh/apache/incubator-dubbo/pull/2632?src=pr=desc) > into >

[GitHub] [incubator-dubbo] Alibner commented on issue #2633: zookeeper集群中有一个节点宕掉，注册中心连接失败

是的，非常抱歉。走错地方了。。。 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2633 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] Alibner closed issue #2633: zookeeper集群中有一个节点宕掉，注册中心连接失败

[ issue closed by Alibner ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2633 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] iorilchen commented on issue #2535: spring boot with dubbo 2.6.3, cause ‘ Cannot initialize context because there is already a root application context present - check wheth

ApplicationContextHolder implements ApplicationContextAware 怀疑是 applicationContext.xml里配置了 引起。 在filter里要拿bean，如果是dubbo provider端可以用ServiceBean.getSpringContext().getBean(), 但如果是web客户端，ServiceBean.getSpringContext()为空，为了拿到applicationContext.xml配置的bean，就要用到applicationContextHolder [ Full content

[GitHub] majinkai opened a new pull request #135: Change API to restful

majinkai opened a new pull request #135: Change API to restful URL: https://github.com/apache/incubator-dubbo-ops/pull/135 Examples: https://restfulapi.net/rest-api-design-tutorial-with-example/ This is an automated message

[GitHub] [incubator-dubbo-ops] majinkai opened pull request #135: Change API to restful

Examples: https://restfulapi.net/rest-api-design-tutorial-with-example/ [ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/135 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-ops] nzomkxia closed pull request #135: Change API to restful

[ pull request closed by nzomkxia ] [ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/135 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] nzomkxia closed pull request #135: Change API to restful

nzomkxia closed pull request #135: Change API to restful URL: https://github.com/apache/incubator-dubbo-ops/pull/135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] majinkai commented on issue #128: develop是不是还是个半成品

majinkai commented on issue #128: develop是不是还是个半成品 URL: https://github.com/apache/incubator-dubbo-ops/issues/128#issuecomment-428851647 develop版本目前还在持续开发中，是最新的代码，请使用JDK8+，最新的提交基本都没什么问题，是可以跑通的，功能还在一步步实现功能，具体启动步骤如下： 1. 用develop分支Clone代码 2.

[GitHub] [incubator-dubbo-ops] majinkai commented on issue #128: develop是不是还是个半成品

develop版本目前还在持续开发中，是最新的代码，请使用JDK8+，最新的提交基本都没什么问题，是可以跑通的，功能还在一步步实现功能，具体启动步骤如下： 1. 用develop分支Clone代码 2. 修改dubbo-admin-backend/src/resources/application.properties中的zk地址，指向你的注册中心 3. 执行mvn clean package 4. 执行mvn --projects dubbo-admin-backend spring-boot:run 5. 访问http://localhost:8080

[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #2636: [Dubbo] move the classes of model from config to rpc-api for reusing

## What is the purpose of the change reusing those model in rpc module. ## Brief changelog the refactor is very safe with unit test convering. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2636 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] codecov-io commented on issue #2636: [Dubbo] move the classes of model from config to rpc-api for reusing

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr=h1) Report > Merging > [#2636](https://codecov.io/gh/apache/incubator-dubbo/pull/2636?src=pr=desc) > into >

[GitHub] zsjzero opened a new issue #293: 使用springboot2.06整合dubbo时运行provider出现Failed to determine a suitable driver class

zsjzero opened a new issue #293: 使用springboot2.06整合dubbo时运行provider出现Failed to determine a suitable driver class URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/293 Description: Failed to configure a DataSource: 'url' attribute is not specified and no

[GitHub] [incubator-dubbo-spring-boot-project] zsjzero opened issue #293: 使用springboot2.06整合dubbo时运行provider出现Failed to determine a suitable driver class

Description: Failed to configure a DataSource: 'url' attribute is not specified and no embedded datasource could be configured. Reason: Failed to determine a suitable driver class [ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/293 ] This

[GitHub] [incubator-dubbo] Jeff-Lv opened issue #2637: AbstractInterfaceConfigTest failed

### Environment * Dubbo version: 2.6.3 * Operating System version: window 7 * Java version: 1.8 ### Steps to reproduce this issue 1. run test case of abstractInterfaceConfigTest Pls. provide [GitHub address] to reproduce this issue. ### paased What do you expected from the above steps？ ###

[GitHub] [incubator-dubbo] carryxyh commented on issue #2637: AbstractInterfaceConfigTest failed

Passed in my mac. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2637: AbstractInterfaceConfigTest failed

> Passed in my mac.  :) As the code, it will be loaded from os filesystem if filename is started with '/'. It will be invalid in windows. [ Full content

[GitHub] [incubator-dubbo] carryxyh commented on issue #2637: AbstractInterfaceConfigTest failed

Oh, I remember there is a pr to fix this issue. Let me check. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh closed issue #2637: AbstractInterfaceConfigTest failed

[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2637: AbstractInterfaceConfigTest failed

https://github.com/apache/incubator-dubbo/pull/2562 Pr is here. It didn't effect on the 2.6.x branch. I will remind him to submit this pr to the 2.6.x branch. Thank you for your issue. :) [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was

[GitHub] [incubator-dubbo] carryxyh commented on issue #2562: Update ConfigUtils.java

There is a issue for this problem in 2.6.x branch: https://github.com/apache/incubator-dubbo/issues/2637 Would u pls bring this pr to 2.6.x ? [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2562 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] chickenlj commented on issue #2637: AbstractInterfaceConfigTest failed

@carryxyh If it's not easy to reach him, I think you can do it directly. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] Jeff-Lv commented on issue #2637: AbstractInterfaceConfigTest failed

@carryxyh cool. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2637: AbstractInterfaceConfigTest failed

> @carryxyh If it's not easy to reach him, I think you can do it directly. No problem. fix it soon. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2562 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] chickenlj commented on issue #2637: AbstractInterfaceConfigTest failed

https://github.com/Jeff-Lv/incubator-dubbo/commit/7cd86a1d0cdc4101a3d1c66e92a1b321ed6ac739 @carryxyh I think the change made by Jeff-Lv is more reasonable. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2637 ] This message was relayed via gitbox.apache.org for

[GitHub] [incubator-dubbo] carryxyh commented on issue #2637: AbstractInterfaceConfigTest failed

@chickenlj I agree with this modification. Compared to our judgment of the environment information in the code, I agree more that the user should set different dubbo.properties.file according to the current environment. All we have to do is determine if the input dubbo.properties.file exists.

[GitHub] [incubator-dubbo] carryxyh closed issue #2634: Provide dubbo-all-without-spring module

[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2634 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2634: Provide dubbo-all-without-spring module

Hi, There is a similar discussion here, we can focus on it: https://github.com/apache/incubator-dubbo/issues/2570 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2634 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2607: remove serviceclassHolder and also fix the issue #2637

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr=h1) Report > Merging > [#2607](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr=desc) > into >

[GitHub] [incubator-dubbo] codecov-io commented on issue #2607: remove serviceclassHolder and also fix the issue #2637

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr=h1) Report > Merging > [#2607](https://codecov.io/gh/apache/incubator-dubbo/pull/2607?src=pr=desc) > into >

[GitHub] [incubator-dubbo] dugenkui03 commented on issue #2627: ReentrantReadWriteLock replace ReentrantLock in LRUCache

> LGTM. > @beiwei30 > Would u pls review this pr? `get()` method in `LinkedHashMap` is not threadsafe.that's a bad pr. [details](https://blog.csdn.net/wawmg/article/details/19482041) 复盘最近PR为明天面试做准备的时候，突然发现这里不能用RWLock，因为其数据结构基础`linkedMap`的`get()`方法将会修改保持顺序的链表，即`get()`操作也有修改。感谢花费时间帮助review。 [

[GitHub] [incubator-dubbo]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2610 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh closed pull request #2627: ReentrantReadWriteLock replace ReentrantLock in LRUCache

[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2627 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [incubator-dubbo] dugenkui03 commented on issue #2610: 优化 LRUCache读取性能

> should we try out ReadWriteLock if semaphore has problem? bed PR, get() in `linkedmap` is not threadSafe,because it will update the position of visited key.thx for review. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2610 ] This message was relayed via

[GitHub] [incubator-dubbo] carryxyh closed issue #2610: 优化 LRUCache读取性能

[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2610 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: