[GitHub] [dubbo] codecov-io commented on issue #4818: enhance consul registry to support matching url between consumer and provider

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr=h1) Report > Merging [#4818](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr=desc) > will **increase** coverage

[GitHub] [dubbo] complone opened pull request #4819: fix bug of serialize or deserialie generic type use fastjson eg:resul…

…t or paramete use List ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues)

[GitHub] [dubbo] yidadi opened pull request #4820: Optimizing and reusing code

Optimizing and reusing code [ Full content available at: https://github.com/apache/dubbo/pull/4820 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] tswstarplanet commented on pull request #4819: fix bug of serialize or deserialie generic type use fastjson eg:resul…

This is not right [ Full content available at: https://github.com/apache/dubbo/pull/4819 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] beiwei30 opened pull request #4818: enhance consul registry to support matching url between consumer and provider

## What is the purpose of the change enhance consul registry to support matching url between consumer and provider ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a

[GitHub] [dubbo] complone closed pull request #4819: fix bug of serialize or deserialie generic type use fastjson eg:resul…

[ pull request closed by complone ] [ Full content available at: https://github.com/apache/dubbo/pull/4819 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] haiyang1985 commented on issue #4775: get wrong default protocolConfig from another service.

@tswstarplanet yes. [ Full content available at: https://github.com/apache/dubbo/issues/4775 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] codecov-io commented on issue #4820: Optimizing and reusing code

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr=h1) Report > Merging [#4820](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr=desc) > will **increase** coverage

[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

我看了代码，优雅关机的过程是先将服务向注册中心unregister，然后再关闭本地的网络连接（你所说的channel.readonly.send事件也是这个时候触发） [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md

Dubbo Dubbo ? [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md

Please compare with chinese version to check this section. [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md

space needed between and replacement [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md

markdown format require a space between title and '#' [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md

maybe use 'version 2.5.7'? [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-spring-boot-project] Johnson-Jia commented on issue #586: dubbo kryo 序列化异常

找到问题了，是因为加了 spring-boot-devtools 热部署引起的。 [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/586 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo] codecov-io commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr=h1) Report > Merging [#4811](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr=desc) > will **increase** coverage

[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #583: SpringBoot 2.1.6项目，只添加dubbo-spring-boot-starter启动报错

Sorry for confusing on the dependencies in Zookeeper, typically there's the basic guide in README.md, and more details in samples, for this case, you could check the sample about Zookeeper, please refer this declaration in pom.xml:

[GitHub] [dubbo-spring-boot-project] mercyblitz closed issue #583: SpringBoot 2.1.6项目，只添加dubbo-spring-boot-starter启动报错

[ issue closed by mercyblitz ] [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/583 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [dubbo] SparkandScala commented on issue #4827: how to use monitor in dubbo 2.7.3

why the dubbo-admin show "Metrics will release later"? [ Full content available at: https://github.com/apache/dubbo/issues/4827 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo] WhaleCloud-platform commented on issue #4821: dubbo-admin 规则路由保存路径和dubbo读取的不一致

zdubbo-admin存取规则时没有namespace概念。但是dubbo有。/${namespace}/config/${group}/.. 所以 我把zdubbo-admin这块修改了。 [ Full content available at: https://github.com/apache/dubbo/issues/4821 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #577: Why is there no version of Dubbo Spring Boot 2.7.2?

Since Dubbo 2.7.2 is a unstable version, please upgrade 2.7.3 and its Spring Boot starter. [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/577 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] LYC-CLamDown commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

> 也许你可以通过增长`dubbo.service.shutdown.wait`来解决你的问题.优雅关机会等待一段时间（`dubbo.service.shutdown.wait`）以处理已到达的请求然后再关闭channel. 这个时间是用来等待在途交易完成，功能不一样。而且没办法从根本解决这个问题，通过sendreadonly事件可以等价于关闭业务channel， 不会再有业务进入。 目前我是加了一个在registryprotocol加了beforeDestory接口发送事件，但感觉不够优雅 [ Full content available at:

[GitHub] [dubbo-samples] complone commented on issue #98: With dubbo-samples-rest , see "No Spring WebApplicationInitializer types detected on classpath" when run tomcat

i think you can see this issue [#95](https://github.com/apache/dubbo/issues/95) ``` public class DubboShutDownListener implements ServletContextListener { @Override public void contextDestroyed(ServletContextEvent arg0){

[GitHub] [dubbo-samples] complone commented on issue #98: With dubbo-samples-rest , see "No Spring WebApplicationInitializer types detected on classpath" when run tomcat

complone commented on issue #98: With dubbo-samples-rest , see "No Spring WebApplicationInitializer types detected on classpath" when run tomcat URL: https://github.com/apache/dubbo-samples/issues/98#issuecomment-521475771 i think you can see this issue

[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #582: Is it appropriate about the suffix of ServiceAnnotationBeanPostProcessor class name?

Good advice, it may be renamed in a future release. Please trace the issue : https://github.com/apache/dubbo/issues/4830 [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/582 ] This message was relayed via gitbox.apache.org for

[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

先关channel也会有问题吧，我先关了，但是registry里还有，这期间你那边也可能会有请求过来 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe,

[GitHub] [dubbo] tswstarplanet opened pull request #4829: [Dubbo-3629]fix set generic method error

## What is the purpose of the change 1.fix ServiceConfig's setGeneric log error when set "false" to generic field 2.simplify ProtocolUtils.isGeneric method ## Brief changelog ServiceConfig.java ProtocolUtils.java ## Verifying this change has been test Follow this checklist to help us

[GitHub] [dubbo] mercyblitz closed issue #4815: [Feature] Add the ServiceLoader for Dubbo's services or components

[ issue closed by mercyblitz ] [ Full content available at: https://github.com/apache/dubbo/issues/4815 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo]

[ Full content available at: https://github.com/apache/dubbo/issues/4792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

[GitHub] [dubbo]

[ Full content available at: https://github.com/apache/dubbo/issues/4792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

[GitHub] [dubbo] complone commented on issue #4825: [dubbo-4097] fix registry of etcd set 'group' cannot isolate

> you can add "fix #xxx" in the "What is the purpose of the change" section, > this may link the pr to the corresponding issue Hello, I have added [#4097](https://github.com/apache/dubbo/issues/4097) [ Full content available at: https://github.com/apache/dubbo/pull/4825 ] This message was

[GitHub] [dubbo] complone commented on issue #4825: [dubbo-4097] fix registry of etcd set 'group' cannot isolate

> you can add "fix #xxx" in the "What is the purpose of the change" section, > this may link the pr to the corresponding issue Hello, I have added [#4097](https://github.com/apache/dubbo/issues/4097),But I don't know why the jdk11 build failed, check the log and found that the build timed out.

[GitHub] [dubbo] complone closed pull request #4769: [dubbo-4760] add type convert .LocalDateTime,DateTimeFormatter

[ pull request closed by complone ] [ Full content available at: https://github.com/apache/dubbo/pull/4769 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] luoning810 commented on issue #4822: the priority of ServiceRouter and AppRouter were not effective

@lexburner pls help confirm it，thanks [ Full content available at: https://github.com/apache/dubbo/issues/4822 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #575: 最新版本的2.7.3在maven仓库中不能下载？

> > > 最新版本的2.7.3在maven仓库中不能下载？ > > > > > > 现在还是Pre-Release阶段 > > 太慢了，dubbo-2.7.3 都发布半个月了。这还没跟上。 Sorry for the delayed release, one main reason is that Apache Dubbo release process has to issue the vote, like this:

[GitHub] [dubbo-samples] complone removed a comment on issue #101: dubbo-samples-generic-impl-provider cannot pass travis CI

complone removed a comment on issue #101: dubbo-samples-generic-impl-provider cannot pass travis CI URL: https://github.com/apache/dubbo-samples/issues/101#issuecomment-521091222 I think you should configure a docker environment on the remote host and debug it on it, because the

[GitHub] [dubbo-samples]

[ Full content available at: https://github.com/apache/dubbo-samples/issues/101 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-website] complone commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md

Ok, I will see it. [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-spring-boot-project] danielye77 commented on issue #585: application.name报没定义

本地配置选择错了，功能没问题，关闭issue [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/585 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo-spring-boot-project]

[ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/585 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

嗯嗯，忘了这个了，不过你看多个invoker的时候，其实也是会重新选择，一个的时候没有其他选择，所以不判断了吧 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To

[GitHub] [dubbo] wavesZh commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

按你的解决方案，先`sendChannelReadOnlyEvent`给consumer以禁用channel，这个过程是有时间差的，仍是会有请求发出，在`dubbo.service.shutdown.wait`内，provider是可以正常处理的。如果时间差大于这个（可能性小），请求会失败。按照目前dubbo的做法：provider先`AbstractRegistryFactory.destroyAll`会触发consumer更新invoker list，然后`sendChannelReadOnlyEvent`后等待`dubbo.service.shutdown.wait`

[dubbo-samples] branch master updated: try to make github action work

This is an automated email from the ASF dual-hosted git repository. iluo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new ca5020c try to make github action work

[GitHub] [dubbo] LYC-CLamDown commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

> 嗯嗯，忘了这个了，不过你看多个invoker的时候，其实也是会重新选择，一个的时候没有其他选择，所以不判断了吧 嗯呐，但是也有个情况，如果只有一个invoke的时候但不校验isavialable（），这个provider在优雅停机过程中，就不能第一时间发现没有提供者了~最差情况要等 dubbo.service.shutdown.wait 这个时间了。 回到一开始那个问题哈，因为我们对业务成功率要求比较高，出现过这个问题，很偶发。目前改法也在上面说了，但感觉不够优雅~还请指点谢谢 [ Full content available at:

[GitHub] [dubbo] LYC-CLamDown commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

> 先关channel也会有问题吧，我先关了，但是registry里还有，这期间你那边也可能会有请求过来 再有多个invoker的时候，doselect（）会判断invoker.isavailable（）的，通过client.isconnect()和channel状态是否不为readonly，在dubboinvoker这个类 但是单个invoker的时候没这个判断，所以有我上面最后的那个小疑问 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was

[dubbo-samples] branch master updated: try github action.

This is an automated email from the ASF dual-hosted git repository. iluo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 727aaaf try github action. 727aaaf is

[GitHub] [dubbo-go] codecov-io commented on issue #121: consul

# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`develop@6614d23`). > [Click here to learn what that > means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is

[GitHub] [dubbo]

[ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org

[GitHub] [dubbo] xwell commented on issue #1273: 使用maven-shade-plugin打包demo程序不能运行

> @smallnest 你好，我遇到了相同的问题，请问你解决了吗？ @bolton1643 你说的这种方式我试了，在项目中直接添加，用maven去build > jar包并不会生效 不用手动添加SPI文件，可以直接在pom文件中引入 ``` com.alibaba dubbo ${project.parent.version} ``` 再用maven编译打包，即可。 [ Full content available at: https://github.com/apache/dubbo/issues/1273 ] This message was

[GitHub] [dubbo-spring-boot-project] Johnson-Jia commented on issue #586: dubbo kryo 序列化异常

是因为 Javassist 的问题吗？ [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/586 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

你说的优雅停机是指telnet之后用offline停机吗？ [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] complone opened pull request #4826: [dubbo-4816] the suffix of ServiceAnnotationBeanPostProcessor class

…name? ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the

[GitHub] [dubbo] codecov-io commented on issue #4826: [dubbo-4816] the suffix of ServiceAnnotationBeanPostProcessor class

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr=h1) Report > Merging [#4826](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr=desc) > will **increase** coverage

[GitHub] [dubbo] complone commented on issue #4823: Not found exported service without using registry

I think it is not set `group` [ Full content available at: https://github.com/apache/dubbo/issues/4823 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] tswstarplanet commented on issue #4823: Not found exported service without using registry

duplicate to #4784 [ Full content available at: https://github.com/apache/dubbo/issues/4823 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] wavesZh commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题

也许你可以通过增长`dubbo.service.shutdown.wait`来解决你的问题.优雅关机会等待一段时间（`dubbo.service.shutdown.wait`）以处理已到达的请求然后再关闭channel. [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo] wavesZh commented on issue #4742: @Method retries set not work

#4644 [ Full content available at: https://github.com/apache/dubbo/issues/4742 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] tswstarplanet closed pull request #4787: Fix use generic invocation via API , lost "version" value [#4784]

[ pull request closed by tswstarplanet ] [ Full content available at: https://github.com/apache/dubbo/pull/4787 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [dubbo] tswstarplanet commented on issue #4470: 同一个dubbo服务一个微服务内多个类引用时,有些类的此dubbo服务reference注解属性不起作用

duplicate to #4674 [ Full content available at: https://github.com/apache/dubbo/issues/4470 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: