[GitHub] [dubbo] codecov-io commented on issue #4818: enhance consul registry to support matching url between consumer and provider
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=h1) Report > Merging [#4818](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr&el=desc) > will **increase** coverage by `0.09%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4818 +/- ## + Coverage 63.83% 63.92% +0.09% - Complexity 450 452 +2 Files 769 769 Lines 3313733173 +36 Branches 5203 5229 +26 + Hits 2115321207 +54 + Misses 9557 9542 -15 + Partials 2427 2424 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnkuamF2YQ==) | `62.11% <100%> (+0.23%)` | `30 <1> (+1)` | :arrow_up: | | [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `70.73% <0%> (-12.2%)` | `0% <0%> (ø)` | | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `61.4% <0%> (-7.02%)` | `0% <0%> (ø)` | | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0%> (-3.85%)` | `0% <0%> (ø)` | | | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `69.64% <0%> (-3.58%)` | `8% <0%> (-1%)` | | | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `83.72% <0%> (-2%)` | `0% <0%> (ø)` | | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `78.54% <0%> (-1.54%)` | `0% <0%> (ø)` | | | [.../main/java/org/apache/dubbo/qos/textui/TTable.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVGFibGUuamF2YQ==) | `83.79% <0%> (-0.87%)` | `0% <0%> (ø)` | | | [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `62.41% <0%> (-0.69%)` | `0% <0%> (ø)` | | | [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnkuamF2YQ==) | `48.15% <0%> (-0.26%)` | `31% <0%> (ø)` | | | ... and [31 more](https://codecov.io/gh/apache/dubbo/pull/4818/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=footer). > Last update > [0e76eb0...9cbed6a](https://codecov.io/gh/apache/dubbo/pull/4818?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.i
[GitHub] [dubbo] complone opened pull request #4819: fix bug of serialize or deserialie generic type use fastjson eg:resul…
…t or paramete use List ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). fix bug of serialize or deserialie generic type use fastjson [ Full content available at: https://github.com/apache/dubbo/pull/4819 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] yidadi opened pull request #4820: Optimizing and reusing code
Optimizing and reusing code [ Full content available at: https://github.com/apache/dubbo/pull/4820 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet commented on pull request #4819: fix bug of serialize or deserialie generic type use fastjson eg:resul…
This is not right [ Full content available at: https://github.com/apache/dubbo/pull/4819 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4820: Optimizing and reusing code
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=h1) Report > Merging [#4820](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr&el=desc) > will **increase** coverage by `0.05%`. > The diff coverage is `17.39%`. [](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4820 +/- ## + Coverage 63.83% 63.89% +0.05% - Complexity 450 451 +1 Files 769 769 Lines 3313733174 +37 Branches 5203 5228 +25 + Hits 2115321196 +43 Misses 9557 9557 + Partials 2427 2421 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...org/apache/dubbo/common/utils/CollectionUtils.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ29sbGVjdGlvblV0aWxzLmphdmE=) | `87.85% <0%> (-1.68%)` | `0 <0> (ø)` | | | [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `18.58% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...mmon/threadpool/support/eager/EagerThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2VhZ2VyL0VhZ2VyVGhyZWFkUG9vbC5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...va/org/apache/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvU2VydmljZUJlYW4uamF2YQ==) | `50% <30%> (+1.78%)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-17.08%)` | `0% <0%> (ø)` | | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `61.4% <0%> (-7.02%)` | `0% <0%> (ø)` | | | [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | | | [...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | | | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0%> (-3.85%)` | `0% <0%> (ø)` | | | ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/4820/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=footer). > Last update > [0e76eb0...047e92f](https://codecov.io/gh/apache/dubbo/pull/4820?src=pr&el=lastupdated). > Read the [comment docs](https
[GitHub] [dubbo] complone closed pull request #4819: fix bug of serialize or deserialie generic type use fastjson eg:resul…
[ pull request closed by complone ] [ Full content available at: https://github.com/apache/dubbo/pull/4819 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] xwell commented on issue #1273: 使用maven-shade-plugin打包demo程序不能运行
> @smallnest 你好，我遇到了相同的问题，请问你解决了吗？ @bolton1643 你说的这种方式我试了，在项目中直接添加，用maven去build
> jar包并不会生效
不用手动添加SPI文件，可以直接在pom文件中引入
```
com.alibaba
dubbo
${project.parent.version}
```
再用maven编译打包，即可。
[ Full content available at: https://github.com/apache/dubbo/issues/1273 ]
This message was relayed via gitbox.apache.org for
notifications@dubbo.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #121: consul
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`develop@6614d23`). > [Click here to learn what that > means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `1.06%`. [](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr&el=tree) ```diff @@Coverage Diff @@ ## develop #121 +/- ## == Coverage ? 65.48% == Files ? 84 Lines ? 4841 Branches ?0 == Hits ? 3170 Misses ? 1358 Partials ? 313 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/121/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `70.68% <ø> (ø)` | | | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/121/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `78.3% <ø> (ø)` | | | [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/121/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `0% <0%> (ø)` | | | [registry/consul/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/121/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL2xpc3RlbmVyLmdv) | `0% <0%> (ø)` | | | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/121/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `53.73% <0%> (ø)` | | | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/121/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `3.38% <3.38%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr&el=footer). > Last update > [6614d23...24e7d6f](https://codecov.io/gh/apache/dubbo-go/pull/121?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/121 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] Johnson-Jia commented on issue #586: dubbo kryo 序列化异常
是因为 Javassist 的问题吗？ [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/586 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
你说的优雅停机是指telnet之后用offline停机吗？ [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo]
[ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] Johnson-Jia commented on issue #586: dubbo kryo 序列化异常
找到问题了，是因为加了 spring-boot-devtools 热部署引起的。 [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/586 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
我看了代码，优雅关机的过程是先将服务向注册中心unregister，然后再关闭本地的网络连接（你所说的channel.readonly.send事件也是这个时候触发） [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=h1) Report > Merging [#4811](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr&el=desc) > will **increase** coverage by `0.1%`. > The diff coverage is `67.28%`. [](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4811 +/- ## === + Coverage 63.83% 63.94% +0.1% - Complexity 450 451 +1 === Files 769 769 Lines 3313733181 +44 Branches 5203 5228 +25 === + Hits 2115321216 +63 + Misses 9557 9553 -4 + Partials 2427 2412 -15 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `79.87% <ø> (-0.32%)` | `0 <0> (ø)` | | | [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `60.94% <50%> (+0.36%)` | `0 <0> (ø)` | :arrow_down: | | [...org/apache/dubbo/config/context/ConfigManager.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9jb250ZXh0L0NvbmZpZ01hbmFnZXIuamF2YQ==) | `66.42% <64.28%> (-0.24%)` | `0 <0> (ø)` | | | [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `59.23% <64.7%> (+0.08%)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdEludGVyZmFjZUNvbmZpZy5qYXZh) | `72.54% <75.55%> (+0.95%)` | `0 <0> (ø)` | :arrow_down: | | [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.85% <0%> (-17.08%)` | `0% <0%> (ø)` | | | [.../org/apache/dubbo/config/spring/ReferenceBean.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvUmVmZXJlbmNlQmVhbi5qYXZh) | `14.15% <0%> (-4.43%)` | `0% <0%> (ø)` | | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0%> (-3.85%)` | `0% <0%> (ø)` | | | [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `56.47% <0%> (-2.36%)` | `0% <0%> (ø)` | | | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `60.86% <0%> (-2.18%)` | `0% <0%> (ø)` | | | ... and [35 more](https://codecov.io/gh/apache/dubbo/pull/4811/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=footer). > Last update > [0e76eb0...772602d](https://codecov.io/gh/apache/dubbo/pull/4811?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content ava
[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md
Dubbo Dubbo ? [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md
Please compare with chinese version to check this section. [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md
space needed between and replacement [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md
markdown format require a space between title and '#' [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] htynkn commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md
maybe use 'version 2.5.7'? [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] complone commented on issue #4823: Not found exported service without using registry
I think it is not set `group` [ Full content available at: https://github.com/apache/dubbo/issues/4823 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] complone opened pull request #4826: [dubbo-4816] the suffix of ServiceAnnotationBeanPostProcessor class
…name? ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). the suffix of ServiceAnnotationBeanPostProcessor class [ Full content available at: https://github.com/apache/dubbo/pull/4826 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4826: [dubbo-4816] the suffix of ServiceAnnotationBeanPostProcessor class
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr&el=h1) Report > Merging [#4826](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/0e76eb000b92a8719413cd0eacabb70d4fb9f7a2?src=pr&el=desc) > will **increase** coverage by `0.1%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4826 +/- ## === + Coverage 63.83% 63.93% +0.1% - Complexity 450 451 +1 === Files 769 769 Lines 3313733172 +35 Branches 5203 5229 +26 === + Hits 2115321210 +57 + Misses 9557 9535 -22 Partials 2427 2427 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `87.73% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../spring/schema/AnnotationBeanDefinitionParser.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvc2NoZW1hL0Fubm90YXRpb25CZWFuRGVmaW5pdGlvblBhcnNlci5qYXZh) | `9.09% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ion/ServiceAnnotationBeanFactoryPostProcessor.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1NlcnZpY2VBbm5vdGF0aW9uQmVhbkZhY3RvcnlQb3N0UHJvY2Vzc29yLmphdmE=) | `80.68% <100%> (ø)` | `0 <0> (?)` | | | [...ontext/annotation/DubboComponentScanRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29tcG9uZW50U2NhblJlZ2lzdHJhci5qYXZh) | `92% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==) | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0%> (-3.85%)` | `0% <0%> (ø)` | | | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `83.72% <0%> (-2%)` | `0% <0%> (ø)` | | | [.../main/java/org/apache/dubbo/qos/textui/TTable.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVGFibGUuamF2YQ==) | `83.79% <0%> (-0.87%)` | `0% <0%> (ø)` | | | [...org/apache/dubbo/registry/redis/RedisRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktcmVkaXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlZ2lzdHJ5L3JlZGlzL1JlZGlzUmVnaXN0cnkuamF2YQ==) | `48.15% <0%> (-0.26%)` | `31% <0%> (ø)` | | | [...n/java/org/apache/dubbo/common/utils/UrlUtils.java](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvVXJsVXRpbHMuamF2YQ==) | `78.04% <0%> (-0.2%)` | `0% <0%> (ø)` | | | ... and [25 more](https://codecov.io/gh/apache/dubbo/pull/4826/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/4826?src=pr&el=footer).
[GitHub] [dubbo] tswstarplanet commented on issue #4823: Not found exported service without using registry
duplicate to #4784 [ Full content available at: https://github.com/apache/dubbo/issues/4823 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wavesZh commented on issue #4742: @Method retries set not work
#4644 [ Full content available at: https://github.com/apache/dubbo/issues/4742 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet closed pull request #4787: Fix use generic invocation via API , lost "version" value [#4784]
[ pull request closed by tswstarplanet ] [ Full content available at: https://github.com/apache/dubbo/pull/4787 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wavesZh commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
也许你可以通过增长`dubbo.service.shutdown.wait`来解决你的问题.优雅关机会等待一段时间（`dubbo.service.shutdown.wait`）以处理已到达的请求然后再关闭channel. [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet commented on issue #4470: 同一个dubbo服务一个微服务内多个类引用时,有些类的此dubbo服务reference注解属性不起作用
duplicate to #4674 [ Full content available at: https://github.com/apache/dubbo/issues/4470 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet opened pull request #4829: [Dubbo-3629]fix set generic method error
## What is the purpose of the change 1.fix ServiceConfig's setGeneric log error when set "false" to generic field 2.simplify ProtocolUtils.isGeneric method ## Brief changelog ServiceConfig.java ProtocolUtils.java ## Verifying this change has been test Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). [ Full content available at: https://github.com/apache/dubbo/pull/4829 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo]
[ Full content available at: https://github.com/apache/dubbo/issues/4792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo]
[ Full content available at: https://github.com/apache/dubbo/issues/4792 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] complone commented on issue #4825: [dubbo-4097] fix registry of etcd set 'group' cannot isolate
> you can add "fix #xxx" in the "What is the purpose of the change" section, > this may link the pr to the corresponding issue Hello, I have added [#4097](https://github.com/apache/dubbo/issues/4097) [ Full content available at: https://github.com/apache/dubbo/pull/4825 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] complone commented on issue #4825: [dubbo-4097] fix registry of etcd set 'group' cannot isolate
> you can add "fix #xxx" in the "What is the purpose of the change" section, > this may link the pr to the corresponding issue Hello, I have added [#4097](https://github.com/apache/dubbo/issues/4097),But I don't know why the jdk11 build failed, check the log and found that the build timed out. [ Full content available at: https://github.com/apache/dubbo/pull/4825 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] complone commented on pull request #443: [Blog] Translation dubbo-annotation-driven.md
Ok, I will see it. [ Full content available at: https://github.com/apache/dubbo-website/pull/443 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] LYC-CLamDown commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
> 也许你可以通过增长`dubbo.service.shutdown.wait`来解决你的问题.优雅关机会等待一段时间（`dubbo.service.shutdown.wait`）以处理已到达的请求然后再关闭channel. 这个时间是用来等待在途交易完成，功能不一样。而且没办法从根本解决这个问题，通过sendreadonly事件可以等价于关闭业务channel， 不会再有业务进入。 目前我是加了一个在registryprotocol加了beforeDestory接口发送事件，但感觉不够优雅 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] complone commented on issue #98: With dubbo-samples-rest , see "No Spring WebApplicationInitializer types detected on classpath" when run tomcat
i think you can see this issue [#95](https://github.com/apache/dubbo/issues/95)
```
public class DubboShutDownListener implements ServletContextListener {
@Override
public void contextDestroyed(ServletContextEvent arg0){
arg0.getServletContext().log("DubboShutDownListener.contextDestroyed
called!");
try {
final Class protocolConfig =
Class.forName("com.alibaba.dubbo.config.ProtocolConfig");
final Method method = protocolConfig.getMethod("destroyAll");
method.invoke(protocolConfig);
} catch (Exception e){
arg0.getServletContext().log("destory dubbo
failed:"+e.getMessage(), e);
}
}
@Override
public void contextInitialized(ServletContextEvent arg0){
//System.out.println("DubboShutDownListener.contextInitialized
called!");
}
}
```
[ Full content available at: https://github.com/apache/dubbo-samples/issues/98 ]
This message was relayed via gitbox.apache.org for
notifications@dubbo.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] complone commented on issue #98: With dubbo-samples-rest , see "No Spring WebApplicationInitializer types detected on classpath" when run tomcat
complone commented on issue #98: With dubbo-samples-rest , see "No Spring
WebApplicationInitializer types detected on classpath" when run tomcat
URL: https://github.com/apache/dubbo-samples/issues/98#issuecomment-521475771
i think you can see this issue
[#95](https://github.com/apache/dubbo/issues/95)
```
public class DubboShutDownListener implements ServletContextListener {
@Override
public void contextDestroyed(ServletContextEvent arg0){
arg0.getServletContext().log("DubboShutDownListener.contextDestroyed called!");
try {
final Class protocolConfig =
Class.forName("com.alibaba.dubbo.config.ProtocolConfig");
final Method method = protocolConfig.getMethod("destroyAll");
method.invoke(protocolConfig);
} catch (Exception e){
arg0.getServletContext().log("destory dubbo
failed:"+e.getMessage(), e);
}
}
@Override
public void contextInitialized(ServletContextEvent arg0){
//System.out.println("DubboShutDownListener.contextInitialized
called!");
}
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] complone closed pull request #4769: [dubbo-4760] add type convert .LocalDateTime,DateTimeFormatter
[ pull request closed by complone ] [ Full content available at: https://github.com/apache/dubbo/pull/4769 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] luoning810 commented on issue #4822: the priority of ServiceRouter and AppRouter were not effective
@lexburner pls help confirm it，thanks [ Full content available at: https://github.com/apache/dubbo/issues/4822 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] mercyblitz closed issue #4815: [Feature] Add the ServiceLoader for Dubbo's services or components
[ issue closed by mercyblitz ] [ Full content available at: https://github.com/apache/dubbo/issues/4815 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #575: 最新版本的2.7.3在maven仓库中不能下载？
> > > 最新版本的2.7.3在maven仓库中不能下载？ > > > > > > 现在还是Pre-Release阶段 > > 太慢了，dubbo-2.7.3 都发布半个月了。这还没跟上。 Sorry for the delayed release, one main reason is that Apache Dubbo release process has to issue the vote, like this:  It costs 72 hours(3 days) for every vote at least, and it's hard to be approved in the first vote. > The prepare for release - > https://dubbo.apache.org/zh-cn/blog/prepare-an-apache-release.html [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/575 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #583: SpringBoot 2.1.6项目，只添加dubbo-spring-boot-starter启动报错
Sorry for confusing on the dependencies in Zookeeper, typically there's the basic guide in README.md, and more details in samples, for this case, you could check the sample about Zookeeper, please refer this declaration in pom.xml: https://github.com/apache/dubbo-spring-boot-project/blob/master/dubbo-spring-boot-samples/dubbo-registry-zookeeper-samples/provider-sample/pom.xml#L53 [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/583 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] mercyblitz closed issue #583: SpringBoot 2.1.6项目，只添加dubbo-spring-boot-starter启动报错
[ issue closed by mercyblitz ] [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/583 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #582: Is it appropriate about the suffix of ServiceAnnotationBeanPostProcessor class name?
Good advice, it may be renamed in a future release. Please trace the issue : https://github.com/apache/dubbo/issues/4830 [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/582 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] mercyblitz commented on issue #577: Why is there no version of Dubbo Spring Boot 2.7.2?
Since Dubbo 2.7.2 is a unstable version, please upgrade 2.7.3 and its Spring Boot starter. [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/577 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] WhaleCloud-platform commented on issue #4821: dubbo-admin 规则路由保存路径和dubbo读取的不一致
zdubbo-admin存取规则时没有namespace概念。但是dubbo有。/${namespace}/config/${group}/..
所以 我把zdubbo-admin这块修改了。
[ Full content available at: https://github.com/apache/dubbo/issues/4821 ]
This message was relayed via gitbox.apache.org for
notifications@dubbo.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] SparkandScala commented on issue #4827: how to use monitor in dubbo 2.7.3
why the dubbo-admin show "Metrics will release later"? [ Full content available at: https://github.com/apache/dubbo/issues/4827 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project]
[ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/585 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project] danielye77 commented on issue #585: application.name报没定义
本地配置选择错了，功能没问题，关闭issue [ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/585 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples] complone removed a comment on issue #101: dubbo-samples-generic-impl-provider cannot pass travis CI
complone removed a comment on issue #101: dubbo-samples-generic-impl-provider cannot pass travis CI URL: https://github.com/apache/dubbo-samples/issues/101#issuecomment-521091222 I think you should configure a docker environment on the remote host and debug it on it, because the successfully packaged classes here don't seem to be automatically published in tomcat. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-samples]
[ Full content available at: https://github.com/apache/dubbo-samples/issues/101 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
先关channel也会有问题吧，我先关了，但是registry里还有，这期间你那边也可能会有请求过来 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] LYC-CLamDown commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
> 先关channel也会有问题吧，我先关了，但是registry里还有，这期间你那边也可能会有请求过来 再有多个invoker的时候，doselect（）会判断invoker.isavailable（）的，通过client.isconnect()和channel状态是否不为readonly，在dubboinvoker这个类 但是单个invoker的时候没这个判断，所以有我上面最后的那个小疑问 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] tswstarplanet commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
嗯嗯，忘了这个了，不过你看多个invoker的时候，其实也是会重新选择，一个的时候没有其他选择，所以不判断了吧 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] LYC-CLamDown commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
> 嗯嗯，忘了这个了，不过你看多个invoker的时候，其实也是会重新选择，一个的时候没有其他选择，所以不判断了吧 嗯呐，但是也有个情况，如果只有一个invoke的时候但不校验isavialable（），这个provider在优雅停机过程中，就不能第一时间发现没有提供者了~最差情况要等 dubbo.service.shutdown.wait 这个时间了。 回到一开始那个问题哈，因为我们对业务成功率要求比较高，出现过这个问题，很偶发。目前改法也在上面说了，但感觉不够优雅~还请指点谢谢 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] wavesZh commented on issue #4714: 高频交易下，优雅停机偶发调用失败逻辑问题
按你的解决方案，先`sendChannelReadOnlyEvent`给consumer以禁用channel，这个过程是有时间差的，仍是会有请求发出，在`dubbo.service.shutdown.wait`内，provider是可以正常处理的。如果时间差大于这个（可能性小），请求会失败。按照目前dubbo的做法：provider先`AbstractRegistryFactory.destroyAll`会触发consumer更新invoker list，然后`sendChannelReadOnlyEvent`后等待`dubbo.service.shutdown.wait` ，关闭channel。如果发生你那种请求处理失败的情况，只有当超过了`dubbo.service.shutdown.wait`，consumer仍没有禁用channel或更新invoker list或请求在路上漂了太久了。这种可能性也比较小吧。我感觉这个无法根本解决，`sendChannelReadOnlyEvent`和 禁用channel 本就不是原子性的。 [ Full content available at: https://github.com/apache/dubbo/issues/4714 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[dubbo-samples] branch master updated: try github action.
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 727aaaf try github action.
727aaaf is described below
commit 727aaafe7fc2346d7cfbc3d4ca4ec0fa337c8389
Author: Ian Luo
AuthorDate: Thu Aug 15 13:44:25 2019 +0800
try github action.
---
.github/workflows/maven.yml | 18 ++
1 file changed, 18 insertions(+)
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
new file mode 100644
index 000..27f3938
--- /dev/null
+++ b/.github/workflows/maven.yml
@@ -0,0 +1,18 @@
+name: Java CI
+
+on: [push]
+
+jobs:
+ build:
+
+runs-on: ubuntu-latest
+
+steps:
+- uses: actions/checkout@v1
+- name: Set up JDK 1.8
+ uses: actions/setup-java@v1
+ with:
+java-version: 1.8
+- name: Build with Maven
+ run: ./mvnw -B clean install -pl dubbo-maven-address-plugin
+ ./mvnw -B clean verify -Pdubbo-integration-test
-Djava-image.name=${JAVA_BASE_IMAGE} -Ddubbo.version=2.7.4-SNAPSHOT
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[dubbo-samples] branch master updated: try to make github action work
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new ca5020c try to make github action work
ca5020c is described below
commit ca5020ca231950fbde6a5ee50961f00e445000e8
Author: Ian Luo
AuthorDate: Thu Aug 15 13:48:33 2019 +0800
try to make github action work
---
.github/workflows/maven.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index 27f3938..0c455b8 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -14,5 +14,4 @@ jobs:
with:
java-version: 1.8
- name: Build with Maven
- run: ./mvnw -B clean install -pl dubbo-maven-address-plugin
- ./mvnw -B clean verify -Pdubbo-integration-test
-Djava-image.name=${JAVA_BASE_IMAGE} -Ddubbo.version=2.7.4-SNAPSHOT
+ run: ./mvnw -B clean install -pl dubbo-maven-address-plugin && ./mvnw -B
clean verify -Pdubbo-integration-test -Djava-image.name=${JAVA_BASE_IMAGE}
-Ddubbo.version=2.7.4-SNAPSHOT
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] qixiaobo commented on issue #4828: dubbo zookeeper registry too slow
2019-08-15 14:17:54,187 [myid:] - INFO [ProcessThread(sid:0 cport:2181)::PrepRequestProcessor@653] - Got user-level KeeperException when processing sessionid:0x1004228f12d5154 type:create cxid:0x495 zxid:0x7c8c87 txntype:-1 reqpath:n/a Error Path:/f6-test/XXX/providers Error:KeeperErrorCode = NodeExists for /f6-test/XXX/providers [ Full content available at: https://github.com/apache/dubbo/issues/4828 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] qixiaobo commented on issue #4828: dubbo zookeeper registry too slow
tail -n 1 zookeeper.out |grep NodeExists|wc -l 9732 We can see almost 97% NodeExistsException [ Full content available at: https://github.com/apache/dubbo/issues/4828 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
