Re: [I] Improve documentation (Web aspect) [dubbo-js]

2024-04-25 Thread via GitHub
0808zhongshang commented on issue #374: URL: https://github.com/apache/dubbo-js/issues/374#issuecomment-2078490799 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] trim application name of old mapping content [dubbo]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #14133: URL: https://github.com/apache/dubbo/pull/14133#issuecomment-2078569260 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2078563393 > I think so, but we need to confirm whether adding ALPN support cause a regression in protocols other than Triple, such as the Dubbo protocol. Submitted a commit. Please take a

[I] [Bug] When calling the interface of the TRIPLE protocol, after a long time of free, it always fails for the first time [dubbo]

2024-04-25 Thread via GitHub
Alleninggx opened a new issue, #14131: URL: https://github.com/apache/dubbo/issues/14131 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the

Re: [PR] fix: Server return with Attachment [dubbo-go]

2024-04-25 Thread via GitHub
chickenlj merged PR #2648: URL: https://github.com/apache/dubbo-go/pull/2648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-25 Thread via GitHub
heliang666s commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2078519387 This issue is basically done, I've filed it at apache/dubbo-spi-extensions#307 and the merge was successful. I was a bit busy a while ago and had a little problem left in the

[PR] trim application name of old mapping content [dubbo]

2024-04-25 Thread via GitHub
zrlw opened a new pull request, #14133: URL: https://github.com/apache/dubbo/pull/14133 ## What is the purpose of the change enhance MetadataServiceNameMapping to avoid registering duplication service name mapping. see #14132 ## Brief changelog ## Verifying this

Re: [PR] Cherry-pick bug fix from master into 3.1.0 branch [dubbo-spi-extensions]

2024-04-25 Thread via GitHub
songxiaosheng merged PR #334: URL: https://github.com/apache/dubbo-spi-extensions/pull/334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump to 3.2.1-SNAPSHOT [dubbo-spi-extensions]

2024-04-25 Thread via GitHub
songxiaosheng merged PR #333: URL: https://github.com/apache/dubbo-spi-extensions/pull/333 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix: After the streaming call ends, client response.tailer() returns empty [dubbo-go]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #2658: URL: https://github.com/apache/dubbo-go/pull/2658#issuecomment-2078512606 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] Improve documentation (Web aspect) [dubbo-js]

2024-04-25 Thread via GitHub
0808zhongshang commented on issue #374: URL: https://github.com/apache/dubbo-js/issues/374#issuecomment-2078628513 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Improve documentation (Web aspect) [dubbo-js]

2024-04-25 Thread via GitHub
0808zhongshang commented on issue #371: URL: https://github.com/apache/dubbo-js/issues/371#issuecomment-2078629116 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] [Feature] enhance service name mapping [dubbo]

2024-04-25 Thread via GitHub
zrlw opened a new issue, #14132: URL: https://github.com/apache/dubbo/issues/14132 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2078594018 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] feat(master): dubbo-samples-triple-reactor proto add java_outer_classname [dubbo-samples]

2024-04-25 Thread via GitHub
chickenlj merged PR #1137: URL: https://github.com/apache/dubbo-samples/pull/1137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Feature] Move Mesh Rule Router to SPI Extensions [dubbo]

2024-04-25 Thread via GitHub
wcy666103 commented on issue #13957: URL: https://github.com/apache/dubbo/issues/13957#issuecomment-2076523022 Is this issue completed? Is there any progress? I am very interested in this and want to join. @heliang666s -- This is an automated message from the Apache Git Service. To

[I] [Bug] The actual number of connections established is twice what I configured [dubbo]

2024-04-25 Thread via GitHub
lpcy opened a new issue, #14129: URL: https://github.com/apache/dubbo/issues/14129 ### Pre-check - [X] I am sure that all the content I provide is in English. ### Search before asking - [X] I had searched in the

Re: [PR] support custom dubbo invoke retry times [dubbo-go-pixiu]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #625: URL: https://github.com/apache/dubbo-go-pixiu/pull/625#issuecomment-2076503053 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] support custom dubbo invoke retry times [dubbo-go-pixiu]

2024-04-25 Thread via GitHub
mark4z merged PR #625: URL: https://github.com/apache/dubbo-go-pixiu/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076522474 > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > ``` > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'

Re: [PR] docs [dubbo-js]

2024-04-25 Thread via GitHub
chickenlj merged PR #389: URL: https://github.com/apache/dubbo-js/pull/389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Feature 3.3] Triple Rest Cors Support [dubbo]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #14073: URL: https://github.com/apache/dubbo/pull/14073#issuecomment-2076624455 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Task] Introduce new script routing in apache/dubbo-spi-extensions [dubbo]

2024-04-25 Thread via GitHub
wcy666103 commented on issue #13864: URL: https://github.com/apache/dubbo/issues/13864#issuecomment-2076528742 Is this issue completed? Is there any progress? I am very interested in this and want to join. @tritone-l -- This is an automated message from the Apache Git Service. To

Re: [PR] docs: common errors & supported browsers and frameworks & getting-started (web aspect) [dubbo-js]

2024-04-25 Thread via GitHub
chickenlj merged PR #388: URL: https://github.com/apache/dubbo-js/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: add commit lint and husky [dubbo-js]

2024-04-25 Thread via GitHub
chickenlj merged PR #392: URL: https://github.com/apache/dubbo-js/pull/392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat: add commit lint and husky [dubbo-js]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #392: URL: https://github.com/apache/dubbo-js/pull/392#issuecomment-2076439246 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076455166 > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > ``` > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'

(dubbo-samples) branch master updated: dubbo-samples-triple-reactor proto add java_outer_classname (#1137)

2024-04-25 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 8a0a9fd43 dubbo-samples-triple-reactor

Re: [I] [Bug] Dubbo Service was called failed in afterPropertiesSet while application built in native-image [dubbo]

2024-04-25 Thread via GitHub
imgoby closed issue #14128: [Bug] Dubbo Service was called failed in afterPropertiesSet while application built in native-image URL: https://github.com/apache/dubbo/issues/14128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Feat security [dubbo-go]

2024-04-25 Thread via GitHub
YarBor commented on code in PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#discussion_r1579138736 ## istio/channel/xds_client_api_store.go: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076766699 > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/

Re: [PR] ignore .iml file for idea and fix eslint error for single quote and semi [dubbo-js]

2024-04-25 Thread via GitHub
openlg closed pull request #384: ignore .iml file for idea and fix eslint error for single quote and semi URL: https://github.com/apache/dubbo-js/pull/384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
oxsean commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076845063 > > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076889743 > > > Test `org.apache.dubbo.demo.provider.ApiProvider` with curl: > > > ``` > > > curl.exe -v --http2 -k -H "Content-Type: application/json" -d '"asd"'

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076895079 > > > Please look into whether Application-Layer Protocol Negotiation is supported in addition to h2c: https://matthewparrilla.com/post/negotiation-http2-alpn-tls-handshake/

Re: [I] [Feature] Remove zk3.4 support in 3.3 [dubbo]

2024-04-25 Thread via GitHub
wcy666103 commented on issue #13960: URL: https://github.com/apache/dubbo/issues/13960#issuecomment-2076967246 Is this issue completed? Is there any progress? I am very interested in this and want to join. @Stellar1999 -- This is an automated message from the Apache Git Service. To

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2076968043 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Feature] Remove zk3.4 support in 3.3 [dubbo]

2024-04-25 Thread via GitHub
Stellar1999 commented on issue #13960: URL: https://github.com/apache/dubbo/issues/13960#issuecomment-2077051833 > Is this issue completed? Is there any progress? I am very interested in this and want to join. @Stellar1999 I believe it's nearly complete and just awaiting merging.

Re: [PR] fix: closing websocket connection returns invalid status code [dubbo-getty]

2024-04-25 Thread via GitHub
AlexStocks merged PR #118: URL: https://github.com/apache/dubbo-getty/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix issue116: limit the reconnect times or duration [dubbo-getty]

2024-04-25 Thread via GitHub
AlexStocks merged PR #117: URL: https://github.com/apache/dubbo-getty/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Is it correct to continue to maintain the connection pool when a connection encounters an error? [dubbo-getty]

2024-04-25 Thread via GitHub
AlexStocks closed issue #116: Is it correct to continue to maintain the connection pool when a connection encounters an error? URL: https://github.com/apache/dubbo-getty/issues/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Triple protocol http1 upgrade support [dubbo]

2024-04-25 Thread via GitHub
walklown commented on code in PR #14026: URL: https://github.com/apache/dubbo/pull/14026#discussion_r1579263649 ## dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java: ## @@ -143,13 +148,63 @@ public void

Re: [PR] fix(3.2): ReactorDubbo3TripleStub.mustache add schema registry [dubbo]

2024-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #14035: URL: https://github.com/apache/dubbo/pull/14035#issuecomment-2076736412 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] Improve documentation (Node aspect) [dubbo-js]

2024-04-25 Thread via GitHub
6iKUN6 commented on issue #367: URL: https://github.com/apache/dubbo-js/issues/367#issuecomment-2077629745 I am sorry that I cannot complete this task within the prescribed time due to my study and work. TvT -- This is an automated message from the Apache Git Service. To respond to the