[GitHub] [incubator-dubbo] carryxyh closed pull request #2620: Fix incorrect descriptions for dubbo-serialization module.

2018-10-08 Thread GitHub
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2620 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] codecov-io commented on issue #2621: fix #1641, support get system load on windows.

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2621?src=pr&el=h1) Report > Merging > [#2621](https://codecov.io/gh/apache/incubator-dubbo/pull/2621?src=pr&el=desc) > into > [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/5adb9bfb59acdba3115f2b4cd1d9ec72ecec42cc?src=p

[GitHub] [incubator-dubbo] codecov-io commented on issue #2621: fix #1641, support get system load on windows.

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2621?src=pr&el=h1) Report > Merging > [#2621](https://codecov.io/gh/apache/incubator-dubbo/pull/2621?src=pr&el=desc) > into > [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/5adb9bfb59acdba3115f2b4cd1d9ec72ecec42cc?src=p

[GitHub] [incubator-dubbo] codecov-io commented on issue #2620: Fix incorrect descriptions for dubbo-serialization module.

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2620?src=pr&el=h1) Report > Merging > [#2620](https://codecov.io/gh/apache/incubator-dubbo/pull/2620?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/8abd59029e7c0bc0973b492fd84a386b26661bc7?src=

[GitHub] [incubator-dubbo] carryxyh commented on issue #2622: Fixed 2.6.x branch a minor issue like #2595

2018-10-08 Thread GitHub
Nice work! LGTM. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2622 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsu

[GitHub] [incubator-dubbo] carryxyh commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
I find several class in dubbo-serialization module. I will start a work on optimize it. Issue: https://github.com/apache/incubator-dubbo/issues/2623 After that, we can make this pr's test simply. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was

[GitHub] [incubator-dubbo] manzhizhen opened pull request #2622: Fixed 2.6.x branch a minor issue like #2595

2018-10-08 Thread GitHub
Fixed 2.6.x branch a minor issue with doConnect not using getConnectTimeout() in NettyClient,like #2595 @carryxyh [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2622 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh opened issue #2623: New module for serialization test

2018-10-08 Thread GitHub
I found that the unit test of the serialization module has serious code duplication problems. I recommend adding a dubbo-serialization-test module to centralize unit tests for other serialization modules. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2623 ] This

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2621: fix #1641, support get system load on windows.

2018-10-08 Thread GitHub
## What is the purpose of the change fix #1641, support get system load on windows. ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache

[GitHub] [incubator-dubbo] carryxyh opened pull request #2620: Fix incorrect descriptions for dubbo-serialization module.

2018-10-08 Thread GitHub
Fix incorrect descriptions for dubbo-serialization module. Simple fix which doesn't need test. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2620 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --

[GitHub] [incubator-dubbo] carryxyh commented on issue #2620: Fix incorrect descriptions for dubbo-serialization module.

2018-10-08 Thread GitHub
Will bring back to 2.6.x. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2620 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notificat

[GitHub] [incubator-dubbo-spring-boot-project] zhucj94 commented on issue #292: 注册不到zookeeper

2018-10-08 Thread GitHub
将base-packages 改为basePackages成功注册 ... [ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/292 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - T

[GitHub] zhucj94 commented on issue #292: 注册不到zookeeper

2018-10-08 Thread GitBox
zhucj94 commented on issue #292: 注册不到zookeeper URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/292#issuecomment-428076858 将base-packages 改为basePackages成功注册 ... This is an automated message from the A

[GitHub] diecui1202 commented on issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo

2018-10-08 Thread GitBox
diecui1202 commented on issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo URL: https://github.com/apache/incubator-dubbo-website/issues/160#issuecomment-428070253 Maybe can not change. If not, what can we do to solve this problem? --

[GitHub] [incubator-dubbo-website] diecui1202 commented on issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo

2018-10-08 Thread GitHub
Maybe can not change. If not, what can we do to solve this problem? [ Full content available at: https://github.com/apache/incubator-dubbo-website/issues/160 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
Why it necessary? Pls test it yourself, but submit simplest. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo-website] diecui1202 commented on issue #159: add download / developer pages

2018-10-08 Thread GitHub
We need to add them to the top menu. @purple-force [ Full content available at: https://github.com/apache/incubator-dubbo-website/issues/159 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] diecui1202 commented on issue #159: add download / developer pages

2018-10-08 Thread GitBox
diecui1202 commented on issue #159: add download / developer pages URL: https://github.com/apache/incubator-dubbo-website/issues/159#issuecomment-428069978 We need to add them to the top menu. @purple-force This is an automa

[GitHub] [incubator-dubbo] 46557783 opened issue #2619: is there a problem in NettyBackedChannelBuffer.setBytes(...)?

2018-10-08 Thread GitHub
hi,I see the code for method setBytes in class com.alibaba.dubbo.remoting.transport.netty4.NettyBackedChannelBuffer.java which is below,is there a problem ? ![image](https://user-images.githubusercontent.com/20593632/46648646-90eaba00-cbc8-11e8-896d-9a1d235d7e0b.png) [ Full content available

[GitHub] [incubator-dubbo] satansk commented on issue #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
@carryxyh The pojos you mention are for tests, and it seems necessary :) [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
miss license [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
remove authoer info [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-u

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
use english [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
unnecessary comment [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-u

[GitHub] [incubator-dubbo] carryxyh commented on pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
license [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2618 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@d

[GitHub] [incubator-dubbo] gudegg commented on issue #2612: 调用dubbo 泛化 rest协议问题

2018-10-08 Thread GitHub
I think the rest protocol is not supported. `GenericService` is not annotated with `@Path`.So throw an exception: ```xml Could not find a method for: public abstract java.lang.Object com.alibaba.dubbo.rpc.service.GenericService.$invoke(java.lang.String,java.lang.String[],java.lang.Object[]) thro

[GitHub] [incubator-dubbo] satansk opened pull request #2618: [Dubbo-1983] Support Protobuf Serialization

2018-10-08 Thread GitHub
## What is the purpose of the change close #1983 ## Brief changelog This Protobuf support is based on [Protostuff](https://github.com/protostuff/protostuff), so we don't need to write proto files by hand. And this PR is based on @vangoleo 's demo [here](https://github.com/vangoleo/incubator-

[GitHub] [incubator-dubbo] dugenkui03 closed pull request #2617: Lru cache fixed

2018-10-08 Thread GitHub
[ pull request closed by dugenkui03 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2617 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] carryxyh closed pull request #2594: 3.x dev cache

2018-10-08 Thread GitHub
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] carryxyh commented on issue #2594: 3.x dev cache

2018-10-08 Thread GitHub
Hi, @dugenkui03 I will close this pr. Expect you to be able to provide a complete cleanup caching strategy. :) [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] carryxyh commented on issue #2595: Fixed a minor issue with doConnect not using getConnectTimeout() in NettyClient

2018-10-08 Thread GitHub
LGTM. Nice work. Pls bring to 2.6.x, too. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2595 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e

[GitHub] [incubator-dubbo] dugenkui03 commented on pull request #2594: 3.x dev cache

2018-10-08 Thread GitHub
when user want to Invalidate cache,espescially in ThreadLocalCache.details about this commit can be found in [#2592](https://github.com/apache/incubator-dubbo/issues/2592) [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ] This message was relayed via gitbox.apac

[GitHub] [incubator-dubbo] carryxyh closed pull request #2595: Fixed a minor issue with doConnect not using getConnectTimeout() in NettyClient

2018-10-08 Thread GitHub
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2595 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] dugenkui03 opened pull request #2617: Lru cache fixed

2018-10-08 Thread GitHub
## What is the purpose of the change #2610 ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the

[GitHub] [incubator-dubbo] carryxyh commented on issue #2610: 优化 LRUCache读取性能

2018-10-08 Thread GitHub
@beiwei30 @dugenkui03 I think it is a good idea. Thx for your issue and pr. But if there are some performance tests, it will be more convincing. :) [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2610 ] This message was relayed via gitbox.apache.org for notificati

[GitHub] [incubator-dubbo] dugenkui03 closed pull request #2616: Lru cache fixed

2018-10-08 Thread GitHub
[ pull request closed by dugenkui03 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2616 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] carryxyh closed pull request #2608: Remove unuse class.

2018-10-08 Thread GitHub
[ pull request closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2608 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail:

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2615: update release script

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2615 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] carryxyh closed issue #2546: Consumer Node Not destroy

2018-10-08 Thread GitHub
[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2546 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: noti

[GitHub] [incubator-dubbo] dugenkui03 opened pull request #2616: Lru cache fixed

2018-10-08 Thread GitHub
## What is the purpose of the change #2610 ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the

[GitHub] [incubator-dubbo] carryxyh commented on issue #2546: Consumer Node Not destroy

2018-10-08 Thread GitHub
@GodIsDevil Hi, thx for your issue. However, I just verified your problem, the consumer node will be deleted, because the currently created consumer node is an ephemeral node. It will be automatically removed from zk when the consumer goes offline. @SuperDubbo As for your explanation, it is a

[GitHub] [incubator-dubbo] dugenkui03 closed pull request #2611: Lru cache fixed

2018-10-08 Thread GitHub
[ pull request closed by dugenkui03 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2611 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] codecov-io commented on issue #2615: update release script

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2615?src=pr&el=h1) Report > Merging > [#2615](https://codecov.io/gh/apache/incubator-dubbo/pull/2615?src=pr&el=desc) > into > [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/c4eb4e8ceb14965f2abd881b70ba6f1f994d3940?src=p

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2615: update release script

2018-10-08 Thread GitHub
## What is the purpose of the change This script can help to do the releasing work simply, just use: `./release.sh g...@github.com:apache/incubator-dubbo.git 2.6.5-release`, then the script will git clone the remote branch to local, build it, deploy it if necessary, it's depend on your choice.

[GitHub] [incubator-dubbo] codecov-io commented on issue #2614: Issue2583

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2614?src=pr&el=h1) Report > Merging > [#2614](https://codecov.io/gh/apache/incubator-dubbo/pull/2614?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/046bc3081f7a98d539f9fb1b9af375ad80868ea8?src=

[GitHub] [incubator-dubbo] codecov-io commented on issue #2614: Issue2583

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2614?src=pr&el=h1) Report > Merging > [#2614](https://codecov.io/gh/apache/incubator-dubbo/pull/2614?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/046bc3081f7a98d539f9fb1b9af375ad80868ea8?src=

[GitHub] [incubator-dubbo] beiwei30 opened pull request #2614: Issue2583

2018-10-08 Thread GitHub
## What is the purpose of the change fix issue2583 ## Brief changelog dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/model/ApplicationModel.java dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/command/impl/Offline.java dubbo-plugin/dubbo-qos/src/main/java/org/apach

[GitHub] [incubator-dubbo] carryxyh commented on issue #2594: 3.x dev cache

2018-10-08 Thread GitHub
Do not agree with this pr. Unless a complete set of expiration policies can be provided. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2594 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [incubator-dubbo] cvictory commented on issue #2522: `org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor#generateReferenceBeanCacheKey` has a bug

2018-10-08 Thread GitHub
@zonghaishang how is it going? If you fix it, please edit the milestone to 2.6.5. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2522 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --

[GitHub] [incubator-dubbo] yishunli opened issue #2613: dubbo在调节权重时,编辑保存后,端口号丢失

2018-10-08 Thread GitHub
- [ ] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate. - [ ] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplic

[GitHub] [incubator-dubbo] zyh1218 opened issue #2612: 调用dubbo 泛化 rest协议问题

2018-10-08 Thread GitHub
当我在setUrl 是rest协议的时候报错,请问这是什么原因的 代码如下 ![image](https://user-images.githubusercontent.com/5111738/46642961-68ed5d80-cbac-11e8-8db1-a3cf5cfdc8ae.png) [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2612 ] This message was relayed via gitbox.apache.org for notificatio

[GitHub] purple-force commented on issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo

2018-10-08 Thread GitBox
purple-force commented on issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo URL: https://github.com/apache/incubator-dubbo-website/issues/160#issuecomment-428034892 The site has a redirect to specific language(zh-cn or en-us), can it change to `curl http://dubb

[GitHub] [incubator-dubbo-website] purple-force commented on issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo

2018-10-08 Thread GitHub
The site has a redirect to specific language(zh-cn or en-us), can it change to `curl http://dubbo.incubator.apache.org/zh-cn/` or `curl http://dubbo.incubator.apache.org/en-us/`? [ Full content available at: https://github.com/apache/incubator-dubbo-website/issues/160 ] This message was relayed

[GitHub] zhucj94 opened a new issue #292: 注册不到zookeeper

2018-10-08 Thread GitBox
zhucj94 opened a new issue #292: 注册不到zookeeper URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/292 yml `dubbo: scan: base-packages: com.zjy.log.service.dubboProducer registry: address: zookeeper://localhost:2181 application: na

[GitHub] [incubator-dubbo-spring-boot-project] zhucj94 opened issue #292: 注册不到zookeeper

2018-10-08 Thread GitHub
yml `dubbo: scan: base-packages: com.zjy.log.service.dubboProducer registry: address: zookeeper://localhost:2181 application: name: logDubboService id: logDubboService protocol: name: dubbo id: dubbo port: 20884` class `@Service(application = "${dubbo.application

[GitHub] itmyhome commented on issue #226: dubbo自动化配置 base-packages 错误导致 无法暴露服务

2018-10-08 Thread GitBox
itmyhome commented on issue #226: dubbo自动化配置 base-packages 错误导致 无法暴露服务 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/226#issuecomment-428034387 同样遇到该问题,但是不明白为什么改成basePackages就能解决 This is an automat

[GitHub] [incubator-dubbo-spring-boot-project] itmyhome commented on issue #226: dubbo自动化配置 base-packages 错误导致 无法暴露服务

2018-10-08 Thread GitHub
同样遇到该问题,但是不明白为什么改成basePackages就能解决 [ Full content available at: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/226 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To u

[GitHub] [incubator-dubbo-website] purple-force commented on issue #159: add download / developer pages

2018-10-08 Thread GitHub
you just need to write a markdown file and add it to blog or docs page [ Full content available at: https://github.com/apache/incubator-dubbo-website/issues/159 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org -

[GitHub] purple-force commented on issue #159: add download / developer pages

2018-10-08 Thread GitBox
purple-force commented on issue #159: add download / developer pages URL: https://github.com/apache/incubator-dubbo-website/issues/159#issuecomment-428033952 you just need to write a markdown file and add it to blog or docs page -

[GitHub] [incubator-dubbo] carryxyh closed issue #2295: Try to remove the lock in DefaultFuture.

2018-10-08 Thread GitHub
[ issue closed by carryxyh ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2295 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: noti

[GitHub] [incubator-dubbo] carryxyh commented on issue #2295: Try to remove the lock in DefaultFuture.

2018-10-08 Thread GitHub
foucus on:https://github.com/apache/incubator-dubbo/issues/2508 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2295 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [incubator-dubbo] carryxyh commented on issue #2508: [Performance optimization] Dubbo performance improvement

2018-10-08 Thread GitHub
Related issue:https://github.com/apache/incubator-dubbo/issues/2295 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2508 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [incubator-dubbo] beiwei30 commented on issue #2610: 优化 LRUCache读取性能

2018-10-08 Thread GitHub
@dugenkui03 looks like your implementation fails the unit tests. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2610 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --

[GitHub] diecui1202 opened a new issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo

2018-10-08 Thread GitBox
diecui1202 opened a new issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo URL: https://github.com/apache/incubator-dubbo-website/issues/160 It uses `curl curl http://dubbo.incubator.apache.org`, and gets the html text, then checks it. But now the html tex

[GitHub] [incubator-dubbo-website] diecui1202 opened issue #160: apache check failed, https://whimsy.apache.org/pods/project/dubbo

2018-10-08 Thread GitHub
It uses `curl curl http://dubbo.incubator.apache.org`, and gets the html text, then checks it. But now the html text is just a javascript code, so all check failed. We need to make sure the text right. [ Full content available at: https://github.com/apache/incubator-dubbo-website/issues/160 ]

[GitHub] [incubator-dubbo-website] diecui1202 opened issue #159: add download / developer pages

2018-10-08 Thread GitHub
just like servicecomb: http://servicecomb.apache.org/release/ http://servicecomb.apache.org/developers/ [ Full content available at: https://github.com/apache/incubator-dubbo-website/issues/159 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --

[GitHub] diecui1202 opened a new issue #159: add download / developer pages

2018-10-08 Thread GitBox
diecui1202 opened a new issue #159: add download / developer pages URL: https://github.com/apache/incubator-dubbo-website/issues/159 just like servicecomb: http://servicecomb.apache.org/release/ http://servicecomb.apache.org/developers/ ---

[GitHub] [incubator-dubbo] diecui1202 closed issue #2605: remove java9 in .travis.yml on 2.6.x

2018-10-08 Thread GitHub
[ issue closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2605 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: no

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2609: Dubbo-2605 Removed java9 from .travis.yml

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2609 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2604: fix #2600 add javadoc-plugin to dubbo-all module

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2604 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] diecui1202 closed issue #2600: add javadoc to dubbo-all module

2018-10-08 Thread GitHub
[ issue closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2600 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: no

[GitHub] [incubator-dubbo] Createst commented on issue #2599: 消费者调用报java.lang.NoSuchMethod异常

2018-10-08 Thread GitHub
> I think most likely you are using different versions of service definition on > the Consumer and Provider side. Have you changed the method signature > recently? > > Can you please paste the exception stack trace? 服务端和消费者的dubbo版本都是2.6.1。 每次修改方法名都会同步到消费者,而且在第一次上线没有出现问题,第二次出现的问题,代码都没有一点修改。 [ F

[GitHub] [incubator-dubbo] Createst commented on issue #2599: 消费者调用报java.lang.NoSuchMethod异常

2018-10-08 Thread GitHub
> it should be interface compatibility issue in your system. 接口兼容性是什么意思?谢谢! [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2599 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [incubator-dubbo] dugenkui03 opened pull request #2611: Lru cache fixed

2018-10-08 Thread GitHub
## What is the purpose of the change #2610 ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the

[GitHub] [incubator-dubbo] dugenkui03 opened issue #2610: 优化 LRUCache读取性能

2018-10-08 Thread GitHub
[LRUCache](https://github.com/apache/incubator-dubbo/blob/master/dubbo-common/src/main/java/org/apache/dubbo/common/utils/LRUCache.java) 问题 查询可以加共享锁,更新时才需要加排他锁。因此可以使用信号量替代排他锁提高查询操作的性能。 思路: 1. 必须使用公平锁:由AQS和Semaphore源码可知非公平锁在高并发情况下会导致更新操作难以执行; 2. 信号量初始值为Integer.MAX_VALUE,读取操作则将状态值减1,更新

[GitHub] [incubator-dubbo] codecov-io commented on issue #2609: Dubbo-2605 Removed java9 from .travis.yml

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=h1) Report > Merging > [#2609](https://codecov.io/gh/apache/incubator-dubbo/pull/2609?src=pr&el=desc) > into > [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/79ea2acba862ed31dec2615220e0accac49c3dfb?src=p

[GitHub] [incubator-dubbo] cbolgiano commented on issue #2605: remove java9 in .travis.yml on 2.6.x

2018-10-08 Thread GitHub
Created PR to fix this issue: https://github.com/apache/incubator-dubbo/pull/2609 [ Full content available at: https://github.com/apache/incubator-dubbo/issues/2605 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] cbolgiano opened pull request #2609: Dubbo-2605 Removed java9 from .travis.yml

2018-10-08 Thread GitHub
## What is the purpose of the change To fix issue 2605 by removing jdk9 from .travis.yml. ## Brief changelog commit 99babae7ff6e947059fee14cc2425aead46e6be8 (HEAD -> remove-javatr avis-issue-2605, origin/remove-java9-travis-issue-2605) Author: devbox

[GitHub] [incubator-dubbo] codecov-io commented on issue #2608: Remove unuse class.

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2608?src=pr&el=h1) Report > Merging > [#2608](https://codecov.io/gh/apache/incubator-dubbo/pull/2608?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/3c34ee88fd79b5df0441320e53042b60a00bf76b?src=

[GitHub] [incubator-dubbo] carryxyh opened pull request #2608: Remove unuse class.

2018-10-08 Thread GitHub
Remove unuse class. * DelegateExporter.java * DelegateInvoker.java [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2608 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org --

[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #2607: remove serviceclassHolder

2018-10-08 Thread GitHub
Fix the issue #2606 [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2607 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-

[GitHub] [incubator-dubbo] Jeff-Lv opened issue #2606: Rest-Rpc adds a uncommon class ServiceClassHolder

2018-10-08 Thread GitHub
As the class ServiceClassHolder's javadoc saying, “TODO this is just a workaround for rest protocol, and now we just ensure it works in the most common dubbo usages” We need to refactor it and remove this temp solution with a common way. ### Expected Result Impove the way of rest impletation

[GitHub] [incubator-dubbo] diecui1202 opened issue #2605: remove java9 in .travis.yml on 2.6.x

2018-10-08 Thread GitHub
[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2605 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2604: fix #2600 add javadoc-plugin to dubbo-all module

2018-10-08 Thread GitHub
## What is the purpose of the change fix #2600 add javadoc-plugin to dubbo-all module ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apac

[GitHub] nzomkxia opened a new issue #133: i18n support

2018-10-08 Thread GitBox
nzomkxia opened a new issue #133: i18n support URL: https://github.com/apache/incubator-dubbo-ops/issues/133 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use th

[GitHub] [incubator-dubbo-ops] nzomkxia opened issue #133: i18n support

2018-10-08 Thread GitHub
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/issues/133 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dub

[GitHub] [incubator-dubbo] mercyblitz commented on issue #1770: [Enhancement] @EnableDubboConfigBinding annotates @Repeatable

2018-10-08 Thread GitHub
@cvictory it both works Dubbo 2.6.x and 2.7.x, and may do later [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2602: fix #2600, add javadoc plugin to dubbo-all module

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2602 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] codecov-io commented on issue #2602: fix #2600, add javadoc plugin to dubbo-all module

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2602?src=pr&el=h1) Report > Merging > [#2602](https://codecov.io/gh/apache/incubator-dubbo/pull/2602?src=pr&el=desc) > into > [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/f77c9fcc5ecfa10ce535a75b877bbce9ba078c70?src=p

[GitHub] [incubator-dubbo] cvictory opened pull request #2603: [Dubbo-2298] Add Annotation-Driven for MethodConfig and ArgumentConfig

2018-10-08 Thread GitHub
## What is the purpose of the change Add Annotation-Driven for MethodConfig and ArgumentConfig for https://github.com/apache/incubator-dubbo/issues/2298 ## Brief changelog * Add @Method and @Argument annotation for MethodConfig and ArgumentConfig. * Make these annotation effecient. ## Verifyi

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2602: fix #2600, add javadoc plugin to dubbo-all module

2018-10-08 Thread GitHub
## What is the purpose of the change fix #2600, add javadoc plugin to dubbo-all module ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apa

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2601 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] codecov-io commented on issue #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr&el=h1) Report > Merging > [#2601](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9b7284f4d5c7f48e5d164670eb512d16987e5e25?src=

[GitHub] [incubator-dubbo] codecov-io commented on issue #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr&el=h1) Report > Merging > [#2601](https://codecov.io/gh/apache/incubator-dubbo/pull/2601?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/incubator-dubbo/commit/9b7284f4d5c7f48e5d164670eb512d16987e5e25?src=

[GitHub] [incubator-dubbo] cvictory commented on issue #1770: [Enhancement] @EnableDubboConfigBinding annotates @Repeatable

2018-10-08 Thread GitHub
I think we can add this annotation at both 2.7.x version. @Repeatable is effcient after jdk1.8. [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1770 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org ---

[GitHub] [incubator-dubbo] diecui1202 opened pull request #2601: update lastest version to 2.6.4

2018-10-08 Thread GitHub
## What is the purpose of the change update lastest version to 2.6.4 ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubb

[GitHub] [incubator-dubbo] carryxyh commented on issue #2595: Fixed a minor issue with doConnect not using getConnectTimeout() in NettyClient

2018-10-08 Thread GitHub
LGTM. Nice work. [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2595 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsu

[GitHub] [incubator-dubbo] diecui1202 closed pull request #2582: applicationmodel provider & consumer serviceName is not unique

2018-10-08 Thread GitHub
[ pull request closed by diecui1202 ] [ Full content available at: https://github.com/apache/incubator-dubbo/pull/2582 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mai

[GitHub] [incubator-dubbo] cvictory commented on issue #1784: Dubbo调用超时,服务端历史统计的处理耗时很短且找不到对应超时上下文的超时日志

2018-10-08 Thread GitHub
@Jaskey is it ok now? [ Full content available at: https://github.com/apache/incubator-dubbo/issues/1784 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notificati

[GitHub] [incubator-dubbo] diecui1202 opened issue #2600: add javadoc to dubbo-all module

2018-10-08 Thread GitHub
``` release maven-javadoc-plugin ${maven_javadoc_version} attach-javadoc

  1   2   >