[GitHub] [dubbo] mercyblitz closed pull request #4955: fix default setting

2019-09-09 Thread GitHub 
[ pull request closed by mercyblitz ]

[ Full content available at: https://github.com/apache/dubbo/pull/4955 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #194: Add: new feature to support dynamic config center which compatible with dubbo 2.6.x & 2.7.x

2019-09-09 Thread GitHub 
@AlexStocks I means this if I delete else ,then I can not access the variable 
rawConfig.

[ Full content available at: https://github.com/apache/dubbo-go/pull/194 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] hxmhlt commented on pull request #194: Add: new feature to support dynamic config center which compatible with dubbo 2.6.x & 2.7.x

2019-09-09 Thread GitHub 
![image](https://user-images.githubusercontent.com/13016899/64581807-1e78f000-d3be-11e9-98c0-016258453c2a.png)


[ Full content available at: https://github.com/apache/dubbo-go/pull/194 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #3649: [Dubbo-3629] Fix ServiceConfig duplicate export produces misleading exception

2019-09-09 Thread GitHub 
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649) before we 
can accept your contribution.**0** out of **2** committers have signed the 
CLA.:x: JerryChin:x: meijieqinYou have signed the CLA 
already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3649) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/3649 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager

2019-09-09 Thread GitHub 
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we 
can accept your contribution.**1** out of **2** committers have signed the 
CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to 
be a GitHub user. You need a GitHub account to be able to sign the CLA. If you 
have already a GitHub account, please [add the email address used for this 
commit to your 
account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You
 have signed the CLA already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/4811 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4955: fix default setting

2019-09-09 Thread GitHub 
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4955)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4955) before we 
can accept your contribution.**6** out of **19** committers have signed 
the CLA.:white_check_mark: beiwei30:white_check_mark: 
mercyblitz:white_check_mark: qixiaobo:white_check_mark: 
chickenlj:white_check_mark: brucelwl:white_check_mark: 
cyejing:x: kexianjun:x: dongYES:x: uglycow:x: 
LiZhenNet:x: lexburner:x: CrazyHZM:x: kuaike:x: 
P3trur0:x: nzomkxia:x: wanghb:x: cvictory:x: 
biyuhao:x: 356082462You have signed the CLA already but the 
status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullR
 equest=4955) it.

[ Full content available at: https://github.com/apache/dubbo/pull/4955 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-admin] codecov-io commented on issue #501: dubbo2.7.3条件路由配置不生效 fix #500

2019-09-09 Thread GitHub 
# [Codecov](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=h1) 
Report
> Merging 
> [#501](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=desc) into 
> [develop](https://codecov.io/gh/apache/dubbo-admin/commit/342e3cbd48b7d26aa228db5b7b529b85cb53a958?src=pr=desc)
>  will **not change** coverage.
> The diff coverage is `33.33%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-admin/pull/501/graphs/tree.svg?width=650=fYsc8RuDGB=150=pr)](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=tree)

```diff
@@Coverage Diff @@
## develop #501   +/-   ##
==
  Coverage  22.55%   22.55%   
  Complexity   293  293   
==
  Files 80   80   
  Lines   3205 3205   
  Branches 515  515   
==
  Hits 723  723   
  Misses  2407 2407   
  Partials  75   75
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=tree) | 
Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/dubbo-admin/pull/501/diff?src=pr=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9jb21tb24vdXRpbC9Db25zdGFudHMuamF2YQ==)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| 
[.../dubbo/admin/service/impl/OverrideServiceImpl.java](https://codecov.io/gh/apache/dubbo-admin/pull/501/diff?src=pr=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvT3ZlcnJpZGVTZXJ2aWNlSW1wbC5qYXZh)
 | `0.57% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| 
[...che/dubbo/admin/service/impl/RouteServiceImpl.java](https://codecov.io/gh/apache/dubbo-admin/pull/501/diff?src=pr=tree#diff-ZHViYm8tYWRtaW4tc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9hZG1pbi9zZXJ2aWNlL2ltcGwvUm91dGVTZXJ2aWNlSW1wbC5qYXZh)
 | `41.46% <50%> (ø)` | `13 <0> (ø)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=footer).
>  Last update 
> [342e3cb...823bbcf](https://codecov.io/gh/apache/dubbo-admin/pull/501?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-admin/pull/501 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-samples] wujun opened a new issue #117: absence of dubbo-maven-address-plugin module for branch 2.6.x

2019-09-09 Thread GitBox 
wujun opened a new issue #117: absence of dubbo-maven-address-plugin module for 
branch 2.6.x
URL: https://github.com/apache/dubbo-samples/issues/117
 
 
   Because official maven repository doesn't support v 2.7.3 of dubbo now, I 
have to go back to branch v2.6.x. for integration test. But I can't found 
dubbo-maven-address-plugin module in repo and pom file


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] Python-IBM closed issue #4965: Dubbo service grouping registered with nacos, the grouping is not valid

2019-09-09 Thread GitHub 
[ issue closed by Python-IBM ]

[ Full content available at: https://github.com/apache/dubbo/issues/4965 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] htynkn closed pull request #5026: Change main method under dubbo-remoting-api to standard test

2019-09-09 Thread GitHub 
[ pull request closed by htynkn ]

[ Full content available at: https://github.com/apache/dubbo/pull/5026 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] htynkn commented on issue #5026: Change main method under dubbo-remoting-api to standard test

2019-09-09 Thread GitHub 
Thanks for your contribution

[ Full content available at: https://github.com/apache/dubbo/pull/5026 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-admin] fllife commented on issue #504: dubbo2.7 应用粒度的权重配置不生效

2019-09-09 Thread GitHub 
### 权重属性读写path不一致导致
权重属性zk写入path和dubbo读取path不一致导致的问题，
+ zk写入路径为:/dubbo/config/${application}/configurators
+ dubbo读取路径为:/dubbo/config/dubbo/${application}.configurators
dubbo读到数据为空，导致不存权重不生效

[ Full content available at: https://github.com/apache/dubbo-admin/issues/504 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] codecov-io commented on issue #5026: Change main method under dubbo-remoting-api to standard test

2019-09-09 Thread GitHub 
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5026?src=pr=h1) Report
> Merging [#5026](https://codecov.io/gh/apache/dubbo/pull/5026?src=pr=desc) 
> into 
> [master](https://codecov.io/gh/apache/dubbo/commit/1cb034cd0b0c8e79b1ecb2595dd283b0d4bd1a9f?src=pr=desc)
>  will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo/pull/5026/graphs/tree.svg?width=650=VnEIkiFQT0=150=pr)](https://codecov.io/gh/apache/dubbo/pull/5026?src=pr=tree)

```diff
@@ Coverage Diff  @@
## master#5026  +/-   ##

- Coverage 63.99%   63.93%   -0.07% 
- Complexity  451  453   +2 

  Files   769  769  
  Lines 3317633194  +18 
  Branches   5230 5236   +6 

- Hits  2123121222   -9 
- Misses 9523 9551  +28 
+ Partials   2422 2421   -1
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5026?src=pr=tree) 
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
| 
[.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh)
 | `61.9% <0%> (-9.53%)` | `0% <0%> (ø)` | |
| 
[.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==)
 | `79.16% <0%> (-8.34%)` | `0% <0%> (ø)` | |
| 
[...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==)
 | `51.42% <0%> (-5.72%)` | `0% <0%> (ø)` | |
| 
[...ng/exchange/support/header/HeartbeatTimerTask.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRUaW1lclRhc2suamF2YQ==)
 | `73.68% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| 
[.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==)
 | `15.78% <0%> (-5.27%)` | `0% <0%> (ø)` | |
| 
[...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh)
 | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| 
[...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==)
 | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | |
| 
[...exchange/support/header/HeaderExchangeHandler.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZUhhbmRsZXIuamF2YQ==)
 | `64.75% <0%> (-2.46%)` | `0% <0%> (ø)` | |
| 
[...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==)
 | `67.87% <0%> (-1.81%)` | `0% <0%> (ø)` | |
| 
[...va/org/apache/dubbo/rpc/support/ProtocolUtils.java](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L1Byb3RvY29sVXRpbHMuamF2YQ==)
 | `70.37% <0%> (-1.63%)` | `0% <0%> (ø)` | |
| ... and [14 
more](https://codecov.io/gh/apache/dubbo/pull/5026/diff?src=pr=tree-more) | |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo/pull/5026?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo/pull/5026?src=pr=footer). 
> Last update 
>

[GitHub] [dubbo-admin] fllife closed issue #499: 动态配置添加service的ConditionRouter。但是consumer生成Invoker过程中未生效

2019-09-09 Thread GitHub 
[ issue closed by fllife ]

[ Full content available at: https://github.com/apache/dubbo-admin/issues/499 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #193: Add: invoker & attachments & merge master

2019-09-09 Thread GitHub 
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=h1) Report
> Merging [#193](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=desc) 
> into 
> [develop](https://codecov.io/gh/apache/dubbo-go/commit/359bdab8e26f71b54158d21a18ad8313790785c0?src=pr=desc)
>  will **decrease** coverage by `0.09%`.
> The diff coverage is `43.07%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/dubbo-go/pull/193/graphs/tree.svg?width=650=dcPE6RyFAL=150=pr)](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=tree)

```diff
@@Coverage Diff @@
##   develop #193 +/-   ##
==
- Coverage66.71%   66.62%   -0.1% 
==
  Files   94   94 
  Lines 5870 5818 -52 
==
- Hits  3916 3876 -40 
+ Misses1545 1540  -5 
+ Partials   409  402  -7
```


| [Impacted 
Files](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=)
 | `95.55% <ø> (ø)` | :arrow_up: |
| 
[protocol/dubbo/dubbo\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vZHViYm9faW52b2tlci5nbw==)
 | `82.92% <100%> (+0.87%)` | :arrow_up: |
| 
[protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=)
 | `76.47% <100%> (+2.94%)` | :arrow_up: |
| 
[filter/impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-ZmlsdGVyL2ltcGwvZWNob19maWx0ZXIuZ28=)
 | `85.71% <100%> (+1.09%)` | :arrow_up: |
| 
[registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=)
 | `75% <25%> (-1.54%)` | :arrow_down: |
| 
[common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==)
 | `18.33% <3.92%> (-81.67%)` | :arrow_down: |
| 
[protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=)
 | `50% <36.36%> (-4.17%)` | :arrow_down: |
| 
[protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==)
 | `69.23% <50%> (-2.57%)` | :arrow_down: |
| 
[protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=)
 | `59.79% <50%> (+7.89%)` | :arrow_up: |
| 
[protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv)
 | `70.94% <96.29%> (+2.56%)` | :arrow_up: |
| ... and [1 
more](https://codecov.io/gh/apache/dubbo-go/pull/193/diff?src=pr=tree-more) 
| |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=continue).
> **Legend** - [Click here to learn 
> more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
> Powered by 
> [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=footer). 
> Last update 
> [359bdab...ddcf560](https://codecov.io/gh/apache/dubbo-go/pull/193?src=pr=lastupdated).
>  Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/193 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org

-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #3649: [Dubbo-3629] Fix ServiceConfig duplicate export produces misleading exception

2019-09-09 Thread GitHub 
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649) before we 
can accept your contribution.**0** out of **2** committers have signed the 
CLA.:x: meijieqin:x: JerryChinYou have signed the CLA 
already but the status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3649) 
it.

[ Full content available at: https://github.com/apache/dubbo/pull/3649 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org

[GitHub] [dubbo] CLAassistant commented on issue #4955: fix default setting

2019-09-09 Thread GitHub 
[![CLA assistant 
check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4955)
 Thank you for your submission, we really appreciate it. Like many open 
source projects, we ask that you all sign our [Contributor License 
Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4955) before we 
can accept your contribution.**6** out of **19** committers have signed 
the CLA.:white_check_mark: chickenlj:white_check_mark: 
beiwei30:white_check_mark: brucelwl:white_check_mark: 
cyejing:white_check_mark: mercyblitz:white_check_mark: 
qixiaobo:x: CrazyHZM:x: cvictory:x: kuaike:x: 
P3trur0:x: nzomkxia:x: wanghb:x: biyuhao:x: 
356082462:x: lexburner:x: kexianjun:x: dongYES:x: 
uglycow:x: LiZhenNetYou have signed the CLA already but the 
status is still pending? Let us 
[recheck](https://cla-assistant.io/check/alibaba/dubbo?pullR
 equest=4955) it.

[ Full content available at: https://github.com/apache/dubbo/pull/4955 ]
This message was relayed via gitbox.apache.org for 
notifications@dubbo.apache.org


-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org