[GitHub] [dubbo] sonymoon commented on issue #5041: No matter how I set it, the version is always 0.0.0
I have a demo locally. It works fine. Do you have a demo git repository link? [ Full content available at: https://github.com/apache/dubbo/issues/5041 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify service annotation protocol
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it. [ Full content available at: https://github.com/apache/dubbo/pull/5051 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #3649: [Dubbo-3629] Fix ServiceConfig duplicate export produces misleading exception
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3649) before we can accept your contribution.**0** out of **2** committers have signed the CLA.:x: meijieqin:x: JerryChinYou have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3649) it. [ Full content available at: https://github.com/apache/dubbo/pull/3649 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #4296: add support for field name convert. e.g. order_id <-> orderId
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4296) before we can accept your contribution.**2** out of **3** committers have signed the CLA.:white_check_mark: rolandhe:white_check_mark: beiwei30:x: hexiufeng**hexiufeng** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullReques t=4296) it. [ Full content available at: https://github.com/apache/dubbo/pull/4296 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #3897: add socks5 proxy support to 2.6.x netty4 client
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=3897) before we can accept your contribution.**骄龙** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3897) it. [ Full content available at: https://github.com/apache/dubbo/pull/3897 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #4636: fix #4635 provider throw RpcException custom retry not correct times
[![CLA assistant check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4636) All committers have signed the CLA. [ Full content available at: https://github.com/apache/dubbo/pull/4636 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we can accept your contribution.**1** out of **2** committers have signed the CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) it. [ Full content available at: https://github.com/apache/dubbo/pull/4811 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5054: code optimization
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5054) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5054) before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5054) it. [ Full content available at: https://github.com/apache/dubbo/pull/5054 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #5051: specify service annotation protocol
[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=5051) before we can accept your contribution.**vghy顾海洋** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=5051) it. [ Full content available at: https://github.com/apache/dubbo/pull/5051 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #201: Fix:fix url params unsafe
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=h1) Report > Merging [#201](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/cf198d0e3e5977f77b52ced2d45da16b52f92d2e?src=pr&el=desc) > will **increase** coverage by `1.17%`. > The diff coverage is `83.33%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/201/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #201 +/- ## === + Coverage 66.7% 67.88% +1.17% === Files 94 94 Lines 5820 5847 +27 === + Hits 3882 3969 +87 + Misses1538 1476 -62 - Partials 400 402 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `68.08% <0%> (-3.03%)` | :arrow_down: | | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `74.5% <100%> (+0.5%)` | :arrow_up: | | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `62.91% <100%> (+0.31%)` | :arrow_up: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `56.25% <100%> (+0.5%)` | :arrow_up: | | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: | | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `75.98% <85.71%> (+1.09%)` | :arrow_up: | | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.58% <0%> (+0.86%)` | :arrow_up: | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (+1.54%)` | :arrow_up: | | [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <0%> (+2.46%)` | :arrow_up: | | [protocol/dubbo/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY29kZWMuZ28=) | `82.35% <0%> (+5.88%)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=footer). > Last update > [cf198d0...d6fadc1](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/201 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4397: fix register config not take effect because of url simplified
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=h1) Report > Merging [#4397](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/7d564e75fe776681e9e3c0a6f6bd1c4ad1ea51af?src=pr&el=desc) > will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/4397/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4397 +/- ## + Coverage 63.96% 63.97% +0.01% Complexity 452 452 Files 769 769 Lines 3320633206 Branches 5237 5237 + Hits 2123921244 +5 + Misses 9546 9543 -3 + Partials 2421 2419 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `82.69% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0%> (-4.55%)` | `20% <0%> (-1%)` | | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `64.77% <0%> (-2.28%)` | `0% <0%> (ø)` | | | [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `62.75% <0%> (+0.34%)` | `0% <0%> (ø)` | :arrow_down: | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `69.68% <0%> (+0.45%)` | `0% <0%> (ø)` | :arrow_down: | | [...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh) | `72.83% <0%> (+1.73%)` | `0% <0%> (ø)` | :arrow_down: | | [...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1yZXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcHJvdG9jb2wvcmVzdC9SZXN0UHJvdG9jb2wuamF2YQ==) | `71.31% <0%> (+3.1%)` | `0% <0%> (ø)` | :arrow_down: | | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `73.21% <0%> (+3.57%)` | `9% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=footer). > Last update > [7d564e7...b905448](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo/pull/4397 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on issue #201: Fix:fix url params unsafe
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=h1) Report > Merging [#201](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/cf198d0e3e5977f77b52ced2d45da16b52f92d2e?src=pr&el=desc) > will **increase** coverage by `0.22%`. > The diff coverage is `83.33%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/201/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #201 +/- ## === + Coverage 66.7% 66.92% +0.22% === Files 94 94 Lines 5820 5847 +27 === + Hits 3882 3913 +31 + Misses1538 1536 -2 + Partials 400 398 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `68.08% <0%> (-3.03%)` | :arrow_down: | | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `74.5% <100%> (+0.5%)` | :arrow_up: | | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `62.91% <100%> (+0.31%)` | :arrow_up: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `56.25% <100%> (+0.5%)` | :arrow_up: | | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: | | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `75.98% <85.71%> (+1.09%)` | :arrow_up: | | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.58% <0%> (+0.86%)` | :arrow_up: | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (+1.54%)` | :arrow_up: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `80.64% <0%> (+2.15%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=footer). > Last update > [cf198d0...d6fadc1](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/201 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] imsunv commented on issue #4397: fix register config not take effect because of url simplified
fixed it by keep Line separator with CRLF [ Full content available at: https://github.com/apache/dubbo/pull/4397 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on issue #129: fix:go emoji to java emoji(a character takes up 3-4 bytes of special symbols)
@pantianying I find that java uses two 16-bit characters to represent emoji "🤣", while golang uses one rune to represent it. So the length of the emoji in java is 2, while 1 in golang. The hessian protocol says that: > The length is the number of 16-bit characters. So, it's a bug of golang hessian2, I will try to fix it. [ Full content available at: https://github.com/apache/dubbo-go-hessian2/issues/129 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] zhangyyii commented on issue #1012: Wanted: who's using dubbo
组织:中通快递 地点:上海 联系方式:zhan...@zto.cn 场景:内部服务化改造,服务治理 [ Full content available at: https://github.com/apache/dubbo/issues/1012 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] YeautyYE opened issue #5056: token and tag is ineffective when I use telnet command
![image](https://user-images.githubusercontent.com/37794518/64752612-cb847180-d552-11e9-842c-5e207e9fd836.png) ![image](https://user-images.githubusercontent.com/37794518/64752621-d212e900-d552-11e9-842b-3761c69050a7.png) [ Full content available at: https://github.com/apache/dubbo/issues/5056 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-spring-boot-project]
[ Full content available at: https://github.com/apache/dubbo-spring-boot-project/issues/537 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] imsunv commented on pull request #4397: fix register config not take effect because of url simplified
调不回来了,我重新开个Pr 吧 [ Full content available at: https://github.com/apache/dubbo/pull/4397 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] sofkyle commented on issue #349: 优先级那段感觉有问题
Please attach the link. [ Full content available at: https://github.com/apache/dubbo-website/issues/349 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] leechor closed pull request #5055: rearrange and simplity ExtensionLoader and config code
[ pull request closed by leechor ] [ Full content available at: https://github.com/apache/dubbo/pull/5055 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-website] sofkyle opened pull request #471: Translate an introduction to metadata center
## What is the purpose of the change Translate an introduction to metadata center ## Brief changelog /docs/zh-cn/user/references/metadata/introduction.md /docs/en-us/user/references/metadata/introduction.md /site_config/docs.js Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo-website/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Test your code locally by running `docsite start`, and make sure it works as expected. - [x] Make sure no files under build directory is added. - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). [ Full content available at: https://github.com/apache/dubbo-website/pull/471 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] leechor opened pull request #5055: rearrange and simplity ExtensionLoader and config code
## What is the purpose of the change rearrange and simplity ExtensionLoader and config code, make more readability. some code rewrite with lambda. [ Full content available at: https://github.com/apache/dubbo/pull/5055 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] xujianhai666 closed pull request #187: Add token attachment and tokenFilter
[ pull request closed by xujianhai666 ] [ Full content available at: https://github.com/apache/dubbo-go/pull/187 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5054: code optimization
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=h1) Report > Merging [#5054](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/7d564e75fe776681e9e3c0a6f6bd1c4ad1ea51af?src=pr&el=desc) > will **increase** coverage by `0.01%`. > The diff coverage is `33.33%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5054/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#5054 +/- ## + Coverage 63.93% 63.95% +0.01% Complexity 451 451 Files 769 769 Lines 3320633209 +3 Branches 5237 5238 +1 + Hits 2123121238 +7 + Misses 9552 9542 -10 - Partials 2423 2429 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `67.3% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/dubbo/common/utils/StringUtils.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvU3RyaW5nVXRpbHMuamF2YQ==) | `84.19% <66.66%> (-0.2%)` | `0 <0> (ø)` | | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `61.4% <0%> (-7.02%)` | `0% <0%> (ø)` | | | [...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | | | [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnkuamF2YQ==) | `62.5% <0%> (+0.62%)` | `29% <0%> (ø)` | :arrow_down: | | [...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh) | `72.83% <0%> (+1.73%)` | `0% <0%> (ø)` | :arrow_down: | | [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `58.82% <0%> (+2.35%)` | `0% <0%> (ø)` | :arrow_down: | | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `83.33% <0%> (+3.33%)` | `0% <0%> (ø)` | :arrow_down: | | [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `70.73% <0%> (+4.87%)` | `0% <0%> (ø)` | :arrow_down: | | [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/5054/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `85.36% <0%> (+4.87%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=footer). > Last update > [7d564e7...5313287](https://codecov.io/gh/apache/dubbo/pull/5054?src=pr&el=lastupdated). > Read the [comment docs](https://d
[GitHub] [dubbo-go] codecov-io commented on issue #201: Fix:fix url params unsafe
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=h1) Report > Merging [#201](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=desc) > into > [develop](https://codecov.io/gh/apache/dubbo-go/commit/cf198d0e3e5977f77b52ced2d45da16b52f92d2e?src=pr&el=desc) > will **increase** coverage by `1.21%`. > The diff coverage is `81.66%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/201/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #201 +/- ## === + Coverage 66.7% 67.91% +1.21% === Files 94 94 Lines 5820 5847 +27 === + Hits 3882 3971 +89 + Misses1538 1474 -64 - Partials 400 402 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [registry/consul/utils.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3V0aWxzLmdv) | `68.08% <0%> (-3.03%)` | :arrow_down: | | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `74.5% <100%> (+0.5%)` | :arrow_up: | | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `62.91% <100%> (+0.31%)` | :arrow_up: | | [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `57.38% <100%> (+1.63%)` | :arrow_up: | | [...rotocol/protocolwrapper/protocol\_filter\_wrapper.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcHJvdG9jb2x3cmFwcGVyL3Byb3RvY29sX2ZpbHRlcl93cmFwcGVyLmdv) | `51.42% <100%> (ø)` | :arrow_up: | | [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `75.98% <83.33%> (+1.09%)` | :arrow_up: | | [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `63.58% <0%> (+0.86%)` | :arrow_up: | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `46.9% <0%> (+1.54%)` | :arrow_up: | | [protocol/dubbo/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcmVhZHdyaXRlci5nbw==) | `70.37% <0%> (+2.46%)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/dubbo-go/pull/201/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=footer). > Last update > [cf198d0...9eec723](https://codecov.io/gh/apache/dubbo-go/pull/201?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo-go/pull/201 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt opened pull request #201: Fix:fix url params unsafe
**What this PR does**: Fix fix url params unsafe completely. **Which issue(s) this PR fixes**: Fixes #200 **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` [ Full content available at: https://github.com/apache/dubbo-go/pull/201 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt closed pull request #198: Add:retries mergeUrl
[ pull request closed by hxmhlt ] [ Full content available at: https://github.com/apache/dubbo-go/pull/198 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] giantpoplar opened issue #200: URL.params concurrent map read and map write problem
**What happened**: program crash due to URL.params concurrent map read and map write problem **What you expected to happen**: **How to reproduce it (as minimally and precisely as possible)**: **Anything else we need to know?**: A paramsLock (common/url.go baseUrl struct) is introduced in recent commit to fix concurrent map read and write problem of params. However, this problem has not been completely solved. In function "MergeUrl", params are set without this lock guard. [ Full content available at: https://github.com/apache/dubbo-go/issues/200 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on issue #129: fix:go emoji to java emoji(a character takes up 3-4 bytes of special symbols)
@pantianying I find that java uses two 16-bit characters to represent emoji "🤣", while golang uses one rune to represent it. So the length of the emoji in java is 2, while 1 in java. The hessian protocol says that: > The length is the number of 16-bit characters. So, it's a bug of golang hessian2, I will try to fix it. [ Full content available at: https://github.com/apache/dubbo-go-hessian2/issues/129 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] LiosWong opened pull request #5054: code optimization
## What is the purpose of the change code optimization ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). [ Full content available at: https://github.com/apache/dubbo/pull/5054 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #4397: fix register config not take effect because of url simplified
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=h1) Report > Merging [#4397](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/7d564e75fe776681e9e3c0a6f6bd1c4ad1ea51af?src=pr&el=desc) > will **decrease** coverage by `0.01%`. > The diff coverage is `82.69%`. [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/4397/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4397 +/- ## - Coverage 63.93% 63.92% -0.02% Complexity 451 451 Files 769 769 Lines 3320633206 Branches 5237 5237 - Hits 2123121226 -5 Misses 9552 9552 - Partials 2423 2428 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/dubbo/registry/integration/RegistryProtocol.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3JhdGlvbi9SZWdpc3RyeVByb3RvY29sLmphdmE=) | `82.69% <82.69%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | | | [...bbo/registry/support/ProviderConsumerRegTable.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVyQ29uc3VtZXJSZWdUYWJsZS5qYXZh) | `80.48% <0%> (-4.88%)` | `0% <0%> (ø)` | | | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `58.69% <0%> (-4.35%)` | `0% <0%> (ø)` | | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `63.63% <0%> (-3.41%)` | `0% <0%> (ø)` | | | [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `78.04% <0%> (-2.44%)` | `0% <0%> (ø)` | | | [...dubbo/metadata/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0L2R1YmJvLW1ldGFkYXRhLXJlcG9ydC1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL21ldGFkYXRhL3N1cHBvcnQvQWJzdHJhY3RNZXRhZGF0YVJlcG9ydC5qYXZh) | `72.83% <0%> (+1.73%)` | `0% <0%> (ø)` | :arrow_down: | | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/4397/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `83.33% <0%> (+3.33%)` | `0% <0%> (ø)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=footer). > Last update > [7d564e7...4c9fe00](https://codecov.io/gh/apache/dubbo/pull/4397?src=pr&el=lastupdated). > Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). [ Full content available at: https://github.com/apache/dubbo/pull/4397 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] thewindkee opened pull request #5053: add BroadcastCluster's NAME
## What is the purpose of the change add BroadcastCluster's NAME ## Brief changelog add BroadcastCluster's NAME ## Verifying this change no need. [ Full content available at: https://github.com/apache/dubbo/pull/5053 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] qinliujie commented on issue #4414: monitor doesn't work on consumer side if only invoke once.
hi @beiwei30 , I can't reproduce this issue, can you describe more detail ? [ Full content available at: https://github.com/apache/dubbo/issues/4414 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org