[GitHub] [dubbo] codecov-io commented on issue #5055: rearrange and simplity ExtensionLoader and config code
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=h1) Report > Merging [#5055](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=desc) > into > [master](https://codecov.io/gh/apache/dubbo/commit/7d564e75fe776681e9e3c0a6f6bd1c4ad1ea51af?src=pr=desc) > will **decrease** coverage by `<.01%`. > The diff coverage is `78.57%`. [](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5055 +/- ## - Coverage 63.99% 63.99% -0.01% - Complexity 452 453 +1 Files 769 769 Lines 3320633199 -7 Branches 5237 5220 -17 - Hits 2125121246 -5 + Misses 9532 9527 -5 - Partials 2423 2426 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ache/dubbo/config/spring/util/AnnotationUtils.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9Bbm5vdGF0aW9uVXRpbHMuamF2YQ==) | `39.25% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `78.01% <76.31%> (-0.96%)` | `0 <0> (ø)` | | | [...n/java/org/apache/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9BYnN0cmFjdENvbmZpZy5qYXZh) | `81.84% <84.61%> (+1.59%)` | `0 <0> (ø)` | :arrow_down: | | [...n/java/org/apache/dubbo/config/RegistryConfig.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWdpc3RyeUNvbmZpZy5qYXZh) | `89.74% <88.88%> (+0.08%)` | `0 <0> (ø)` | :arrow_down: | | [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `55.68% <0%> (-4.55%)` | `20% <0%> (-1%)` | | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `80.07% <0%> (-1.54%)` | `0% <0%> (ø)` | | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.87% <0%> (-1.36%)` | `0% <0%> (ø)` | | | [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jb25zdWwvQ29uc3VsUmVnaXN0cnkuamF2YQ==) | `61.87% <0%> (-0.63%)` | `29% <0%> (ø)` | | | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: | | ... and [7 more](https://codecov.io/gh/apache/dubbo/pull/5055/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=continue). > **Legend** - [Click here to learn > more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by > [Codecov](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=footer). > Last update > [7d564e7...d1fe82a](https://codecov.io/gh/apache/dubbo/pull/5055?src=pr=lastupdated). > Read the [comment
[GitHub] [dubbo-go] xujianhai666 commented on pull request #202: Add token support
thx, Happy Mid-autumn Day！ [ Full content available at: https://github.com/apache/dubbo-go/pull/202 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] CLAassistant commented on issue #4811: remove duplicated references from ServiceConfig and ReferenceConfig, keep them in ConfigManager
[](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our [Contributor License Agreement](https://cla-assistant.io/alibaba/dubbo?pullRequest=4811) before we can accept your contribution.**1** out of **2** committers have signed the CLA.:white_check_mark: mzorro:x: 君时**君时** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/alibaba/dubbo?pullRequest=4811) it. [ Full content available at: https://github.com/apache/dubbo/pull/4811 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] htynkn commented on issue #5032: [Dubbo-4984]Fix: type definition for String class
@lexburner This is PR for #4984, could you help on reviewing it? [ Full content available at: https://github.com/apache/dubbo/pull/5032 ] This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
