[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #495: Imp: refactor the network transport layer
AlexStocks commented on a change in pull request #495:
URL: https://github.com/apache/dubbo-go/pull/495#discussion_r429508894
##
File path: config/application_config.go
##
@@ -40,7 +37,7 @@ func (*ApplicationConfig) Prefix() string {
return constant.DUBBO + ".application."
}
-// Id ...
+// ID ...
Review comment:
if u do not wanna add comment here, pls add `// nolint`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
codecov-commenter edited a comment on pull request #530: URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=h1) Report > Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3=desc) will **increase** coverage by `0.02%`. > The diff coverage is `78.12%`. [](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #530 +/- ## === + Coverage66.55% 66.57% +0.02% === Files 184 184 Lines 9729 9720 -9 === - Hits 6475 6471 -4 + Misses2613 2611 -2 + Partials 641 638 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) | Coverage Δ | | |---|---|---| | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | | | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | | | [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | | | [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | | | ... and [32 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=footer). Last update [84b38fe...6489acf](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
codecov-commenter edited a comment on pull request #530: URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=h1) Report > Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3=desc) will **increase** coverage by `0.05%`. > The diff coverage is `78.12%`. [](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #530 +/- ## === + Coverage66.55% 66.60% +0.05% === Files 184 184 Lines 9729 9723 -6 === + Hits 6475 6476 +1 + Misses2613 2607 -6 + Partials 641 640 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) | Coverage Δ | | |---|---|---| | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | | | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | | | [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | | | [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | | | ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=footer). Last update [84b38fe...6489acf](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #535: Rft : Change subscribe service key in registrydatalistener
zouyx merged pull request #535: URL: https://github.com/apache/dubbo-go/pull/535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #535: Rft : Change subscribe service key in registrydatalistener
codecov-commenter edited a comment on pull request #535: URL: https://github.com/apache/dubbo-go/pull/535#issuecomment-632188560 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=h1) Report > Merging [#535](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/7e7db7bd628f334262f1edf24d2c5fe72217e4f9=desc) will **increase** coverage by `0.10%`. > The diff coverage is `61.53%`. [](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=tree) ```diff @@ Coverage Diff @@ ## feature/dubbo-2.7.5 #535 +/- ## === + Coverage66.76% 66.86% +0.10% === Files 199 199 Lines1027210282 +10 === + Hits 6858 6875 +17 + Misses2755 2750 -5 + Partials 659 657 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.70% <16.66%> (-1.54%)` | :arrow_down: | | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `67.08% <100.00%> (+2.70%)` | :arrow_up: | | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: | | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | | | [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `69.09% <0.00%> (+1.21%)` | :arrow_up: | | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `62.90% <0.00%> (+5.37%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=footer). Last update [7e7db7b...c21d928](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #535: Rft : Change subscribe service key in registrydatalistener
codecov-commenter edited a comment on pull request #535: URL: https://github.com/apache/dubbo-go/pull/535#issuecomment-632188560 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=h1) Report > Merging [#535](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/7e7db7bd628f334262f1edf24d2c5fe72217e4f9=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `40.00%`. [](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=tree) ```diff @@ Coverage Diff @@ ## feature/dubbo-2.7.5 #535 +/- ## === - Coverage66.76% 66.64% -0.13% === Files 199 199 Lines1027210276 +4 === - Hits 6858 6848 -10 - Misses2755 2769 +14 Partials 659 659 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=tree) | Coverage Δ | | |---|---|---| | [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.70% <10.00%> (-1.54%)` | :arrow_down: | | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `64.38% <100.00%> (ø)` | | | [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.71% <0.00%> (-4.57%)` | :arrow_down: | | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/535/diff?src=pr=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=footer). Last update [7e7db7b...c21d928](https://codecov.io/gh/apache/dubbo-go/pull/535?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] zouyx merged pull request #529: Fix: gitee code analysis shadow err
zouyx merged pull request #529: URL: https://github.com/apache/dubbo-go/pull/529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #535: Rft : Change subscribe service key in registrydatalistener
zouyx commented on a change in pull request #535:
URL: https://github.com/apache/dubbo-go/pull/535#discussion_r429304205
##
File path: registry/zookeeper/registry.go
##
@@ -129,12 +129,17 @@ func (r *zkRegistry) InitListeners() {
recoverd := r.dataListener.subscribed
if recoverd != nil && len(recoverd) > 0 {
// recover all subscribed url
- for conf, oldListener := range recoverd {
+ for recoveredURL, oldListener := range recoverd {
if regConfigListener, ok :=
oldListener.(*RegistryConfigurationListener); ok {
regConfigListener.Close()
}
- newDataListener.SubscribeURL(conf,
NewRegistryConfigurationListener(r.client, r))
- go r.listener.ListenServiceEvent(conf,
fmt.Sprintf("/dubbo/%s/"+constant.DEFAULT_CATEGORY,
url.QueryEscape(conf.Service())), newDataListener)
+ serviceURL, err := common.NewURL(recoveredURL)
Review comment:
There will use key of subscribed map to recover , so i think it can not
change to service key.
@hxmhlt what do you think?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on issue #193: Add: go struct for jdk8 time
AlexStocks commented on issue #193: URL: https://github.com/apache/dubbo-go-hessian2/issues/193#issuecomment-632679844 to [willson-chen](github.com/willson-chen) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #524: hessian enhance: support java.time.LocalTime, java.time.LocalDate, java.time.LocalDateTime in jdk8
AlexStocks commented on issue #524: URL: https://github.com/apache/dubbo-go/issues/524#issuecomment-632678909 has been moved to [#193](https://github.com/apache/dubbo-go-hessian2/issues/193) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #523: hessian enhance: support java.sql.Date, java.sql.Time, java.sql.Timestamp
AlexStocks closed issue #523: URL: https://github.com/apache/dubbo-go/issues/523 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #524: hessian enhance: support java.time.LocalTime, java.time.LocalDate, java.time.LocalDateTime in jdk8
AlexStocks closed issue #524: URL: https://github.com/apache/dubbo-go/issues/524 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #523: hessian enhance: support java.sql.Date, java.sql.Time, java.sql.Timestamp
AlexStocks commented on issue #523: URL: https://github.com/apache/dubbo-go/issues/523#issuecomment-632678963 has been moved to [#193](https://github.com/apache/dubbo-go-hessian2/issues/193) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #525: hessian enhance: support java.time.Instant, java.time.Duration, java.time.Period in jdk8
AlexStocks commented on issue #525: URL: https://github.com/apache/dubbo-go/issues/525#issuecomment-632678840 has been moved to [#193](https://github.com/apache/dubbo-go-hessian2/issues/193) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #525: hessian enhance: support java.time.Instant, java.time.Duration, java.time.Period in jdk8
AlexStocks closed issue #525: URL: https://github.com/apache/dubbo-go/issues/525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #526: hessian enhance: support java.time.Year, java.time.YearMonth, java.time.MonthDay in jdk8
AlexStocks closed issue #526: URL: https://github.com/apache/dubbo-go/issues/526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #526: hessian enhance: support java.time.Year, java.time.YearMonth, java.time.MonthDay in jdk8
AlexStocks commented on issue #526: URL: https://github.com/apache/dubbo-go/issues/526#issuecomment-632678266 has been moved to [dubbo-go-hessian2 #193](https://github.com/apache/dubbo-go-hessian2/issues/193) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #527: hessian enhance: support java.time.OffsetDateTime, java.time.ZoneOffset, java.time.OffsetTime, java.time.ZoneDateTime in jdk8
AlexStocks commented on issue #527: URL: https://github.com/apache/dubbo-go/issues/527#issuecomment-632677642 @cvictory has been moved to https://github.com/apache/dubbo-go-hessian2/issues/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed issue #527: hessian enhance: support java.time.OffsetDateTime, java.time.ZoneOffset, java.time.OffsetTime, java.time.ZoneDateTime in jdk8
AlexStocks closed issue #527: URL: https://github.com/apache/dubbo-go/issues/527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks opened a new issue #193: Add: go struct for jdk8 time
AlexStocks opened a new issue #193: URL: https://github.com/apache/dubbo-go-hessian2/issues/193 **What would you like to be added**: Add go structs for the following time classes in jdk8: - java.time.OffsetDateTime - java.time.ZoneOffset - java.time.OffsetTime - java.time.ZoneDateTime **Why is this needed**: these classes are very popular in jdk8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #467: tps limit leaky bucket implementation
AlexStocks closed pull request #467: URL: https://github.com/apache/dubbo-go/pull/467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #529: Fix: gitee code analysis shadow err
codecov-commenter edited a comment on pull request #529: URL: https://github.com/apache/dubbo-go/pull/529#issuecomment-631860328 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=h1) Report > Merging [#529](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3=desc) will **decrease** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #529 +/- ## === - Coverage66.55% 66.43% -0.13% === Files 184 184 Lines 9729 9720 -9 === - Hits 6475 6457 -18 - Misses2613 2623 +10 + Partials 641 640 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=tree) | Coverage Δ | | |---|---|---| | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `72.46% <ø> (ø)` | | | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `65.90% <0.00%> (ø)` | | | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | | | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.09% <0.00%> (ø)` | | | [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (ø)` | | | [protocol/jsonrpc/http.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9odHRwLmdv) | `75.00% <0.00%> (ø)` | | | [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <0.00%> (ø)` | | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.66% <ø> (+0.28%)` | :arrow_up: | | [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.61% <33.33%> (ø)` | | | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <50.00%> (ø)` | | | ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=footer). Last update [84b38fe...1800a67](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] watermelo commented on a change in pull request #536: Opt: opt err handling
watermelo commented on a change in pull request #536:
URL: https://github.com/apache/dubbo-go/pull/536#discussion_r429201949
##
File path: config/metadata_report_config.go
##
@@ -103,7 +103,7 @@ func startMetadataReport(metadataType string,
metadataReportConfig *MetadataRepo
if url, err := metadataReportConfig.ToUrl(); err == nil {
instance.GetMetadataReportInstance(url)
} else {
- return perrors.New("MetadataConfig is invalid!")
+ return perrors.Wrap(err, "Start MetadataReport failed.")
Review comment:
> why use Wrap instead of New?
fuction metadataReportConfig.ToUrl() returns the err, but original codes
ignore it and return a new error, actual `err` is the same as new error. so
wrap it to get more infomation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] watermelo commented on a change in pull request #536: Opt: opt err handling
watermelo commented on a change in pull request #536:
URL: https://github.com/apache/dubbo-go/pull/536#discussion_r429201854
##
File path: config/metadata_report_config.go
##
@@ -103,7 +103,7 @@ func startMetadataReport(metadataType string,
metadataReportConfig *MetadataRepo
if url, err := metadataReportConfig.ToUrl(); err == nil {
instance.GetMetadataReportInstance(url)
} else {
- return perrors.New("MetadataConfig is invalid!")
+ return perrors.Wrap(err, "Start MetadataReport failed.")
Review comment:
fuction metadataReportConfig.ToUrl() returns the err, but original codes
ignore it and return a new error, actual err is the same as new error. so wrap
it to get more infomation.
##
File path: config/metadata_report_config.go
##
@@ -103,7 +103,7 @@ func startMetadataReport(metadataType string,
metadataReportConfig *MetadataRepo
if url, err := metadataReportConfig.ToUrl(); err == nil {
instance.GetMetadataReportInstance(url)
} else {
- return perrors.New("MetadataConfig is invalid!")
+ return perrors.Wrap(err, "Start MetadataReport failed.")
Review comment:
> why use Wrap instead of New?
fuction metadataReportConfig.ToUrl() returns the err, but original codes
ignore it and return a new error, actual err is the same as new error. so wrap
it to get more infomation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] watermelo commented on a change in pull request #536: Opt: opt err handling
watermelo commented on a change in pull request #536:
URL: https://github.com/apache/dubbo-go/pull/536#discussion_r429201949
##
File path: config/metadata_report_config.go
##
@@ -103,7 +103,7 @@ func startMetadataReport(metadataType string,
metadataReportConfig *MetadataRepo
if url, err := metadataReportConfig.ToUrl(); err == nil {
instance.GetMetadataReportInstance(url)
} else {
- return perrors.New("MetadataConfig is invalid!")
+ return perrors.Wrap(err, "Start MetadataReport failed.")
Review comment:
> why use Wrap instead of New?
fuction `metadataReportConfig.ToUrl()` returns the `err`, but original codes
ignore it and return a new error, actual `err` is the same as new error. so
wrap it to get more infomation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #529: Fix: gitee code analysis shadow err
codecov-commenter edited a comment on pull request #529: URL: https://github.com/apache/dubbo-go/pull/529#issuecomment-631860328 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=h1) Report > Merging [#529](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3=desc) will **increase** coverage by `0.12%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #529 +/- ## === + Coverage66.55% 66.67% +0.12% === Files 184 184 Lines 9729 9753 +24 === + Hits 6475 6503 +28 + Misses2613 2611 -2 + Partials 641 639 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=tree) | Coverage Δ | | |---|---|---| | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `72.46% <ø> (ø)` | | | [cluster/directory/base\_directory.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y2x1c3Rlci9kaXJlY3RvcnkvYmFzZV9kaXJlY3RvcnkuZ28=) | `65.90% <0.00%> (ø)` | | | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | | | [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.09% <0.00%> (ø)` | | | [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `68.64% <0.00%> (ø)` | | | [protocol/jsonrpc/http.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9odHRwLmdv) | `75.00% <0.00%> (ø)` | | | [protocol/jsonrpc/json.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9qc29uLmdv) | `52.94% <0.00%> (ø)` | | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.66% <ø> (+0.28%)` | :arrow_up: | | [protocol/jsonrpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvanNvbnJwYy9zZXJ2ZXIuZ28=) | `59.61% <33.33%> (ø)` | | | [protocol/dubbo/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree#diff-cHJvdG9jb2wvZHViYm8vbGlzdGVuZXIuZ28=) | `57.52% <50.00%> (ø)` | | | ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/529/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=footer). Last update [84b38fe...1800a67](https://codecov.io/gh/apache/dubbo-go/pull/529?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
codecov-commenter edited a comment on pull request #530: URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=h1) Report > Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3=desc) will **increase** coverage by `0.05%`. > The diff coverage is `78.12%`. [](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #530 +/- ## === + Coverage66.55% 66.60% +0.05% === Files 184 184 Lines 9729 9723 -6 === + Hits 6475 6476 +1 + Misses2613 2607 -6 + Partials 641 640 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) | Coverage Δ | | |---|---|---| | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | | | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | | | [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcmVhZGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | | | [common/extension/health\_checker.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9oZWFsdGhfY2hlY2tlci5nbw==) | `66.66% <ø> (ø)` | | | ... and [26 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=footer). Last update [84b38fe...2ffbe96](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] georgehao commented on a change in pull request #529: Fix: gitee code analysis shadow err
georgehao commented on a change in pull request #529:
URL: https://github.com/apache/dubbo-go/pull/529#discussion_r429194389
##
File path: cluster/directory/static_directory.go
##
@@ -61,7 +61,7 @@ func (dir *staticDirectory) IsAvailable() bool {
// List List invokers
func (dir *staticDirectory) List(invocation protocol.Invocation)
[]protocol.Invoker {
l := len(dir.invokers)
- invokers := make([]protocol.Invoker, l, l)
+ invokers := make([]protocol.Invoker, l)
Review comment:
gosamle detect it. I also think the `capactity` no useful
```
static_directory.go:64:39: S1019: should use make([]protocol.Invoker, l)
instead (gosimple)
invokers := make([]protocol.Invoker, l, l)
^
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #530: Add comments for common directory
codecov-commenter edited a comment on pull request #530: URL: https://github.com/apache/dubbo-go/pull/530#issuecomment-631894490 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=h1) Report > Merging [#530](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) ```diff @@ Coverage Diff @@ ## develop #530 +/- ## === - Coverage66.55% 66.54% -0.02% === Files 184 184 Lines 9729 9723 -6 === - Hits 6475 6470 -5 - Misses2613 2614 +1 + Partials 641 639 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=tree) | Coverage Δ | | |---|---|---| | [common/config/environment.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2NvbmZpZy9lbnZpcm9ubWVudC5nbw==) | `52.38% <ø> (ø)` | | | [common/extension/cluster.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jbHVzdGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyLmdv) | `0.00% <ø> (ø)` | | | [common/extension/config\_center\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfY2VudGVyX2ZhY3RvcnkuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/configurator.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWd1cmF0b3IuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9maWx0ZXIuZ28=) | `0.00% <ø> (ø)` | | | [common/extension/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9ncmFjZWZ1bF9zaHV0ZG93bi5nbw==) | `0.00% <ø> (ø)` | | | [common/extension/loadbalance.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9sb2FkYmFsYW5jZS5nbw==) | `0.00% <ø> (ø)` | | | [common/extension/metadata\_report\_factory.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9tZXRhZGF0YV9yZXBvcnRfZmFjdG9yeS5nbw==) | `0.00% <ø> (ø)` | | | [common/extension/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9wcm90b2NvbC5nbw==) | `0.00% <ø> (ø)` | | | ... and [19 more](https://codecov.io/gh/apache/dubbo-go/pull/530/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=footer). Last update [84b38fe...2ffbe96](https://codecov.io/gh/apache/dubbo-go/pull/530?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #530: Add comments for common directory
zouyx commented on a change in pull request #530:
URL: https://github.com/apache/dubbo-go/pull/530#discussion_r429180038
##
File path: common/config/environment.go
##
@@ -67,21 +67,22 @@ func NewEnvInstance() {
// return env.configCenterFirst
//}
-// UpdateExternalConfigMap ...
+// UpdateExternalConfigMap update env externalConfigMap field
func (env *Environment) UpdateExternalConfigMap(externalMap map[string]string)
{
for k, v := range externalMap {
env.externalConfigMap.Store(k, v)
}
}
-// UpdateAppExternalConfigMap ...
+// UpdateAppExternalConfigMap update env appExternalConfigMap field
func (env *Environment) UpdateAppExternalConfigMap(externalMap
map[string]string) {
for k, v := range externalMap {
env.appExternalConfigMap.Store(k, v)
}
}
-// Configuration ...
+// List represents a doubly linked list.
+// Configuration put externalConfigMap and appExternalConfigMap into list
Review comment:
```suggestion
// Configuration puts externalConfigMap and appExternalConfigMap into list
// List represents a doubly linked list.
```
##
File path: common/logger/logger.go
##
@@ -125,18 +125,18 @@ func InitLogger(conf *zap.Config) {
getty.SetLogger(logger)
}
-// SetLogger ...
+// SetLogger sets logger for dubbo and getty
func SetLogger(log Logger) {
logger = log
getty.SetLogger(logger)
}
-// GetLogger ...
+// GetLogger gets the logger
func GetLogger() Logger {
return logger
}
-// SetLoggerLevel ...
+// SetLoggerLevel used to set logger level
Review comment:
use for?
##
File path: common/extension/configurator.go
##
@@ -61,7 +61,7 @@ func GetDefaultConfigurator(url *common.URL)
config_center.Configurator {
}
-// GetDefaultConfiguratorFunc ...
+// GetDefaultConfiguratorFunc default configurator function
Review comment:
```suggestion
// GetDefaultConfiguratorFunc gets default configurator function
```
##
File path: common/logger/logger.go
##
@@ -145,13 +145,13 @@ func SetLoggerLevel(level string) bool {
return false
}
-// OpsLogger ...
+// OpsLogger used by the SetLoggerLevel
Review comment:
as above
##
File path: common/url.go
##
@@ -432,7 +434,7 @@ func (c URL) GetParamAndDecoded(key string) (string, error)
{
return value, err
}
-// GetRawParam ...
+// GetRawParam is used to get raw param
Review comment:
use for?
##
File path: common/url.go
##
@@ -452,7 +454,7 @@ func (c URL) GetRawParam(key string) string {
}
}
-// GetParamBool ...
+// GetParamBool is used to judge whether key exists or not
Review comment:
use for?
##
File path: common/node.go
##
@@ -17,7 +17,7 @@
package common
-// Node ...
+// Node is used to process dubbo node
Review comment:
as above
##
File path: common/logger/logger.go
##
@@ -145,13 +145,13 @@ func SetLoggerLevel(level string) bool {
return false
}
-// OpsLogger ...
+// OpsLogger used by the SetLoggerLevel
type OpsLogger interface {
Logger
SetLoggerLevel(level string)
}
-// SetLoggerLevel ...
+// SetLoggerLevel used to set logger level
Review comment:
as above
##
File path: common/url.go
##
@@ -86,7 +86,7 @@ type baseUrl struct {
PrimitiveURL string
}
-// URL ...
+// URL is used to locate resourse to transfer data between nodes
Review comment:
use for?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #529: Fix: gitee code analysis shadow err
zouyx commented on a change in pull request #529:
URL: https://github.com/apache/dubbo-go/pull/529#discussion_r429176060
##
File path: cluster/directory/static_directory.go
##
@@ -61,7 +61,7 @@ func (dir *staticDirectory) IsAvailable() bool {
// List List invokers
func (dir *staticDirectory) List(invocation protocol.Invocation)
[]protocol.Invoker {
l := len(dir.invokers)
- invokers := make([]protocol.Invoker, l, l)
+ invokers := make([]protocol.Invoker, l)
Review comment:
why delete capacity ?
##
File path: cluster/directory/base_directory.go
##
@@ -92,7 +92,7 @@ func (dir *BaseDirectory) SetRouters(urls []*common.URL) {
factory := extension.GetRouterFactory(url.Protocol)
r, err := factory.NewRouter(url)
if err != nil {
- logger.Errorf("Create router fail. router key:
%s, error: %v", routerKey, url.Service(), err)
+ logger.Errorf("Create router fail. router key:
%s, url:%s, error: %s", routerKey, url.Service(), err.Error())
Review comment:
```suggestion
logger.Errorf("Create router fail. router key:
%s, url:%s, error: %+v", routerKey, url.Service(), err.Error())
```
##
File path: registry/kubernetes/registry_test.go
##
@@ -68,7 +68,7 @@ func (s *KubernetesRegistryTestSuite) TestSubscribe() {
time.Sleep(1e9)
go func() {
- err := r.Register(url)
+ err = r.Register(url)
Review comment:
i think assign to `err` outside goroutine should cause concurrent
problems
##
File path: filter/filter_impl/hystrix_filter.go
##
@@ -124,7 +124,7 @@ func (hf *HystrixFilter) Invoke(ctx context.Context,
invoker protocol.Invoker, i
_, _, err := hystrix.GetCircuit(cmdName)
configLoadMutex.RUnlock()
if err != nil {
- logger.Errorf("[Hystrix Filter]Errors occurred getting circuit
for %s , will invoke without hystrix, error is: ", cmdName, err)
+ logger.Errorf("[Hystrix Filter]Errors occurred getting circuit
for %s , will invoke without hystrix, error is: %s", cmdName, err.Error())
Review comment:
```suggestion
logger.Errorf("[Hystrix Filter]Errors occurred getting circuit
for %s , will invoke without hystrix, error is: %+v", cmdName, err.Error())
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #536: Opt: opt err handling
AlexStocks commented on a change in pull request #536:
URL: https://github.com/apache/dubbo-go/pull/536#discussion_r429148444
##
File path: config/metadata_report_config.go
##
@@ -103,7 +103,7 @@ func startMetadataReport(metadataType string,
metadataReportConfig *MetadataRepo
if url, err := metadataReportConfig.ToUrl(); err == nil {
instance.GetMetadataReportInstance(url)
} else {
- return perrors.New("MetadataConfig is invalid!")
+ return perrors.Wrap(err, "Start MetadataReport failed.")
Review comment:
why use Wrap instead of New?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #519: remove lock from url
zouyx commented on pull request #519: URL: https://github.com/apache/dubbo-go/pull/519#issuecomment-632590821 resolve conflicts This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] watermelo opened a new pull request #536: Featue/opt err handling
watermelo opened a new pull request #536: URL: https://github.com/apache/dubbo-go/pull/536 **What this PR does**: optimize error handling **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
