[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8510: test: Verify the mapping between exported provider and metadata
codecov-commenter edited a comment on pull request #8510: URL: https://github.com/apache/dubbo/pull/8510#issuecomment-899223854 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8510](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea4af5f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ##3.0#8510 +/- ## = Coverage 62.80% 62.80% Complexity 311 311 = Files 1117 1117 Lines 4673546735 Branches 7032 7032 = + Hits 2935029351+1 + Misses1411914117-2 - Partials 3266 3267+1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `58.13% <0.00%> (-9.31%)` | :arrow_down: | | [...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvQ29kZWMuamF2YQ==) | `63.39% <0.00%> (-1.79%)` | :arrow_down: | | [...e/dubbo/remoting/exchange/codec/ExchangeCodec.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9jb2RlYy9FeGNoYW5nZUNvZGVjLmphdmE=) | `75.30% <0.00%> (-0.81%)` | :arrow_down: | | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `79.20% <0.00%> (ø)` | | | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `85.71% <0.00%> (ø)` | | | [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `79.03% <0.00%> (+0.34%)` | :arrow_up: | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZH
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
codecov-commenter edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-899550897 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8519](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a4b93c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0809a168db5fd71a58dd3f87b0bce00bd5ed8916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0809a16) will **decrease** coverage by `0.15%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8519 +/- ## - Coverage 62.92% 62.77% -0.16% + Complexity 311 310 -1 Files 1115 1117 +2 Lines 4671646689 -27 Branches 7029 6998 -31 - Hits 2939829307 -91 - Misses1406314111 +48 - Partials 3255 3271 +16 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `68.96% <0.00%> (-20.69%)` | :arrow_down: | | [...rg/apache/dubbo/remoting/utils/PayloadDropper.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy91dGlscy9QYXlsb2FkRHJvcHBlci5qYXZh) | `76.92% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `50.00% <0.00%> (-11.54%)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2ZpeGVkL0ZpeGVkVGhyZWFkUG9vbC5qYXZh) | `80.00% <0.00%> (-7.50%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=t
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
codecov-commenter edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-899550897 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8519](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6a4b93c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0809a168db5fd71a58dd3f87b0bce00bd5ed8916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0809a16) will **decrease** coverage by `0.11%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8519 +/- ## - Coverage 62.92% 62.80% -0.12% + Complexity 311 310 -1 Files 1115 1117 +2 Lines 4671646735 +19 Branches 7029 7032 +3 - Hits 2939829354 -44 - Misses1406314113 +50 - Partials 3255 3268 +13 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `68.96% <0.00%> (-20.69%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvU3RhbmRhcmRNZXRhZGF0YVNlcnZpY2VVUkxCdWlsZGVyLmphdmE=) | `85.36% <0.00%> (-4.88%)` | :arrow_down: | | [...ster/router/condition/config/ListenableRouter.
[GitHub] [dubbo] codecov-commenter commented on pull request #8554: fix Issue8516 on branch master
codecov-commenter commented on pull request #8554: URL: https://github.com/apache/dubbo/pull/8554#issuecomment-902432889 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8554](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9964e8e) into [master](https://codecov.io/gh/apache/dubbo/commit/6acd5a2a935c41c3f0b29ad9dce0d7e14586fded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6acd5a2) will **decrease** coverage by `0.74%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#8554 +/- ## - Coverage 61.06% 60.32% -0.75% + Complexity 447 446 -1 Files 1097 1097 Lines 4440144356 -45 Branches 6469 6438 -31 - Hits 2711326756 -357 - Misses1430214624 +322 + Partials 2986 2976 -10 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.03% <75.00%> (-0.59%)` | :arrow_down: | | [...gcenter/wrapper/CompositeDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci93cmFwcGVyL0NvbXBvc2l0ZUR5bmFtaWNDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-73.34%)` | :arrow_down: | | [...ookeeper/ZookeeperDynamicConfigurationFactory.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...pport/zookeeper/ZookeeperDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-62.86%)` | :arrow_down: | | [...fig/configcenter/TreePathDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9UcmVlUGF0aER5bmFtaWNDb25maWd1cmF0aW9uLmphdmE=) | `31.42% <0.00%> (-54.29%)` | :arrow_down: | | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `12.50% <0.00%> (-40.63%)` | :arrow_down: | | [.../configcente
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8554: fix Issue8516 on branch master
codecov-commenter edited a comment on pull request #8554: URL: https://github.com/apache/dubbo/pull/8554#issuecomment-902432889 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8554](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9964e8e) into [master](https://codecov.io/gh/apache/dubbo/commit/6acd5a2a935c41c3f0b29ad9dce0d7e14586fded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6acd5a2) will **decrease** coverage by `0.73%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#8554 +/- ## - Coverage 61.06% 60.32% -0.74% Complexity 447 447 Files 1097 1097 Lines 4440144403 +2 Branches 6469 6470 +1 - Hits 2711326788 -325 - Misses1430214635 +333 + Partials 2986 2980 -6 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.03% <75.00%> (-0.59%)` | :arrow_down: | | [...gcenter/wrapper/CompositeDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci93cmFwcGVyL0NvbXBvc2l0ZUR5bmFtaWNDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-73.34%)` | :arrow_down: | | [...ookeeper/ZookeeperDynamicConfigurationFactory.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbkZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [...pport/zookeeper/ZookeeperDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnY2VudGVyL2R1YmJvLWNvbmZpZ2NlbnRlci16b29rZWVwZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZ2NlbnRlci9zdXBwb3J0L3pvb2tlZXBlci9ab29rZWVwZXJEeW5hbWljQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-62.86%)` | :arrow_down: | | [...fig/configcenter/TreePathDynamicConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL2NvbmZpZ2NlbnRlci9UcmVlUGF0aER5bmFtaWNDb25maWd1cmF0aW9uLmphdmE=) | `31.42% <0.00%> (-54.29%)` | :arrow_down: | | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `12.50% <0.00%> (-40.63%)` | :arrow_down: | | [.../conf
[GitHub] [dubbo-go] AlexStocks closed pull request #1402: build(deps): bump k8s.io/apimachinery from 0.16.9 to 0.22.1
AlexStocks closed pull request #1402: URL: https://github.com/apache/dubbo-go/pull/1402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] dependabot[bot] commented on pull request #1402: build(deps): bump k8s.io/apimachinery from 0.16.9 to 0.22.1
dependabot[bot] commented on pull request #1402: URL: https://github.com/apache/dubbo-go/pull/1402#issuecomment-902438735 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks closed pull request #1401: build(deps): bump go.etcd.io/etcd/server/v3 from 3.5.0-alpha.0 to 3.5.0
AlexStocks closed pull request #1401: URL: https://github.com/apache/dubbo-go/pull/1401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8554: fix Issue8516 on branch master
codecov-commenter edited a comment on pull request #8554: URL: https://github.com/apache/dubbo/pull/8554#issuecomment-902432889 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8554](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9964e8e) into [master](https://codecov.io/gh/apache/dubbo/commit/6acd5a2a935c41c3f0b29ad9dce0d7e14586fded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6acd5a2) will **decrease** coverage by `0.05%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#8554 +/- ## - Coverage 61.06% 61.01% -0.06% - Complexity 447 448 +1 Files 1097 1097 Lines 4440144403 +2 Branches 6469 6470 +1 - Hits 2711327091 -22 - Misses1430214326 +24 Partials 2986 2986 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.03% <75.00%> (-0.59%)` | :arrow_down: | | [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `35.52% <0.00%> (-10.53%)` | :arrow_down: | | [...port/identifier/BaseServiceMetadataIdentifier.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvaWRlbnRpZmllci9CYXNlU2VydmljZU1ldGFkYXRhSWRlbnRpZmllci5qYXZh) | `53.57% <0.00%> (-3.58%)` | :arrow_down: | | [...etadata/report/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvc3VwcG9ydC9BYnN0cmFjdE1ldGFkYXRhUmVwb3J0LmphdmE=) | `56.31% <0.00%> (-3.40%)` | :arrow_down: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `62.37% <0.00%> (-1.99%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `69.56% <0.00%> (-1.45%)` | :arrow_down: | | [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/
[GitHub] [dubbo-go] dependabot[bot] commented on pull request #1401: build(deps): bump go.etcd.io/etcd/server/v3 from 3.5.0-alpha.0 to 3.5.0
dependabot[bot] commented on pull request #1401: URL: https://github.com/apache/dubbo-go/pull/1401#issuecomment-902438796 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on issue #7231: Guide: Contributing to Dubbo
changfubai commented on issue #7231: URL: https://github.com/apache/dubbo/issues/7231#issuecomment-902438917 您好，有没有关于分支规范、提代码写单测中遇到的问题等相关总结的经验贴呀？方便新加入的人快速查询 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1400: build(deps): bump github.com/fsnotify/fsnotify from 1.4.9 to 1.5.0
AlexStocks merged pull request #1400: URL: https://github.com/apache/dubbo-go/pull/1400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on issue #7231: Guide: Contributing to Dubbo
changfubai commented on issue #7231: URL: https://github.com/apache/dubbo/issues/7231#issuecomment-902439408 另外，有微信交流群嘛~.~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8554: fix Issue8516 on branch master
codecov-commenter edited a comment on pull request #8554: URL: https://github.com/apache/dubbo/pull/8554#issuecomment-902432889 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8554](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9964e8e) into [master](https://codecov.io/gh/apache/dubbo/commit/6acd5a2a935c41c3f0b29ad9dce0d7e14586fded?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6acd5a2) will **decrease** coverage by `0.02%`. > The diff coverage is `75.00%`. [](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#8554 +/- ## - Coverage 61.06% 61.04% -0.03% - Complexity 447 448 +1 Files 1097 1097 Lines 4440144403 +2 Branches 6469 6470 +1 - Hits 2711327105 -8 - Misses1430214315 +13 + Partials 2986 2983 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.03% <75.00%> (-0.59%)` | :arrow_down: | | [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `35.52% <0.00%> (-10.53%)` | :arrow_down: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `62.37% <0.00%> (-1.99%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `69.56% <0.00%> (-1.45%)` | :arrow_down: | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.44% <0.00%> (-0.94%)` | :arrow_down: | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `79.62% <0.00%> (-0.75%)` | :arrow_down: | | [...g/apache/dubbo/registry/consul/ConsulRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8554/diff?src=
[GitHub] [dubbo] changfubai opened a new pull request #8558: fix issue-8516 on branch 3.0
changfubai opened a new pull request #8558: URL: https://github.com/apache/dubbo/pull/8558 same as #8520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
xavier-niu commented on a change in pull request #1370: URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692678588 ## File path: config/config_loader_hook.go ## @@ -0,0 +1,367 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package config + +import ( + "fmt" + "reflect" +) + +import ( + "dubbo.apache.org/dubbo-go/v3/common/constant" +) + +const ( + hookParams = constant.HookParams Review comment: use `constant.HookParams` directly please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1403: build(deps): bump github.com/emicklei/go-restful/v3 from 3.4.0 to 3.5.2
codecov-commenter commented on pull request #1403: URL: https://github.com/apache/dubbo-go/pull/1403#issuecomment-902448356 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1403](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (787cdb3) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/e855fdebfcb5787f0bd44d868b5631a4c3737c5f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e855fde) will **decrease** coverage by `0.10%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 3.0#1403 +/- ## == - Coverage 54.98% 54.88% -0.11% == Files 272 272 Lines 1474614746 == - Hits 8108 8093 -15 - Misses 5764 5778 +14 - Partials 874 875 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `50.00% <0.00%> (-12.77%)` | :arrow_down: | | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.60% <0.00%> (-2.44%)` | :arrow_down: | | [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: | | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.70% <0.00%> (-1.86%)` | :arrow_down: | | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | | | [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1403/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e855fde...787cdb3](https://codecov.io/gh/apache/dubbo-go/pull/1403?src=pr&el=lastupdated&utm_medium=referral&utm_source=github
[GitHub] [dubbo] EarthChen removed a comment on pull request #8542: [3.0-Triple] Support triple server stream
EarthChen removed a comment on pull request #8542: URL: https://github.com/apache/dubbo/pull/8542#issuecomment-902408850 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure commented on pull request #8077: Update NacosServiceDiscovery.java Remove useless code
24kpure commented on pull request #8077: URL: https://github.com/apache/dubbo/pull/8077#issuecomment-902453356 > The interval is too long，is not a pr？ QwQ@24kpure You'd better have a look at checklist. `Each commit in the pull request should have a meaningful subject line and body` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8558: fix Issue 8516 on branch 3.0
codecov-commenter commented on pull request #8558: URL: https://github.com/apache/dubbo/pull/8558#issuecomment-902456723 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8558](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ea3304) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **decrease** coverage by `0.12%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8558 +/- ## - Coverage 62.93% 62.81% -0.13% + Complexity 313 310 -3 Files 1117 1117 Lines 4673546690 -45 Branches 7032 6999 -33 - Hits 2941429326 -88 - Misses1406314088 +25 - Partials 3258 3276 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.42% <66.66%> (-0.70%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `50.00% <0.00%> (-11.54%)` | :arrow_down: | | [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `81.13% <0.00%> (-11.33%)` | :arrow_down: | | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `59.52% <0.00%> (-7.92%)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2ZpeGVkL0ZpeGVkVGhyZWFkUG9vbC5qYXZh) | `80.00% <0.00%> (-7.50%)` | :arrow_down: | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `75.86% <0.00%> (-6.90%)` | :arrow_down: | | [...moting/transport/netty4/NettyEventLoopFactory.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_camp
[GitHub] [dubbo-go] cityiron commented on a change in pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
cityiron commented on a change in pull request #1388:
URL: https://github.com/apache/dubbo-go/pull/1388#discussion_r692690914
##
File path: remoting/getty/config.go
##
@@ -179,6 +184,23 @@ func (c *GettySessionParam) CheckValidity() error {
return nil
}
+func parseTimeDurationByRange(timeStr string, min *time.Duration, max
*time.Duration) (time.Duration, error) {
+ result, err := time.ParseDuration(timeStr)
+ if err != nil {
+ return *min, err
+ }
+ if min != nil && max != nil && *min > *max { // swap
Review comment:
The semantics of the min and max parameters are not clear, I don't
think swap is need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] Colin678 commented on pull request #8077: Update NacosServiceDiscovery.java Remove useless code
Colin678 commented on pull request #8077: URL: https://github.com/apache/dubbo/pull/8077#issuecomment-902456885 I give up ，I will find a more meaningful submission@24kpure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8558: fix Issue 8516 on branch 3.0
codecov-commenter edited a comment on pull request #8558: URL: https://github.com/apache/dubbo/pull/8558#issuecomment-902456723 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8558](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ea3304) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **decrease** coverage by `0.07%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8558 +/- ## - Coverage 62.93% 62.86% -0.08% + Complexity 313 311 -2 Files 1117 1117 Lines 4673546736 +1 Branches 7032 7033 +1 - Hits 2941429380 -34 - Misses1406314087 +24 - Partials 3258 3269 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.42% <66.66%> (-0.70%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `81.13% <0.00%> (-11.33%)` | :arrow_down: | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `75.86% <0.00%> (-6.90%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.54% <0.00%> (-5.69%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvU3RhbmRhcmRNZXRhZGF0YVNlcnZpY2VVUkxCdWlsZGVyLmphdmE=) | `85.36% <0.00%> (-4.88%)` | :arrow_down: | | [...ster/router/condition/config/ListenableRouter.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_sou
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8558: fix Issue 8516 on branch 3.0
codecov-commenter edited a comment on pull request #8558: URL: https://github.com/apache/dubbo/pull/8558#issuecomment-902456723 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8558](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ea3304) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **increase** coverage by `0.01%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8558 +/- ## + Coverage 62.93% 62.95% +0.01% + Complexity 313 311 -2 Files 1117 1117 Lines 4673546736 +1 Branches 7032 7033 +1 + Hits 2941429421 +7 + Misses1406314054 -9 - Partials 3258 3261 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.42% <66.66%> (-0.70%)` | :arrow_down: | | [...in/java/org/apache/dubbo/common/utils/JVMUtil.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvSlZNVXRpbC5qYXZh) | `81.13% <0.00%> (-11.33%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.54% <0.00%> (-5.69%)` | :arrow_down: | | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `79.20% <0.00%> (ø)` | | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.59% <0.00%> (+0.92%)` | :arrow_up: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `66.33% <0.00%> (+1.98%)` | :arrow_up: | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Ap
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8558: fix Issue 8516 on branch 3.0
codecov-commenter edited a comment on pull request #8558: URL: https://github.com/apache/dubbo/pull/8558#issuecomment-902456723 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8558](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ea3304) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **increase** coverage by `0.04%`. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8558 +/- ## + Coverage 62.93% 62.98% +0.04% + Complexity 313 311 -2 Files 1117 1117 Lines 4673546736 +1 Branches 7032 7033 +1 + Hits 2941429435 +21 + Misses1406314041 -22 - Partials 3258 3260 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8558?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `84.42% <66.66%> (-0.70%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.54% <0.00%> (-5.69%)` | :arrow_down: | | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vZXh0ZW5zaW9uL0V4dGVuc2lvbkxvYWRlci5qYXZh) | `79.20% <0.00%> (ø)` | | | [...vent/listener/ServiceInstancesChangedListener.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvZXZlbnQvbGlzdGVuZXIvU2VydmljZUluc3RhbmNlc0NoYW5nZWRMaXN0ZW5lci5qYXZh) | `78.10% <0.00%> (+0.49%)` | :arrow_up: | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `67.59% <0.00%> (+0.92%)` | :arrow_up: | | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyQ2xpZW50LmphdmE=) | `72.41% <0.00%> (+0.98%)` | :arrow_up: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8558/diff?src=pr&el=tr
[GitHub] [dubbo] pinxiong commented on pull request #8519: fix ShortestResponseLoadBalanceTest failure
pinxiong commented on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-902473511 @24kpure please fix the failed testcase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD opened a new pull request #1405: Ftr: Added more event distribution types and improved event distribution mechanism for 1.5
ChangedenCZD opened a new pull request #1405:
URL: https://github.com/apache/dubbo-go/pull/1405
**What this PR does**:
分发机制
[单元测试](https://github.com/Chans-Open-Source/dubbo-go/blob/866b03c3153136ee7f4203de4aa2047aaff14f7f/config/config_loader_test.go#L147)
```go
// 实现事件分发接口
type CustomEvent struct {
t *testing.T
}
// implements interfaces.ConfigPostProcessor's functions
func (c CustomEvent) PostProcessReferenceConfig(u *common.URL) {
logger.Debug("PostProcessReferenceConfig Start")
logger.Debug("Event: ", u.GetParam(constant.HOOK_EVENT_PARAM_KEY, ""))
logger.Debug("Url: ", u)
logger.Debug("Error Message: ",
u.GetParam(constant.HOOK_EVENT_ERROR_MESSAGE_PARAM_KEY, ""))
logger.Debug("PostProcessReferenceConfig End")
assert.Equal(c.t, u.GetParam(constant.SIDE_KEY, ""), "consumer")
}
func (c CustomEvent) PostProcessServiceConfig(u *common.URL) {
logger.Debug("PostProcessServiceConfig Start")
logger.Debug("Event: ", u.GetParam(constant.HOOK_EVENT_PARAM_KEY, ""))
logger.Debug("Url: ", u)
logger.Debug("Error Message: ",
u.GetParam(constant.HOOK_EVENT_ERROR_MESSAGE_PARAM_KEY, ""))
logger.Debug("PostProcessServiceConfig End")
assert.Equal(c.t, u.GetParam(constant.SIDE_KEY, ""), "provider")
}
// implements interfaces.ConfigLoaderHook's functions
func (c CustomEvent) AllConsumersConnectComplete() {
logger.Debug("AllConsumersConnectComplete")
}
func (c CustomEvent) AllProvidersConnectComplete() {
logger.Debug("AllProvidersConnectComplete")
}
func (c CustomEvent) BeforeShutdown() {
logger.Debug("BeforeShutdown")
}
func TestLoadWithEventDispatch(t *testing.T) {
doInitConsumer()
doInitProvider()
for _, v := range providerConfig.Services {
v.export = true
}
ms := &MockService{}
SetConsumerService(ms)
SetProviderService(ms)
extension.SetProtocol("registry", GetProtocol)
extension.SetCluster(constant.ZONEAWARE_CLUSTER_NAME,
cluster_impl.NewZoneAwareCluster)
extension.SetProxyFactory("default",
proxy_factory.NewDefaultProxyFactory)
GetApplicationConfig().MetadataType = "mock"
var mm *mockMetadataService
extension.SetMetadataService("mock", func() (metadataService
service.MetadataService, err error) {
if mm == nil {
mm = &mockMetadataService{
exportedServiceURLs: new(sync.Map),
lock:new(sync.RWMutex),
}
}
return mm, nil
})
extension.SetConfigPostProcessor("TestLoadWithEventDispatch",
CustomEvent{t})
Load()
assert.Equal(t, ms, GetRPCService(ms.Reference()))
ms2 := &struct {
MockService
}{}
RPCService(ms2)
assert.NotEqual(t, ms2, GetRPCService(ms2.Reference()))
conServices = map[string]common.RPCService{}
proServices = map[string]common.RPCService{}
err := common.ServiceMap.UnRegister("com.MockService", "mock",
common.ServiceKey("com.MockService", "huadong_idc", "1.0.0"))
assert.Nil(t, err)
consumerConfig = nil
providerConfig = nil
}
```
**Which issue(s) this PR fixes**:
Fixes #1364
**Special notes for your reviewer**:
钩子方式的实现方式 #1372
**Does this PR introduce a user-facing change?**:
```release-note
- 已兼容旧版分发机制
- 如需使用新版机制，自定义事件实现interfaces.ConfigLoaderHook的想法函数即可
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] shensi199312 opened a new issue #8559: 如何在consumer端获取调用的provider的application name
shensi199312 opened a new issue #8559: URL: https://github.com/apache/dubbo/issues/8559 如题： 如题： ### Environment * Dubbo version: 2.7.12 * Operating System version: macos10.15.7 * Java version: 1.8 ### Steps to reproduce this issue 1. xxx 2. xxx 3. xxx Pls. provide [GitHub address] to reproduce this issue. ### Expected Result What do you expected from the above steps？ ### Actual Result What actually happens? If there is an exception, please attach the exception trace: ``` Just put your stack trace here! ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8510: test: Verify the mapping between exported provider and metadata
codecov-commenter edited a comment on pull request #8510: URL: https://github.com/apache/dubbo/pull/8510#issuecomment-899223854 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8510](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4731f9a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **decrease** coverage by `0.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8510 +/- ## - Coverage 62.93% 62.81% -0.13% + Complexity 313 310 -3 Files 1117 1117 Lines 4673546689 -46 Branches 7032 6998 -34 - Hits 2941429326 -88 - Misses1406314087 +24 - Partials 3258 3276 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `60.86% <0.00%> (-10.15%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0.00%> (-7.96%)` | :arrow_down: | | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `59.52% <0.00%> (-7.92%)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2ZpeGVkL0ZpeGVkVGhyZWFkUG9vbC5qYXZh) | `80.00% <0.00%> (-7.50%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [...moting/transport/netty4/NettyEventLoopFactory.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5RXZlbnRMb29wRmFjdG9yeS5qYXZh) | `30.00% <0.00%> (-6.37%)` | :arrow_down: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8510: test: Verify the mapping between exported provider and metadata
codecov-commenter edited a comment on pull request #8510: URL: https://github.com/apache/dubbo/pull/8510#issuecomment-899223854 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8510](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4731f9a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/5630a3c1fd390ace46f5bf3f7916f9390681f1b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5630a3c) will **decrease** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8510 +/- ## - Coverage 62.93% 62.87% -0.07% + Complexity 313 311 -2 Files 1117 1117 Lines 4673546735 Branches 7032 7032 - Hits 2941429384 -30 - Misses1406314079 +16 - Partials 3258 3272 +14 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFydGJlYXRIYW5kbGVyLmphdmE=) | `58.13% <0.00%> (-9.31%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty4/NettyClient.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50LmphdmE=) | `62.31% <0.00%> (-8.70%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0.00%> (-7.96%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `58.13% <0.00%> (-4.66%)` | :arrow_down: | | [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `60.39% <0.00%> (-3.97%)` | :arrow_down: | | [.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9leGNoYW5nZS9zdXBwb3J0L2hlYWRlci9IZWFkZXJFeGNoYW5nZVNlcnZlci5qYXZh) | `65.09% <0.00%> (-3.78%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyCl
[GitHub] [dubbo] frlzk commented on issue #6814: Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version
frlzk commented on issue #6814:
URL: https://github.com/apache/dubbo/issues/6814#issuecomment-902492746
* Dubbo version: 3.0.2.1
* Operating System version: Ubuntu
* Java version: 1.8
`ServiceConfig ns1=new ServiceConfig();
ns1.setRegistry(r);
ns1.setInterface(NameService.class);
ns1.setRef(new NameServiceImpl());
ns1.setGroup("group1");
ns1.export();
ServiceConfig ns2=new ServiceConfig();
ns2.setRegistry(r);
ns2.setInterface(NameService.class);
ns2.setRef(new NameServiceImpl());
ns2.setGroup("group2");
ns2.export();`
`ReferenceConfig nameRef = new ReferenceConfig<>();
nameRef.setRegistry(rc);
nameRef.setInterface(NameService.class);
nameRef.setGroup("*");
NameService nameServ = nameRef.get();
String name = nameServ.getName("dubbo");`
`Exception in thread "main" java.lang.IllegalStateException: Failed to
subscribe
dubbo://10.2.77.247/org.example.provider.test.NameService?application=first-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&interface=org.example.provider.test.NameService&methods=getName,getSupportCodes&pid=13407&release=3.0.2.1&side=consumer&sticky=false×tamp=1629444044395,
cause: Failed to filter serviceName from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:315)
at
org.apache.dubbo.registry.ListenerRegistryWrapper.subscribe(ListenerRegistryWrapper.java:106)
at
org.apache.dubbo.registry.integration.RegistryDirectory.subscribe(RegistryDirectory.java:107)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doCreateInvoker(RegistryProtocol.java:515)
at
org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol.getInvoker(InterfaceCompatibleRegistryProtocol.java:58)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.refreshInterfaceInvoker(MigrationInvoker.java:448)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.migrateToApplicationFirstInvoker(MigrationInvoker.java:239)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.refreshInvoker(MigrationRuleHandler.java:73)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.doMigrate(MigrationRuleHandler.java:57)
at
org.apache.dubbo.registry.client.migration.MigrationRuleListener.onRefer(MigrationRuleListener.java:211)
at
org.apache.dubbo.registry.integration.RegistryProtocol.interceptInvoker(RegistryProtocol.java:486)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doRefer(RegistryProtocol.java:468)
at
org.apache.dubbo.registry.integration.RegistryProtocol.refer(RegistryProtocol.java:448)
at
org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.refer(ProtocolListenerWrapper.java:74)
at
org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.refer(ProtocolFilterWrapper.java:68)
at
org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.refer(ProtocolSerializationWrapper.java:51)
at
org.apache.dubbo.qos.protocol.QosProtocolWrapper.refer(QosProtocolWrapper.java:73)
at org.apache.dubbo.rpc.Protocol$Adaptive.refer(Protocol$Adaptive.java)
at
org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:391)
at
org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:327)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:204)
at org.example.provider.test.TestConumer.main(TestConumer.java:31)
Caused by: org.apache.dubbo.rpc.RpcException: Failed to filter serviceName
from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.nacos.NacosRegistry.filterServiceNames(NacosRegistry.java:316)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames0(NacosRegistry.java:298)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames(NacosRegistry.java:279)
at
org.apache.dubbo.registry.nacos.NacosRegistry.doSubscribe(NacosRegistry.java:193)
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:298)
... 21 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
at
org.apache.dubbo.regist
[GitHub] [dubbo] frlzk edited a comment on issue #6814: Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version
frlzk edited a comment on issue #6814:
URL: https://github.com/apache/dubbo/issues/6814#issuecomment-902492746
* Dubbo version: 3.0.2.1
* Operating System version: Ubuntu
* Java version: 1.8
`
ServiceConfig ns1=new ServiceConfig();
ns1.setRegistry(r);
ns1.setInterface(NameService.class);
ns1.setRef(new NameServiceImpl());
ns1.setGroup("group1");
ns1.export();
ServiceConfig ns2=new ServiceConfig();
ns2.setRegistry(r);
ns2.setInterface(NameService.class);
ns2.setRef(new NameServiceImpl());
ns2.setGroup("group2");
ns2.export();
`
`
ReferenceConfig nameRef = new ReferenceConfig<>();
nameRef.setRegistry(rc);
nameRef.setInterface(NameService.class);
nameRef.setGroup("*");
NameService nameServ = nameRef.get();
String name = nameServ.getName("dubbo");
`
`
Exception in thread "main" java.lang.IllegalStateException: Failed to
subscribe
dubbo://10.2.77.247/org.example.provider.test.NameService?application=first-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&interface=org.example.provider.test.NameService&methods=getName,getSupportCodes&pid=13407&release=3.0.2.1&side=consumer&sticky=false×tamp=1629444044395,
cause: Failed to filter serviceName from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:315)
at
org.apache.dubbo.registry.ListenerRegistryWrapper.subscribe(ListenerRegistryWrapper.java:106)
at
org.apache.dubbo.registry.integration.RegistryDirectory.subscribe(RegistryDirectory.java:107)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doCreateInvoker(RegistryProtocol.java:515)
at
org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol.getInvoker(InterfaceCompatibleRegistryProtocol.java:58)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.refreshInterfaceInvoker(MigrationInvoker.java:448)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.migrateToApplicationFirstInvoker(MigrationInvoker.java:239)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.refreshInvoker(MigrationRuleHandler.java:73)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.doMigrate(MigrationRuleHandler.java:57)
at
org.apache.dubbo.registry.client.migration.MigrationRuleListener.onRefer(MigrationRuleListener.java:211)
at
org.apache.dubbo.registry.integration.RegistryProtocol.interceptInvoker(RegistryProtocol.java:486)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doRefer(RegistryProtocol.java:468)
at
org.apache.dubbo.registry.integration.RegistryProtocol.refer(RegistryProtocol.java:448)
at
org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.refer(ProtocolListenerWrapper.java:74)
at
org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.refer(ProtocolFilterWrapper.java:68)
at
org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.refer(ProtocolSerializationWrapper.java:51)
at
org.apache.dubbo.qos.protocol.QosProtocolWrapper.refer(QosProtocolWrapper.java:73)
at org.apache.dubbo.rpc.Protocol$Adaptive.refer(Protocol$Adaptive.java)
at
org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:391)
at
org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:327)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:204)
at org.example.provider.test.TestConumer.main(TestConumer.java:31)
Caused by: org.apache.dubbo.rpc.RpcException: Failed to filter serviceName
from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.nacos.NacosRegistry.filterServiceNames(NacosRegistry.java:316)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames0(NacosRegistry.java:298)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames(NacosRegistry.java:279)
at
org.apache.dubbo.registry.nacos.NacosRegistry.doSubscribe(NacosRegistry.java:193)
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:298)
... 21 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
[GitHub] [dubbo] frlzk edited a comment on issue #6814: Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version
frlzk edited a comment on issue #6814:
URL: https://github.com/apache/dubbo/issues/6814#issuecomment-902492746
* Dubbo version: 3.0.2.1
* Operating System version: Ubuntu
* Java version: 1.8
`
ServiceConfig ns1=new ServiceConfig();
ns1.setRegistry(r);
ns1.setInterface(NameService.class);
ns1.setRef(new NameServiceImpl());
ns1.setGroup("group1");
ns1.export();
ServiceConfig ns2=new ServiceConfig();
ns2.setRegistry(r);
ns2.setInterface(NameService.class);
ns2.setRef(new NameServiceImpl());
ns2.setGroup("group2");
ns2.export();
`
`
ReferenceConfig nameRef = new ReferenceConfig<>();
nameRef.setRegistry(rc);
nameRef.setInterface(NameService.class);
nameRef.setGroup("*");
NameService nameServ = nameRef.get();
String name = nameServ.getName("dubbo");
`
`
Exception in thread "main" java.lang.IllegalStateException: Failed to
subscribe
dubbo://10.2.77.247/org.example.provider.test.NameService?application=first-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&interface=org.example.provider.test.NameService&methods=getName,getSupportCodes&pid=13407&release=3.0.2.1&side=consumer&sticky=false×tamp=1629444044395,
cause: Failed to filter serviceName from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:315)
at
org.apache.dubbo.registry.ListenerRegistryWrapper.subscribe(ListenerRegistryWrapper.java:106)
at
org.apache.dubbo.registry.integration.RegistryDirectory.subscribe(RegistryDirectory.java:107)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doCreateInvoker(RegistryProtocol.java:515)
at
org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol.getInvoker(InterfaceCompatibleRegistryProtocol.java:58)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.refreshInterfaceInvoker(MigrationInvoker.java:448)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.migrateToApplicationFirstInvoker(MigrationInvoker.java:239)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.refreshInvoker(MigrationRuleHandler.java:73)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.doMigrate(MigrationRuleHandler.java:57)
at
org.apache.dubbo.registry.client.migration.MigrationRuleListener.onRefer(MigrationRuleListener.java:211)
at
org.apache.dubbo.registry.integration.RegistryProtocol.interceptInvoker(RegistryProtocol.java:486)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doRefer(RegistryProtocol.java:468)
at
org.apache.dubbo.registry.integration.RegistryProtocol.refer(RegistryProtocol.java:448)
at
org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.refer(ProtocolListenerWrapper.java:74)
at
org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.refer(ProtocolFilterWrapper.java:68)
at
org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.refer(ProtocolSerializationWrapper.java:51)
at
org.apache.dubbo.qos.protocol.QosProtocolWrapper.refer(QosProtocolWrapper.java:73)
at org.apache.dubbo.rpc.Protocol$Adaptive.refer(Protocol$Adaptive.java)
at
org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:391)
at
org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:327)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:204)
at org.example.provider.test.TestConumer.main(TestConumer.java:31)
Caused by: org.apache.dubbo.rpc.RpcException: Failed to filter serviceName
from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.nacos.NacosRegistry.filterServiceNames(NacosRegistry.java:316)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames0(NacosRegistry.java:298)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames(NacosRegistry.java:279)
at
org.apache.dubbo.registry.nacos.NacosRegistry.doSubscribe(NacosRegistry.java:193)
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:298)
... 21 more
Caused by:
[GitHub] [dubbo] frlzk edited a comment on issue #6814: Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version
frlzk edited a comment on issue #6814:
URL: https://github.com/apache/dubbo/issues/6814#issuecomment-902492746
* Dubbo version: 3.0.2.1
* Operating System version: Ubuntu
* Java version: 1.8
Service provider:
ServiceConfig ns1=new ServiceConfig();
ns1.setRegistry(r);
ns1.setInterface(NameService.class);
ns1.setRef(new NameServiceImpl());
ns1.setGroup("group1");
ns1.export();
ServiceConfig ns2=new ServiceConfig();
ns2.setRegistry(r);
ns2.setInterface(NameService.class);
ns2.setRef(new NameServiceImpl());
ns2.setGroup("group2");
ns2.export();
Service consumer:
ReferenceConfig nameRef = new ReferenceConfig<>();
nameRef.setRegistry(rc);
nameRef.setInterface(NameService.class);
nameRef.setGroup("*");
NameService nameServ = nameRef.get();
String name = nameServ.getName("dubbo");
Exception:
'
Exception in thread "main" java.lang.IllegalStateException: Failed to
subscribe
dubbo://10.2.77.247/org.example.provider.test.NameService?application=first-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&interface=org.example.provider.test.NameService&methods=getName,getSupportCodes&pid=13407&release=3.0.2.1&side=consumer&sticky=false×tamp=1629444044395,
cause: Failed to filter serviceName from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:315)
at
org.apache.dubbo.registry.ListenerRegistryWrapper.subscribe(ListenerRegistryWrapper.java:106)
at
org.apache.dubbo.registry.integration.RegistryDirectory.subscribe(RegistryDirectory.java:107)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doCreateInvoker(RegistryProtocol.java:515)
at
org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol.getInvoker(InterfaceCompatibleRegistryProtocol.java:58)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.refreshInterfaceInvoker(MigrationInvoker.java:448)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.migrateToApplicationFirstInvoker(MigrationInvoker.java:239)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.refreshInvoker(MigrationRuleHandler.java:73)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.doMigrate(MigrationRuleHandler.java:57)
at
org.apache.dubbo.registry.client.migration.MigrationRuleListener.onRefer(MigrationRuleListener.java:211)
at
org.apache.dubbo.registry.integration.RegistryProtocol.interceptInvoker(RegistryProtocol.java:486)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doRefer(RegistryProtocol.java:468)
at
org.apache.dubbo.registry.integration.RegistryProtocol.refer(RegistryProtocol.java:448)
at
org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.refer(ProtocolListenerWrapper.java:74)
at
org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.refer(ProtocolFilterWrapper.java:68)
at
org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.refer(ProtocolSerializationWrapper.java:51)
at
org.apache.dubbo.qos.protocol.QosProtocolWrapper.refer(QosProtocolWrapper.java:73)
at org.apache.dubbo.rpc.Protocol$Adaptive.refer(Protocol$Adaptive.java)
at
org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:391)
at
org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:327)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:204)
at org.example.provider.test.TestConumer.main(TestConumer.java:31)
Caused by: org.apache.dubbo.rpc.RpcException: Failed to filter serviceName
from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.nacos.NacosRegistry.filterServiceNames(NacosRegistry.java:316)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames0(NacosRegistry.java:298)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames(NacosRegistry.java:279)
at
org.apache.dubbo.registry.nacos.NacosRegistry.doSubscribe(NacosRegistry.java:193)
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:29
[GitHub] [dubbo] frlzk edited a comment on issue #6814: Consumer aborted with ArrayIndexOutOfBoundsException when subscribing services from Nacos with '*' in group or version
frlzk edited a comment on issue #6814:
URL: https://github.com/apache/dubbo/issues/6814#issuecomment-902492746
* Dubbo version: 3.0.2.1
* Operating System version: Ubuntu
* Java version: 1.8
**Service provider:**
ServiceConfig ns1=new ServiceConfig();
ns1.setRegistry(r);
ns1.setInterface(NameService.class);
ns1.setRef(new NameServiceImpl());
ns1.setGroup("group1");
ns1.export();
ServiceConfig ns2=new ServiceConfig();
ns2.setRegistry(r);
ns2.setInterface(NameService.class);
ns2.setRef(new NameServiceImpl());
ns2.setGroup("group2");
ns2.export();
**Service consumer:**
ReferenceConfig nameRef = new ReferenceConfig<>();
nameRef.setRegistry(rc);
nameRef.setInterface(NameService.class);
nameRef.setGroup("*");
NameService nameServ = nameRef.get();
String name = nameServ.getName("dubbo");
**Exception:**
'
Exception in thread "main" java.lang.IllegalStateException: Failed to
subscribe
dubbo://10.2.77.247/org.example.provider.test.NameService?application=first-consumer&category=providers,configurators,routers&dubbo=2.0.2&group=*&interface=org.example.provider.test.NameService&methods=getName,getSupportCodes&pid=13407&release=3.0.2.1&side=consumer&sticky=false×tamp=1629444044395,
cause: Failed to filter serviceName from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:315)
at
org.apache.dubbo.registry.ListenerRegistryWrapper.subscribe(ListenerRegistryWrapper.java:106)
at
org.apache.dubbo.registry.integration.RegistryDirectory.subscribe(RegistryDirectory.java:107)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doCreateInvoker(RegistryProtocol.java:515)
at
org.apache.dubbo.registry.integration.InterfaceCompatibleRegistryProtocol.getInvoker(InterfaceCompatibleRegistryProtocol.java:58)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.refreshInterfaceInvoker(MigrationInvoker.java:448)
at
org.apache.dubbo.registry.client.migration.MigrationInvoker.migrateToApplicationFirstInvoker(MigrationInvoker.java:239)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.refreshInvoker(MigrationRuleHandler.java:73)
at
org.apache.dubbo.registry.client.migration.MigrationRuleHandler.doMigrate(MigrationRuleHandler.java:57)
at
org.apache.dubbo.registry.client.migration.MigrationRuleListener.onRefer(MigrationRuleListener.java:211)
at
org.apache.dubbo.registry.integration.RegistryProtocol.interceptInvoker(RegistryProtocol.java:486)
at
org.apache.dubbo.registry.integration.RegistryProtocol.doRefer(RegistryProtocol.java:468)
at
org.apache.dubbo.registry.integration.RegistryProtocol.refer(RegistryProtocol.java:448)
at
org.apache.dubbo.rpc.protocol.ProtocolListenerWrapper.refer(ProtocolListenerWrapper.java:74)
at
org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.refer(ProtocolFilterWrapper.java:68)
at
org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.refer(ProtocolSerializationWrapper.java:51)
at
org.apache.dubbo.qos.protocol.QosProtocolWrapper.refer(QosProtocolWrapper.java:73)
at org.apache.dubbo.rpc.Protocol$Adaptive.refer(Protocol$Adaptive.java)
at
org.apache.dubbo.config.ReferenceConfig.createProxy(ReferenceConfig.java:391)
at
org.apache.dubbo.config.ReferenceConfig.init(ReferenceConfig.java:327)
at org.apache.dubbo.config.ReferenceConfig.get(ReferenceConfig.java:204)
at org.example.provider.test.TestConumer.main(TestConumer.java:31)
Caused by: org.apache.dubbo.rpc.RpcException: Failed to filter serviceName
from nacos, url:
nacos://127.0.0.1:8848/org.apache.dubbo.registry.RegistryService?application=first-consumer&dubbo=2.0.2&interface=org.apache.dubbo.registry.RegistryService&pid=13407&release=3.0.2.1,
serviceName: providers:org.example.provider.test.NameService::*, cause: 1
at
org.apache.dubbo.registry.nacos.NacosRegistry.filterServiceNames(NacosRegistry.java:316)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames0(NacosRegistry.java:298)
at
org.apache.dubbo.registry.nacos.NacosRegistry.getServiceNames(NacosRegistry.java:279)
at
org.apache.dubbo.registry.nacos.NacosRegistry.doSubscribe(NacosRegistry.java:193)
at
org.apache.dubbo.registry.support.FailbackRegistry.subscribe(FailbackRegistry.java:298
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1405: Ftr: Added more event distribution types and improved event distribution mechanism for 1.5
codecov-commenter commented on pull request #1405: URL: https://github.com/apache/dubbo-go/pull/1405#issuecomment-902512969 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1405?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1405](https://codecov.io/gh/apache/dubbo-go/pull/1405?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17ea03f) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.36%`. > The diff coverage is `63.63%`. [](https://codecov.io/gh/apache/dubbo-go/pull/1405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 1.5#1405 +/- ## == - Coverage 58.07% 55.71% -2.37% == Files 275 276 +1 Lines 1338116018+2637 == + Hits 7771 8924+1153 - Misses 4650 6149+1499 + Partials 960 945 -15 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1405?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [common/extension/config\_post\_processor.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maWdfcG9zdF9wcm9jZXNzb3IuZ28=) | `0.00% <0.00%> (ø)` | | | [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `55.43% <0.00%> (+1.14%)` | :arrow_up: | | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: | | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: | | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <ø> (-41.29%)` | :arrow_down: | | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: | | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `54.68% <45.83%> (+15.85%)` | :arrow_up: | | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1405/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5
[GitHub] [dubbo-go] ChangedenCZD commented on pull request #1372: Ftr: Add config loader hooks for 1.5
ChangedenCZD commented on pull request #1372: URL: https://github.com/apache/dubbo-go/pull/1372#issuecomment-902519615 使用事件分发机制实现 #1405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] LiWenGu commented on issue #8513: org.apache.dubbo.remoting.TimeoutException: Waiting server-side response timeout by scan timer. start time: 2021-08-15 23:04:35.615, end time: 2021-0
LiWenGu commented on issue #8513: URL: https://github.com/apache/dubbo/issues/8513#issuecomment-902539097 > 查过线程池的状态了没？ 我去查看了，发现 005 机器线程数量飙升，这个日志就是 005 机器爆的异常。至于线程池状态没法定位到当时的快照信息。我再看看当时的业务日志有什么异常，这个线程数量突然变多是导致这个的原因？  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1388: Fix: fix the exception when tcp timeout is less than 1s for 1.5 #1362
codecov-commenter edited a comment on pull request #1388: URL: https://github.com/apache/dubbo-go/pull/1388#issuecomment-900870735 # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1388](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e77623) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.69%`. > The diff coverage is `65.64%`. [](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## 1.5#1388 +/- ## == - Coverage 58.07% 55.37% -2.70% == Files 275 276 +1 Lines 1338115948+2567 == + Hits 7771 8832+1061 - Misses 4650 6178+1528 + Partials 960 938 -22 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: | | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: | | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: | | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: | | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: | | [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `0.00% <ø> (-41.29%)` | :arrow_down: | | [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <33.33%> (+2.03%)` | :arrow_up: | | [remoting/getty/config.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZ2V0dHkvY29uZmlnLmdv) | `20.21% <50.00%> (+4.73%)` | :arrow_up: | | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/1388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.89% <
[GitHub] [dubbo-go] wangxw666 opened a new issue #1406: grpc goroutine optimize
wangxw666 opened a new issue #1406: URL: https://github.com/apache/dubbo-go/issues/1406 环境： - 注册中心： zk - 协议：grpc - dubbo-go 版本：1.5.7-rc2 问题： 消费者一个服务，提供者每增加一个实例都会创建6个协程。 查看pprof： ``` goroutine profile: total 44 5 @ 0x43bba0 0x407a25 0x4076db 0x8dddfa 0x46be31 #0x8dddf9google.golang.org/grpc.(*addrConn).resetTransport+0x6e9 /home/gopath/pkg/mod/google.golang.org/grpc@v1.38.0/clientconn.go:1214 5 @ 0x43bba0 0x43481a 0x433d85 0x4d91f5 0x4da08b 0x4da06d 0x65656f 0x66927e 0x5a4ccf 0x4d67c7 0x83d047 0x83cffa 0x83d881 0x8645a9 0x46be31 #0x433d84internal/poll.runtime_pollWait+0x54 /home/go/src/runtime/netpoll.go:203 #0x4d91f4internal/poll.(*pollDesc).wait+0x44 /home/go/src/internal/poll/fd_poll_runtime.go:87 #0x4da08ainternal/poll.(*pollDesc).waitRead+0x19a /home/go/src/internal/poll/fd_poll_runtime.go:92 #0x4da06cinternal/poll.(*FD).Read+0x17c /home/go/src/internal/poll/fd_unix.go:169 #0x65656enet.(*netFD).Read+0x4e /home/go/src/net/fd_unix.go:202 #0x66927dnet.(*conn).Read+0x8d /home/go/src/net/net.go:184 #0x5a4ccebufio.(*Reader).Read+0x24e /home/go/src/bufio/bufio.go:226 #0x4d67c6io.ReadAtLeast+0x86 /home/go/src/io/io.go:310 #0x83d046io.ReadFull+0x86 /home/go/src/io/io.go:329 #0x83cff9golang.org/x/net/http2.readFrameHeader+0x39 /home/gopath/pkg/mod/golang.org/x/net@v0.0.0-20201202161906-c7110b5ffcbb/http2/frame.go:237 #0x83d880golang.org/x/net/http2.(*Framer).ReadFrame+0xa0 /home/gopath/pkg/mod/golang.org/x/net@v0.0.0-20201202161906-c7110b5ffcbb/http2/frame.go:492 #0x8645a8 google.golang.org/grpc/internal/transport.(*http2Client).reader+0x178 /home/gopath/pkg/mod/google.golang.org/grpc@v1.38.0/internal/transport/http2_client.go:1347 5 @ 0x43bba0 0x44bf91 0x853052 0x85395d 0x87757b 0x46be31 #0x853051 google.golang.org/grpc/internal/transport.(*controlBuffer).get+0x121 /home/gopath/pkg/mod/google.golang.org/grpc@v1.38.0/internal/transport/controlbuf.go:407 #0x85395c google.golang.org/grpc/internal/transport.(*loopyWriter).run+0x1cc /home/gopath/pkg/mod/google.golang.org/grpc@v1.38.0/internal/transport/controlbuf.go:527 #0x87757a google.golang.org/grpc/internal/transport.newHTTP2Client.func3+0x7a /home/gopath/pkg/mod/google.golang.org/grpc@v1.38.0/internal/transport/http2_client.go:396 5 @ 0x43bba0 0x44bf91 0x8d5792 0x46be31 #0x8d5791 google.golang.org/grpc.(*ccBalancerWrapper).watcher+0xc1 /home/gopath/pkg/mod/google.golang.org/grpc@v1.38.0/balancer_conn_wrappers.go:69 5 @ 0x43bba0 0x44bf91 0xc853b6 0xc896c8 0x46be31 #0xc853b5 github.com/apache/dubbo-go/remoting/zookeeper.(*ZkEventListener).listenServiceNodeEvent+0x195 /home/gopath/pkg/mod/github.com/apache/dubbo-go@v1.5.7-rc2-0.20210809082309-ace2a0e6c0f9/remoting/zookeeper/listener.go:94 #0xc896c7 github.com/apache/dubbo-go/remoting/zookeeper.(*ZkEventListener).listenDirEvent.func1+0x97 /home/gopath/pkg/mod/github.com/apache/dubbo-go@v1.5.7-rc2-0.20210809082309-ace2a0e6c0f9/remoting/zookeeper/listener.go:309 3 @ 0x43bba0 0x44bf91 0xc853b6 0xc8942a 0x46be31 #0xc853b5 github.com/apache/dubbo-go/remoting/zookeeper.(*ZkEventListener).listenServiceNodeEvent+0x195 /home/gopath/pkg/mod/github.com/apache/dubbo-go@v1.5.7-rc2-0.20210809082309-ace2a0e6c0f9/remoting/zookeeper/listener.go:94 #0xc89429 github.com/apache/dubbo-go/remoting/zookeeper.(*ZkEventListener).handleZkNodeEvent.func2+0x89 /home/gopath/pkg/mod/github.com/apache/dubbo-go@v1.5.7-rc2-0.20210809082309-ace2a0e6c0f9/remoting/zookeeper/listener.go:181 ``` provider每增加一个实例，消费者都会创建上面的每一个协程，共6个 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure commented on pull request #8519: fix ShortestResponseLoadBalanceTest failure
24kpure commented on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-902604199 > @24kpure please fix the failed testcase Thanks for your notice. I have reviewed my changed code which make no relate with org.apache.dubbo.config.spring.schema.GenericServiceTest#testGeneric. As a matter of fact,I don't commit anything, however,ut offen run failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
24kpure edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-902604199 > @24kpure please fix the failed testcase @pinxiong Thanks for your notice. I have reviewed my changed code which make no relate with org.apache.dubbo.config.spring.schema.GenericServiceTest#testGeneric. As a matter of fact,I don't commit anything, however,ut offen run failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
24kpure edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-902604199 @pinxiong Thanks for your notice. I have reviewed my changed code which make no relate with org.apache.dubbo.config.spring.schema.GenericServiceTest#testGeneric. As a matter of fact,I don't commit anything, however,ut offen run failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure commented on issue #3472: How can I get the provider application.name in a consumer filter
24kpure commented on issue #3472: URL: https://github.com/apache/dubbo/issues/3472#issuecomment-902624804 `invoker.getUrl().getParameter(REMOTE_APPLICATION_KEY)` It works for me. Maybe you can get answer from `org.apache.dubbo.rpc.filter.ConsumerContextFilter#invoke`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure removed a comment on issue #3472: How can I get the provider application.name in a consumer filter
24kpure removed a comment on issue #3472: URL: https://github.com/apache/dubbo/issues/3472#issuecomment-902624804 `invoker.getUrl().getParameter(REMOTE_APPLICATION_KEY)` It works for me. Maybe you can get answer from `org.apache.dubbo.rpc.filter.ConsumerContextFilter#invoke`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] 24kpure commented on issue #8559: 如何在consumer端获取调用的provider的application name
24kpure commented on issue #8559: URL: https://github.com/apache/dubbo/issues/8559#issuecomment-902625138 `invoker.getUrl().getParameter(REMOTE_APPLICATION_KEY)` It works for me. Maybe you can get the answer from `org.apache.dubbo.rpc.filter.ConsumerContextFilter#invoke`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] pinxiong commented on pull request #8519: fix ShortestResponseLoadBalanceTest failure
pinxiong commented on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-902645657 > @pinxiong Thanks for your notice. I have reviewed my changed code which make no relate with org.apache.dubbo.config.spring.schema.GenericServiceTest#testGeneric. As a matter of fact,I don't commit anything, however,ut offen run failed. You also can have a try😎 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] BurningCN opened a new pull request #8560: Add test cases to the Configurator after version 2.7
BurningCN opened a new pull request #8560: URL: https://github.com/apache/dubbo/pull/8560 ## What is the purpose of the change Add test cases to the Configurator after version 2.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] BurningCN commented on pull request #8558: fix Issue 8516 on branch 3.0
BurningCN commented on pull request #8558: URL: https://github.com/apache/dubbo/pull/8558#issuecomment-902651312 The name of pr should be more specific, such as what problem is fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] malone081021 opened a new pull request #8561: AA
malone081021 opened a new pull request #8561: URL: https://github.com/apache/dubbo/pull/8561 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #8560: Add test cases to the Configurator after version 2.7
codecov-commenter commented on pull request #8560: URL: https://github.com/apache/dubbo/pull/8560#issuecomment-902677171 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8560](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b36098f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/873937453b41374d58421f977b4eca5ee1ca4730?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8739374) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8560 +/- ## + Coverage 62.94% 62.97% +0.03% - Complexity 310 311 +1 Files 1117 1117 Lines 4673546735 Branches 7010 7032 +22 + Hits 2941629431 +15 + Misses1405714041 -16 - Partials 3262 3263 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `70.17% <0.00%> (-3.51%)` | :arrow_down: | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `78.10% <0.00%> (-1.46%)` | :arrow_down: | | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyQ2xpZW50LmphdmE=) | `71.42% <0.00%> (-0.99%)` | :arrow_down: | | [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `77.16% <0.00%> (-0.46%)` | :arrow_down: | | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `65.38% <0.00%> (-0.35%)` | :arrow_down: | | [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=refe
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8560: Add test cases to the Configurator after version 2.7
codecov-commenter edited a comment on pull request #8560: URL: https://github.com/apache/dubbo/pull/8560#issuecomment-902677171 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8560](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b36098f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/873937453b41374d58421f977b4eca5ee1ca4730?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8739374) will **increase** coverage by `0.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8560 +/- ## + Coverage 62.94% 63.00% +0.06% - Complexity 310 312 +2 Files 1117 1117 Lines 4673546735 Branches 7010 7032 +22 + Hits 2941629445 +29 + Misses1405714031 -26 + Partials 3262 3259 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `78.46% <0.00%> (-1.10%)` | :arrow_down: | | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyQ2xpZW50LmphdmE=) | `71.42% <0.00%> (-0.99%)` | :arrow_down: | | [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `77.16% <0.00%> (-0.46%)` | :arrow_down: | | [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `65.38% <0.00%> (-0.35%)` | :arrow_down: | | [...in/java/org/apache/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9TZXJ2aWNlQ29uZmlnLmphdmE=) | `70.76% <0.00%> (-0.28%)` | :arrow_down: | | [...apache/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/dubbo/pull/8560/diff?src=pr&el=tree&utm_medium=referral&utm_source=githu
[GitHub] [dubbo-go-samples] Mulavar commented on issue #180: delete the redundant getty config params
Mulavar commented on issue #180: URL: https://github.com/apache/dubbo-go-samples/issues/180#issuecomment-902701365 https://github.com/apache/dubbo-go-samples/pull/199 https://github.com/apache/dubbo-go-samples/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8558: fix Issue 8516 on branch 3.0
changfubai commented on pull request #8558: URL: https://github.com/apache/dubbo/pull/8558#issuecomment-902708825 > The name of pr should be more specific, such as what problem is fixed ok.thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1389: 建立dubbo自己统一入口平台和鉴权权限认证
LaurenceLiZhixin commented on issue #1389: URL: https://github.com/apache/dubbo-go/issues/1389#issuecomment-902717434 @zhaoyunxing92 @AlexStocks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516 on branch 2.7-native_image
changfubai commented on pull request #8520: URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902717538 > > thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch? > > Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem. I submit to master branch and 3.0 branch. could you please help me revirew? by the way, should i submit this commit to all the branches if this bug exist on the all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin edited a comment on issue #1389: 建立dubbo自己统一入口平台和鉴权权限认证
LaurenceLiZhixin edited a comment on issue #1389: URL: https://github.com/apache/dubbo-go/issues/1389#issuecomment-902717434 @zhaoyunxing92 @AlexStocks What's your ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on issue #1389: 建立dubbo自己统一入口平台和鉴权权限认证
LaurenceLiZhixin commented on issue #1389: URL: https://github.com/apache/dubbo-go/issues/1389#issuecomment-902718142 全局的日志接口配置、自定义日志接口，我们将会在3.0接下来给出方案。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516 on branch 2.7-native_image
changfubai edited a comment on pull request #8520: URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902717538 > > thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch? > > Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem. I submit to master branch and 3.0 branch. could you please help me revirew? #8558 #8554 by the way, should i submit this commit to all the branches if this bug exist on the all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai edited a comment on pull request #8520: fix Issue 8516 on branch 2.7-native_image
changfubai edited a comment on pull request #8520: URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902717538 > > thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch? > > Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem. I submit to master branch and 3.0 branch. could you please help me review? #8558 #8554 by the way, should i submit this commit to all the branches if this bug exist on the all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] TonyXb opened a new pull request #201: 20210820 fix java entity user id xingbin01
TonyXb opened a new pull request #201: URL: https://github.com/apache/dubbo-go-samples/pull/201 Java Client and Server fix User Entity id to ID -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] TonyXb closed pull request #201: 20210820 fix java entity user id xingbin01
TonyXb closed pull request #201: URL: https://github.com/apache/dubbo-go-samples/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] TonyXb opened a new pull request #202: fix java User pojo id to ID
TonyXb opened a new pull request #202: URL: https://github.com/apache/dubbo-go-samples/pull/202 fix dubbo-go sample java client and server User pojo id to ID -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on pull request #8520: fix Issue 8516 on branch 2.7-native_image
changfubai commented on pull request #8520: URL: https://github.com/apache/dubbo/pull/8520#issuecomment-902832853 2.7-native_image这个分支本身单测就过不了啊 -。- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] changfubai commented on issue #8514: org.apache.dubbo.remoting.TimeoutException: Waiting server-side response timeout
changfubai commented on issue #8514: URL: https://github.com/apache/dubbo/issues/8514#issuecomment-903037281 请问解决了么？和api的参数有关的话，是有什么特殊的处理逻辑么？这个参数对应的响应内容有什么特殊的嘛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] xiaoheng1 commented on issue #8513: org.apache.dubbo.remoting.TimeoutException: Waiting server-side response timeout by scan timer. start time: 2021-08-15 23:04:35.615, end time: 2021
xiaoheng1 commented on issue #8513: URL: https://github.com/apache/dubbo/issues/8513#issuecomment-903042864 > 我去查看了，发现 005 机器线程数量飙升，这个日志就是 005 机器爆的异常。至于线程池状态没法定位到当时的快照信息。我再看看当时的业务日志有什么异常，这个线程数量突然变多是导致这个的原因？ 线程数量飙升可能会引起这个问题。具体确认的话，还是要结合当时的日志，机器状态来确认。 方便贴下你们线程池这块的配置不？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
codecov-commenter edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-899550897 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8519](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5318a93) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0809a168db5fd71a58dd3f87b0bce00bd5ed8916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0809a16) will **decrease** coverage by `0.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8519 +/- ## - Coverage 62.92% 62.76% -0.17% + Complexity 311 309 -2 Files 1115 1117 +2 Lines 4671646735 +19 Branches 7029 7010 -19 - Hits 2939829333 -65 - Misses1406314125 +62 - Partials 3255 3277 +22 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-27.59%)` | :arrow_down: | | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0.00%> (-5.27%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://codecov.io/gh/apache/dubbo
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
codecov-commenter edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-899550897 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8519](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5318a93) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0809a168db5fd71a58dd3f87b0bce00bd5ed8916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0809a16) will **decrease** coverage by `0.10%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8519 +/- ## - Coverage 62.92% 62.82% -0.11% + Complexity 311 310 -1 Files 1115 1117 +2 Lines 4671646735 +19 Branches 7029 7032 +3 - Hits 2939829359 -39 - Misses1406314109 +46 - Partials 3255 3267 +12 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-27.59%)` | :arrow_down: | | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0.00%> (-5.27%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://codecov.io/gh/apache/dubbo
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
codecov-commenter edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-899550897 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8519](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5318a93) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0809a168db5fd71a58dd3f87b0bce00bd5ed8916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0809a16) will **increase** coverage by `0.00%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff@@ ##3.0#8519 +/- ## = Coverage 62.92% 62.93% Complexity 311 311 = Files 1115 1117+2 Lines 4671646735 +19 Branches 7029 7032+3 = + Hits 2939829414 +16 + Misses1406314061-2 - Partials 3255 3260+5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `82.75% <0.00%> (-6.90%)` | :arrow_down: | | [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <0.00%> (-2.98%)` | :arrow_down: | | [...etadata/report/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvc3VwcG9ydC9BYnN0cmFjdE1ldGFkYXRhUmVwb3J0LmphdmE=) | `57.89% <0.00%> (-2.88%)` | :arrow_down: | | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `52.17% <0.00%> (-1.32%)` | :arrow_down: | | [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `70.23% <0.00%> (-1.20%)` | :arrow_down: | | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comme
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8519: fix ShortestResponseLoadBalanceTest failure
codecov-commenter edited a comment on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-899550897 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8519](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5318a93) into [3.0](https://codecov.io/gh/apache/dubbo/commit/0809a168db5fd71a58dd3f87b0bce00bd5ed8916?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0809a16) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8519 +/- ## + Coverage 62.92% 62.95% +0.03% - Complexity 311 312 +1 Files 1115 1117 +2 Lines 4671646735 +19 Branches 7029 7032 +3 + Hits 2939829424 +26 + Misses1406314054 -9 - Partials 3255 3257 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8519?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/dubbo/monitor/support/MonitorFilter.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vbW9uaXRvci9zdXBwb3J0L01vbml0b3JGaWx0ZXIuamF2YQ==) | `66.66% <0.00%> (-25.50%)` | :arrow_down: | | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `82.75% <0.00%> (-6.90%)` | :arrow_down: | | [...ubbo/rpc/protocol/tri/ClientTransportObserver.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQ2xpZW50VHJhbnNwb3J0T2JzZXJ2ZXIuamF2YQ==) | `80.00% <0.00%> (-2.98%)` | :arrow_down: | | [...he/dubbo/rpc/protocol/tri/TripleClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvVHJpcGxlQ2xpZW50SGFuZGxlci5qYXZh) | `52.17% <0.00%> (-1.32%)` | :arrow_down: | | [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `70.23% <0.00%> (-1.20%)` | :arrow_down: | | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3Rpbmctem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy96b29rZWVwZXIvY3VyYXRvci9DdXJhdG9yWm9va2VlcGVyQ2xpZW50LmphdmE=) | `71.42% <0.00%> (-0.99%)` | :arrow_down: | | [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/dubbo/pull/8519/diff?src=pr&el=tree&utm_
[GitHub] [dubbo] 24kpure commented on pull request #8519: fix ShortestResponseLoadBalanceTest failure
24kpure commented on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-903046727 Luckily，it worked，but it did cost a lot of time. @pinxiong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] fsx379 opened a new issue #8562: [2.6.*]关于netty4中 NettyClientHandler 的问题反馈
fsx379 opened a new issue #8562: URL: https://github.com/apache/dubbo/issues/8562 1.在2.6.*中默认使用netty4后，NettyClientHandler在 channelActive()方法中，没有像NettyServerHandler一样，调用handler.connected(channel); 2.这样导致consumer端客户端连接创建成功时，HeaderExchangeHandler.connected() 和HeartbeatHandler.connected()没有被触发; 3.上述两个方法中，会初始化 channel 中 READ_IMESTAMP、WRITE_TIMESTAMP两个属性； 4.而这两个属性，用于consumer 的 HeartBeatTask 心跳检测；如果为空，不会进入心跳发送或超时重新连接的逻辑； 5.通过测试，发现目前channel 中 READ_IMESTAMP、WRITE_TIMESTAMP两个属性的设置，无法在连接创建时被设置，只能在收到provider端的心跳时才被设置； 6.这样会在一种极端情况下产生问题，即由于backlog问题，产生了单边连接。即consumer端连接状态为 established，而provider端根本没有这个连接； 7.provider端没有心跳发送到consumer端，而consumer端由于READ_IMESTAMP为空，不会进入心跳发送或超时重新连接的逻辑；只能等consumer真正触发业务请求，才会发现这个问题，并导致请求失败； 8.上述问题如果可以修复，对于qps比较低的consumer，即在前3次心跳内，无业务请求的客户端，还是可以通过心跳发现并解决问题的。但对于qps高的业务，其实还是会导致第一笔请求失败。 所以需官方评估下是否有修复的必要。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1407: fix: prepare to refactor samples
LaurenceLiZhixin opened a new pull request #1407: URL: https://github.com/apache/dubbo-go/pull/1407 **What this PR does**: 1. Add imports package 2. remote default protocol ip. **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1407: fix: prepare to refactor samples
LaurenceLiZhixin merged pull request #1407: URL: https://github.com/apache/dubbo-go/pull/1407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] LaurenceLiZhixin merged pull request #203: Config enhance v3
LaurenceLiZhixin merged pull request #203: URL: https://github.com/apache/dubbo-go-samples/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #8519: fix ShortestResponseLoadBalanceTest failure
AlbumenJ merged pull request #8519: URL: https://github.com/apache/dubbo/pull/8519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #8519: fix ShortestResponseLoadBalanceTest failure
AlbumenJ commented on pull request #8519: URL: https://github.com/apache/dubbo/pull/8519#issuecomment-903083337 @24kpure Thanks for your contribution. I think if you can directly using merge instead of force-pushed would be better for others to track the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #202: fix java User pojo id to ID
AlexStocks merged pull request #202: URL: https://github.com/apache/dubbo-go-samples/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on issue #1389: 建立dubbo自己统一入口平台和鉴权权限认证
AlexStocks commented on issue #1389: URL: https://github.com/apache/dubbo-go/issues/1389#issuecomment-903095370 Sounds a good idea. Hope we can implement this feature this year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks closed issue #180: delete the redundant getty config params
AlexStocks closed issue #180: URL: https://github.com/apache/dubbo-go-samples/issues/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #194: Ftr: Add dubbo3-protobuf-nacos sample
AlexStocks merged pull request #194: URL: https://github.com/apache/dubbo-go-samples/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8510: test: Verify the mapping between exported provider and metadata
codecov-commenter edited a comment on pull request #8510: URL: https://github.com/apache/dubbo/pull/8510#issuecomment-899223854 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8510](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f963ada) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.17%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8510 +/- ## - Coverage 62.95% 62.77% -0.18% + Complexity 311 309 -2 Files 1117 1117 Lines 4673546735 Branches 7032 7010 -22 - Hits 2942029338 -82 - Misses1405114128 +77 - Partials 3264 3269 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-20.69%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0.00%> (-5.27%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://cod
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8540: test: Add testcases for checking exported metadata service in single registry center
codecov-commenter edited a comment on pull request #8540: URL: https://github.com/apache/dubbo/pull/8540#issuecomment-901252623 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8540](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39b1c1e) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.18%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8540 +/- ## - Coverage 62.95% 62.76% -0.19% + Complexity 311 309 -2 Files 1117 1117 Lines 4673546689 -46 Branches 7032 6998 -34 - Hits 2942029306 -114 - Misses1405114110 +59 - Partials 3264 3273 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-20.69%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `50.00% <0.00%> (-11.54%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2ZpeGVkL0ZpeGVkVGhyZWFkUG9vbC5qYXZh) | `80.00% <0.00%> (-7.50%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [...moting/transport/netty4/NettyEventLoopFactory.java](https://codecov
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8540: test: Add testcases for checking exported metadata service in single registry center
codecov-commenter edited a comment on pull request #8540: URL: https://github.com/apache/dubbo/pull/8540#issuecomment-901252623 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8540](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39b1c1e) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.14%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8540 +/- ## - Coverage 62.95% 62.80% -0.15% + Complexity 311 310 -1 Files 1117 1117 Lines 4673546735 Branches 7032 7032 - Hits 2942029352 -68 - Misses1405114116 +65 - Partials 3264 3267 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-20.69%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0.00%> (-5.27%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://cod
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8510: test: Verify the mapping between exported provider and metadata
codecov-commenter edited a comment on pull request #8510: URL: https://github.com/apache/dubbo/pull/8510#issuecomment-899223854 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8510](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f963ada) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8510 +/- ## - Coverage 62.95% 62.92% -0.03% + Complexity 311 310 -1 Files 1117 1117 Lines 4673546735 Branches 7032 7032 - Hits 2942029406 -14 - Misses1405114067 +16 + Partials 3264 3262 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8510?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `52.27% <0.00%> (-3.41%)` | :arrow_down: | | [...va/org/apache/dubbo/registry/RegistryNotifier.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9SZWdpc3RyeU5vdGlmaWVyLmphdmE=) | `85.71% <0.00%> (-2.86%)` | :arrow_down: | | [...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvQ29kZWMuamF2YQ==) | `65.17% <0.00%> (-1.79%)` | :arrow_down: | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `76.64% <0.00%> (-1.46%)` | :arrow_down: | | [.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTdGF0dXMuamF2YQ==) | `70.23% <0.00%> (-1.20%)` | :arrow_down: | | [...ting/zookeeper/curator/CuratorZookeeperClient.java](https://codecov.io/gh/apache/dubbo/pull/8510/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_con
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8540: test: Add testcases for checking exported metadata service in single registry center
codecov-commenter edited a comment on pull request #8540: URL: https://github.com/apache/dubbo/pull/8540#issuecomment-901252623 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8540](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39b1c1e) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8540 +/- ## - Coverage 62.95% 62.93% -0.02% - Complexity 311 312 +1 Files 1117 1117 Lines 4673546735 Branches 7032 7032 - Hits 2942029414 -6 - Misses1405114059 +8 + Partials 3264 3262 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvQ29kZWMuamF2YQ==) | `63.39% <0.00%> (-3.58%)` | :arrow_down: | | [...etadata/report/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvc3VwcG9ydC9BYnN0cmFjdE1ldGFkYXRhUmVwb3J0LmphdmE=) | `60.76% <0.00%> (-0.96%)` | :arrow_down: | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `66.66% <0.00%> (-0.93%)` | :arrow_down: | | [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0.00%> (ø)` | | | [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `79.56% <0.00%> (+1.45%)` | :arrow_up: | | [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/8540/diff?src=pr&el=tr
[GitHub] [dubbo] 294033186 opened a new issue #8563: Consumer is shutting down and this call is going to be stopped without receiving any result, usually this is called by a slow provider instance or
294033186 opened a new issue #8563:
URL: https://github.com/apache/dubbo/issues/8563
- [ ]
已经有类似的issue了[issues](https://github.com/apache/dubbo/issues/6294)，但是没有看到合理的解决方式
### Environment
* Dubbo version: 2.7.9
* Operating System version: centos7
* Java version: 1.8
### Steps to reproduce this issue
1. 服务提供端是hsf，edas-sdk版本是1.5.1，Pandora版本是3.0，服务调用端是dubbo2.7.9。
2. 调用端是调用一个会耗时大概2分钟的hsf服务。
3. 在1分30秒到2分钟之间dubbo会抛错Consumer is shutting down and this call is going to
be stopped without receiving any result, usually this is called by a slow
provider instance or bad service implementation，此时服务端hsf线程还在执行。
If there is an exception, please attach the exception trace:
```
2021-08-21 19:07:28 ERROR [http-nio-8080-exec-4] o.s.b.w.s.s.ErrorPageFilter
- Forwarding to error page from request [/invoke] due to exception [Failed to
invoke the method queryEomAccountSalePresaleMain in the service
com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi.
Tried 1 times of the providers [10.xx.xx.81:12200] (1/4) from the registry
10.xx.xx.45.1:2181 on the consumer 10.xx.xxx.xxx using the dubbo version 2.7.9.
Last error is: Failed to invoke remote method: queryEomAccountSalePresaleMain,
provider:
dubbo://10.xx.xx.81:12200/com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi?application=fss-account-center&check=false&group=yy_run&init=false&interface=com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi&invokeType=DUBBO&keep.alive=true&pid=71709&reference.filter=oyaccesslog,countInvoke,oplatConsumerLogFilter®ister.ip=10.70.114.154&remote.application=285a890d-8137-4e55-b6eb-dcd1b7cba94d&retries=0&r
evision=0.0.3-release-SNAPSHOT&send.reconnect=true&side=consumer&sticky=false&timeout=50&version=0.0.1,
cause: org.apache.dubbo.remoting.RemotingException: Channel NettyChannel
[channel=[id: 0xea8a2de3, L:0.0.0.0/0.0.0.0:12792]] is inactive. Directly
return the unFinished request : Request [id=126, version=2.0.2, twoway=true,
event=false, broken=false, data=RpcInvocation
[methodName=queryEomAccountSalePresaleMain, parameterTypes=[class
com.oyys.yjyg.service.yy.api.eomAccount.command.PresaleCommand],
arguments=[PresaleCommand(segNo=C001, periodCode=202108, presaleType=10,
method=ouyeel.apis.gateway.asc.sales.presale, appId=OYXH, sign=NA,
timestamp=2021-08-21 18:56:58, customFields=1629543955398,
costCenterList=[BSWWAA00], pageIndex=1, pageSize=1000)],
attachments={path=com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi,
remote.application=fss-account-center,
interface=com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi,
version=0.0
.1, ePlatErrorId=ff526afbe3e94ed68bb17d9687d8481a,
consumerApp=fss-account-center, group=yy_run}]]]
% org.apache.dubbo.rpc.RpcException: Failed to invoke the method
queryEomAccountSalePresaleMain in the service
com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi.
Tried 1 times of the providers [10.70.14.81:12200] (1/4) from the registry
10.70.45.1:2181 on the consumer 10.70.114.154 using the dubbo version 2.7.9.
Last error is: Failed to invoke remote method: queryEomAccountSalePresaleMain,
provider:
dubbo://10.70.14.81:12200/com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi?application=fss-account-center&check=false&group=yy_run&init=false&interface=com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi&invokeType=DUBBO&keep.alive=true&pid=71709&reference.filter=oyaccesslog,countInvoke,oplatConsumerLogFilter®ister.ip=10.70.114.154&remote.application=285a890d-8137-4e55-b6eb-dcd1b7cba94d&retries=0&revision=0.0.3-release-SNAPSHOT&send.reconnect=true&side=consumer&sticky=false&timeout=50&version=0.0.1,
cau
se: org.apache.dubbo.remoting.RemotingException: Channel NettyChannel
[channel=[id: 0xea8a2de3, L:0.0.0.0/0.0.0.0:12792]] is inactive. Directly
return the unFinished request : Request [id=126, version=2.0.2, twoway=true,
event=false, broken=false, data=RpcInvocation
[methodName=queryEomAccountSalePresaleMain, parameterTypes=[class
com.oyys.yjyg.service.yy.api.eomAccount.command.PresaleCommand],
arguments=[PresaleCommand(segNo=C001, periodCode=202108, presaleType=10,
method=ouyeel.apis.gateway.asc.sales.presale, appId=OYXH, sign=NA,
timestamp=2021-08-21 18:56:58, customFields=1629543955398,
costCenterList=[BSWWAA00], pageIndex=1, pageSize=1000)],
attachments={path=com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi,
remote.application=fss-account-center,
interface=com.baosight.shgt.service.yy.api.eomAccount.EomAccountSalePresaleAccountApi,
version=0.0.1, ePlatErrorId=ff526afbe3e94ed68bb17d9687d8481a,
consumerApp=fss-account-center, group=yy_run}]]
at
org.apache.dubbo.rpc.cluster.support.FailoverClusterInvoker.doInvoke(FailoverClusterInvoker.java:113)
~[dubbo-2.7.9.jar:2.7
[GitHub] [dubbo] Mozartaa commented on issue #8523: 【call provider service failed】The provider service used a virtual IP when registering
Mozartaa commented on issue #8523: URL: https://github.com/apache/dubbo/issues/8523#issuecomment-903111515 您好，非常感谢回复！ 但是我想表达的问题是一个优化兼容问题，同样的代码在不同的机器上问题是不一样的。这个问题我遇到了，是因为我电脑有多个网卡，但是dubbo并没有做兼容，在其他机器没有问题，只不过他们网卡单一，或者获取的ip是ok的。这个问题不是必现的，但是是可以优化的，希望您看一下我上封邮件中的帖子。如果对它进行了优化，那么dubbo的功能可以更加完善。 https://blog.csdn.net/f641385712/article/details/105233229 -- 原始邮件 -- 发件人: "apache/dubbo" ***@***.***>; 发送时间: 2021年8月20日(星期五) 中午11:38 ***@***.***>; ***@***.**@***.***>; 主题: Re: [apache/dubbo] 【call provider service failed】The provider service used a virtual IP when registering (#8523) 你好，我自己试了下。我用的dubbo里的dubbo-demo-xml-provider和dubbo-demo-xml-consumer案例功能是正常的(最新版本)，能正常消费，提供者案例代码也没有配置ip — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-benchmark] plusmancn closed issue #10: [Dubbo 3.0] Support benchmark test of Dubbo 3.0
plusmancn closed issue #10: URL: https://github.com/apache/dubbo-benchmark/issues/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-benchmark] plusmancn closed pull request #11: [ISSUE-10] Support benchmark test of Dubbo 3.0
plusmancn closed pull request #11: URL: https://github.com/apache/dubbo-benchmark/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1405: Ftr: Added more event distribution types and improved event distribution mechanism for 1.5
AlexStocks commented on a change in pull request #1405:
URL: https://github.com/apache/dubbo-go/pull/1405#discussion_r693358915
##
File path: config/reference_config.go
##
@@ -302,8 +304,36 @@ func publishConsumerDefinition(url *common.URL) {
}
// postProcessConfig asks registered ConfigPostProcessor to post-process the
current ReferenceConfig.
-func (c *ReferenceConfig) postProcessConfig(url *common.URL) {
+func (c *ReferenceConfig) postProcessConfig(url *common.URL, params
*map[string]string) {
for _, p := range extension.GetConfigPostProcessors() {
+ if params != nil && len(*params) > 0 {
+ if url == nil {
+ url = &common.URL{}
+ } else {
+ url = url.Clone()
+ }
+ for k, v := range *params {
+ url.SetParam(k, v)
+ }
+ }
p.PostProcessReferenceConfig(url)
}
}
+
+func (c *ReferenceConfig) getValidUrl() *common.URL {
Review comment:
Url --> URL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1403: build(deps): bump github.com/emicklei/go-restful/v3 from 3.4.0 to 3.5.2
AlexStocks merged pull request #1403: URL: https://github.com/apache/dubbo-go/pull/1403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo] pinxiong opened a new pull request #8564: perf: Optimize the zookeeper timeout in all testcase
pinxiong opened a new pull request #8564: URL: https://github.com/apache/dubbo/pull/8564 ## What is the purpose of the change There are still something wrong with zookeeper in testcases ```java [21/08/21 11:12:05:135 UTC] DubboShutdownHook INFO config.DubboShutdownHook: [DUBBO] Dubbo Service has been destroyed., dubbo version: 3.0.3-SNAPSHOT, current host: 10.1.0.20 [13314](https://github.com/apache/dubbo/pull/8510/checks?check_run_id=338982#step:5:13314)[21/08/21 11:12:05:199 UTC] Curator-ConnectionStateManager-0 WARN curator.CuratorZookeeperClient: [DUBBO] Curator zookeeper connection of session 10e18a6 timed out. connection timeout value is 3000, session expire timeout value is 6, dubbo version: 3.0.3-SNAPSHOT, current host: 10.1.0.20 [13315](https://github.com/apache/dubbo/pull/8510/checks?check_run_id=338982#step:5:13315)[21/08/21 11:12:05:202 UTC] Curator-ConnectionStateManager-0 WARN curator.CuratorZookeeperClient: [DUBBO] Curator zookeeper connection of session 10e1c93 timed out. connection timeout value is 3000, session expire timeout value is 6, dubbo version: 3.0.3-SNAPSHOT, current host: 10.1.0.20 ``` ```java java.lang.IllegalStateException: Failed to load ApplicationContext at org.springframework.test.context.cache.DefaultCacheAwareContextLoaderDelegate.loadContext(DefaultCacheAwareContextLoaderDelegate.java:132) at org.springframework.test.context.support.DefaultTestContext.getApplicationContext(DefaultTestContext.java:123) at org.springframework.test.context.web.ServletTestExecutionListener.setUpRequestContextIfNecessary(ServletTestExecutionListener.java:190) at org.springframework.test.context.web.ServletTestExecutionListener.prepareTestInstance(ServletTestExecutionListener.java:132) at org.springframework.test.context.TestContextManager.prepareTestInstance(TestContextManager.java:244) at org.springframework.test.context.junit.jupiter.SpringExtension.postProcessTestInstance(SpringExtension.java:98) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeTestInstancePostProcessors$5(ClassBasedTestDescriptor.java:341) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.executeAndMaskThrowable(ClassBasedTestDescriptor.java:346) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeTestInstancePostProcessors$6(ClassBasedTestDescriptor.java:341) at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193) at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1384) at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) at java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:312) at java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:743) at java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:742) at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeTestInstancePostProcessors(ClassBasedTestDescriptor.java:340) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateAndPostProcessTestInstance(ClassBasedTestDescriptor.java:263) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$2(ClassBasedTestDescriptor.java:256) at java.util.Optional.orElseGet(Optional.java:267) at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$3(ClassBasedTestDescriptor.java:255) at org.junit.jupiter.engine.execution.TestInstancesProvider.getTestInstances(TestInstancesProvider.java:29) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$prepare$0(TestMethodTestDescriptor.java:108) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:107) at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:71) at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$prepare$1(NodeTestTask.java:107) at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73) at org.junit.platform.engine.support.hierarchical.NodeTestTask.prepare(NodeTestTask.java:107) at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:75)
[GitHub] [dubbo-getty] Mulavar opened a new pull request #73: Rft/code format
Mulavar opened a new pull request #73: URL: https://github.com/apache/dubbo-getty/pull/73 **What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**: ```release-note ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] [dubbo-getty] codecov-commenter commented on pull request #73: Rft/code format
codecov-commenter commented on pull request #73: URL: https://github.com/apache/dubbo-getty/pull/73#issuecomment-903126368 # [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#73](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b3a800) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/1f33b205a929aa0324ab97875c602abbf603bbc3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f33b20) will **not change** coverage. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #73 +/- ## === Coverage 69.14% 69.14% === Files 88 Lines1426 1426 === Hits 986 986 Misses347 347 Partials 93 93 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `71.53% <ø> (ø)` | | | [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `79.73% <ø> (ø)` | | | [const.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3QuZ28=) | `80.00% <ø> (ø)` | | | [logger.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2VyLmdv) | `16.00% <ø> (ø)` | | | [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `80.85% <ø> (ø)` | | | [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `70.28% <ø> (ø)` | | | [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `67.88% <66.66%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f33b20...0b3a800](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment
[GitHub] [dubbo-getty] codecov-commenter edited a comment on pull request #73: Rft/code format
codecov-commenter edited a comment on pull request #73: URL: https://github.com/apache/dubbo-getty/pull/73#issuecomment-903126368 # [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#73](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b3a800) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/1f33b205a929aa0324ab97875c602abbf603bbc3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f33b20) will **not change** coverage. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #73 +/- ## === Coverage 69.14% 69.14% === Files 88 Lines1426 1426 === Hits 986 986 Misses347 347 Partials 93 93 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `71.53% <ø> (ø)` | | | [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `79.73% <ø> (ø)` | | | [const.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3QuZ28=) | `80.00% <ø> (ø)` | | | [logger.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2VyLmdv) | `16.00% <ø> (ø)` | | | [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `80.85% <ø> (ø)` | | | [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `70.28% <ø> (ø)` | | | [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `67.88% <66.66%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f33b20...0b3a800](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=
[GitHub] [dubbo-getty] codecov-commenter edited a comment on pull request #73: Rft/code format
codecov-commenter edited a comment on pull request #73: URL: https://github.com/apache/dubbo-getty/pull/73#issuecomment-903126368 # [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#73](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ada6920) into [master](https://codecov.io/gh/apache/dubbo-getty/commit/1f33b205a929aa0324ab97875c602abbf603bbc3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f33b20) will **not change** coverage. > The diff coverage is `66.66%`. [](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #73 +/- ## === Coverage 69.14% 69.14% === Files 88 Lines1426 1426 === Hits 986 986 Misses347 347 Partials 93 93 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [client.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50Lmdv) | `71.53% <ø> (ø)` | | | [connection.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29ubmVjdGlvbi5nbw==) | `79.73% <ø> (ø)` | | | [const.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3QuZ28=) | `80.00% <ø> (ø)` | | | [logger.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2VyLmdv) | `16.00% <ø> (ø)` | | | [options.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-b3B0aW9ucy5nbw==) | `80.85% <ø> (ø)` | | | [session.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Vzc2lvbi5nbw==) | `70.28% <ø> (ø)` | | | [server.go](https://codecov.io/gh/apache/dubbo-getty/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyLmdv) | `67.88% <66.66%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f33b20...ada6920](https://codecov.io/gh/apache/dubbo-getty/pull/73?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=
[GitHub] [dubbo] codecov-commenter commented on pull request #8564: perf: Optimize the zookeeper timeout in all testcase
codecov-commenter commented on pull request #8564: URL: https://github.com/apache/dubbo/pull/8564#issuecomment-903130095 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8564](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02ed114) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.18%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8564 +/- ## - Coverage 62.95% 62.77% -0.19% Complexity 311 311 Files 1117 1117 Lines 4673546689 -46 Branches 7032 6998 -34 - Hits 2942029307 -113 - Misses1405114111 +60 - Partials 3264 3271 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-20.69%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `50.00% <0.00%> (-11.54%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [...mmon/threadpool/support/fixed/FixedThreadPool.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9zdXBwb3J0L2ZpeGVkL0ZpeGVkVGhyZWFkUG9vbC5qYXZh) | `80.00% <0.00%> (-7.50%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [...moting/transport/netty4/NettyEventLoopFactory.java](https://codecov.io/gh/
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8564: perf: Optimize the zookeeper timeout in all testcase
codecov-commenter edited a comment on pull request #8564: URL: https://github.com/apache/dubbo/pull/8564#issuecomment-903130095 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8564](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02ed114) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8564 +/- ## - Coverage 62.95% 62.82% -0.13% Complexity 311 311 Files 1117 1117 Lines 4673546735 Branches 7032 7032 - Hits 2942029360 -60 - Misses1405114108 +57 - Partials 3264 3267 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ng/transport/dispatcher/all/AllChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9hbGwvQWxsQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `62.06% <0.00%> (-20.69%)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc3RhdHVzL3N1cHBvcnQvTG9hZFN0YXR1c0NoZWNrZXIuamF2YQ==) | `46.15% <0.00%> (-15.39%)` | :arrow_down: | | [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `43.47% <0.00%> (-15.22%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `62.06% <0.00%> (-6.90%)` | :arrow_down: | | [.../org/apache/dubbo/remoting/ExecutionException.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9FeGVjdXRpb25FeGNlcHRpb24uamF2YQ==) | `15.78% <0.00%> (-5.27%)` | :arrow_down: | | [...nt/metadata/StandardMetadataServiceURLBuilder.java](https://cod
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8564: perf: Optimize the zookeeper timeout in all testcase
codecov-commenter edited a comment on pull request #8564: URL: https://github.com/apache/dubbo/pull/8564#issuecomment-903130095 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#8564](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (02ed114) into [3.0](https://codecov.io/gh/apache/dubbo/commit/74fcf4d933fb2f38991cc94759e63482a70dd498?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (74fcf4d) will **decrease** coverage by `0.00%`. > The diff coverage is `n/a`. > :exclamation: Current head 02ed114 differs from pull request most recent head 620ded4. Consider uploading reports for the commit 620ded4 to get more accurate results [](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ##3.0#8564 +/- ## - Coverage 62.95% 62.94% -0.01% Complexity 311 311 Files 1117 1117 Lines 4673546735 Branches 7032 7032 - Hits 2942029416 -4 - Misses1405114058 +7 + Partials 3264 3261 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8564?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `62.79% <0.00%> (-9.31%)` | :arrow_down: | | [...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvQ29kZWMuamF2YQ==) | `65.17% <0.00%> (-1.79%)` | :arrow_down: | | [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `54.54% <0.00%> (-1.14%)` | :arrow_down: | | [...etadata/report/support/AbstractMetadataReport.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvc3VwcG9ydC9BYnN0cmFjdE1ldGFkYXRhUmVwb3J0LmphdmE=) | `60.76% <0.00%> (-0.96%)` | :arrow_down: | | [...he/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9tdWx0aWNhc3QvTXVsdGljYXN0UmVnaXN0cnkuamF2YQ==) | `66.66% <0.00%> (-0.93%)` | :arrow_down: | | [.../dubbo/registry/integration/RegistryDirectory.java](https://codecov.io/gh/apache/dubbo/pull/8564/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9pbnRlZ3J
