[GitHub] codecov-io commented on issue #1810: [Dubbo-199] Remove duplicate call to setProvider/setConsumer. #199
codecov-io commented on issue #1810: [Dubbo-199] Remove duplicate call to setProvider/setConsumer. #199 URL: https://github.com/apache/incubator-dubbo/pull/1810#issuecomment-389458117 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1810?src=pr=h1) Report > Merging [#1810](https://codecov.io/gh/apache/incubator-dubbo/pull/1810?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/36ba4c9b16834b58d84620e85ba428a2cab0da55?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1810?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1810 +/- ## + Coverage 40.4% 40.44% +0.04% - Complexity 4412 4413 +1 Files 626 626 Lines 3004530075 +30 Branches 5287 5317 +30 + Hits 1214012165 +25 - Misses1597415982 +8 + Partials 1931 1928 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1810?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...om/alibaba/dubbo/config/spring/AnnotationBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL0Fubm90YXRpb25CZWFuLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...dubbo/common/status/support/LoadStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3N0YXR1cy9zdXBwb3J0L0xvYWRTdGF0dXNDaGVja2VyLmphdmE=) | `60% <0%> (-6.67%)` | `2% <0%> (ø)` | | | [...main/java/com/alibaba/dubbo/qos/textui/TTable.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3Fvcy90ZXh0dWkvVFRhYmxlLmphdmE=) | `77.22% <0%> (-0.75%)` | `50% <0%> (ø)` | | | [.../java/com/alibaba/dubbo/common/utils/UrlUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL1VybFV0aWxzLmphdmE=) | `67.38% <0%> (-0.49%)` | `64% <0%> (ø)` | | | [.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `81.53% <0%> (-0.29%)` | `81% <0%> (ø)` | | | [...dubbo/remoting/exchange/support/DefaultFuture.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2Uvc3VwcG9ydC9EZWZhdWx0RnV0dXJlLmphdmE=) | `7.24% <0%> (-0.22%)` | `2% <0%> (ø)` | | | [...ting/exchange/support/header/HeartbeatHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2Uvc3VwcG9ydC9oZWFkZXIvSGVhcnRiZWF0SGFuZGxlci5qYXZh) | `6.66% <0%> (-0.16%)` | `1% <0%> (ø)` | | | [.../java/com/alibaba/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05ldFV0aWxzLmphdmE=) | `15.78% <0%> (-0.12%)` | `13% <0%> (ø)` | | | [...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh) | `26.34% <0%> (-0.04%)` | `77% <0%> (ø)` | | | [...om/alibaba/com/caucho/hessian/io/HessianInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW5JbnB1dC5qYXZh) | `19.58% <0%> (+0.03%)` | `42% <0%> (ø)` | :arrow_down: | | ... and [13 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1810/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1810?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not
[GitHub] ralf0131 closed issue #200: ScriptRouter脚本路由规则执行存在问题
ralf0131 closed issue #200: ScriptRouter脚本路由规则执行存在问题 URL: https://github.com/apache/incubator-dubbo/issues/200 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #201: dubbo provider和consumer传输对象用什么协议比较好，需要序列化吗
ralf0131 closed issue #201: dubbo provider和consumer传输对象用什么协议比较好，需要序列化吗 URL: https://github.com/apache/incubator-dubbo/issues/201 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #189: dubbo-admin启动报错
ralf0131 commented on issue #189: dubbo-admin启动报错 URL: https://github.com/apache/incubator-dubbo/issues/189#issuecomment-389445400 This is because you compiled the code under Java 8 but run it under Java 7 or lower. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #210: dubbo调用报错HessianFieldException
ralf0131 closed issue #210: dubbo调用报错HessianFieldException URL: https://github.com/apache/incubator-dubbo/issues/210 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #179: 你好，有关nodejs调用dubbo服务的问题
ralf0131 closed issue #179: 你好，有关nodejs调用dubbo服务的问题 URL: https://github.com/apache/incubator-dubbo/issues/179 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #179: 你好，有关nodejs调用dubbo服务的问题
ralf0131 commented on issue #179: 你好，有关nodejs调用dubbo服务的问题 URL: https://github.com/apache/incubator-dubbo/issues/179#issuecomment-389444649 Please check out this awesome project: https://github.com/dubbo/dubbo2.js This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service
YoungHu commented on issue #1624: [Design bug] unreasonable design for register dubbo service URL: https://github.com/apache/incubator-dubbo/issues/1624#issuecomment-389413272 But that is not a fully solution, I just resolved the group problem not the version. In my onion, we should a discussion, because this change will affect dubbo service registry and discovery directly. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #206: 使用注解定义Service，结果自定义的Aop用不了，根本启动不起来，怎么搞？
ralf0131 closed issue #206: 使用注解定义Service，结果自定义的Aop用不了，根本启动不起来，怎么搞？ URL: https://github.com/apache/incubator-dubbo/issues/206 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #189: dubbo-admin启动报错
ralf0131 closed issue #189: dubbo-admin启动报错 URL: https://github.com/apache/incubator-dubbo/issues/189 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #212: dubbo-2.5.3，com.alibaba.dubbo.config.spring.AnnotationBean，serviceConfig.setProtocols报错
ralf0131 commented on issue #212: dubbo-2.5.3，com.alibaba.dubbo.config.spring.AnnotationBean，serviceConfig.setProtocols报错 URL: https://github.com/apache/incubator-dubbo/issues/212#issuecomment-389452354 This issue has been fixed. Please try using the latest version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #212: dubbo-2.5.3，com.alibaba.dubbo.config.spring.AnnotationBean，serviceConfig.setProtocols报错
ralf0131 closed issue #212: dubbo-2.5.3，com.alibaba.dubbo.config.spring.AnnotationBean，serviceConfig.setProtocols报错 URL: https://github.com/apache/incubator-dubbo/issues/212 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] vangoleo opened a new pull request #1808: Fix Issue : https://github.com/apache/incubator-dubbo/issues/1470
vangoleo opened a new pull request #1808: Fix Issue :
https://github.com/apache/incubator-dubbo/issues/1470
URL: https://github.com/apache/incubator-dubbo/pull/1808
## What is the purpose of the change
Fix an error in URL class -- can not get username or password correctly
while them contains "@" character.
For example : admin:hello@1234@10.20.30.40/context/path
## Brief changelog
Replace indexOf("@") with lastIndexOf("@")
## Verifying this change
Run unit test URLTest.testUserNamePasswordContainsAt()
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a
[GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a GITHUB issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException
when host config not exist #XXX`. Each commit in the pull request should have a
meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add integration-test in
[test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile
failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation
Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] htynkn opened a new pull request #1809: add unit test for dubbo spring config
htynkn opened a new pull request #1809: add unit test for dubbo spring config URL: https://github.com/apache/incubator-dubbo/pull/1809 ## What is the purpose of the change Add test for dubbo spring config module Close #1684 ## Brief changelog + ignore AnnotationBean in codecov + replace junit.framework.Assert; to org.junit.Assert; + add unit test ## Verifying this change CI Pass somehow even master branch fail in my fork repo... I guess travis ci has some issue. Hope pull request CI can pass in dubbo repo travis ci. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #200: ScriptRouter脚本路由规则执行存在问题
ralf0131 commented on issue #200: ScriptRouter脚本路由规则执行存在问题 URL: https://github.com/apache/incubator-dubbo/issues/200#issuecomment-389450760 It has been fixed in the latest documentation: http://dubbo.apache.org/books/dubbo-user-book/demos/routing-rule.html This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] diecui1202 commented on issue #1048: Failed to send attachments to provider when using thrift RPC protocol.
diecui1202 commented on issue #1048: Failed to send attachments to provider when using thrift RPC protocol. URL: https://github.com/apache/incubator-dubbo/issues/1048#issuecomment-390145757 @lovepoem please consider this in native-thrift protocol. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ningyu1 commented on issue #1708: [Dubbo-1637] Fix When using hibernate-validator, class 'org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl' is wrong with hessian
ningyu1 commented on issue #1708: [Dubbo-1637] Fix When using hibernate-validator, class 'org.hibernate.validator.internal.metadata.descriptor.ConstraintDescriptorImpl' is wrong with hessian deserialization. URL: https://github.com/apache/incubator-dubbo/pull/1708#issuecomment-390145589 @chickenlj Can you suggest a better way? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] Mrbug001 commented on issue #26: 启东时没有按照配置的zookeeper找注册中心
Mrbug001 commented on issue #26: 启东时没有按照配置的zookeeper找注册中心 URL: https://github.com/apache/incubator-dubbo-ops/issues/26#issuecomment-390147115 @mark-wk 解决了吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] Mrbug001 commented on issue #26: 启东时没有按照配置的zookeeper找注册中心
Mrbug001 commented on issue #26: 启东时没有按照配置的zookeeper找注册中心 URL: https://github.com/apache/incubator-dubbo-ops/issues/26#issuecomment-390147050 @ChoingHyun 解决了吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] Jaskey commented on issue #1784: Dubbo调用超时，服务端历史统计的处理耗时很短且找不到对应超时上下文的超时日志
Jaskey commented on issue #1784: Dubbo调用超时，服务端历史统计的处理耗时很短且找不到对应超时上下文的超时日志 URL: https://github.com/apache/incubator-dubbo/issues/1784#issuecomment-390152044 @feelwing1314 设置的超时就是provider设置的，其他超时是有warn日志的，所以不可能是error级别的问题 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] wmwangmin closed pull request #1818: 2.6.2 release
wmwangmin closed pull request #1818: 2.6.2 release URL: https://github.com/apache/incubator-dubbo/pull/1818 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] wmwangmin opened a new pull request #1818: 2.6.2 release
wmwangmin opened a new pull request #1818: 2.6.2 release URL: https://github.com/apache/incubator-dubbo/pull/1818 ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] yanhaizhe opened a new issue #140: 0.2.0版本什么时候能release
yanhaizhe opened a new issue #140: 0.2.0版本什么时候能release URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/140 有版本计划吗？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] zyongbai opened a new issue #1819: AnnotationProvider启动报错
zyongbai opened a new issue #1819: AnnotationProvider启动报错 URL: https://github.com/apache/incubator-dubbo/issues/1819 com.alibaba.dubbo.examples.annotation.AnnotationProvider Exception in thread "main" java.lang.IllegalStateException: No such application config! Please add to your spring config. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] 136759790 opened a new issue #141: 提供者加上@transactional注解就无法再注册中心注册了
136759790 opened a new issue #141: 提供者加上@transactional注解就无法再注册中心注册了 URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/141 提供者加上@transactional注解就无法再注册中心注册了 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #944: AbstractClient reconnect() should be synchronized under concurrency scene
ralf0131 commented on issue #944: AbstractClient reconnect() should be synchronized under concurrency scene URL: https://github.com/apache/incubator-dubbo/issues/944#issuecomment-390463964 Hi, would you mind send a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #840: dubbo:annotation注解扫描到被代理的对象时，无法发布服务
ralf0131 closed issue #840: dubbo:annotation注解扫描到被代理的对象时，无法发布服务 URL: https://github.com/apache/incubator-dubbo/issues/840 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #625: maven install时一直提示无法解析项目jar包
ralf0131 closed issue #625: maven install时一直提示无法解析项目jar包 URL: https://github.com/apache/incubator-dubbo/issues/625 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #625: maven install时一直提示无法解析项目jar包
ralf0131 commented on issue #625: maven install时一直提示无法解析项目jar包 URL: https://github.com/apache/incubator-dubbo/issues/625#issuecomment-390465356 Hi, please try the latest code. Feel free to reopen it if it still exists. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #652: 用户手册基准测试工具包地址失效了
ralf0131 commented on issue #652: 用户手册基准测试工具包地址失效了 URL: https://github.com/apache/incubator-dubbo/issues/652#issuecomment-390464961 Hi, please check this doc: https://github.com/apache/incubator-dubbo-docs/blob/master/dubbo-user-book/benchmark-tool.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1690: Enhance the test coverage part-11 : dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default modules
ralf0131 commented on issue #1690: Enhance the test coverage part-11 : dubbo-registry/dubbo-registry-api and dubbo-registry/dubbo-registry-default modules URL: https://github.com/apache/incubator-dubbo/issues/1690#issuecomment-390466160 Hi, I am willing to take this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1820: Improve graceful shutdown
codecov-io commented on issue #1820: Improve graceful shutdown URL: https://github.com/apache/incubator-dubbo/pull/1820#issuecomment-390465824 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr=h1) Report > Merging [#1820](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5a3b1553dda84dc6e73e918bb6e025764d8c9a63?src=pr=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `44.44%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #1820 +/- ## === - Coverage 40.43% 40.4% -0.04% - Complexity 44154416 +1 === Files 628 629 +1 Lines 30081 30108 +27 Branches 53205322 +2 === Hits 12164 12164 - Misses15993 16015 +22 - Partials 19241929 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/com/alibaba/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvUHJvdG9jb2xDb25maWcuamF2YQ==) | `73.48% <0%> (-1.14%)` | `59 <0> (ø)` | | | [.../java/com/alibaba/dubbo/config/AbstractConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RDb25maWcuamF2YQ==) | `73.3% <100%> (+0.09%)` | `116 <0> (ø)` | :arrow_down: | | [...libaba/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb250YWluZXIvc3ByaW5nL1NwcmluZ0NvbnRhaW5lci5qYXZh) | `72.22% <100%> (+1.63%)` | `4 <0> (ø)` | :arrow_down: | | [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `43.47% <43.47%> (ø)` | `5 <5> (?)` | | | [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `87.85% <0%> (-1.87%)` | `15% <0%> (ø)` | | | ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1820/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1820?src=pr=footer). Last update
[GitHub] ralf0131 commented on issue #795: dubbo-admin corrupts when starting
ralf0131 commented on issue #795: dubbo-admin corrupts when starting URL: https://github.com/apache/incubator-dubbo/issues/795#issuecomment-390464509 Please check the latest dubbo-admin code, if you still get this issue, feel free to reopen it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #795: dubbo-admin corrupts when starting
ralf0131 closed issue #795: dubbo-admin corrupts when starting URL: https://github.com/apache/incubator-dubbo/issues/795 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1820: Improve graceful shutdown
ralf0131 commented on issue #1820: Improve graceful shutdown URL: https://github.com/apache/incubator-dubbo/pull/1820#issuecomment-390464834 @zonghaishang Please help to review this pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 opened a new pull request #1820: Improve graceful shutdown
ralf0131 opened a new pull request #1820: Improve graceful shutdown URL: https://github.com/apache/incubator-dubbo/pull/1820 ## What is the purpose of the change Improve compatibility for graceful shutdown. The implementation fo #1763 lack consideration for compatibility. ## Brief changelog * Create a dedicated class DubboShutdownHook, and make it singleton. * Restore ProtocolConfig#destroyAll() for compatabitility. * Register DubboShutdownHook in static initialization of AbstractConfig. ## Verifying this change Unit test passed. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #848: 多语言支持
ralf0131 closed issue #848: 多语言支持 URL: https://github.com/apache/incubator-dubbo/issues/848 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #848: 多语言支持
ralf0131 commented on issue #848: 多语言支持 URL: https://github.com/apache/incubator-dubbo/issues/848#issuecomment-390464239 Other language support can be found at: https://github.com/dubbo This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #642: dubbo用户手册连接错误
ralf0131 closed issue #642: dubbo用户手册连接错误 URL: https://github.com/apache/incubator-dubbo/issues/642 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #642: dubbo用户手册连接错误
ralf0131 commented on issue #642: dubbo用户手册连接错误 URL: https://github.com/apache/incubator-dubbo/issues/642#issuecomment-390465270 Hi, this issue has already be fixed. Please check the latest code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #341: dubbo_admin 部署失败的问题
ralf0131 commented on issue #341: dubbo_admin 部署失败的问题 URL: https://github.com/apache/incubator-dubbo/issues/341#issuecomment-389823792 The specific error is: ``` Caused by: org.springframework.beans.NotWritablePropertyException: Invalid property 'URIType' of bean class [com.alibaba.citrus.service.uribroker.uri.GenericURIBroker]: Bean property 'URIType' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter? at org.springframework.beans.BeanWrapperImpl.setPropertyValue(BeanWrapperImpl.java:801) at org.springframework.beans.BeanWrapperImpl.setPropertyValue(BeanWrapperImpl.java:651) at org.springframework.beans.AbstractPropertyAccessor.setPropertyValues(AbstractPropertyAccessor.java:78) at org.springframework.beans.AbstractPropertyAccessor.setPropertyValues(AbstractPropertyAccessor.java:59) at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1276) ... 50 more ``` I cannot reproduce this error by latest dubbo-admin code, please verify it again. I am closing this issue for now. If you still encounter this issue, please feel free to reopen it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] KMnO4 opened a new issue #1813: can dubbo support Serialization configuration to dubbo:service or dubbo:method
KMnO4 opened a new issue #1813: can dubbo support Serialization configuration to dubbo:service or dubbo:method URL: https://github.com/apache/incubator-dubbo/issues/1813 In my scenario, some methods in the provider return a large amount of data each time, because the response is internally duplicated, so the serialization and transmission performance can be improved by implementing a new Serialization (protostuff+snappy).I hope that the remaining services or methods in the provider continue to use the default Hessian2 Serialization, however， the Serialization configuration supports only the protocol level. In dubbo-remoting-netty, NettyServer, when the tcp connection is established, the response serialization type is specified through the NettyCodecAdapter's final url, it seems that Serialization configuration can not support the service or method level now. Does dubbo subsequently plan to support serialization configuration to service or method? 在我们的使用场景中，provider中有些接口返回数据量较大，在M级别，因为数据内部重复数据多，通过实现新的Serialization插件（protostuff+snappy）可以提高序列化和传输的性能。我们希望provider中其余service或者method继续使用默认hessian2 Serialization，但是现有Serialization配置只支持到protocol级别。 netty通讯方式中，NettyServer当中，当tcp连接被建立，response序列化方式通过NettyCodecAdapter的final url被指定下来，Serialization配置不能支持到service或者method级别。 dubbo后续有计划将Serialization配置支持到service或者method么？ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #341: dubbo_admin 部署失败的问题
ralf0131 closed issue #341: dubbo_admin 部署失败的问题 URL: https://github.com/apache/incubator-dubbo/issues/341 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #323: JfreeChart版本过低
ralf0131 closed issue #323: JfreeChart版本过低 URL: https://github.com/apache/incubator-dubbo/issues/323 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #890: 希望在文档中可以给出详细一些的线程模型图
ralf0131 commented on issue #890: 希望在文档中可以给出详细一些的线程模型图 URL: https://github.com/apache/incubator-dubbo/issues/890#issuecomment-389922719 Hello, well done! Can you please send a pull request to https://github.com/apache/incubator-dubbo-docs ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #296: 为什么Hessian不使用重载方法
ralf0131 commented on issue #296: 为什么Hessian不使用重载方法 URL: https://github.com/apache/incubator-dubbo/issues/296#issuecomment-389916160 To enable hessian method overloading, you can set `hessian.overload.method=true` to you provider url. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1665: Could not stop elegantly when running under tomcat
ralf0131 commented on issue #1665: Could not stop elegantly when running under tomcat URL: https://github.com/apache/incubator-dubbo/issues/1665#issuecomment-389919565 Fixed by #1763 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1652: memory leak warning when stop tomcat.
ralf0131 closed issue #1652: memory leak warning when stop tomcat. URL: https://github.com/apache/incubator-dubbo/issues/1652 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] wendal closed issue #319: AbstractConfig的shutdownHook应可配置
wendal closed issue #319: AbstractConfig的shutdownHook应可配置 URL: https://github.com/apache/incubator-dubbo/issues/319 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] wendal commented on issue #319: AbstractConfig的shutdownHook应可配置
wendal commented on issue #319: AbstractConfig的shutdownHook应可配置 URL: https://github.com/apache/incubator-dubbo/issues/319#issuecomment-389926660 becase it can't disable or stop at old version. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #319: AbstractConfig的shutdownHook应可配置
ralf0131 commented on issue #319: AbstractConfig的shutdownHook应可配置 URL: https://github.com/apache/incubator-dubbo/issues/319#issuecomment-389908067 Why should not the shutdown hook not be added? Have you encountered any issue? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #320: FailbackRegistry及其子类的线程池均没有销毁
ralf0131 commented on issue #320: FailbackRegistry及其子类的线程池均没有销毁 URL: https://github.com/apache/incubator-dubbo/issues/320#issuecomment-389907128 It is fixed in #1763 , will be available from 2.6.3 onwards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #320: FailbackRegistry及其子类的线程池均没有销毁
ralf0131 closed issue #320: FailbackRegistry及其子类的线程池均没有销毁 URL: https://github.com/apache/incubator-dubbo/issues/320 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #296: 为什么Hessian不使用重载方法
ralf0131 closed issue #296: 为什么Hessian不使用重载方法 URL: https://github.com/apache/incubator-dubbo/issues/296 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #559: 如何使用Python调用dubbo接口
ralf0131 commented on issue #559: 如何使用Python调用dubbo接口 URL: https://github.com/apache/incubator-dubbo/issues/559#issuecomment-389925743 Please checkout this awesome project: https://github.com/dubbo/dubbo-client-py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #326: 消费端调用java.lang.NullPointerException ,看不出注解有错。日志如下：
ralf0131 commented on issue #326: 消费端调用java.lang.NullPointerException ,看不出注解有错。日志如下： URL: https://github.com/apache/incubator-dubbo/issues/326#issuecomment-389909422 It looks like the NPE is thrown by your business code, check this: ``` at org.nutz.mvc.NutFilter.doFilter(NutFilter.java:198) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #323: JfreeChart版本过低
ralf0131 commented on issue #323: JfreeChart版本过低 URL: https://github.com/apache/incubator-dubbo/issues/323#issuecomment-389910997 Hi, I can correctly compile dubbo-monitor under Jdk 1.8. I am closing this issue. Please try again, if you still have such problem, please attach the detailed error message and reopen this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #303: corethreads设置
ralf0131 commented on issue #303: corethreads设置 URL: https://github.com/apache/incubator-dubbo/issues/303#issuecomment-389914519 I agree. Indeed `corethreads` should be added to `dubbo.xsd`. May there and more to be added. Would you mind send a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] lovepoem commented on issue #465: dubbo目前的支持优雅停机吗？
lovepoem commented on issue #465: dubbo目前的支持优雅停机吗？ URL: https://github.com/apache/incubator-dubbo/issues/465#issuecomment-389917537 @taige ,can you please create a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1665: Could not stop elegantly when running under tomcat
ralf0131 closed issue #1665: Could not stop elegantly when running under tomcat URL: https://github.com/apache/incubator-dubbo/issues/1665 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1665: Could not stop elegantly when running under tomcat
ralf0131 commented on issue #1665: Could not stop elegantly when running under tomcat URL: https://github.com/apache/incubator-dubbo/issues/1665#issuecomment-389919139 This issue has been fixed from 2.6.3 onwards. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #199: 为什么AnnotationBean中postProcessAfterInitialization方法和refer方法中的serviceConfig.setProvider方法和referenceConfig.setConsumer方法要重复执行一次呢？
ralf0131 commented on issue #199: 为什么AnnotationBean中postProcessAfterInitialization方法和refer方法中的serviceConfig.setProvider方法和referenceConfig.setConsumer方法要重复执行一次呢？ URL: https://github.com/apache/incubator-dubbo/issues/199#issuecomment-389522876 Yes, I have send a pull request to address this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667
codecov-io commented on issue #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667 URL: https://github.com/apache/incubator-dubbo/pull/1811#issuecomment-389574602 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=h1) Report > Merging [#1811](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/36ba4c9b16834b58d84620e85ba428a2cab0da55?src=pr=desc) will **decrease** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1811 +/- ## - Coverage 40.48% 40.45% -0.03% + Complexity 4417 4415 -2 Files 626 626 Lines 3007930079 Branches 5319 5319 - Hits 1217612167 -9 - Misses1597615985 +9 Partials 1927 1927 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1811/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==) | `37.5% <0%> (-8.34%)` | `3% <0%> (ø)` | | | [...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1811/diff?src=pr=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==) | `25% <0%> (-5.96%)` | `5% <0%> (-2%)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1811/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1811/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1811/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (+5.55%)` | `6% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=footer). Last update [36ba4c9...7fe2cfd](https://codecov.io/gh/apache/incubator-dubbo/pull/1811?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #241: miss dependecy 'jetty-maven-plugin'
ralf0131 closed issue #241: miss dependecy 'jetty-maven-plugin' URL: https://github.com/apache/incubator-dubbo/issues/241 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #236: dubbo分组校验不起作用的原因
ralf0131 commented on issue #236: dubbo分组校验不起作用的原因 URL: https://github.com/apache/incubator-dubbo/issues/236#issuecomment-389529988 Hi, would you please send a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 opened a new pull request #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667
ralf0131 opened a new pull request #1811: [Dubbo-1667] Fix unstable hessian protocol unit test. #1667 URL: https://github.com/apache/incubator-dubbo/pull/1811 ## What is the purpose of the change Fix unstable hessian protocol unit test ## Brief changelog Add `hessian.overload.method` to url. ## Verifying this change Unit test passed. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1667: com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest fails occasionally
ralf0131 commented on issue #1667: com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest fails occasionally URL: https://github.com/apache/incubator-dubbo/issues/1667#issuecomment-389567440 @htynkn I think you are right. The two failing ut ``` HessianProtocolTest.testHessianProtocol:48 » HessianRuntime com.caucho.hessian... HessianProtocolTest.testHttpClient:83 » HessianRuntime com.caucho.hessian.io.H... ``` both call `com.alibaba.dubbo.rpc.protocol.hessian.HessianServiceImpl#sayHello(String name)`, which has an override method `sayHello(String name, int times)`. In the opposite, `com.alibaba.dubbo.rpc.protocol.hessian.HessianProtocolTest#testOverload` never fails because `hessian.overload.method` is set to true. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #272: Linux 环境 dubbo-admin无法启动，显示一直启动中。。。
ralf0131 commented on issue #272: Linux 环境 dubbo-admin无法启动，显示一直启动中。。。 URL: https://github.com/apache/incubator-dubbo/issues/272#issuecomment-389528781 If you are running under Tomcat, please use jstack to check what the thread 'catalina-start-stop-xxx' is doing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1136: com.caucho.hessian.io.HessianProtocolException: '' is an unknown code
ralf0131 commented on issue #1136: com.caucho.hessian.io.HessianProtocolException: '�' is an unknown code URL: https://github.com/apache/incubator-dubbo/issues/1136#issuecomment-389568342 Please try adding `hessian.overload.method` to the url. e.g. `hessian://127.0.0.1:5342/com.alibaba.dubbo.rpc.protocol.hessian.HessianService?hessian.overload.method=true=1.0.0` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] codecov-io commented on issue #1803: Fix bug in InternalThreadLocal and provides unit test
codecov-io commented on issue #1803: Fix bug in InternalThreadLocal and provides unit test URL: https://github.com/apache/incubator-dubbo/pull/1803#issuecomment-389107807 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=h1) Report > Merging [#1803](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/71366d6f284acdeafdf5c9dae52f21e8311c0cad?src=pr=desc) will **increase** coverage by `0.14%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1803 +/- ## + Coverage 40.01% 40.16% +0.14% - Complexity 4347 4364 +17 Files 626 626 Lines 3007830079 +1 Branches 5319 5319 + Hits 1203712082 +45 + Misses1612916077 -52 - Partials 1912 1920 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../dubbo/common/threadlocal/InternalThreadLocal.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWwuamF2YQ==) | `70.58% <100%> (+34.76%)` | `16 <0> (+8)` | :arrow_up: | | [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `59.37% <0%> (+1.56%)` | `9% <0%> (+1%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+5%)` | `21% <0%> (+1%)` | :arrow_up: | | [...alibaba/dubbo/common/utils/NamedThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05hbWVkVGhyZWFkRmFjdG9yeS5qYXZh) | `76.47% <0%> (+11.76%)` | `4% <0%> (+1%)` | :arrow_up: | | [...bbo/common/threadlocal/InternalThreadLocalMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL0ludGVybmFsVGhyZWFkTG9jYWxNYXAuamF2YQ==) | `82.43% <0%> (+18.91%)` | `21% <0%> (+6%)` | :arrow_up: | | [...common/threadlocal/NamedInternalThreadFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1803/diff?src=pr=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3RocmVhZGxvY2FsL05hbWVkSW50ZXJuYWxUaHJlYWRGYWN0b3J5LmphdmE=) | `80% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=footer). Last update [71366d6...64bc20c](https://codecov.io/gh/apache/incubator-dubbo/pull/1803?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1734: why dependency 'commons-lang3' is provided scope?
ralf0131 commented on issue #1734: why dependency 'commons-lang3' is provided
scope?
URL:
https://github.com/apache/incubator-dubbo/issues/1734#issuecomment-389111804
Where did you get the provided scope? In dependencies-bom/pom.xml:
```xml
org.apache.commons
commons-lang3
${commons_lang3_version}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1594: Does Dubbo currently support PHP?
ralf0131 closed issue #1594: Does Dubbo currently support PHP? URL: https://github.com/apache/incubator-dubbo/issues/1594 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232)
ralf0131 closed issue #1609: incomplete: Fix hessian2 serialized short, byte is converted to int bug (#1232) URL: https://github.com/apache/incubator-dubbo/issues/1609 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch
ralf0131 closed issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch URL: https://github.com/apache/incubator-dubbo/issues/1656 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch
ralf0131 commented on issue #1656: [Release] Sync 2.6.2-SNAPSHOT to master branch URL: https://github.com/apache/incubator-dubbo/issues/1656#issuecomment-389113364 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss
ralf0131 commented on issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss URL: https://github.com/apache/incubator-dubbo/issues/1660#issuecomment-389113198 Please try the latest version 2.6.1, if you still have the problem, please re-open this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss
ralf0131 closed issue #1660: dubbo2.5.11 in your incubator-dubbo-spring-boot-project-0.2.0 miss URL: https://github.com/apache/incubator-dubbo/issues/1660 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #60: 有几个pom少依赖
ralf0131 commented on issue #60: 有几个pom少依赖 URL: https://github.com/apache/incubator-dubbo/issues/60#issuecomment-389123400 This is a legacy issue, which should be fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #60: 有几个pom少依赖
ralf0131 closed issue #60: 有几个pom少依赖 URL: https://github.com/apache/incubator-dubbo/issues/60 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖
ralf0131 closed issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖 URL: https://github.com/apache/incubator-dubbo/issues/72 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code
ralf0131 commented on issue #11: dubbo.apache.org does not reflect the latest code URL: https://github.com/apache/incubator-dubbo-website/issues/11#issuecomment-389103983 It has been fixed by manual sync via selfserve. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1?
ralf0131 commented on issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1? URL: https://github.com/apache/incubator-dubbo/issues/1752#issuecomment-389109898 duplicated to #1524 #1466 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1723: dubbo demo start failure
ralf0131 closed issue #1723: dubbo demo start failure URL: https://github.com/apache/incubator-dubbo/issues/1723 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1625: typo in architecture graph
ralf0131 commented on issue #1625: typo in architecture graph URL: https://github.com/apache/incubator-dubbo/issues/1625#issuecomment-389117360 This issue has been tracked in https://github.com/apache/incubator-dubbo-docs/issues/24 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖
ralf0131 commented on issue #72: dubbo-rpc-thrift 少了 commons-lang 的pom依赖 URL: https://github.com/apache/incubator-dubbo/issues/72#issuecomment-389123724 It should be fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1753: 升级到2.6.1版本后，是默认使用curator连接吗？
ralf0131 commented on issue #1753: 升级到2.6.1版本后，是默认使用curator连接吗？ URL: https://github.com/apache/incubator-dubbo/issues/1753#issuecomment-389110563 Are you still getting this error? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1638: [Codecov configuration] PR failing if test coverage went down
ralf0131 commented on issue #1638: [Codecov configuration] PR failing if test coverage went down URL: https://github.com/apache/incubator-dubbo/issues/1638#issuecomment-389113588 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty.
ralf0131 commented on issue #1447: NettyHelper in netty extension populated Logger "InternalLogger" in netty. URL: https://github.com/apache/incubator-dubbo/issues/1447#issuecomment-389121798 @beiwei30 Can this issue be closed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] wuwen5 commented on issue #118: 消费者端能支持node吗？
wuwen5 commented on issue #118: 消费者端能支持node吗？ URL: https://github.com/apache/incubator-dubbo/issues/118#issuecomment-94113064 jsonrpc https://github.com/apache/incubator-dubbo-rpc-jsonrpc node-client https://github.com/QianmiOpen/dubbo-node-client python-client https://github.com/dubbo/dubbo-client-py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误
EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742#issuecomment-389154679 @liangyuanpeng @lingfengsan 好尴尬，已删除评论，thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1?
ralf0131 closed issue #1752: Why is the implementation-version in Dubbo 2.5.10 is 2.0.1? URL: https://github.com/apache/incubator-dubbo/issues/1752 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1492: 2.5.7 之后，dubbo增加了qos-server，然后打印日志出来的版本号是 2.0.1
ralf0131 commented on issue #1492: 2.5.7 之后，dubbo增加了qos-server，然后打印日志出来的版本号是 2.0.1 URL: https://github.com/apache/incubator-dubbo/issues/1492#issuecomment-389121211 Can you check whether it is duplicate of #1524 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 opened a new pull request #1805: make unit test stable
beiwei30 opened a new pull request #1805: make unit test stable URL: https://github.com/apache/incubator-dubbo/pull/1805 ## What is the purpose of the change make thread-pool unit test stable ## Brief changelog ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/alibaba/dubbo/tree/master/dubbo-test). - [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1805: make unit test stable
beiwei30 closed pull request #1805: make unit test stable
URL: https://github.com/apache/incubator-dubbo/pull/1805
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
index 63c7c93b74..083af0f263 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
@@ -66,7 +66,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
index a7f240896d..8d3e939601 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
index faefe6f4d5..9d285f6511 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
index b99ce6c8cc..d58da069b4 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/limited/LimitedThreadPoolTest.java
@@ -65,7 +65,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #1624: [Design bug] unreasonable design for register dubbo service
ralf0131 commented on issue #1624: [Design bug] unreasonable design for register dubbo service URL: https://github.com/apache/incubator-dubbo/issues/1624#issuecomment-389118087 Hello, it looks like you have already fix this issue, would you mind send a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 closed issue #123: linux 运行dubbo-provider-assembly 脚本启动出错
ralf0131 closed issue #123: linux 运行dubbo-provider-assembly 脚本启动出错 URL: https://github.com/apache/incubator-dubbo/issues/123 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] ralf0131 commented on issue #123: linux 运行dubbo-provider-assembly 脚本启动出错
ralf0131 commented on issue #123: linux 运行dubbo-provider-assembly 脚本启动出错 URL: https://github.com/apache/incubator-dubbo/issues/123#issuecomment-389124696 Please check your machine's physical memory. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] beiwei30 closed pull request #1804: issue#1682: Enhance the test coverage part-4 : dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils) modules
beiwei30 closed pull request #1804: issue#1682: Enhance the test coverage
part-4 :
dubbo-common/src/main/java/com/alibaba/dubbo/common/status(store|threadpoolutils)
modules
URL: https://github.com/apache/incubator-dubbo/pull/1804
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
index 72a242f9bc..040c43d3bb 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/Assert.java
@@ -28,9 +28,9 @@ public static void notNull(Object obj, String message) {
}
}
-public static void notNull(Object obj, RuntimeException exeception) {
+public static void notNull(Object obj, RuntimeException exception) {
if (obj == null) {
-throw exeception;
+throw exception;
}
}
diff --git
a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
index f6ac8d3bb1..ce9425639d 100644
--- a/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
+++ b/dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ClassHelper.java
@@ -20,7 +20,6 @@
import java.util.Arrays;
import java.util.HashMap;
import java.util.HashSet;
-import java.util.Iterator;
import java.util.Map;
import java.util.Set;
@@ -57,12 +56,11 @@
Set primitiveTypeNames = new HashSet(16);
primitiveTypeNames.addAll(primitiveWrapperTypeMap.values());
-primitiveTypeNames.addAll(Arrays
-.asList(new Class[]{boolean[].class, byte[].class,
char[].class, double[].class,
-float[].class, int[].class, long[].class,
short[].class}));
-for (Iterator it = primitiveTypeNames.iterator();
it.hasNext(); ) {
-Class primitiveClass = (Class) it.next();
-primitiveTypeNameMap.put(primitiveClass.getName(), primitiveClass);
+primitiveTypeNames.addAll(Arrays.asList(
+boolean[].class, byte[].class, char[].class, double[].class,
float[].class, int[].class,
+long[].class, short[].class));
+for (Class primitiveTypeName : primitiveTypeNames) {
+primitiveTypeNameMap.put((primitiveTypeName).getName(),
primitiveTypeName);
}
}
@@ -193,7 +191,7 @@ public static ClassLoader getClassLoader() {
// SHOULD sit in a package, so a length check is worthwhile.
if (name != null && name.length() <= 8) {
// Could be a primitive - likely.
-result = (Class) primitiveTypeNameMap.get(name);
+result = primitiveTypeNameMap.get(name);
}
return result;
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
index 63c7c93b74..083af0f263 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/cached/CachedThreadPoolTest.java
@@ -66,7 +66,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
index a7f240896d..8d3e939601 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/eager/EagerThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
}
});
-latch.await(5000, TimeUnit.MICROSECONDS);
+latch.await();
assertThat(latch.getCount(), is(0L));
}
diff --git
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
index faefe6f4d5..9d285f6511 100644
---
a/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
+++
b/dubbo-common/src/test/java/com/alibaba/dubbo/common/threadpool/support/fixed/FixedThreadPoolTest.java
@@ -67,7 +67,7 @@ public void run() {
[GitHub] EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误
EdwardLee03 commented on issue #1742: Dubbo2..6.1报线程池已满错误 URL: https://github.com/apache/incubator-dubbo/issues/1742#issuecomment-386869200 @qq282485068 线程池满了，正常行为哦。看看服务提供方是否需要扩容，还是提供者处理慢引起 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] vangoleo commented on issue #1431: here is a StackOverflow bug? dubbo version 2.5.9, FailsafeLogger.appendContextMessage() > NetUtils.getLocalAddress()
vangoleo commented on issue #1431: here is a StackOverflow bug? dubbo version 2.5.9, FailsafeLogger.appendContextMessage() > NetUtils.getLocalAddress() URL: https://github.com/apache/incubator-dubbo/issues/1431#issuecomment-389487358 It's a bug. when NetUtils.getLocalHost() raise an exception, the invoke chain will go to an endless loop: NetUtils.getLocalHost() -> FailsafeLogger.appendContextMessage() -> NetUtils.getLocalHost() @kimmking there are some conflict in your PR #1435. Could you please update the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
