[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-28 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-28 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-28 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo-samples] plusmancn opened a new pull request #361: [NPE] Fix the reference of demoService is null

2021-08-28 Thread GitBox
plusmancn opened a new pull request #361: URL: https://github.com/apache/dubbo-samples/pull/361 According to author's original purpose, the `fallbackMethod` is triggered by remote RpcException but not NPE of `demoService`. ```java @HystrixCommand(fallbackMethod = "reliable")

[GitHub] [dubbo-samples] plusmancn commented on pull request #361: [NPE] Fix the reference of demoService is null

2021-08-28 Thread GitBox
plusmancn commented on pull request #361: URL: https://github.com/apache/dubbo-samples/pull/361#issuecomment-907648822 @xiaoheng1 @AlbumenJ Need help with workflows approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

2021-08-28 Thread GitBox
zrlw edited a comment on issue #8581: URL: https://github.com/apache/dubbo/issues/8581#issuecomment-904368301 ``` String ignoredInterfaces = "Intel(R) wireless XXX"; System.setProperty(DUBBO_NETWORK_IGNORED_INTERFACE,ignoredInterfaces); ``` 详细可参考NetUtilsTest.java测试类里的testIgnoreGi

[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1419: Ftr: add config enhance logger

2021-08-28 Thread GitBox
zhaoyunxing92 commented on a change in pull request #1419: URL: https://github.com/apache/dubbo-go/pull/1419#discussion_r697883325 ## File path: config/testdata/config/logger/log.yml ## @@ -0,0 +1,36 @@ +dubbo: + registries: +nacos: + timeout: 5s + group: dev +

[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #242: Pixiu Config

2021-08-28 Thread GitBox
AlexStocks merged pull request #242: URL: https://github.com/apache/dubbo-go-pixiu/pull/242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [dubbo-go-pixiu] AlexStocks opened a new pull request #243: Improvement: onAir -> Enable

2021-08-28 Thread GitBox
AlexStocks opened a new pull request #243: URL: https://github.com/apache/dubbo-go-pixiu/pull/243 **What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: OnAir 一词无法望文生义,现在直接改造成 Enable。 ``` -- This is

[GitHub] [dubbo] wangchengming666 commented on pull request #8629: fix #8581

2021-08-28 Thread GitBox
wangchengming666 commented on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907733566 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [dubbo] wangchengming666 removed a comment on pull request #8629: fix #8581

2021-08-28 Thread GitBox
wangchengming666 removed a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907733566 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8612: [3.0.X] fix issue #8611, use HTTPS

2021-08-28 Thread GitBox
codecov-commenter edited a comment on pull request #8612: URL: https://github.com/apache/dubbo/pull/8612#issuecomment-906516740 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] wangchengming666 closed pull request #8613: [2.7.x] fix issue #8611, use HTTPS

2021-08-28 Thread GitBox
wangchengming666 closed pull request #8613: URL: https://github.com/apache/dubbo/pull/8613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [dubbo] wangchengming666 closed pull request #8612: [3.0.X] fix issue #8611, use HTTPS

2021-08-28 Thread GitBox
wangchengming666 closed pull request #8612: URL: https://github.com/apache/dubbo/pull/8612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notific

[GitHub] [dubbo-go] Mulavar commented on issue #1415: 自定义log

2021-08-28 Thread GitBox
Mulavar commented on issue #1415: URL: https://github.com/apache/dubbo-go/issues/1415#issuecomment-907737455 你这边目前在用 dubbo-go 哪个版本,目前3.0这边在做配置优化,优化过程会把这边的错误信息直接去掉,如果是1.5,我们这边针对性修一下吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [dubbo] wangchengming666 opened a new pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-28 Thread GitBox
wangchengming666 opened a new pull request #8630: URL: https://github.com/apache/dubbo/pull/8630 issue no #8611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [dubbo] caoyuan1 opened a new issue #8631: ZookeeperDynamicConfiguration#ZookeeperDynamicConfiguration(URL url, ZookeeperTransporter zookeeperTransporter)

2021-08-28 Thread GitBox
caoyuan1 opened a new issue #8631: URL: https://github.com/apache/dubbo/issues/8631 - [ ] I have searched the [issues](https://github.com/apache/dubbo/issues) of this repository and believe that this is not a duplicate. - [ ] I have checked the [FAQ](https://github.com/apache/dubbo/blob

[GitHub] [dubbo] wangchengming666 opened a new pull request #8632: on branch 2.7.x, fix issue #8611, use HTTPS

2021-08-28 Thread GitBox
wangchengming666 opened a new pull request #8632: URL: https://github.com/apache/dubbo/pull/8632 issue no #8611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [dubbo] plusmancn opened a new issue #8633: [CodeReview 3.0] Dubbo in spring

2021-08-28 Thread GitBox
plusmancn opened a new issue #8633: URL: https://github.com/apache/dubbo/issues/8633 ### 1) DubboConfigConfigurationRegistrar duplicate with DubboComponentScanRegistrar. DubboConfigConfigurationRegistrar only has one function call: ```java public void registerBeanDefinitions(Annota

[GitHub] [dubbo] codecov-commenter commented on pull request #8632: on branch 2.7.x, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #8632: URL: https://github.com/apache/dubbo/pull/8632#issuecomment-907741118 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [dubbo] codecov-commenter commented on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8632: on branch 2.7.x, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8632: URL: https://github.com/apache/dubbo/pull/8632#issuecomment-907741118 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8632: on branch 2.7.x, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8632: URL: https://github.com/apache/dubbo/pull/8632#issuecomment-907741118 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8632: on branch 2.7.x, fix issue #8611, use HTTPS

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8632: URL: https://github.com/apache/dubbo/pull/8632#issuecomment-907741118 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8632?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8600: Adjust the scope of the spi extension

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8600: URL: https://github.com/apache/dubbo/pull/8600#issuecomment-906075229 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8600: Adjust the scope of the spi extension

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8600: URL: https://github.com/apache/dubbo/pull/8600#issuecomment-906075229 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo-go] cjphaha commented on pull request #1419: Ftr: add config enhance logger

2021-08-29 Thread GitBox
cjphaha commented on pull request #1419: URL: https://github.com/apache/dubbo-go/pull/1419#issuecomment-90771 @zhaoyunxing92 谢谢 review,新的 commit 修复了上面的问题 * 统一使用 ;-' 来替代 '_' * 移除 common/logger 里面的单测 * 移除 yaml 中的双引号 -- This is an automated message from the Apache Git Serv

[GitHub] [dubbo-go-pixiu] mark4z closed issue #172: Make filter configurable

2021-08-29 Thread GitBox
mark4z closed issue #172: URL: https://github.com/apache/dubbo-go-pixiu/issues/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

[GitHub] [dubbo-go-pixiu] mark4z commented on issue #172: Make filter configurable

2021-08-29 Thread GitBox
mark4z commented on issue #172: URL: https://github.com/apache/dubbo-go-pixiu/issues/172#issuecomment-907745478 close via #242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8600: Adjust the scope of the spi extension

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8600: URL: https://github.com/apache/dubbo/pull/8600#issuecomment-906075229 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8600?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #243: Improvement: onAir -> Enable

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #243: URL: https://github.com/apache/dubbo-go-pixiu/pull/243#issuecomment-907754158 # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #243: Improvement: onAir -> Enable

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #243: URL: https://github.com/apache/dubbo-go-pixiu/pull/243#issuecomment-907754158 # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&ut

[GitHub] [dubbo] hylyLLL opened a new issue #8634: dubbo2.84版本

2021-08-29 Thread GitBox
hylyLLL opened a new issue #8634: URL: https://github.com/apache/dubbo/issues/8634 IOrderService与IGoodServicee形成循环依赖,dubbo在生成对象时 ![image](https://user-images.githubusercontent.com/46893979/131244779-50e1caa4-2cf7-4668-83dc-f55689f03744.png) ![image](https://user-images.githubusercont

[GitHub] [dubbo] zrlw commented on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

2021-08-29 Thread GitBox
zrlw commented on issue #8581: URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372 debug测试发现网卡名包含某些元字符时,matches直接抛异常,需要做一下捕获处理。 顺便修订了一下原来测试案例的一处手误(匹配所有应该用```.*```,不能省略```.```字符),新增了一个网卡名称包含常见元字符的测试案例。 -- This is an automated message from the Apache Git Service. To r

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

2021-08-29 Thread GitBox
zrlw edited a comment on issue #8581: URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372 debug测试发现网卡名包含某些元字符时,matches直接抛异常,需要做一下捕获处理。 新提交的PR内容里顺便修订了一下原来测试案例的一处手误(匹配所有应该用```.*```,不能省略```.```字符),新增了一个网卡名称包含常见元字符的测试案例。 -- This is an automated message from the Apache

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] shanuo0312 closed pull request #8525: service discovery registry process test

2021-08-29 Thread GitBox
shanuo0312 closed pull request #8525: URL: https://github.com/apache/dubbo/pull/8525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [dubbo] shanuo0312 opened a new pull request #8635: service discovery registry protocol unit test

2021-08-29 Thread GitBox
shanuo0312 opened a new pull request #8635: URL: https://github.com/apache/dubbo/pull/8635 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.c

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter commented on pull request #8635: service discovery registry protocol unit test

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #8635: URL: https://github.com/apache/dubbo/pull/8635#issuecomment-907821216 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8635: service discovery registry protocol unit test

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8635: URL: https://github.com/apache/dubbo/pull/8635#issuecomment-907821216 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8635: service discovery registry protocol unit test

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8635: URL: https://github.com/apache/dubbo/pull/8635#issuecomment-907821216 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8635?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] zrlw commented on pull request #8629: fix #8581

2021-08-29 Thread GitBox
zrlw commented on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907824811 @wangchengming666 pls review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

2021-08-29 Thread GitBox
zrlw edited a comment on issue #8581: URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372 debug测试发现忽略的网卡名包含某些元字符时,matches直接抛异常,需要做一下捕获处理。 新提交的PR内容里顺便修订了一下原来测试案例的一处手误(匹配所有应该用```.*```,不能省略```.```字符),新增了一个网卡名称包含常见元字符的测试案例。 -- This is an automated message from the Apac

[GitHub] [dubbo] zrlw edited a comment on issue #8581: [2.7.13] org.apache.dubbo.common.utils.NetUtils的ignoreNetworkInterface方法处理不了网卡名包含圆括号的环境

2021-08-29 Thread GitBox
zrlw edited a comment on issue #8581: URL: https://github.com/apache/dubbo/issues/8581#issuecomment-907761372 debug测试发现忽略的网卡名包含某些元字符时,matches直接抛异常,需要做一下捕获处理。 新提交的PR内容里顺便修订了一下原来测试案例的一处手误(匹配所有应该用```.*```,不能省略```.```字符),新增了一个忽略网卡名称包含常见元字符的测试案例。 -- This is an automated message from the Ap

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8629: fix #8581

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8629: URL: https://github.com/apache/dubbo/pull/8629#issuecomment-907613917 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo-js] chenShengYa opened a new issue #252: 请问交流群还能加么,二维码过期了

2021-08-29 Thread GitBox
chenShengYa opened a new issue #252: URL: https://github.com/apache/dubbo-js/issues/252 没有找到其他方式去加入了,目前遇到一些问题无法解决- - -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [dubbo] guohao merged pull request #8585: Add Header Filter for Triple Protocol

2021-08-29 Thread GitBox
guohao merged pull request #8585: URL: https://github.com/apache/dubbo/pull/8585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [dubbo] guohao merged pull request #8608: [3.0-Triple]Support triple void response

2021-08-29 Thread GitBox
guohao merged pull request #8608: URL: https://github.com/apache/dubbo/pull/8608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [dubbo] guohao merged pull request #8615: [3.0-Triple] Fix error in filters can not be returned to client

2021-08-29 Thread GitBox
guohao merged pull request #8615: URL: https://github.com/apache/dubbo/pull/8615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [dubbo] BurningCN opened a new pull request #8636: Resource clean before destroy or stop

2021-08-29 Thread GitBox
BurningCN opened a new pull request #8636: URL: https://github.com/apache/dubbo/pull/8636 ## What is the purpose of the change Resource clean before destroy or stop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [dubbo] codecov-commenter commented on pull request #8636: Resource clean before destroy or stop

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #8636: URL: https://github.com/apache/dubbo/pull/8636#issuecomment-907985446 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8636?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [dubbo] wangxiang93 commented on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
wangxiang93 commented on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-907992456 > @wangxiang93 It may be helpful for you See: https://www.yuque.com/plusman/zaq57o/qhg0d1 sorry,I thinks this way not workes well for my reuest; 我的核心诉求是这样的 我们系统有A、

[GitHub] [dubbo] guohao opened a new pull request #8637: [3.0-Triple] Remove operation handler

2021-08-29 Thread GitBox
guohao opened a new pull request #8637: URL: https://github.com/apache/dubbo/pull/8637 ## What is the purpose of the change Remove unused OpertionHandler ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a [GitH

[GitHub] [dubbo] plusmancn commented on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn commented on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。 我理解下来,你只需要在 B 模块配置多注册中心支持,是可能解决你的问题的。 -- This is an automated message from the Apache Git Service. To

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。 我理解下来,你只需要在 B 模块配置多注册中心支持,是可以解决你的问题的。 -- This is an automated message from the Apache Git Service. To

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。 我理解下来,你只需要在 B 模块配置多注册中心支持,是可以解决你的问题的。 如果有可能话,建议使用 2.7.x 最新版本,可能是因为历史遗留 BUG 导致的问题。 -- This is an

[GitHub] [dubbo-go] tonyjt commented on issue #1415: 自定义log

2021-08-29 Thread GitBox
tonyjt commented on issue #1415: URL: https://github.com/apache/dubbo-go/issues/1415#issuecomment-908051456 3.0的,非常感谢! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。如果有可能话,建议使用 2.7.x 最新版本,可能是因为历史遗留 BUG 导致的问题。 我理解下来,你只需要在 B 模块配置多注册中心支持,是可以解决你的问题的,假如部署架构如下: ```shel

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。如果有可能话,建议使用 2.7.x 最新版本,可能是因为历史遗留 BUG 导致的问题。 我理解下来,你只需要在 B 模块配置多注册中心支持,是可以解决你的问题的,假如部署架构如下: ```shel

[GitHub] [dubbo] plusmancn edited a comment on issue #8603: 2.7.6.dubbo在指定的注册中心消费或者提供服务

2021-08-29 Thread GitBox
plusmancn edited a comment on issue #8603: URL: https://github.com/apache/dubbo/issues/8603#issuecomment-908047161 > 更严重的是我要调D的zk的zk服务 @wangxiang93 请问这怎么理解?方便的话,可以画个简单的用例图。如果有可能话,建议使用 2.7.x 最新版本,可能是因为历史遗留 BUG 导致的问题。 我理解下来,你只需要在 B 模块配置多注册中心支持,是可以解决你的问题的,假如你的部署架构如下: ```sh

[GitHub] [dubbo] RuoBingCoder commented on issue #8634: dubbo2.84版本 aop代理无效

2021-08-29 Thread GitBox
RuoBingCoder commented on issue #8634: URL: https://github.com/apache/dubbo/issues/8634#issuecomment-908066345 你能描述清楚你的问题吗?我的理解是例如:你的两个service加了事务spring对这两个接口生成代理,而Dubbo的注入是通过对ServiceBean构造器注入接口实例,这是spring所管理的就算循环依赖也都会注入proxy!你看看你的哪块配置出了问题! -- This is an automated message from the Apache

[GitHub] [dubbo] RuoBingCoder removed a comment on issue #8634: dubbo2.84版本 aop代理无效

2021-08-29 Thread GitBox
RuoBingCoder removed a comment on issue #8634: URL: https://github.com/apache/dubbo/issues/8634#issuecomment-908066345 你能描述清楚你的问题吗?我的理解是例如:你的两个service加了事务spring对这两个接口生成代理,而Dubbo的注入是通过对ServiceBean构造器注入接口实例,这是spring所管理的就算循环依赖也都会注入proxy!你看看你的哪块配置出了问题! -- This is an automated message from th

[GitHub] [dubbo] houseyoung opened a new issue #8638: URL.equals抛出npe

2021-08-29 Thread GitBox
houseyoung opened a new issue #8638: URL: https://github.com/apache/dubbo/issues/8638 使用dubbo 2.7.13作为客户端时(2.7.10、2.7.12也都试过),reference注册时报出如下异常: Failed to notify addresses for subscribe consumer://172.20.9.10/XX?application=Y&category=providers,configurators,routers&check=fa

[GitHub] [dubbo] codecov-commenter commented on pull request #8637: [3.0-Triple] Remove operation handler

2021-08-29 Thread GitBox
codecov-commenter commented on pull request #8637: URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8637: [3.0-Triple] Remove operation handler

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8637: URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8637: [3.0-Triple] Remove operation handler

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8637: URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8637: [3.0-Triple] Remove operation handler

2021-08-29 Thread GitBox
codecov-commenter edited a comment on pull request #8637: URL: https://github.com/apache/dubbo/pull/8637#issuecomment-908072232 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] abel533 commented on issue #8604: 本地调试超时导致forbiden设置

2021-08-30 Thread GitBox
abel533 commented on issue #8604: URL: https://github.com/apache/dubbo/issues/8604#issuecomment-908084754 补充,发现问题在 nacos 30秒的定时任务 ``` "Nacos-Watch-Task-Scheduler-1" Id=95 TIMED_WAITING on io.netty.bootstrap.AbstractBootstrap$PendingRegistrationPromise@e6c8d28 at java.base@1

[GitHub] [dubbo] hylyLLL commented on issue #8634: dubbo2.84版本 aop代理无效

2021-08-30 Thread GitBox
hylyLLL commented on issue #8634: URL: https://github.com/apache/dubbo/issues/8634#issuecomment-908089748 ***@***.***注解去解决,也不行 -- 原始邮件 -- 发件人:

[GitHub] [dubbo] abel533 closed issue #8604: 本地调试超时导致forbiden设置

2021-08-30 Thread GitBox
abel533 closed issue #8604: URL: https://github.com/apache/dubbo/issues/8604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-30 Thread GitBox
codecov-commenter edited a comment on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-30 Thread GitBox
codecov-commenter edited a comment on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8630: on branch 3.0, fix issue #8611, use HTTPS

2021-08-30 Thread GitBox
codecov-commenter edited a comment on pull request #8630: URL: https://github.com/apache/dubbo/pull/8630#issuecomment-907741257 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8630?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo-go] tonyjt opened a new issue #1420: panic: proxy factory for default is not existing

2021-08-30 Thread GitBox
tonyjt opened a new issue #1420: URL: https://github.com/apache/dubbo-go/issues/1420 ` package main import ( "context" "dubbo.apache.org/dubbo-go/v3/config" hessian "github.com/apache/dubbo-go-hessian2" gxlog "github.com/dubbogo/gost/log"

[GitHub] [dubbo-go] tonyjt commented on issue #1420: panic: proxy factory for default is not existing

2021-08-30 Thread GitBox
tonyjt commented on issue #1420: URL: https://github.com/apache/dubbo-go/issues/1420#issuecomment-908131579 dubbo-go版本:v3.0.0-rc2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [dubbo-go] LaurenceLiZhixin opened a new pull request #1421: fix: pb stub function bug

2021-08-30 Thread GitBox
LaurenceLiZhixin opened a new pull request #1421: URL: https://github.com/apache/dubbo-go/pull/1421 **What this PR does**: **Which issue(s) this PR fixes**: Fixes # **Special notes for your reviewer**: **Does this PR introduce a user-facing change?**:

[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1421: fix: pb stub function bug

2021-08-30 Thread GitBox
LaurenceLiZhixin commented on pull request #1421: URL: https://github.com/apache/dubbo-go/pull/1421#issuecomment-908165402 I would ignore the ci failed message for this hsf-go-dependency branch, as the old api of 1.5 is deprecated. -- This is an automated message from the Apache Git Serv

[GitHub] [dubbo-go] LaurenceLiZhixin merged pull request #1421: fix: pb stub function bug

2021-08-30 Thread GitBox
LaurenceLiZhixin merged pull request #1421: URL: https://github.com/apache/dubbo-go/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: noti

[GitHub] [dubbo-samples] xiaoheng1 commented on pull request #361: [NPE] Fix the reference of demoService is null

2021-08-30 Thread GitBox
xiaoheng1 commented on pull request #361: URL: https://github.com/apache/dubbo-samples/pull/361#issuecomment-908174175 > @xiaoheng1 @AlbumenJ Need help with workflows approval. workflows triggered -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [dubbo] codecov-commenter commented on pull request #8607: add test case for service discovery process

2021-08-30 Thread GitBox
codecov-commenter commented on pull request #8607: URL: https://github.com/apache/dubbo/pull/8607#issuecomment-908238633 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8607?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8607: add test case for service discovery process

2021-08-30 Thread GitBox
codecov-commenter edited a comment on pull request #8607: URL: https://github.com/apache/dubbo/pull/8607#issuecomment-908238633 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8607?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #243: Improvement: onAir -> Enable

2021-08-30 Thread GitBox
codecov-commenter edited a comment on pull request #243: URL: https://github.com/apache/dubbo-go-pixiu/pull/243#issuecomment-907754158 # [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8607: add test case for service discovery process

2021-08-30 Thread GitBox
codecov-commenter edited a comment on pull request #8607: URL: https://github.com/apache/dubbo/pull/8607#issuecomment-908238633 # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8607?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

<    3   4   5   6   7   8   9   10   11   12   >