jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-351151776
@jwonders I've been looking at your suggestions and had a question. I'm
still unclear as to what AsynCommitResult's purpose is
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-350618251
@keith-turner The indirection worked, just pushed the fix.
Th
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-350272582
Gotcha, when I first came across those pages I misinterpreted them as saying
there was a bug in CompletableFutures not Maven.
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-350170664
@keith-turner I went back to try again and keep running into the same error.
```
[INFO] --- findbugs-maven-plugin:3.0.5:c
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349853418
So I was able to change AsyncConditionalWriter and OracleClient to use
CompletableFutures and changed the TransactionImpl call
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349853418
So I was able to change AsyncConditionalWriter and OracleClient to use
CompletableFutures and changed the TransactionImpl call
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349787927
@jwonders @keith-turner I think I'd prefer to first do a direct conversion
to CompletableFutures, that way I can get a better
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349787927
@jwonders @keith-turner I think I'd prefer to first do a direct conversion
to CompletableFutures, that way I can get a better
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349787927
@jwonders @keith-turner I think I'd prefer to first do a direct conversion
to CompletableFutures, that way I can get a better
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
**Edit:** I changed this around since I first posted this.
OracleClient and SharedBatchWriter seem to only use and deal
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
**Edit:** I changed this around since I first posted this.
OracleClient and SharedBatchWriter seem to only use and deal
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
**Edit** : after thinking about this some more and doing some more
investigation, this is wrong. Ignore this while I do some m
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349184990
Did some analysis of where ListenableFuture is used and here's what I found:
Classes that use ListenableFuture:
- ...
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349184990
Did some analysis of where ListenableFuture is used and here's what I found:
Classes that use ListenableFuture:
\t...
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349184990
Did some analysis of where ListenableFuture is used and here's what I found:
Classes that use ListenableFuture:
...
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349510196
OracleClient and SharedBatchWriter seem to only use and deal with
ListenableFutureTask. The only method they seem to call is `
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349487794
What if we had an interface like this (name needs some serious improvement)
```
private static interface OnSuccessInterfa
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349487794
What if we had an interface like this (name needs some serious improvement)
```
private static interface OnSuccessInterfa
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349487794
What if we had an interface like this (name needs some serious improvement)
```
private static interface OnSuccessInterfa
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349487794
What if we had an interface like this (name needs some serious improvement)
```private static interface OnSuccessInterface {
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349487794
What if we had an interface like this (name needs some serious improvement)
`private static interface OnSuccessInterface {
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349398314
Ok so in general the functions of TransactionImpl that use ListenableFutures
are of the following form
...
```
Listen
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349398314
Ok so in general the functions of TransactionImpl that use ListenableFutures
are of the following form
...
```
Listen
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349398314
Ok so in general the functions of TransactionImpl that use ListenableFutures
are of the following form
...
```
Listen
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349398314
Ok so in general the functions of TransactionImpl that use ListenableFutures
are of the following form
...
```
Listen
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349184990
Did some analysis of where ListenableFuture is used and here's what I found:
Classes that use ListenableFuture:
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349370306
So I wanted to start with changing SharedBatchWriter.MutationBatch since
it's the most independent.
Currently it uses L
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349370306
So I wanted to start with changing SharedBatchWriter.MutationBatch since
it's the most independent.
Currently it uses L
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349370306
So I wanted to start with changing SharedBatchWriter.MutationBatch since
it's the most independent.
Currently it uses L
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349184990
Did some analysis of where ListenableFuture is used and here's what I found:
Classes that use ListenableFuture:
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349050151
Hey sorry I've had an extremely hectic week and haven't been able to look at
this yet. I'm going to start on this tonight. Unl
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-349050151
Hey sorry I've had an extremely hectic week and haven't been able to look at
this yet. I'm going to start on this tonight. Unl
jkosh44 commented on issue #722: Move from Guava ListenableFuture to Java 8
CompletableFuture
URL: https://github.com/apache/fluo/issues/722#issuecomment-347378967
Since I just got some experience using CompletableFutures I'd like to give
this a shot.
-
40 matches
Mail list logo
