[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351572833 @keith-turner I've been trying to think of a way to synthesize @jwonders idea of an AysncCommitResult and your idea of having

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351581495 I was going to try and see how this worked in actual code and I noticed that this would not cover the case where we commit and

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351564607 Just wanted to also copy some relevant comments from #722 by @jwonders, to avoid having to flip back and forth. >Assuming

[GitHub] jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic

jkosh44 commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351573940 `AsyncCommitResult` would look like ``` public class AsyncCommitResult { private CommitData cd; private

[GitHub] ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic

ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458579 @keith-turner that Gist isn't public. This is an automated

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458277 I created a [Gist](https://gist.github.com/keith-turner/387dc83332bc330fee673be14684899) containing some local

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351460771 This is the commit code as it existed before being converted to an async process.

[GitHub] keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic

keith-turner commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458277 I created a [Gist](https://gist.github.com/keith-turner/387dc83332bc330fee673be146848994) containing some local

[GitHub] ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic

ctubbsii commented on issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978#issuecomment-351458579 @keith-turner that Gist isn't public. This is an automated

[GitHub] keith-turner opened a new issue #978: Use CompleteableFuture compose to centralize commit logic

keith-turner opened a new issue #978: Use CompleteableFuture compose to centralize commit logic URL: https://github.com/apache/fluo/issues/978 Opening this issue for follow on work identified in the comments of #975 and #722.