ctubbsii commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial
implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145805466
##
File path: src/main/java/org/apache/bytes/Bytes.java
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Apache
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145786386
##
File path: src/main/java/org/apache/bytes/Bytes.java
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Ap
kpm1985 commented on issue #943: FLUO-942 The constructor for VisibilityCache
now uses the values from?
URL: https://github.com/apache/fluo/pull/943#issuecomment-337990736
@keith-turner I have fixed my git config --global user.name and user.email.
Thank you very much for the heads up. Taki
kpm1985 commented on issue #943: FLUO-942 The constructor for VisibilityCache
now uses the values from?
URL: https://github.com/apache/fluo/pull/943#issuecomment-337990736
@keith-turner I have fixed my git config --global user.name and user.email.
Thank you very much for the heads up. Taki
keith-turner closed issue #944: Refactor Bytes - Remove duplicate call to
expensive function whos ret val is ignored
URL: https://github.com/apache/fluo/issues/944
This is an automated message from the Apache Git Service.
To
keith-turner commented on issue #944: Refactor Bytes - Remove duplicate call to
expensive function whos ret val is ignored
URL: https://github.com/apache/fluo/issues/944#issuecomment-337966959
Fixed by 5180acb943c55726fd4e223e6fe63026b78221c7
---
keith-turner commented on issue #945: Remove redundant call whos value is not
used anyways
URL: https://github.com/apache/fluo/pull/945#issuecomment-337966546
The other thing I mentioned is that when looking at
[commits](https://github.com/apache/fluo/commits/master), your recent commits
asfgit closed pull request #945: Remove redundant call whos value is not used
anyways
URL: https://github.com/apache/fluo/pull/945
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fore
kpm1985 commented on issue #945: Remove redundant call whos value is not used
anyways
URL: https://github.com/apache/fluo/pull/945#issuecomment-337961954
It's all good go ahead and push the remote changes I'm fine with that email
address being listed I'll fix it in the future don't want
keith-turner commented on issue #945: Remove redundant call whos value is not
used anyways
URL: https://github.com/apache/fluo/pull/945#issuecomment-337961059
@kpm1985 using a different email addresses is not a problem. I just want
to ensure you are happy w/ the one in the commit. Once
kpm1985 commented on issue #945: Remove redundant call whos value is not used
anyways
URL: https://github.com/apache/fluo/pull/945#issuecomment-337954691
@keith-turner
I'm not sure what I've screwed up but I'm off to class in a few minutes and
don't want to hold you up while I'm g
ctubbsii commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial
implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145741192
##
File path: src/main/java/org/apache/bytes/ByteSequence.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the
ctubbsii commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial
implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145740710
##
File path: src/main/java/org/apache/bytes/Bytes.java
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Apache
ctubbsii commented on a change in pull request #5: [WIP] DO NOT MERGE - Initial
implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145740390
##
File path: src/main/java/org/apache/bytes/Bytes.java
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Apache
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145729557
##
File path: src/main/java/org/apache/bytes/Bytes.java
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Ap
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145736121
##
File path: src/main/java/org/apache/bytes/Bytes.java
##
@@ -0,0 +1,452 @@
+/*
+ * Licensed to the Ap
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145734898
##
File path: src/main/java/org/apache/bytes/AbstractByteSequence.java
##
@@ -0,0 +1,119 @@
+/*
+ * Lic
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145737225
##
File path: src/main/java/org/apache/bytes/ByteSequence.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145733258
##
File path: src/main/java/org/apache/bytes/ByteSequence.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
keith-turner commented on a change in pull request #5: [WIP] DO NOT MERGE -
Initial implementation
URL: https://github.com/apache/fluo-bytes/pull/5#discussion_r145736738
##
File path: src/main/java/org/apache/bytes/ByteSequence.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
keith-turner commented on issue #945: Remove redundant call whos value is not
used anyways
URL: https://github.com/apache/fluo/pull/945#issuecomment-337930673
@kpm1985 I Am going to wait to merge this until after getting confirmation
about the email addr used in the commit. I asked about
keith-turner commented on issue #942: VisibilityCache constructor is out of date
URL: https://github.com/apache/fluo/issues/942#issuecomment-337930150
Good find, `TxInfoCache.CACHE_TIMEOUT_MIN` should be removed. I think it
would be good make this configurable with two new props.
---
keith-turner commented on issue #943: FLUO-942 The constructor for
VisibilityCache now uses the values from?
URL: https://github.com/apache/fluo/pull/943#issuecomment-337928416
@kpm1985 I noticed these commits are not showing your GitHub account picture
in the GitHub UI. I think this is b
keith-turner commented on issue #943: FLUO-942 The constructor for
VisibilityCache now uses the values from?
URL: https://github.com/apache/fluo/pull/943#issuecomment-337927567
Can the constant `TxInfoCache.CACHE_TIMEOUT_MIN` be removed now?
kpm1985 opened a new pull request #945: Remove redundant call whos value is not
used anyways
URL: https://github.com/apache/fluo/pull/945
This is an automated message from the Apache Git Service.
To respond to the message, p
kpm1985 opened a new issue #944: Refactor Bytes - Remove duplicate call to
expensive function whos ret val is ignored
URL: https://github.com/apache/fluo/issues/944
'''java
private int compareToUnchecked(byte[] bytes, int offset, int len) {
if (this.length == this.data.length && l
kpm1985 commented on issue #942: VisibilityCache constructor is out of date
URL: https://github.com/apache/fluo/issues/942#issuecomment-337826720
While I notice I did not earse TxInfoCache.CACHE_TIMEOUT_MIN, it is still
cleaner to use the values from FluoConfigurationImpl and the following
kpm1985 commented on issue #942: VisibilityCache constructor is out of date
URL: https://github.com/apache/fluo/issues/942#issuecomment-337826720
https://github.com/apache/fluo/pull/943
This is an automated message from the Ap
kpm1985 opened a new pull request #943: FLUO-942 The constructor for
VisibilityCache now uses the values from?
URL: https://github.com/apache/fluo/pull/943
? FluoConfigurationImpl. Also, an instantiation test has been included in
the event that properties are invalidated in the future. Thi
kpm1985 opened a new issue #942: VisibilityCache constructor is out of date
URL: https://github.com/apache/fluo/issues/942
```
private final Cache visCache;
VisibilityCache() {
visCache =
CacheBuilder.newBuilder().expireAfterAccess(TxInfoCache.CACHE_TIMEOUT_M
30 matches
Mail list logo
