[GitHub] keith-turner commented on issue #969: [WIP] Issue-967

2017-11-28 Thread GitBox
keith-turner commented on issue #969: [WIP] Issue-967 URL: https://github.com/apache/fluo/pull/969#issuecomment-347557885 > On an unrelated note, I feel like all my commits fail on the continuous-integration Travis CI build. Is there a specific reason? The builds on travis are not

[GitHub] keith-turner commented on issue #969: [WIP] Issue-967

2017-11-27 Thread GitBox
keith-turner commented on issue #969: [WIP] Issue-967 URL: https://github.com/apache/fluo/pull/969#issuecomment-347307505 @jkosh44 these changes are looking good. I am still puzzling out the async story for Fluo. Currently there are a few areas I have identified and opened issue about.

[GitHub] keith-turner commented on issue #969: [WIP] Issue-967

2017-11-20 Thread GitBox
keith-turner commented on issue #969: [WIP] Issue-967 URL: https://github.com/apache/fluo/pull/969#issuecomment-345889897 > Is it too late to follow the git upstream steps for this issue? No, you can try. If you are new to git I would recommend experimenting in another branch. Try

[GitHub] keith-turner commented on issue #969: [WIP] Issue-967

2017-11-20 Thread GitBox
keith-turner commented on issue #969: [WIP] Issue-967 URL: https://github.com/apache/fluo/pull/969#issuecomment-345737294 @jkosh44 I noticed your branch is based off an older commit. I usually add a git remote called upstream like the following. ```bash git remote add upstream