[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337762153 @keith-turner thank you, I made a few changes to the constructor On Oct 18, 2017 1:58 PM, "Keith Turner" wrote: > @kpm1985 th

[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337745507 @keith-turner Thank you, I've modified the constructor to take the new methods This is an automated me

[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337722536 @keith-turner I get what the intent was. Hopefully QED On Oct 18, 2017 12:59 PM, "Keith Turner" wrote: > *@keith-turner* commented on this pull request.

[GitHub] kpm1985 commented on issue #941: WIP: Fix for FLUO-938

2017-10-18 Thread GitBox
kpm1985 commented on issue #941: WIP: Fix for FLUO-938 URL: https://github.com/apache/fluo/pull/941#issuecomment-337706073 I changed the data type for the default property to simply be a long instead of an int. Same functionality, no more boxing or casting and can use conf.getLong().