[GitHub] keith-turner commented on issue #896: Limit connections to Zookeeper

2017-08-03 Thread git
keith-turner commented on issue #896: Limit connections to Zookeeper URL: https://github.com/apache/incubator-fluo/issues/896#issuecomment-320122722 Noticed that `CommandUtil.verifyAppInitialized()` also creates a curator. Th

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131284274 ## File path: modules/command/src/main/java/org/apache/fluo/command/FluoExec.java ###

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131282737 ## File path: modules/api/src/test/resources/application.properties ## @@ -0

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131208886 ## File path: modules/distribution/src/main/config/fluo-env.sh ## @@ -32,16 +32

[GitHub] keith-turner commented on issue #897: Add high level application lifecycle overview to docs

2017-08-03 Thread git
keith-turner commented on issue #897: Add high level application lifecycle overview to docs URL: https://github.com/apache/incubator-fluo/issues/897#issuecomment-320018766 Also need to add docs about updating whats stored in zookeeper --

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131174058 ## File path: docs/install.md ## @@ -104,101 +101,66 @@ Running the script w

[GitHub] keith-turner opened a new issue #897: Add high level application lifecycle overview to docs

2017-08-03 Thread git
keith-turner opened a new issue #897: Add high level application lifecycle overview to docs URL: https://github.com/apache/incubator-fluo/issues/897 I think application documentation needs a high level overview that helps users understand the lifecycle of an application and how the command

[GitHub] keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
keith-turner commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131148971 ## File path: modules/distribution/src/main/config/fluo-env.sh ## @@ -32,16

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131158277 ## File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131157737 ## File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131157519 ## File path: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.jav

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131157581 ## File path: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.jav

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131157442 ## File path: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.jav

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131157171 ## File path: modules/api/src/test/java/org/apache/fluo/api/config/FluoConfigurationTest

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131157047 ## File path: modules/distribution/src/main/config/fluo-env.sh ## @@ -11,11 +11

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131156804 ## File path: modules/distribution/src/main/scripts/fluo ## @@ -13,73 +13,111 @

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131156650 ## File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoClientImpl.java

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131156733 ## File path: modules/core/src/main/java/org/apache/fluo/core/impl/Environment.java ###

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131156553 ## File path: modules/command/src/main/java/org/apache/fluo/command/FluoList.java ##

[GitHub] mikewalch opened a new issue #896: Limit connections to Zookeeper

2017-08-03 Thread git
mikewalch opened a new issue #896: Limit connections to Zookeeper URL: https://github.com/apache/incubator-fluo/issues/896 The method `FluoAdminImpl.mergeZookeeperConfig` currently creates a curator to connect to Zookeeper. This method could accept a curator object and calls to it could b

[GitHub] mikewalch opened a new issue #895: Improve 'fluo list' to print number of running oracles and workers

2017-08-03 Thread git
mikewalch opened a new issue #895: Improve 'fluo list' to print number of running oracles and workers URL: https://github.com/apache/incubator-fluo/issues/895 This was brought up in review of #883 This is an automated messa

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131143595 ## File path: modules/distribution/src/main/config/fluo-app.properties ## @@ -0

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131143683 ## File path: modules/distribution/src/main/config/fluo-app.properties ## @@ -0

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131143737 ## File path: modules/distribution/src/main/config/fluo-app.properties ## @@ -0

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131142304 ## File path: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.jav

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131141976 ## File path: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.jav

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131138387 ## File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java

[GitHub] mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications

2017-08-03 Thread git
mikewalch commented on a change in pull request #883: Fixes #842 Support multiple ways for running Fluo applications URL: https://github.com/apache/incubator-fluo/pull/883#discussion_r131008113 ## File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java