[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-24 Thread keith-turner
Github user keith-turner commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r113102707 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -356,29 +357,44 @@ public static final Bytes of(String s, Charset

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800518 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c) {

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800350 --- Diff: modules/api/src/test/java/org/apache/fluo/api/data/BytesTest.java --- @@ -79,6 +79,19 @@ public void testHashSubsequence() { }

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800377 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c) {

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800248 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c) {

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread ctubbsii
Github user ctubbsii commented on a diff in the pull request: https://github.com/apache/incubator-fluo/pull/825#discussion_r112800262 --- Diff: modules/api/src/main/java/org/apache/fluo/api/data/Bytes.java --- @@ -355,6 +354,36 @@ public static final Bytes of(String s, Charset c) {

[GitHub] incubator-fluo pull request #825: fixes #823

2017-04-21 Thread cjmctague
GitHub user cjmctague opened a pull request: https://github.com/apache/incubator-fluo/pull/825 fixes #823 -added startsWith(Byte prefix) method to Bytes.java -added endsWith(Bytes suffix) method to Bytes.java -added testPrefixSuffix() method to BytesTest.java You can merge