Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
bmarwell commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783782483 > Maybe you could also just integrate the Migration tool That's exactly what I suggested. No new in packages. Maven transformers do exactly the same thing. One project, two

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
dtrunk90 commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783782143 > So, we have to decide which of the end results we want. Those are, multiple artifact with different classifier (or version), or separate freemarker.servlet and

Re: [PR] Add a simple mechanism for runtime debugging of templates. [freemarker]

2023-10-28 Thread via GitHub
chrisrueger commented on PR #89: URL: https://github.com/apache/freemarker/pull/89#issuecomment-1783775166 Great, thanks. One more question maybe on the two of you @nolaviz and @ddekany : Does this mechanism allow to also hook into processing of lambda-ish expressions

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
ddekany commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783774704 So, we have to decide which of the end results we want. Those are, multiple artifact with different classifier (or version), or separate freemarker.servlet and freemarker.jakartaservlet

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
ddekany commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783771861 Yeah, actually, there's the othe way of "duplicating", where we have freemarker:freemarker:2.3.33, and freemarker:freemarker:2.3.33-jakarta artifas. Kind of like Guava does it. Or use

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
dtrunk90 commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783769607 > From the perspective of the JVM, you end up having a `freemarker.ext.servlet` that's not changed, and a `freemarker.ext.jakartaservlet` package that's a basically a copy of the

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
ddekany commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783769414 3 is irrelevant here. Treat is as vapor ware until it produced some candidate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
ppodgorsek commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783768229 @firatkucuk As you can see in the above discussion, a few points were raised: * upgrading to Jakarta means many other things must change, (that explains why the PR is so large

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
ddekany commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783767477 From the perspective of the JVM, you end up having a `freemarker.ext.servlet` that's not changed, and a `freemarker.ext.jakartaservlet` package that's a basically a copy of the

[jira] [Updated] (FREEMARKER-222) JPMS still does not work as expected

2023-10-28 Thread Jira
[ https://issues.apache.org/jira/browse/FREEMARKER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dániel Dékány updated FREEMARKER-222: - Affects Version/s: 2.3.32 > JPMS still does not work as expected >

[jira] [Commented] (FREEMARKER-222) JPMS still does not work as expected

2023-10-28 Thread Jira
[ https://issues.apache.org/jira/browse/FREEMARKER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780605#comment-17780605 ] Dániel Dékány commented on FREEMARKER-222: -- That's because the java package name is also

[jira] [Updated] (FREEMARKER-223) JPMS: Split package

2023-10-28 Thread Jira
[ https://issues.apache.org/jira/browse/FREEMARKER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dániel Dékány updated FREEMARKER-223: - Affects Version/s: 3.0.0 > JPMS: Split package > --- > >

[jira] [Commented] (FREEMARKER-223) JPMS: Split package

2023-10-28 Thread Jira
[ https://issues.apache.org/jira/browse/FREEMARKER-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780604#comment-17780604 ] Dániel Dékány commented on FREEMARKER-223: -- Yeah, I changed that in osgi.bnd, but it's not

(freemarker) branch 3 updated: (org.apache.freemarker, not org.freemarker...)

2023-10-28 Thread ddekany
This is an automated email from the ASF dual-hosted git repository. ddekany pushed a commit to branch 3 in repository https://gitbox.apache.org/repos/asf/freemarker.git The following commit(s) were added to refs/heads/3 by this push: new 931dbfdb (org.apache.freemarker, not

Re: [PR] Add a simple mechanism for runtime debugging of templates. [freemarker]

2023-10-28 Thread via GitHub
ddekany commented on PR #89: URL: https://github.com/apache/freemarker/pull/89#issuecomment-1783755576 This is in the TODO for the next release. Will see if on closer look I see a better approach. But my current guess is that it will be in it. (The plan is that I will work on FM near the

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
bmarwell commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783751638 That's not true. With Maven we can create an additional artifact with a transformer which just replaces the imports. That's probably true for Gradle as well. -- This is an automated

Re: [PR] FREEMARKER-218 - Add jakarta.servlet support [freemarker]

2023-10-28 Thread via GitHub
ddekany commented on PR #94: URL: https://github.com/apache/freemarker/pull/94#issuecomment-1783749190 Unfortunately, we will have to duplicate everything servlet-related, into its own package. Otherwise we break apps that expect the original Servlet API. So, if someone wants to work on a

Re: [PR] Add a simple mechanism for runtime debugging of templates. [freemarker]

2023-10-28 Thread via GitHub
chrisrueger commented on PR #89: URL: https://github.com/apache/freemarker/pull/89#issuecomment-1783736353 How are the chances to get this in the next release? @ddekany -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use