(freemarker) branch 2.3-gae updated (fb9335ab -> e571099d)

2023-11-05 Thread ddekany
This is an automated email from the ASF dual-hosted git repository. ddekany pushed a change to branch 2.3-gae in repository https://gitbox.apache.org/repos/asf/freemarker.git from fb9335ab Merge pull request #101 from bmarwell/patch-1 new a33970de [BUILD] add github workflow new

Re: [PR] [BUILD] add github workflow [freemarker]

2023-11-05 Thread via GitHub
ddekany commented on PR #100: URL: https://github.com/apache/freemarker/pull/100#issuecomment-1793940828 We don't need `ant dist`, but `ant ci`, which I see you have discovered. If we want to test more, it should be added to `ci`. But, yes, these will go away with the Gradle PR anyway.

Re: [PR] [BUILD] add github workflow [freemarker]

2023-11-05 Thread via GitHub
ddekany merged PR #100: URL: https://github.com/apache/freemarker/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FREEMARKER-224] change Automatic-Module-Name to org.freemarker [freemarker]

2023-11-05 Thread via GitHub
ddekany commented on PR #98: URL: https://github.com/apache/freemarker/pull/98#issuecomment-1793885260 > Oh please keep OSGi support. That comment only applied to FM3 anyway. But, sure. BTW, in the Gradle build (of 2.x), it uses a much more fresh bnd internally, the contributor said

Re: [PR] [FREEMARKER-224] change Automatic-Module-Name to org.freemarker [freemarker]

2023-11-05 Thread via GitHub
ddekany commented on PR #98: URL: https://github.com/apache/freemarker/pull/98#issuecomment-1793883275 So auto modules export everything, and we should be fine. That's good to know. I'm not seeing the relevance of the fact the module name derived from jar name is unstable. That's

Re: [PR] Speedup ConcatenatedSequence iteration [freemarker]

2023-11-05 Thread via GitHub
ddekany commented on PR #97: URL: https://github.com/apache/freemarker/pull/97#issuecomment-1793876693 How to accelerate this further: My idea is this. We can accelerate accessing elements sequentially, by index, with keeping the current data structure. The current data structure is

(freemarker) branch 2.3-gae updated: Update .asf.yaml, disable issues

2023-11-05 Thread ddekany
This is an automated email from the ASF dual-hosted git repository. ddekany pushed a commit to branch 2.3-gae in repository https://gitbox.apache.org/repos/asf/freemarker.git The following commit(s) were added to refs/heads/2.3-gae by this push: new 05d6158c Update .asf.yaml, disable

Re: [PR] Update .asf.yaml, disable issues [freemarker]

2023-11-05 Thread via GitHub
ddekany merged PR #101: URL: https://github.com/apache/freemarker/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FREEMARKER-224] change Automatic-Module-Name to org.freemarker [freemarker]

2023-11-05 Thread via GitHub
bmarwell commented on PR #98: URL: https://github.com/apache/freemarker/pull/98#issuecomment-1793831679 Hi @ddekany I asked in #maven on ASF slack. The general consensus is: 1. derived module name derived from file name is unstable. Gradle users might not get the same

Re: [PR] [BUILD] add github workflow [freemarker]

2023-11-05 Thread via GitHub
bmarwell commented on PR #100: URL: https://github.com/apache/freemarker/pull/100#issuecomment-1793674871 We can add a cache in a later PR, but for now this should be fine. Maybe not even worth it as the project is heading towards Gradle. -- This is an automated message from the Apache