[jira] [Commented] (FREEMARKER-34) ignore_missing option of the <#include does directive not work as expected
[ https://issues.apache.org/jira/browse/FREEMARKER-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506557#comment-15506557 ] Jacques Le Roux commented on FREEMARKER-34: --- Thank you both! Jacopo should we then not close here as "Invalid" or "Not a problem" and handle this in OFBIZ-8292 now on? > ignore_missing option of the <#include does directive not work as expected > -- > > Key: FREEMARKER-34 > URL: https://issues.apache.org/jira/browse/FREEMARKER-34 > Project: Apache Freemarker > Issue Type: Bug > Components: engine >Affects Versions: 2.3.24-incubating > Environment: Windows and *nix >Reporter: Jacques Le Roux > > I found this issue while working on OFBIZ-8250. > It can be easily reproduced on our trunk demo at > https://ofbiz-vm.apache.org:8443/catalog/control/main?USERNAME=admin=ofbiz=Y > By default the footer shows information about the revision and others. They > are beforehand generated in a file which is then used by a Freemarker > template for rendering. > This template depends on themes, by default it's at > http://svn.apache.org/viewvc/ofbiz/trunk/themes/tomahawk/template/Footer.ftl?view=markup > (see lines 26-27) > If we remove the generated file, which is at > /home/ofbizDemo/trunk/runtime/SvnInfo.ftl on the OFBiz demo server. Then the > error appears. > Let me know when you want to test this (ie temporary rename the file). Even > if it's benign, better to not annoy OFBiz users with this issue on screen. > Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FREEMARKER-34) ignore_missing option of the <#include does directive not work as expected
[ https://issues.apache.org/jira/browse/FREEMARKER-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505992#comment-15505992 ] Jacopo Cappellato commented on FREEMARKER-34: - Your "blind guess" was indeed right, thank you [~ddekany]! I was able to fix the error by changing as you have suggested the custom loader that is implemented in OFBiz. I actually have a question about an implementation detail for TemplateLoader, but I will ask it to the dev list. Thank you again. Jacopo > ignore_missing option of the <#include does directive not work as expected > -- > > Key: FREEMARKER-34 > URL: https://issues.apache.org/jira/browse/FREEMARKER-34 > Project: Apache Freemarker > Issue Type: Bug > Components: engine >Affects Versions: 2.3.24-incubating > Environment: Windows and *nix >Reporter: Jacques Le Roux > > I found this issue while working on OFBIZ-8250. > It can be easily reproduced on our trunk demo at > https://ofbiz-vm.apache.org:8443/catalog/control/main?USERNAME=admin=ofbiz=Y > By default the footer shows information about the revision and others. They > are beforehand generated in a file which is then used by a Freemarker > template for rendering. > This template depends on themes, by default it's at > http://svn.apache.org/viewvc/ofbiz/trunk/themes/tomahawk/template/Footer.ftl?view=markup > (see lines 26-27) > If we remove the generated file, which is at > /home/ofbizDemo/trunk/runtime/SvnInfo.ftl on the OFBiz demo server. Then the > error appears. > Let me know when you want to test this (ie temporary rename the file). Even > if it's benign, better to not annoy OFBiz users with this issue on screen. > Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (FREEMARKER-34) ignore_missing option of the <#include does directive not work as expected
[
https://issues.apache.org/jira/browse/FREEMARKER-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505790#comment-15505790
]
Daniel Dekany commented on FREEMARKER-34:
-
What's the stack trace? A bling guess... a mistake that used to occur is that a
custom {{TemplateLoader}} throws exception when it doesn't find a template,
instead of returning {{null}} (as the {{TemplateLoader}} API requires).
> ignore_missing option of the <#include does directive not work as expected
> --
>
> Key: FREEMARKER-34
> URL: https://issues.apache.org/jira/browse/FREEMARKER-34
> Project: Apache Freemarker
> Issue Type: Bug
> Components: engine
>Affects Versions: 2.3.24-incubating
> Environment: Windows and *nix
>Reporter: Jacques Le Roux
>
> I found this issue while working on OFBIZ-8250.
> It can be easily reproduced on our trunk demo at
> https://ofbiz-vm.apache.org:8443/catalog/control/main?USERNAME=admin=ofbiz=Y
> By default the footer shows information about the revision and others. They
> are beforehand generated in a file which is then used by a Freemarker
> template for rendering.
> This template depends on themes, by default it's at
> http://svn.apache.org/viewvc/ofbiz/trunk/themes/tomahawk/template/Footer.ftl?view=markup
> (see lines 26-27)
> If we remove the generated file, which is at
> /home/ofbizDemo/trunk/runtime/SvnInfo.ftl on the OFBiz demo server. Then the
> error appears.
> Let me know when you want to test this (ie temporary rename the file). Even
> if it's benign, better to not annoy OFBiz users with this issue on screen.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
