[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-675809133 This pull request **introduces 2 alerts** and **fixes 2** when merging a0fc2c1fbd591e060860cd2f0dbb442e53856cc0 into be9a2329d1e06f1ae67baaaf875b6ff20b2922cf - [view on LGT

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r472588532 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -186,6 +186,16 @@ public Result

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-675785863 This pull request **introduces 2 alerts** and **fixes 2** when merging e553fab12c998b87ddd863a361ac9e9ca689e2ba into be9a2329d1e06f1ae67baaaf875b6ff20b2922cf - [view on LGT

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

pivotal-jbarrett commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472543514 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +106,65 @@ private void testBindExcep

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472539017 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +102,30 @@ private void testBindExceptionM

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472538826 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +102,30 @@ private void testBindExceptionM

[GitHub] [geode] gesterzhou commented on a change in pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

gesterzhou commented on a change in pull request #5464: URL: https://github.com/apache/geode/pull/5464#discussion_r472530187 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,19 @@ public bool

[GitHub] [geode] gesterzhou commented on a change in pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

gesterzhou commented on a change in pull request #5464: URL: https://github.com/apache/geode/pull/5464#discussion_r472529105 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,19 @@ public bool

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472527125 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^ host

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472525063 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472524195 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-675747104 This pull request **introduces 2 alerts** and **fixes 2** when merging ea366f928d469226b75789a0da8427d02a2a0fbd into be9a2329d1e06f1ae67baaaf875b6ff20b2922cf - [view on LGT

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

pivotal-jbarrett commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472521802 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +102,30 @@ private void testBindExcep

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

pivotal-eshu commented on a change in pull request #5464: URL: https://github.com/apache/geode/pull/5464#discussion_r472499344 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,19 @@ public bo

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472483145 ## File path: cppcache/include/geode/PoolFactory.hpp ## @@ -426,6 +426,11 @@ class APACHE_GEODE_EXPORT PoolFactory { */ PoolFactory& addSe

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472483043 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^ host, I

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472481911 ## File path: cppcache/src/ThinClientLocatorHelper.hpp ## @@ -71,6 +74,8 @@ class ThinClientLocatorHelper { const ThinClientPoolDM* m_poolDM;

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472481270 ## File path: cppcache/src/PoolAttributes.cpp ## @@ -44,46 +44,13 @@ PoolAttributes::PoolAttributes() m_subsEnabled(PoolFactory::DEFAULT_S

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472480996 ## File path: cppcache/integration/test/sni-test-config/geode-config/truststore_sni.pem ## @@ -0,0 +1,68 @@ +-BEGIN CERTIFICATE- Review

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472480140 ## File path: sni-test-config/docker-compose.yml ## @@ -0,0 +1,43 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472479203 ## File path: cppcache/integration/test/SNITest.cpp ## @@ -108,41 +112,51 @@ class SNITest : public ::testing::Test { } std::string certi

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472473631 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472472720 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [geode] smgoller merged pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

smgoller merged pull request #5458: URL: https://github.com/apache/geode/pull/5458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [geode] bschuchardt opened a new pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

bschuchardt opened a new pull request #5465: URL: https://github.com/apache/geode/pull/5465 Configure cipher suites when creating an SSLEngine Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure

[GitHub] [geode] gesterzhou opened a new pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

gesterzhou opened a new pull request #5464: URL: https://github.com/apache/geode/pull/5464 …nt into parallelGatewaySenderQueue Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following st

[GitHub] [geode] Bill commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

Bill commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r472360083 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandTest.java ## @@ -417,4 +417,21 @@ public void connectTo

[GitHub] [geode] kirklund merged pull request #5451: GEODE-8425: Add new handling netsearch statistics

kirklund merged pull request #5451: URL: https://github.com/apache/geode/pull/5451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [geode] jujoramos opened a new pull request #5463: [WIP]: GEM-2931

jujoramos opened a new pull request #5463: URL: https://github.com/apache/geode/pull/5463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] mkevo merged pull request #629: GEODE-8364: Change log level at runtime

mkevo merged pull request #629: URL: https://github.com/apache/geode-native/pull/629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] mkevo merged pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

mkevo merged pull request #628: URL: https://github.com/apache/geode-native/pull/628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-675311553 thanks for the reviews! Sorry but I need someone to merge the PR because Im not a committer This is an aut