[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

2018-12-06 Thread GitHub
This is where the AssemblyContentIntegrationTest dumps the file it generates (at least on my workstation). I copy this file to the src folder that it is supposed to reference, but this file itself I usually delete so that it doesn't get checked in. I thought I'd gitignore it so I don't have to

[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

2018-12-06 Thread GitHub
Can we mark this with a JIRA ticket number, so we can track it? [ Full content available at: https://github.com/apache/geode/pull/2875 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

2018-11-19 Thread GitHub
Yes, this and the RegionAttributeSetFunction are "functional interfaces" which we are using as lambda functions to create and retrieve different kinds of region attributes. Please see RegionConfigFactory for an example of how this is used. If you haven't heard of it before, it's actually a

[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

2018-11-19 Thread GitHub
See comment above [ Full content available at: https://github.com/apache/geode/pull/2875 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

2018-11-19 Thread GitHub
Sure -- we can do that instead of bounce. [ Full content available at: https://github.com/apache/geode/pull/2875 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] aditya87 commented on pull request #2875: GEODE-5971: Refactor CreateRegionCommand to extend SingleGfshCommand

2018-11-19 Thread GitHub
I agree that the RegionConfigFactory should be in the command directory -- we will move that. With regards to the RegionFunctionArgs -- yes, we should ideally not use it, but we wanted to do this in the most incremental fashion possible. The most important takeaway here is moving away from