[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473447837 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,27 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473447837 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,27 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473195346 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public ResultModel

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473194273 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473194273 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473186241 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473185831 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public ResultModel

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473142076 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473085253 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public