[GitHub] [geode] jinmeiliao commented on pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

2022-05-19 Thread GitBox
jinmeiliao commented on PR #7703: URL: https://github.com/apache/geode/pull/7703#issuecomment-1132414898 > The ArchUnit test is failing. I recommend moving the locator string parsing logic from the `geode-membership` subproject to a class in a new package in the `geode-common` subproject

[GitHub] [geode] jinmeiliao commented on pull request #7703: GEODE-10318: do not add duplicate entries in the locators list

2022-05-19 Thread GitBox
jinmeiliao commented on PR #7703: URL: https://github.com/apache/geode/pull/7703#issuecomment-1131987304 > The scope of this problem is in question. At the highest level it's not clear why (before this PR) it is necessary for an `InternalLocator` to add itself to the effective set of