[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
Please update README.md with the correct output: ``` C:\Program Files\nativeclient\examples\build\dotnet\FunctionExecutionCs\Debug>FunctionExecutionCs.exe Storing id and username in the region Getting the user info from the region rtimmons = Robert Timmons scharles = Sylvia Charles Result count o

[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
Maybe we should take that line out then, so that people don't wonder why it is never printed. [ Full content available at: https://github.com/apache/geode-native/pull/409 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
It wouldn't be what's in the README. The print from line 75 is missing, and I don't see where lines 21 and on (in the README) would come from. `Console.WriteLine("Result count of: " + res.Count)` [ Full content available at: https://github.com/apache/geode-native/pull/409 ] This message was rela

[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
I feel that we're adding unnecessary complexity. Why are we building oddKeyFilter, if the only thing we're going to do with it is add each element to oddKeyArgs? Why not just build the latter and throw out the former? [ Full content available at: https://github.com/apache/geode-native/pull/409 ]

[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
I don't think the output looks like this, anymore. Line 75 in Program.cs just prints the number of elements in the result set, nothing more. [ Full content available at: https://github.com/apache/geode-native/pull/409 ] This message was relayed via gitbox.apache.org for notifications@geode.apach

[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
I don't think the output looks like this, anymore. Line 75 just prints the number of elements in the result set, nothing more. [ Full content available at: https://github.com/apache/geode-native/pull/409 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] igodwin commented on pull request #409: GEODE-4346: .NET function execution example

2018-12-14 Thread GitHub
resultList is not "really" being used. I don't think it, or the following for loop should be in the example if we're just going to print the number of elements in the result set. [ Full content available at: https://github.com/apache/geode-native/pull/409 ] This message was relayed via gitbox.ap