[GitHub] [geode] jdeppe-pivotal commented on issue #3083: GEODE-6280: Create new public module for the Management API
@aditya87 - for your review [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on issue #3088: GEODE-6283: have the management rest controller call the internal clu…
@aditya87 @Petahhh [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao opened pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
…ster management service to actually create the region * inject cluster management service to the rest controller * have the controller produce json string for response * refactor the controller exception handler to always send back json string Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3068: GEODE-6269: Extract StatisticsRegistry from InternalDistributedSystem
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3068 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller merged pull request #43: GEODE-6147 - Fail benchmark task if average latency change is 5+%
smgoller merged pull request #43: GEODE-6147 - Fail benchmark task if average latency change is 5+% URL: https://github.com/apache/geode-benchmarks/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode] kirklund closed pull request #3073: GEODE-6232: Remove ReadWriteLock from ManagementListener
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3073 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on issue #3071: GEODE-6232: Extract ResourceEventNotifier from InternalDistributedSystem
This PR needs to wait for PR #3087 to be merged in. [ Full content available at: https://github.com/apache/geode/pull/3071 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller opened pull request #43: GEODE-6147 - Fail benchmark task if average latency change is 5+%
* Change ratio to difference * Add difference calculation to ProbeResult * Fail analyzeRun task if average latency difference is >= 5% Authored-by: Sean Goller [ Full content available at: https://github.com/apache/geode-benchmarks/pull/43 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller closed pull request #43: GEODE-6147 - Fail benchmark task if average latency change is 5+%
[ pull request closed by smgoller ] [ Full content available at: https://github.com/apache/geode-benchmarks/pull/43 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller closed pull request #42: GEODE-6276: use named cli options for scripts
[ pull request closed by smgoller ] [ Full content available at: https://github.com/apache/geode-benchmarks/pull/42 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] smgoller closed pull request #3085: GEODE-6276: Use named cli option in benchmark
[ pull request closed by smgoller ] [ Full content available at: https://github.com/apache/geode/pull/3085 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller merged pull request #42: GEODE-6276: use named cli options for scripts
smgoller merged pull request #42: GEODE-6276: use named cli options for scripts URL: https://github.com/apache/geode-benchmarks/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] smgoller opened a new pull request #43: GEODE-6147 - Fail benchmark task if average latency change is 5+%
smgoller opened a new pull request #43: GEODE-6147 - Fail benchmark task if average latency change is 5+% URL: https://github.com/apache/geode-benchmarks/pull/43 * Change ratio to difference * Add difference calculation to ProbeResult * Fail analyzeRun task if average latency difference is >= 5% Authored-by: Sean Goller This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode] jdeppe-pivotal commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
It seems a bit redundant having 'CacheElement' in the name of these methods. It's also not entirely accurate seeing that the methods will result in both persistence and realization. [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
It seems a bit redundant having 'CacheElement' in the name of these methods. It's also not entirely accurate seeing that the methods will result in both persistence and realization. I think they'd be better as just `cerate`, `update` and `delete` [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
It seems a bit redundant having 'CacheElement' in the name of these methods. It's also not entirely accurate seeing that the methods will result in both persistence and realization. I think they'd be better as just `create`, `update` and `delete`. [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
It seems a bit redundant having 'CacheElement' in the name of these methods. It's also not entirely accurate seeing that the methods will result in both persistence and realization. I think they'd be better as just `create`, `update` and `delete` [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] davebarnes97 closed pull request #435: GEODE-4337, GEODE-4346 Geode-native guide: Document function execution examples
[ pull request closed by davebarnes97 ] [ Full content available at: https://github.com/apache/geode-native/pull/435 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3083: GEODE-6280: Create new public module for the Management API
should this be T instead? [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
Seems more obvious to just use a `Properties` object here. I don't know why we made the underlying methods use an array of (implicit) `Object[2]` arguments. [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
What is `V` supposed to be? `V extends *SomeSpecificType` or `V extends Object`? Without declaration of what `V` is, you might just as well return `Object` [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal opened pull request #3090: GEODE-6289: check for null className on createPdxInstanceFactory
Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3090 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller opened pull request #45: Fix defaults and dependencies.
* Add default for branch under test * Fetch dependencies before running benchmarks. Authored-by: Sean Goller [ Full content available at: https://github.com/apache/geode-benchmarks/pull/45 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller opened a new pull request #45: Fix defaults and dependencies.
smgoller opened a new pull request #45: Fix defaults and dependencies. URL: https://github.com/apache/geode-benchmarks/pull/45 * Add default for branch under test * Fetch dependencies before running benchmarks. Authored-by: Sean Goller This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode] jinmeiliao commented on pull request #3083: GEODE-6280: Create new public module for the Management API
I see the need to move this functionality out of here. We can probably completely get rid of this method, and have an instantiator to instantiate the instance. e.g. ``` mutator.setCacheLoader(ConfigInstantiator.instantiate(config, cache)); ``` [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
Maybe `T extends Declarable` [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode]
[ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
just to avoid having to create a Property and manipulate it based on what
webapp it is. one webapp only requires security service, another requires
security service and sslConfig, and another requires securityService and
managementService. So instead of
```
Properties properties = new Properties();
properties.put("securityService", securityService);
addWebapp(context1, war1, properties);
properties.put("sslConfig", sslConfig);
addWebapp(context2, war2, properties);
```
I could do
```
addWebapp(context1, war1, new Object[]{"securityService", securityService});
addWebapp(context2, war2, new Object[]{"sslConfig", sslConfig}, new
Object[]{"securityService", securityService});
```
[ Full content available at: https://github.com/apache/geode/pull/3088 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
Yes - thanks! [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
Doesn't seem to be syntactically possible, but my Generic foo is weak... [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal opened pull request #3091: GEODE-6290: change PdxInstance.equals for empty class name
PdxInstance.equals will only act as if an instance has a field with the default value if the class name is not empty. If the class name is empty it will now require that both instances have all the same identity fields. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3091 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
you'll have to define the `ConfigTypeInstantiator` as follows:
`public interface ConfigTypeInstantiator{
V newInstance(T type)
}`
and then the `DeclarableTypeInstantiator` can become:
`public class DeclarableTypeInstantiator implements
ConfigTypeInstantiator{
@Override
public T newInstance(DeclarableType type){...
...
...
}`
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
you'll have to define the `ConfigTypeInstantiator` as follows:
`public interface ConfigTypeInstantiator{
V newInstance(T type)
}`
and then the `DeclarableTypeInstantiator` can become:
`public class DeclarableTypeInstantiator implements
ConfigTypeInstantiator{
@Override
public T newInstance(DeclarableType type){...
...
...
}`
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
you'll have to define the `ConfigTypeInstantiator` as follows:
`public interface ConfigTypeInstantiator{
V newInstance(T type)
}`
and then the `DeclarableTypeInstantiator` can become:
`public class DeclarableTypeInstantiator implements
ConfigTypeInstantiator{
@Override
public T newInstance(DeclarableType type){...
...
...
}`
[ Full content available at: https://github.com/apache/geode/pull/3083 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[GitHub] [geode] kohlmu-pivotal commented on pull request #3083: GEODE-6280: Create new public module for the Management API
We cannot change this method declaration. :( public API... or at least this Class is not in the "internal" namespace and therefore can be seen as public. We'd have to deprecate this in favor of the alternative of asking the `ConfigTypeInstantiator` create this instance [ Full content available at: https://github.com/apache/geode/pull/3083 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt opened pull request #3093: Feature/geode 6244b
Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3093 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller opened a new pull request #44: Add ability to fetch dependencies.
smgoller opened a new pull request #44: Add ability to fetch dependencies. URL: https://github.com/apache/geode-benchmarks/pull/44 Authored-by: Sean Goller This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] smgoller merged pull request #44: Add ability to fetch dependencies.
smgoller merged pull request #44: Add ability to fetch dependencies. URL: https://github.com/apache/geode-benchmarks/pull/44 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode-benchmarks] smgoller closed pull request #44: Add ability to fetch dependencies.
[ pull request closed by smgoller ] [ Full content available at: https://github.com/apache/geode-benchmarks/pull/44 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller opened pull request #44: Add ability to fetch dependencies.
Authored-by: Sean Goller [ Full content available at: https://github.com/apache/geode-benchmarks/pull/44 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal opened pull request #3089: GEODE-6288: change isDeserializable to return true on JSON pdx
Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3089 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #3089: GEODE-6288: change isDeserializable to return true on JSON pdx
[ pull request closed by dschneider-pivotal ] [ Full content available at: https://github.com/apache/geode/pull/3089 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller closed pull request #45: Fix defaults and dependencies.
[ pull request closed by smgoller ] [ Full content available at: https://github.com/apache/geode-benchmarks/pull/45 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller merged pull request #45: Fix defaults and dependencies.
smgoller merged pull request #45: Fix defaults and dependencies. URL: https://github.com/apache/geode-benchmarks/pull/45 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode] jdeppe-pivotal opened pull request #3092: GEODE-6268: Reduce the number of iterations for unique port ranges in AvailablePortHelperIntegrationTest
- This test was failing fairly consistently on Windows. An initial assumption was that the given port range would be completely free. This is typically true in a Linux/Docker environment but is not the case on Windows. - The logic of these modified tests is somewhat extreme as in actual use, there would never be a need for 1000 ranges. Signed-off-by: Aditya Anchuri Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3092 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3088: GEODE-6283: have the management rest controller call the internal clu…
sounds good. [ Full content available at: https://github.com/apache/geode/pull/3088 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt closed pull request #3051: Feature/geode 6244 sick member kicks out healthy member
[ pull request closed by bschuchardt ] [ Full content available at: https://github.com/apache/geode/pull/3051 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3087: GEODE-6285: Make MBean names immutable in loner
[ pull request closed by kirklund ] [ Full content available at: https://github.com/apache/geode/pull/3087 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on issue #3094: GEODE-6292 hot loop in GMSJoinLeave.findCoordinator
This came from an internal ticket from a Pivotal customer: GEM-2367 [ Full content available at: https://github.com/apache/geode/pull/3094 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] dschneider-pivotal closed pull request #3090: GEODE-6289: check for null className on createPdxInstanceFactory
[ pull request closed by dschneider-pivotal ] [ Full content available at: https://github.com/apache/geode/pull/3090 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu closed pull request #3082: GEODE-6212: Add unit test coverage for ValueComparisonHelper
[ pull request closed by pivotal-eshu ] [ Full content available at: https://github.com/apache/geode/pull/3082 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller opened a new pull request #46: Add debugging because reasons.
smgoller opened a new pull request #46: Add debugging because reasons. URL: https://github.com/apache/geode-benchmarks/pull/46 Authored-by: Sean Goller This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode-benchmarks] smgoller closed pull request #46: Add debugging because reasons.
[ pull request closed by smgoller ] [ Full content available at: https://github.com/apache/geode-benchmarks/pull/46 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-benchmarks] smgoller opened pull request #46: Add debugging because reasons.
Authored-by: Sean Goller [ Full content available at: https://github.com/apache/geode-benchmarks/pull/46 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] smgoller merged pull request #46: Add debugging because reasons.
smgoller merged pull request #46: Add debugging because reasons. URL: https://github.com/apache/geode-benchmarks/pull/46 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [geode] bschuchardt opened pull request #3094: GEODE-6292 hot loop in GMSJoinLeave.findCoordinator
Added a 1 second pause before retrying if no locators could be contacted and locator-wait-time has been set. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/3094 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund opened pull request #3095: GEODE-6294: Add disable-jmx config property
This is needed in order to disable JMX in PersistentPartitionedRegionRegressionTest which will then prevent that test from deadlocking in the JMX ManagementListener. [ Full content available at: https://github.com/apache/geode/pull/3095 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund opened pull request #3096: GEODE-6232: Disable JMX in persistent PersistentPartitionedRegionRegressionTest
The cause of the hang in GEODE-6232 is lock ordering that involves JMX ManagementListener. Since PersistentPartitionedRegionRegressionTest does not need JMX, this change will disable JMX in the test. Requires PR #3095 to be merged first. The commit in that PR is included in this PR's branch. Please just the 2nd commit which changes PersistentPartitionedRegionRegressionTest to use disable-jmx. [ Full content available at: https://github.com/apache/geode/pull/3096 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
