* Using the constructor with initial value rather than using addAll
after the constructor.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ]
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/4069 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Can we change this to `Cache` and `LogWriter` instead?.
[ Full content available at: https://github.com/apache/geode/pull/4061 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Do we really need all these new methods to create, write, and other operations
on low level java classes just for mocking purposes?. Looks "a bit overkilling"
to me...
[ Full content available at: https://github.com/apache/geode/pull/4061 ]
This message was relayed via gitbox.apache.org for
[ pull request closed by jujoramos ]
[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by nabarunnag ]
[ Full content available at: https://github.com/apache/geode/pull/4070 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The test was failing on machines with ports 2000 or 2001 in use.
This change replaces GatewayReceiverImpl's dependency on AvailablePort
with functions that are now injected by the unit tests.
Specifically, this test was failing for @dickcav and @onichols-pivotal.
[ Full content available at:
[ pull request closed by jujoramos ]
[ Full content available at: https://github.com/apache/geode/pull/3996 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
> Should I remove them or keep them?
As a general rule, I'd say adhere to the existing style. However, in Geode we
don't seem to have a standard style for test names. I personally prefer the
style with the underscores, but I'd be fine with it either way.
[ Full content available at:
There is a lot going on here. I will preface that I haven't read the entire PR.
I would prefer to have seen an RFC that described the intent of this PR. I
believe the intent is go move all the Log4J specific code into its own module.
This module is expected to be an SPI implementation of the
There is a lot going on here. I will preface that I haven't read the entire PR.
I would prefer to have seen an RFC that described the intent of this PR. I
believe the intent is to move all the Log4J specific code into its own module.
This module is expected to be an SPI implementation of the
The problem is all these input streams are being created, used, and discarded
internally in the load/unload process. This means that if we want to verify any
behavior of those objects (in addition to avoiding the NullPointerExceptions
that come with trying to actually perform these filesystem
VersionTag serialization was being affected by concurrent modification
of its memberId/previousMemberId fields, causing the HAS_PREVIOUS_MEMBER_ID
flag bit to be set and the DUPLICATE_MEMBER_IDS flag to _not_ be set.
It then went on to perform the same checks later in toData() and make
different
In other tests this was possible and I've replaced internal uses there with the
public interfaces. For this test specifically, the 3 internal references are
necessary. The product itself performs a cast of the retrieved Cache object to
GemFireCacheImpl, and as a result passing a mock of
[ Full content available at: https://github.com/apache/geode/pull/4072 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
> Seems alright to me, I appreciate the descriptive test names!
Its better to use descriptive names than comments explaining the test case :)
Thanks!
[ Full content available at: https://github.com/apache/geode/pull/4067 ]
This message was relayed via gitbox.apache.org for
Please add tests showing that the LocalRegion closes cachePerfStats when the
holder has own stats, and does not when the holder doesn't have own stats.
[ Full content available at: https://github.com/apache/geode/pull/4072 ]
This message was relayed via gitbox.apache.org for
I'm curious why you chose to introduce a new variable rather than referencing
the `DUPLICATE_MEMBER_IDS` bit in `flags`?
[ Full content available at: https://github.com/apache/geode/pull/4073 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
18 matches
Mail list logo
