[GitHub] [geode] albertogpz commented on pull request #5313: GEODE-8302: Fixed 'events not queued conflated' stats when group-tran…
albertogpz commented on pull request #5313: URL: https://github.com/apache/geode/pull/5313#issuecomment-651582218 > @albertogpz Good material - thanks for writing the docs for this feature. > I have some edits for clarification and consistency, in both user guide files and the javadoc comments in class files. I will send these to you in email for you to incorporate as you see fit. Thanks! Thanks for the review, Dave. I have accepted all your proposals with the exception of the javadoc on ```GatewaySenderQueue.java``` which had not ended up describing correctly the ```peekedIdsWithoutExtra``` member variable. I changed it to a simpler sentence. Let me know if you are ok with the change. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] albertogpz commented on a change in pull request #5273: GEODE-8240: solve rolling upgrade bug with new VersionOrdinal interface
albertogpz commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r447434620
##
File path:
geode-core/src/upgradeTest/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java
##
@@ -191,20 +207,26 @@ void doTestRollAll(String regionType, String objectType,
String startingVersion)
}
putAndVerify(objectType, server1, regionName, 0, 10, server2);
- locator = rollLocatorToCurrent(locator, hostName, locatorPorts[0],
getTestMethodName(),
- locatorString);
+ locator =
+ rollLocatorToCurrent(locator, hostName, locatorPort, locatorProps,
getTestMethodName(),
+ locatorString);
server1 = rollServerToCurrentAndCreateRegion(server1, regionType,
testingDirs[0],
- shortcutName, regionName, locatorPorts);
+ shortcutName, regionName, new int[] {locatorPort});
verifyValues(objectType, regionName, 0, 10, server1);
putAndVerify(objectType, server1, regionName, 5, 15, server2);
putAndVerify(objectType, server2, regionName, 10, 20, server1);
server2 = rollServerToCurrentAndCreateRegion(server2, regionType,
testingDirs[1],
- shortcutName, regionName, locatorPorts);
+ shortcutName, regionName, ports);
verifyValues(objectType, regionName, 0, 10, server2);
putAndVerify(objectType, server2, regionName, 15, 25, server1);
+ String shutDownCommand = "shutdown --include-locators=true";
Review comment:
Overall, great work. Thanks, Bill.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] jujoramos opened a new pull request #5329: [WIP] - GEODE-8029: Allow OplogEntryIdSet to Overflow
jujoramos opened a new pull request #5329: URL: https://github.com/apache/geode/pull/5329 Do not delete drf files during member startup as that should be only done by the compactor thread. Instead, allow the OplogEntryIdSet to grow over the default capacity and log a warning message instructing the user to manually compact the disk-stores. - Added unit tests. - Replaced usages of 'junit.Assert' by 'assertj'. - Modified DiskStoreImpl.deadRecordCount to return long instead of int. - Added internal overflow implementation to the OplogEntryIdSet so it can grow above the default limit. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [X] Is your initial contribution a single, squashed commit? - [X] Does `gradlew build` run cleanly? - [X] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jujoramos closed pull request #5322: [WIP]: Do not review.
jujoramos closed pull request #5322: URL: https://github.com/apache/geode/pull/5322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #5324: Migrate to JUnit 5 framework.
pivotal-jbarrett commented on pull request #5324: URL: https://github.com/apache/geode/pull/5324#issuecomment-651845490 @dhemery can you take a quick look at the results. I fear they might be false positives. I would like two eyes on them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #5324: Migrate to JUnit 5 framework.
pivotal-jbarrett commented on pull request #5324: URL: https://github.com/apache/geode/pull/5324#issuecomment-651854835 As I suspected, something is up. Far fewer tests run in distributed tests. PR: https://concourse.apachegeode-ci.info/builds/171472 Main: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #5330: GEODE-7864: Fix array index out of bounds alerts
lgtm-com[bot] commented on pull request #5330: URL: https://github.com/apache/geode/pull/5330#issuecomment-651976168 This pull request **fixes 9 alerts** when merging 209665716235025c0967c8ae1c8e7760647cd42e into bfe1ca113124ea958dc02dd9be90cdb0aabe5c4d - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-bd9d26ca8975c37e3bb7f4dd43fda3573d309eeb) **fixed alerts:** * 9 for Array index out of bounds This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #5330: GEODE-7864: Fix array index out of bounds alerts
DonalEvans merged pull request #5330: URL: https://github.com/apache/geode/pull/5330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] gesterzhou merged pull request #5253: GEODE-8259: when client singlehop getAll encountered SerializationException, it should retry
gesterzhou merged pull request #5253: URL: https://github.com/apache/geode/pull/5253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill closed pull request #5278: GEODE-8240: GMSMemberData keeps VersionOrdinal
Bill closed pull request #5278: URL: https://github.com/apache/geode/pull/5278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill commented on pull request #5278: GEODE-8240: GMSMemberData keeps VersionOrdinal
Bill commented on pull request #5278: URL: https://github.com/apache/geode/pull/5278#issuecomment-652050659 closing this PR. it's out of date. It was made with an early version of the GEODE-8240 fix on the `develop` branch. I'm about to make a brand new 1.12-based branch to test the latest version of that fix that just merged to `develop`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] boglesby opened a new pull request #5331: GEODE-8324: Don't add a remote ds id to recipients unless it is running
boglesby opened a new pull request #5331: URL: https://github.com/apache/geode/pull/5331 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] rhoughton-pivot opened a new pull request #5332: buildSrc depends directly on guava. Declare it. Misc other build fixups
rhoughton-pivot opened a new pull request #5332: URL: https://github.com/apache/geode/pull/5332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] pivotal-eshu opened a new pull request #5333: GEODE-8323: Process QueueRemovalMessage after queue initialized.
pivotal-eshu opened a new pull request #5333: URL: https://github.com/apache/geode/pull/5333 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
