[GitHub] [geode] rhoughton-pivot commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
rhoughton-pivot commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661343930 @metatype The module that pulls those in was also getting the symbols transitively. I'm not convinced that anything we can call can hit any symbols from these particular `javax` jars. If this change to drop the duplication of license in our source-license file doesn't work, can we close this PR as will-not-fix? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund opened a new pull request #5388: GEODE-8371: Move ClassGraph to MIT License
kirklund opened a new pull request #5388: URL: https://github.com/apache/geode/pull/5388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
onichols-pivotal commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661346610 @rhoughton-pivot don't forget to remove activation 1.1 (lines 269-270) from geode-assembly/src/main/dist/LICENSE as part of this PR, and also please add the ticket to the front of the PR title. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
onichols-pivotal commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661346111 @metatype this PR is in response to the ticket you asked me to create during the last license review: GEODE-8066 Geode should not be using both activation 1.1 and javax.activation 1.2 So we are trying to go from 2 versions of a dependency to just one (not trying to get rid of it entirely). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] karensmolermiller opened a new pull request #5386: GEODE-8363: Label Micrometer docs as experimental
karensmolermiller opened a new pull request #5386: URL: https://github.com/apache/geode/pull/5386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] metatype commented on pull request #5291: [DRAFT] Pull up transitive dependency to clean up javax.activation and mail licenses.
metatype commented on pull request #5291: URL: https://github.com/apache/geode/pull/5291#issuecomment-661242217 IIUC, this removes javax.mail and javax.activation from the bundled dependencies. I believe that we need those dependencies until we remove the admin API entirely. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #5387: GEODE-7628: Block jmx mbean creation when no security manager (docs)
davebarnes97 merged pull request #5387: URL: https://github.com/apache/geode/pull/5387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] karensmolermiller merged pull request #5386: GEODE-8363: Label Micrometer docs as experimental
karensmolermiller merged pull request #5386: URL: https://github.com/apache/geode/pull/5386 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87
onichols-pivotal commented on pull request #5382: URL: https://github.com/apache/geode/pull/5382#issuecomment-661500736 Out of curiosity what are we changing this? Was there a specific issue with 4.8.52 you are trying to solve? I would much rather go back to 4.0.6 and fix the log4j issue with an exclusion, than mess around with any of these newfangled versions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] davebarnes97 opened a new pull request #5387: GEODE-7628: Block jmx mbean creation when no security manager (docs)
davebarnes97 opened a new pull request #5387: URL: https://github.com/apache/geode/pull/5387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #4848: GEODE-7670: Add Tests for PR clear
DonalEvans commented on a change in pull request #4848:
URL: https://github.com/apache/geode/pull/4848#discussion_r457469700
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java
##
@@ -0,0 +1,733 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.apache.geode.internal.util.ArrayUtils.asList;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.VM.getVM;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import java.io.Serializable;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.IntStream;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import junitparams.naming.TestCaseName;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.ForcedDisconnectException;
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.PartitionAttributes;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.partition.PartitionRegionHelper;
+import org.apache.geode.distributed.DistributedSystemDisconnectedException;
+import org.apache.geode.distributed.internal.ClusterDistributionManager;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.DistributionMessage;
+import org.apache.geode.distributed.internal.DistributionMessageObserver;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import
org.apache.geode.distributed.internal.membership.api.MembershipManagerHelper;
+import org.apache.geode.internal.cache.versions.RegionVersionHolder;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionSource;
+import org.apache.geode.test.dunit.AsyncInvocation;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.CacheRule;
+import org.apache.geode.test.dunit.rules.DistributedRule;
+
+/**
+ * Tests to verify that {@link PartitionedRegion#clear()} operation can be
executed multiple times
+ * on the same region while other cache operations are being executed
concurrently and members are
+ * added or removed.
+ */
+@RunWith(JUnitParamsRunner.class)
+public class PartitionedRegionClearWithConcurrentOperationsDUnitTest
implements Serializable {
+ private static final Integer BUCKETS = 13;
+ private static final String REGION_NAME = "PartitionedRegion";
+ private static final String TEST_CASE_NAME =
+ "[{index}] {method}(Coordinator:{0}, RegionType:{1})";
+
+ @Rule
+ public DistributedRule distributedRule = new DistributedRule(3);
+
+ @Rule
+ public CacheRule cacheRule = CacheRule.builder().createCacheInAll().build();
+
+ private VM accessor, server1, server2;
Review comment:
It's recommended not to declare multiple variables inline, so this
should ideally be split into three separate lines.
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java
##
@@ -0,0 +1,733 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under
[GitHub] [geode] jdeppe-pivotal opened a new pull request #5384: GEODE-8369: Do not build docker images on Windows for geode-assembly:acceptanceTest
jdeppe-pivotal opened a new pull request #5384: URL: https://github.com/apache/geode/pull/5384 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] Bill merged pull request #5370: GEODE-8298: Member version comparison sense inconsistent when deciding on multicast
Bill merged pull request #5370: URL: https://github.com/apache/geode/pull/5370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] rhoughton-pivot merged pull request #5384: GEODE-8369: Do not build docker images on Windows for geode-assembly:acceptanceTest
rhoughton-pivot merged pull request #5384: URL: https://github.com/apache/geode/pull/5384 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] gesterzhou closed pull request #5372: Revert "GEODE-7384: Members's old Persistent Member Id should be remo…
gesterzhou closed pull request #5372: URL: https://github.com/apache/geode/pull/5372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sabbeyPivotal opened a new pull request #5385: GEODE-8370: Add test for maxInactiveInterval
sabbeyPivotal opened a new pull request #5385: URL: https://github.com/apache/geode/pull/5385 Write test verifying that maxInactiveInterval propagates correctly to all buckets This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
