jivthesh commented on pull request #5430:
URL: https://github.com/apache/geode/pull/5430#issuecomment-670828286
@metatype okay
This is an automated message from the Apache Git Service.
To respond to the message, please lo
jinmeiliao opened a new pull request #5436:
URL: https://github.com/apache/geode/pull/5436
* allow ClusterStartupRule to launch dunit default locator
This is an automated message from the Apache Git Service.
To respond to the
moleske commented on a change in pull request #628:
URL: https://github.com/apache/geode-native/pull/628#discussion_r467228776
##
File path: cppcache/integration/test/Order.cpp
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * co
moleske commented on a change in pull request #625:
URL: https://github.com/apache/geode-native/pull/625#discussion_r467223869
##
File path: cppcache/src/ExceptionTypes.cpp
##
@@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();
PutAllPartialResultEx
jujoramos commented on pull request #5175:
URL: https://github.com/apache/geode/pull/5175#issuecomment-670655764
@mkevo
Thanks for adding the extra tests. I'm not fully convinced about the
implemented fix, however, did you consider my comments
[here](https://github.com/apache/geode/pul
bschuchardt closed pull request #5433:
URL: https://github.com/apache/geode/pull/5433
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
bschuchardt merged pull request #5435:
URL: https://github.com/apache/geode/pull/5435
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
bschuchardt commented on pull request #5435:
URL: https://github.com/apache/geode/pull/5435#issuecomment-670643196
Since this is a test-only change and the checks that use that test have
passed I'm merging this PR before all of the non-required checks have finished.
--
bschuchardt opened a new pull request #5435:
URL: https://github.com/apache/geode/pull/5435
Fixing directory path formation problem for Windows. I've tested these
changes on a Mac and on a Windows machine.
Thank you for submitting a contribution to Apache Geode.
In order
DonalEvans merged pull request #5418:
URL: https://github.com/apache/geode/pull/5418
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
albertogpz opened a new pull request #5434:
URL: https://github.com/apache/geode/pull/5434
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all cha
agingade merged pull request #5424:
URL: https://github.com/apache/geode/pull/5424
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
bschuchardt opened a new pull request #5433:
URL: https://github.com/apache/geode/pull/5433
…e name b… (#5428)"
This reverts commit d6c3b1f20a55c5d867f162a338910d5df7d47de5.
The new test fails consistently on Windows.
Thank you for submitting a contribution to Apache Geode.
rhoughton-pivot merged pull request #5427:
URL: https://github.com/apache/geode/pull/5427
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mivanac merged pull request #5432:
URL: https://github.com/apache/geode/pull/5432
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
albertogpz commented on a change in pull request #5348:
URL: https://github.com/apache/geode/pull/5348#discussion_r467116996
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java
##
@@ -0,0 +1,148 @
albertogpz commented on a change in pull request #5348:
URL: https://github.com/apache/geode/pull/5348#discussion_r467114892
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBeanBridge.java
##
@@ -334,4 +334,8 @@ public boolean is
albertogpz commented on a change in pull request #5348:
URL: https://github.com/apache/geode/pull/5348#discussion_r467114776
##
File path:
geode-core/src/main/java/org/apache/geode/management/GatewaySenderMXBean.java
##
@@ -273,6 +273,8 @@
*/
int getEventsExceedingAlert
masaki-yamakawa commented on pull request #5418:
URL: https://github.com/apache/geode/pull/5418#issuecomment-670544653
@DonalEvans Thanks for the review.
This is an automated message from the Apache Git Service.
To respond to
mivanac opened a new pull request #5432:
URL: https://github.com/apache/geode/pull/5432
…n of each child region
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been t
jujoramos commented on pull request #5227:
URL: https://github.com/apache/geode/pull/5227#issuecomment-670514196
Dang!, somehow I totally missed that notification and there wasn't any new
comments on the `PR` (other than the one from Owen) so I didn't get any
specific email addressed to my
mivanac commented on pull request #5227:
URL: https://github.com/apache/geode/pull/5227#issuecomment-670507310
Just for record, If you look at last commit, you can see that your requst
(to force the bucket creation) is fullfilled.
--
jujoramos commented on pull request #5227:
URL: https://github.com/apache/geode/pull/5227#issuecomment-670504376
Hello @mivanac ,
Just for the record, I've been actively reviewing this `PR` since it was
opened but I don't think the fix is sufficient to fix the flakiness, that's why
I r
mivanac commented on pull request #5227:
URL: https://github.com/apache/geode/pull/5227#issuecomment-670492076
Since there is no reply on this PR, I will close it.
This is an automated message from the Apache Git Service.
To
mivanac closed pull request #5227:
URL: https://github.com/apache/geode/pull/5227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
mivanac merged pull request #5426:
URL: https://github.com/apache/geode/pull/5426
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
26 matches
Mail list logo