[GitHub] [geode] jujoramos commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-24 Thread GitBox
jujoramos commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678986015 Thanks you @mkevo ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [geode] mkevo merged pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-24 Thread GitBox
mkevo merged pull request #5466: URL: https://github.com/apache/geode/pull/5466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mkevo commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-24 Thread GitBox
mkevo commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678983408 @jujoramos , thanks a lot! :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [geode-native] mmartell merged pull request #639: GEODE-8441: AppDomainContext was initialized too late

2020-08-24 Thread GitBox
mmartell merged pull request #639: URL: https://github.com/apache/geode-native/pull/639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jinmeiliao commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-24 Thread GitBox
jinmeiliao commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r475689526 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -0,0

[GitHub] [geode] mhansonp commented on a change in pull request #5467: GEODE-8444: When requester's RVV equals provider's rvvGC, should do f…

2020-08-24 Thread GitBox
mhansonp commented on a change in pull request #5467: URL: https://github.com/apache/geode/pull/5467#discussion_r475768556 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/versions/RegionVersionVector.java ## @@ -994,13 +994,18 @@ public boolean

[GitHub] [geode] DonalEvans opened a new pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-24 Thread GitBox
DonalEvans opened a new pull request #5473: URL: https://github.com/apache/geode/pull/5473 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #640: GEODE-8445: Remove copy step for cryptoimpl library

2020-08-24 Thread GitBox
pdxcodemonkey opened a new pull request #640: URL: https://github.com/apache/geode-native/pull/640 - dotnet SSL example build was broken, because we no longer use cryptoimpl to access SSL @mreddington @dihardman @karensmolermiller @davebarnes97

[GitHub] [geode] agingade commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-24 Thread GitBox
agingade commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r475670905 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -0,0 +1,149

[GitHub] [geode] gesterzhou commented on a change in pull request #5467: GEODE-8444: When requester's RVV equals provider's rvvGC, should do f…

2020-08-24 Thread GitBox
gesterzhou commented on a change in pull request #5467: URL: https://github.com/apache/geode/pull/5467#discussion_r475777699 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/versions/RegionVersionVector.java ## @@ -994,13 +994,18 @@ public boolean

[GitHub] [geode] jhutchison opened a new pull request #5472: GEODE-8451 Redis ping response contains uneeded quotes

2020-08-24 Thread GitBox
jhutchison opened a new pull request #5472: URL: https://github.com/apache/geode/pull/5472 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jdeppe-pivotal merged pull request #5472: GEODE-8451 Redis ping response contains unneeded quotes

2020-08-24 Thread GitBox
jdeppe-pivotal merged pull request #5472: URL: https://github.com/apache/geode/pull/5472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] pivotal-jbarrett opened a new pull request #5475: Wip/ephemeral member ports and non dockerization

2020-08-24 Thread GitBox
pivotal-jbarrett opened a new pull request #5475: URL: https://github.com/apache/geode/pull/5475 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] lgtm-com[bot] commented on pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-24 Thread GitBox
lgtm-com[bot] commented on pull request #5473: URL: https://github.com/apache/geode/pull/5473#issuecomment-679329116 This pull request **fixes 34 alerts** when merging 45f04b8da7c3071352c3805af465896cf13406f3 into afb161fe793ebaede473c996e88cc161b9c5b6f5 - [view on

[GitHub] [geode] smgoller opened a new pull request #5474: Part 2 - Change all tests to use liberica instead of openjdk. Part 3 will remove openjdk.

2020-08-24 Thread GitBox
smgoller opened a new pull request #5474: URL: https://github.com/apache/geode/pull/5474 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] sabbeyPivotal commented on pull request #5472: GEODE-8451 Redis ping response contains unneeded quotes

2020-08-24 Thread GitBox
sabbeyPivotal commented on pull request #5472: URL: https://github.com/apache/geode/pull/5472#issuecomment-679355527 AcceptanceTest failure is unrelated to this PR This is an automated message from the Apache Git Service. To

[GitHub] [geode-native] pdxcodemonkey merged pull request #640: GEODE-8445: Remove copy step for cryptoimpl library

2020-08-24 Thread GitBox
pdxcodemonkey merged pull request #640: URL: https://github.com/apache/geode-native/pull/640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above