[GitHub] [geode-native] alb3rtobr commented on pull request #648: GEODE-8480: Add txmanager check in tx example

2020-09-17 Thread GitBox
alb3rtobr commented on pull request #648: URL: https://github.com/apache/geode-native/pull/648#issuecomment-694081548 Dont worry, I think its not needed to split this in two different tickets, I will try to write a test when I find time. Im moving this PR to draft in the meanwhile.

[GitHub] [geode] jdeppe-pivotal merged pull request #5522: GEODE-8503: Limit netty threads used in PubSubDUnitTest

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5522: URL: https://github.com/apache/geode/pull/5522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] onichols-pivotal commented on pull request #5523: GEODE-8505: Upgrade netty from 4.1.48 to 4.1.52

2020-09-17 Thread GitBox
onichols-pivotal commented on pull request #5523: URL: https://github.com/apache/geode/pull/5523#issuecomment-694437262 as a general rule for bumping dependencies, `git grep 4\\.1\\.48` for everywhere the version appears so you don't miss any files

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5523: GEODE-8505: Upgrade netty from 4.1.48 to 4.1.52

2020-09-17 Thread GitBox
jdeppe-pivotal opened a new pull request #5523: URL: https://github.com/apache/geode/pull/5523 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jhuynh1 opened a new pull request #5524: WIP: Changes for usability

2020-09-17 Thread GitBox
jhuynh1 opened a new pull request #5524: URL: https://github.com/apache/geode/pull/5524 Create DiskStore REST API This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [geode] jdeppe-pivotal merged pull request #5523: GEODE-8505: Upgrade netty from 4.1.48 to 4.1.52

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5523: URL: https://github.com/apache/geode/pull/5523 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt opened a new pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-17 Thread GitBox
bschuchardt opened a new pull request #5525: URL: https://github.com/apache/geode/pull/5525 …han requested Create a "slice" of the acquired buffer to return to the caller instead of returning a buffer larger than what was requested. On return we fish out the parent buffer and

[GitHub] [geode] echobravopapa commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-17 Thread GitBox
echobravopapa commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r490616848 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -98,14 +101,18 @@ private ByteBuffer

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-17 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r490648118 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java ## @@ -133,27 +135,42 @@ public void

[GitHub] [geode] sabbeyPivotal commented on pull request #5518: GEODE-8499: Redis subscriptions leak if they are not explicitly unsubscribed

2020-09-17 Thread GitBox
sabbeyPivotal commented on pull request #5518: URL: https://github.com/apache/geode/pull/5518#issuecomment-694225105 Distributed test failure is unrelated to this PR This is an automated message from the Apache Git Service.

[GitHub] [geode] jdeppe-pivotal merged pull request #5518: GEODE-8499: Redis subscriptions leak if they are not explicitly unsubscribed

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5518: URL: https://github.com/apache/geode/pull/5518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] mreddington closed pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-17 Thread GitBox
mreddington closed pull request #650: URL: https://github.com/apache/geode-native/pull/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5522: GEODE-8503: Limit netty threads used in PubSubDUnitTest

2020-09-17 Thread GitBox
jdeppe-pivotal opened a new pull request #5522: URL: https://github.com/apache/geode/pull/5522 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jdeppe-pivotal commented on pull request #5522: GEODE-8503: Limit netty threads used in PubSubDUnitTest

2020-09-17 Thread GitBox
jdeppe-pivotal commented on pull request #5522: URL: https://github.com/apache/geode/pull/5522#issuecomment-694319828 @sabbey @ringles @jhutchison for your review... This is an automated message from the Apache Git Service.

[GitHub] [geode-native] alb3rtobr opened a new pull request #651: Remove bucketServerLocation if timeout error

2020-09-17 Thread GitBox
alb3rtobr opened a new pull request #651: URL: https://github.com/apache/geode-native/pull/651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-17 Thread GitBox
albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r490270113 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] jdeppe-pivotal merged pull request #5511: GEODE-8493: Redis idle clients can cause server stuck thread warning

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5511: URL: https://github.com/apache/geode/pull/5511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] dschneider-pivotal merged pull request #5521: GEODE-8500: Tests for Redis QUIT command

2020-09-17 Thread GitBox
dschneider-pivotal merged pull request #5521: URL: https://github.com/apache/geode/pull/5521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal closed pull request #5513: changed PubSubDUnitTest

2020-09-17 Thread GitBox
dschneider-pivotal closed pull request #5513: URL: https://github.com/apache/geode/pull/5513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above