[GitHub] [geode] dickcav opened a new pull request #7447: GEODE-10100: Replace 1.13.7 with 1.13.8 as old version

2022-03-15 Thread GitBox
dickcav opened a new pull request #7447: URL: https://github.com/apache/geode/pull/7447 Replace 1.13.7 with 1.13.8 in old versions on develop to enable rolling upgrade tests from 1.13.8 The serialization version has not changed between 1.13.7 and 1.13.8, so there should be no

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7403: GEODE-9953: Implement LTRIM Command

2022-03-15 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7403: URL: https://github.com/apache/geode/pull/7403#discussion_r827418512 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LTrimDUnitTest.java ## @@ -0,0 +1,184

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7403: GEODE-9953: Implement LTRIM Command

2022-03-15 Thread GitBox
dschneider-pivotal commented on a change in pull request #7403: URL: https://github.com/apache/geode/pull/7403#discussion_r827462119 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ## @@ -127,50 +127,139 @@ private int

[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #7403: GEODE-9953: Implement LTRIM Command

2022-03-15 Thread GitBox
nonbinaryprogrammer commented on a change in pull request #7403: URL: https://github.com/apache/geode/pull/7403#discussion_r827502777 ## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractLTrimIntegrationTest.java

[GitHub] [geode] jchen21 commented on a change in pull request #7440: GEODE-10039: Fix the issue that BucketProfile can be stale in rare cases.

2022-03-15 Thread GitBox
jchen21 commented on a change in pull request #7440: URL: https://github.com/apache/geode/pull/7440#discussion_r827457762 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java ## @@ -180,19 +180,23 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7396: GEODE-9952: Support LSET Command

2022-03-15 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7396: URL: https://github.com/apache/geode/pull/7396#discussion_r827589901 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LSetExecutor.java ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7396: GEODE-9952: Support LSET Command

2022-03-15 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7396: URL: https://github.com/apache/geode/pull/7396#discussion_r827589901 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LSetExecutor.java ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [geode] mivanac closed pull request #7114: GEODE-9642: skip RedundancyRecovery for colocated regions, if colocat…

2022-03-15 Thread GitBox
mivanac closed pull request #7114: URL: https://github.com/apache/geode/pull/7114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] gesterzhou commented on a change in pull request #7440: GEODE-10039: Fix the issue that BucketProfile can be stale in rare cases.

2022-03-15 Thread GitBox
gesterzhou commented on a change in pull request #7440: URL: https://github.com/apache/geode/pull/7440#discussion_r826633575 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/RebalanceWhileCreatingRegionDistributedTest.java ## @@ -0,0 +1,298 @@

[GitHub] [geode] jvarenina opened a new pull request #7443: GEODE-10123: Improve create region checks

2022-03-15 Thread GitBox
jvarenina opened a new pull request #7443: URL: https://github.com/apache/geode/pull/7443 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7396: GEODE-9952: Support LSET Command

2022-03-15 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7396: URL: https://github.com/apache/geode/pull/7396#discussion_r826989730 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LSetExecutor.java ## @@ -0,0 +1,59 @@ +/* + *

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7418: GEODE-9951:Add support for RPOP.

2022-03-15 Thread GitBox
jdeppe-pivotal commented on a change in pull request #7418: URL: https://github.com/apache/geode/pull/7418#discussion_r827142797 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LPopDUnitTest.java ## @@ -141,20

[GitHub] [geode] jinmeiliao commented on a change in pull request #7416: GEODE-10097: Avoid Thread.sleep for reauthentication in MessageDispatcher

2022-03-15 Thread GitBox
jinmeiliao commented on a change in pull request #7416: URL: https://github.com/apache/geode/pull/7416#discussion_r827193959 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/MessageDispatcher.java ## @@ -432,34 +442,38 @@ protected void

[GitHub] [geode] nabarunnag commented on pull request #7387: GEODE-8140: Set scope field in gfsh.

2022-03-15 Thread GitBox
nabarunnag commented on pull request #7387: URL: https://github.com/apache/geode/pull/7387#issuecomment-1068229025 @jinmeiliao if you feel all concerns are addressed, can you approve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7440: GEODE-10039: Fix the issue that BucketProfile can be stale in rare cases.

2022-03-15 Thread GitBox
dschneider-pivotal commented on a change in pull request #7440: URL: https://github.com/apache/geode/pull/7440#discussion_r827147415 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/DestroyRegionOperation.java ## @@ -167,32 +167,23 @@ public void run() {

[GitHub] [geode] jinmeiliao commented on a change in pull request #7416: GEODE-10097: Avoid Thread.sleep for reauthentication in MessageDispatcher

2022-03-15 Thread GitBox
jinmeiliao commented on a change in pull request #7416: URL: https://github.com/apache/geode/pull/7416#discussion_r827159691 ## File path: geode-core/src/distributedTest/java/org/apache/geode/security/AuthExpirationDUnitTest.java ## @@ -66,6 +67,12 @@ private ClientVM

[GitHub] [geode] DonalEvans merged pull request #7437: GEODE-10010: Refine per-second Redis stats

2022-03-15 Thread GitBox
DonalEvans merged pull request #7437: URL: https://github.com/apache/geode/pull/7437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] gesterzhou commented on a change in pull request #7440: GEODE-10039: Fix the issue that BucketProfile can be stale in rare cases.

2022-03-15 Thread GitBox
gesterzhou commented on a change in pull request #7440: URL: https://github.com/apache/geode/pull/7440#discussion_r827240916 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java ## @@ -180,19 +180,23 @@ public void

[GitHub] [geode] mivanac merged pull request #7421: GEODE-10104: allow create gateway sender command with dispatch thread…

2022-03-15 Thread GitBox
mivanac merged pull request #7421: URL: https://github.com/apache/geode/pull/7421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] nabarunnag merged pull request #7387: GEODE-8140: Set scope field in gfsh.

2022-03-15 Thread GitBox
nabarunnag merged pull request #7387: URL: https://github.com/apache/geode/pull/7387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7407: GEODE-10087: Enhance off-heap fragmentation visibility.

2022-03-15 Thread GitBox
dschneider-pivotal commented on a change in pull request #7407: URL: https://github.com/apache/geode/pull/7407#discussion_r827251656 ## File path: geode-core/src/main/java/org/apache/geode/internal/offheap/MemoryAllocatorImpl.java ## @@ -55,6 +57,16 @@ public static final

[GitHub] [geode] jhuynh1 opened a new pull request #7444: WIP - Please Ignore

2022-03-15 Thread GitBox
jhuynh1 opened a new pull request #7444: URL: https://github.com/apache/geode/pull/7444 Ide added this. back in... not intending to check this in, just verifying if certaint ests pass/fail with these changes ### For all changes: - [ ] Is there a JIRA ticket associated

[GitHub] [geode] jhuynh1 closed pull request #7444: WIP - Please Ignore

2022-03-15 Thread GitBox
jhuynh1 closed pull request #7444: URL: https://github.com/apache/geode/pull/7444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] DonalEvans commented on a change in pull request #7392: GEODE-9948: Implement LINSERT Command

2022-03-15 Thread GitBox
DonalEvans commented on a change in pull request #7392: URL: https://github.com/apache/geode/pull/7392#discussion_r827259098 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ## @@ -126,6 +127,25 @@ private int getArrayIndex(int

[GitHub] [geode] upthewaterspout commented on a change in pull request #7113: GEODE-9809: stop monitoring of destroyed regions

2022-03-15 Thread GitBox
upthewaterspout commented on a change in pull request #7113: URL: https://github.com/apache/geode/pull/7113#discussion_r827256779 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PersistentBucketRecoverer.java ## @@ -197,17 +209,23 @@ public

[GitHub] [geode] jchen21 commented on a change in pull request #7440: GEODE-10039: Fix the issue that BucketProfile can be stale in rare cases.

2022-03-15 Thread GitBox
jchen21 commented on a change in pull request #7440: URL: https://github.com/apache/geode/pull/7440#discussion_r827385315 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java ## @@ -426,6 +430,23 @@ public void

[GitHub] [geode] jhuynh1 opened a new pull request #7446: WIP - ignore

2022-03-15 Thread GitBox
jhuynh1 opened a new pull request #7446: URL: https://github.com/apache/geode/pull/7446 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit

[GitHub] [geode] jchen21 commented on a change in pull request #7440: GEODE-10039: Fix the issue that BucketProfile can be stale in rare cases.

2022-03-15 Thread GitBox
jchen21 commented on a change in pull request #7440: URL: https://github.com/apache/geode/pull/7440#discussion_r827375306 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java ## @@ -180,19 +180,23 @@ public void

[GitHub] [geode] jinmeiliao merged pull request #7441: GEODE-10092: cleanup unused code

2022-03-15 Thread GitBox
jinmeiliao merged pull request #7441: URL: https://github.com/apache/geode/pull/7441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] jinmeiliao opened a new pull request #7445: GEODE-10092: cleanup unnecessary method arguments

2022-03-15 Thread GitBox
jinmeiliao opened a new pull request #7445: URL: https://github.com/apache/geode/pull/7445 more code cleanup while investigating an issue in this code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] DonalEvans commented on a change in pull request #7418: GEODE-9951:Add support for RPOP.

2022-03-15 Thread GitBox
DonalEvans commented on a change in pull request #7418: URL: https://github.com/apache/geode/pull/7418#discussion_r824918319 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LPopDUnitTest.java ## @@ -141,20 +141,22

[GitHub] [geode] jinmeiliao merged pull request #7416: GEODE-10097: Avoid Thread.sleep for reauthentication in MessageDispatcher

2022-03-15 Thread GitBox
jinmeiliao merged pull request #7416: URL: https://github.com/apache/geode/pull/7416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] DonalEvans commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

2022-03-15 Thread GitBox
DonalEvans commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r825176132 ## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractBLPopIntegrationTest.java ## @@

[GitHub] [geode] Bill opened a new pull request #7449: GEODE-10122: P2P Handles TLS KeyUpdate Message

2022-03-15 Thread GitBox
Bill opened a new pull request #7449: URL: https://github.com/apache/geode/pull/7449 [GEODE-1022](https://issues.apache.org/jira/browse/GEODE-10122) Just getting started here. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in

[GitHub] [geode] jinmeiliao merged pull request #7445: GEODE-10092: cleanup unnecessary method arguments

2022-03-15 Thread GitBox
jinmeiliao merged pull request #7445: URL: https://github.com/apache/geode/pull/7445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] boglesby commented on pull request #7378: GEODE-10056: Improve gateway-receiver load balance

2022-03-15 Thread GitBox
boglesby commented on pull request #7378: URL: https://github.com/apache/geode/pull/7378#issuecomment-1068616384 I'm not sure how to resolve the race condition you mention, but I see similar behavior with client/server connections. If a burst of connections is requested and none of