[GitHub] [geode] onichols-pivotal merged pull request #7447: GEODE-10100: Replace 1.13.7 with 1.13.8 as old version

onichols-pivotal merged pull request #7447: URL: https://github.com/apache/geode/pull/7447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r827967329 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/BLPopDUnitTest.java ## @@ -0,0 +1,100

[GitHub] [geode] mivanac commented on pull request #7113: GEODE-9809: stop monitoring of destroyed regions

mivanac commented on pull request #7113: URL: https://github.com/apache/geode/pull/7113#issuecomment-1069011973 Hi @dschneider-pivotal, are changes OK with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r827965981 ## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractBLPopIntegrationTest.java ##

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r827964327 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/eventing/EventListener.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r827965816 ## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/eventing/EventDistributorTest.java ## @@ -0,0 +1,207 @@ +/*

[GitHub] [geode] mivanac edited a comment on pull request #7113: GEODE-9809: stop monitoring of destroyed regions

mivanac edited a comment on pull request #7113: URL: https://github.com/apache/geode/pull/7113#issuecomment-1069011973 Hi @dschneider-pivotal, are changes OK with you, and can you remove Changes requested on this PR. -- This is an automated message from the Apache Git Service. To

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r827964035 ## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractBLPopIntegrationTest.java ##

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r827964214 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/eventing/EventListener.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[GitHub] [geode] onichols-pivotal commented on pull request #7406: GEODE-10089: update release scripts to handle 1.15

onichols-pivotal commented on pull request #7406: URL: https://github.com/apache/geode/pull/7406#issuecomment-1069494028 after one more test (by way of the 1.14.4 release) this should be ready to merge -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] pivotal-jbarrett opened a new pull request #7450: GEODE-10127: Reverts changes from GEODE-8955.

pivotal-jbarrett opened a new pull request #7450: URL: https://github.com/apache/geode/pull/7450 Reverts 516bdc9322e1068c14e901879a7fb4afeac9b181 These changes inadvertently changed the hostname sent to the remote locators. ### For all changes: - [ ] Is

[GitHub] [geode] mivanac merged pull request #7113: GEODE-9809: stop monitoring of destroyed regions

mivanac merged pull request #7113: URL: https://github.com/apache/geode/pull/7113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7431: GEODE-9946: Add Radish LREM command

dschneider-pivotal commented on a change in pull request #7431: URL: https://github.com/apache/geode/pull/7431#discussion_r828338887 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ## @@ -48,6 +49,33 @@ public RedisList() {

[GitHub] [geode] DonalEvans commented on a change in pull request #7417: GEODE-9954: Implement Radish RPUSH command

DonalEvans commented on a change in pull request #7417: URL: https://github.com/apache/geode/pull/7417#discussion_r828215165 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/RPushDUnitTest.java ## @@ -0,0 +1,211 @@

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

dschneider-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r828304833 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/eventing/BlockingCommandListener.java ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7431: GEODE-9946: Add Radish LREM command

dschneider-pivotal commented on a change in pull request #7431: URL: https://github.com/apache/geode/pull/7431#discussion_r828340856 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/collections/SizeableByteArrayList.java ## @@ -31,6 +33,57 @@

[GitHub] [geode] pivotal-jbarrett merged pull request #7430: GEODE-288: Adds @Deprecated annotation to old admin service.

pivotal-jbarrett merged pull request #7430: URL: https://github.com/apache/geode/pull/7430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] pivotal-jbarrett merged pull request #7450: GEODE-10127: Reverts changes from GEODE-8955.

pivotal-jbarrett merged pull request #7450: URL: https://github.com/apache/geode/pull/7450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] DonalEvans commented on a change in pull request #7417: GEODE-9954: Implement Radish RPUSH command

DonalEvans commented on a change in pull request #7417: URL: https://github.com/apache/geode/pull/7417#discussion_r828215604 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/RPushDUnitTest.java ## @@ -0,0 +1,211 @@

[GitHub] [geode] lgtm-com[bot] commented on pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules.

lgtm-com[bot] commented on pull request #7348: URL: https://github.com/apache/geode/pull/7348#issuecomment-1069381328 This pull request **introduces 6 alerts** and **fixes 1** when merging 361c36fc0f0d63b4bf690d7b6d9129e1157fc62e into b129e58e4a20cda67ff80a728c85e095d491419c - [view on

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7418: GEODE-9951:Add support for RPOP.

dschneider-pivotal commented on a change in pull request #7418: URL: https://github.com/apache/geode/pull/7418#discussion_r828321437 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ## @@ -161,6 +167,26 @@ public int llen() {

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7418: GEODE-9951:Add support for RPOP.

dschneider-pivotal commented on a change in pull request #7418: URL: https://github.com/apache/geode/pull/7418#discussion_r828320817 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ## @@ -143,13 +143,19 @@ public long lpush(List

[GitHub] [geode] onichols-pivotal merged pull request #7434: GEODE-10046: Bump 3rd-party dependency versions

onichols-pivotal merged pull request #7434: URL: https://github.com/apache/geode/pull/7434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

dschneider-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r828311176 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/eventing/BlockingCommandListener.java ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [geode] lgtm-com[bot] commented on pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules.

lgtm-com[bot] commented on pull request #7348: URL: https://github.com/apache/geode/pull/7348#issuecomment-1069567680 This pull request **introduces 6 alerts** and **fixes 1** when merging 51daa368aa7ca97acb790daf4a42534edf67e34d into 9ff27b37cf5cc7a97700c64c77a28eefe8ae9d4a - [view on

[GitHub] [geode] demery-pivotal opened a new pull request #7451: GEODE-10128: Open/export packages for JDK 17

demery-pivotal opened a new pull request #7451: URL: https://github.com/apache/geode/pull/7451 PROBLEM JDK 17 throws exceptions when product and test code attempts to access elements in modules that do not make those elements accessible. SOLUTION Open and export the

[GitHub] [geode] DonalEvans commented on a change in pull request #7392: GEODE-9948: Implement LINSERT Command

DonalEvans commented on a change in pull request #7392: URL: https://github.com/apache/geode/pull/7392#discussion_r828492901 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LInsertDUnitTest.java ## @@ -136,26

[GitHub] [geode] pivotal-eshu opened a new pull request #7452: GEODE-10130: Check containsKey under synchronization.

pivotal-eshu opened a new pull request #7452: URL: https://github.com/apache/geode/pull/7452 * containsKey in HashMap can return false even though the key exists in the map possibly due to map resizes as other concurrent operations occur. Now it will be checked under

[GitHub] [geode] jinmeiliao commented on pull request #7448: GEODE-10092: Prevent tombstone count update in the middle of size count

jinmeiliao commented on pull request #7448: URL: https://github.com/apache/geode/pull/7448#issuecomment-1069681823 > Are there potential performance impacts for this change? Put/Destroy (essentially every operation that would change the tombstone count) will need an extra step to

[GitHub] [geode] mivanac commented on pull request #6909: GEODE-9642: Wait for colocation completed at partitioned region initialization

mivanac commented on pull request #6909: URL: https://github.com/apache/geode/pull/6909#issuecomment-1069569276 Hi, just reminder for @boglesby, @nabarunnag and @gesterzhou, could you review this PR. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] DonalEvans commented on a change in pull request #7392: GEODE-9948: Implement LINSERT Command

DonalEvans commented on a change in pull request #7392: URL: https://github.com/apache/geode/pull/7392#discussion_r828297704 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LInsertDUnitTest.java ## @@ -0,0 +1,182

[GitHub] [geode] DonalEvans commented on a change in pull request #7452: GEODE-10130: Check containsKey under synchronization.

DonalEvans commented on a change in pull request #7452: URL: https://github.com/apache/geode/pull/7452#discussion_r828491040 ## File path: geode-cq/src/test/java/org/apache/geode/cache/query/cq/internal/ServerCQResultsCacheReplicateRegionImplTest.java ## @@ -0,0 +1,101 @@ +/*

[GitHub] [geode] lgtm-com[bot] commented on pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules.

lgtm-com[bot] commented on pull request #7348: URL: https://github.com/apache/geode/pull/7348#issuecomment-1070308451 This pull request **introduces 2 alerts** and **fixes 1** when merging f3c41c091a425b70ca30d0fb2cc5bf3c30396028 into a2f475699c4dfcb1734376dbfb14c208540ce954 - [view on

[GitHub] [geode] DonalEvans commented on a change in pull request #7431: GEODE-9946: Add Radish LREM command

DonalEvans commented on a change in pull request #7431: URL: https://github.com/apache/geode/pull/7431#discussion_r828520584 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ## @@ -148,7 +175,7 @@ public long lpush(List

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r828551150 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/eventing/BlockingCommandListener.java ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [geode] jdeppe-pivotal commented on pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on pull request #7408: URL: https://github.com/apache/geode/pull/7408#issuecomment-1069766895 @dschneider-pivotal I also made the change of using `JavaWorkarounds.computeIfAbsent`. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode] onichols-pivotal opened a new pull request #7453: Revert "roll develop to 1.16.0 now that support/1.15 has been created"

onichols-pivotal opened a new pull request #7453: URL: https://github.com/apache/geode/pull/7453 per dev list discussion on Mar 16, we will roll back the support/1.15 branch cut and return develop to being 1.15 until we are in a better place to try cutting the branch again -- This is

[GitHub] [geode] pivotal-eshu removed a comment on pull request #7452: GEODE-10130: Check containsKey under synchronization.

pivotal-eshu removed a comment on pull request #7452: URL: https://github.com/apache/geode/pull/7452#issuecomment-1069745973 Originally I was trying to see if the test written can fail repeatably, so same random seed can make the test more likely to fail repeatedly. Once fix is there, I

[GitHub] [geode] pivotal-eshu commented on a change in pull request #7452: GEODE-10130: Check containsKey under synchronization.

pivotal-eshu commented on a change in pull request #7452: URL: https://github.com/apache/geode/pull/7452#discussion_r828535429 ## File path: geode-cq/src/test/java/org/apache/geode/cache/query/cq/internal/ServerCQResultsCacheReplicateRegionImplTest.java ## @@ -0,0 +1,101 @@

[GitHub] [geode] pivotal-eshu commented on pull request #7452: GEODE-10130: Check containsKey under synchronization.

pivotal-eshu commented on pull request #7452: URL: https://github.com/apache/geode/pull/7452#issuecomment-1069745973 Originally I was trying to see if the test written can fail repeatably, so same random seed can make the test more likely to fail repeatedly. Once fix is there, I think

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #7408: GEODE-10048: Add framework for Redis events and BLPOP command

jdeppe-pivotal commented on a change in pull request #7408: URL: https://github.com/apache/geode/pull/7408#discussion_r828549463 ## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/eventing/BlockingCommandListener.java ## @@ -0,0 +1,121 @@ +/* + *

[GitHub] [geode] lgtm-com[bot] commented on pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules.

lgtm-com[bot] commented on pull request #7348: URL: https://github.com/apache/geode/pull/7348#issuecomment-1069742534 This pull request **introduces 2 alerts** and **fixes 1** when merging ce9b4bfbf0039554bfdf8cc61c2639b3dbcebab6 into 9ff27b37cf5cc7a97700c64c77a28eefe8ae9d4a - [view on

[GitHub] [geode-native] moleske opened a new pull request #947: Remove set but unused variables

moleske opened a new pull request #947: URL: https://github.com/apache/geode-native/pull/947 - On AppleClang 13.1.6.13160021, the warning -Wunused-but-set-variable is appears as an error. This allows compilation on AppleClang on MacOS 12.3 Authored-by: M. Oleske --

[GitHub] [geode] nonbinaryprogrammer commented on a change in pull request #7392: GEODE-9948: Implement LINSERT Command

nonbinaryprogrammer commented on a change in pull request #7392: URL: https://github.com/apache/geode/pull/7392#discussion_r828542347 ## File path: geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LInsertDUnitTest.java ## @@

[GitHub] [geode] onichols-pivotal merged pull request #7453: Revert "roll develop to 1.16.0 now that support/1.15 has been created"

onichols-pivotal merged pull request #7453: URL: https://github.com/apache/geode/pull/7453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] lgtm-com[bot] commented on pull request #7348: GEODE-8705: Introduce classloader isolation for deployments using JBoss Modules.

lgtm-com[bot] commented on pull request #7348: URL: https://github.com/apache/geode/pull/7348#issuecomment-1070048680 This pull request **introduces 2 alerts** and **fixes 1** when merging b80316f56b1e761ce534b194d3f5c5cb056a8e58 into a2f475699c4dfcb1734376dbfb14c208540ce954 - [view on