[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout

mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1120843776 @echobravopapa, @kamilla1201, @Bill, can you please review this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [geode] mivanac commented on pull request #7515: GEODE-10020: For Ping task avoid registering new destination endpoint

mivanac commented on PR #7515: URL: https://github.com/apache/geode/pull/7515#issuecomment-1121065697 Hi @kirklund, just a reminder, could you comment if something needs to be changed, or remove changes requested. -- This is an automated message from the Apache Git Service. To

[GitHub] [geode] mivanac commented on pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage

mivanac commented on PR #7323: URL: https://github.com/apache/geode/pull/7323#issuecomment-1121064843 Hi @kirklund , are changes OK with you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7652: GEODE-10271: ConnectionProxyJUnitTest cleanup

pivotal-jbarrett commented on code in PR #7652: URL: https://github.com/apache/geode/pull/7652#discussion_r868152259 ## geode-core/src/integrationTest/java/org/apache/geode/internal/cache/tier/sockets/ConnectionProxyJUnitTest.java: ## @@ -19,753 +19,377 @@ package

[GitHub] [geode] onichols-pivotal merged pull request #7668: GEODE-10089: roll develop to 1.16.0 now that support/1.15 has been created

onichols-pivotal merged PR #7668: URL: https://github.com/apache/geode/pull/7668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [geode] jdeppe-pivotal commented on a diff in pull request #7666: GEODE-10284: Add partition-listener option to gfsh create region command

jdeppe-pivotal commented on code in PR #7666: URL: https://github.com/apache/geode/pull/7666#discussion_r868200094 ## geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java: ## @@ -168,6 +169,8 @@ public ResultModel createRegion(

[GitHub] [geode] jdeppe-pivotal commented on a diff in pull request #7600: Remove problematic buildSrc project, replacing with includeBuild projects

jdeppe-pivotal commented on code in PR #7600: URL: https://github.com/apache/geode/pull/7600#discussion_r868259385 ## build.gradle: ## @@ -29,16 +29,21 @@ plugins { id "org.ajoberstar.grgit" version "4.1.1" apply false id "org.nosphere.apache.rat" version "0.7.1" apply

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7666: GEODE-10284: Add partition-listener option to gfsh create region command

jinmeiliao commented on code in PR #7666: URL: https://github.com/apache/geode/pull/7666#discussion_r868198619 ## geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java: ## @@ -168,6 +169,8 @@ public ResultModel createRegion(

[GitHub] [geode] jinmeiliao commented on a diff in pull request #7652: GEODE-10271: ConnectionProxyJUnitTest cleanup

jinmeiliao commented on code in PR #7652: URL: https://github.com/apache/geode/pull/7652#discussion_r868201573 ## geode-core/src/integrationTest/java/org/apache/geode/internal/cache/tier/sockets/ConnectionProxyJUnitTest.java: ## @@ -19,753 +19,377 @@ package

[GitHub] [geode] jdeppe-pivotal commented on a diff in pull request #7600: Remove problematic buildSrc project, replacing with includeBuild projects

jdeppe-pivotal commented on code in PR #7600: URL: https://github.com/apache/geode/pull/7600#discussion_r868260710 ## buildScripts/src/main/groovy/code-analysis.gradle: ## @@ -15,61 +15,85 @@ * limitations under the License. */ -if (project.hasProperty("staticAnalysis"))

[GitHub] [geode] rhoughton-pivot commented on a diff in pull request #7600: Remove problematic buildSrc project, replacing with includeBuild projects

rhoughton-pivot commented on code in PR #7600: URL: https://github.com/apache/geode/pull/7600#discussion_r868260864 ## build.gradle: ## @@ -29,16 +29,21 @@ plugins { id "org.ajoberstar.grgit" version "4.1.1" apply false id "org.nosphere.apache.rat" version "0.7.1" apply

[GitHub] [geode] lgtm-com[bot] commented on pull request #7668: GEODE-10089: roll develop to 1.16.0 now that support/1.15 has been created

lgtm-com[bot] commented on PR #7668: URL: https://github.com/apache/geode/pull/7668#issuecomment-1121294848 LGTM pull request analysis was skipped for 8d7065dea1773e073a4bc44a3b895987cb78b889 by [onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future commits will

[GitHub] [geode] jdeppe-pivotal commented on a diff in pull request #7666: GEODE-10284: Add partition-listener option to gfsh create region command

jdeppe-pivotal commented on code in PR #7666: URL: https://github.com/apache/geode/pull/7666#discussion_r868200094 ## geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java: ## @@ -168,6 +169,8 @@ public ResultModel createRegion(

[GitHub] [geode] dschneider-pivotal commented on a diff in pull request #7667: GEODE-10226: Added monitoring of async writer

dschneider-pivotal commented on code in PR #7667: URL: https://github.com/apache/geode/pull/7667#discussion_r868325789 ## geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java: ## @@ -1716,67 +1723,78 @@ void doAsyncFlush() { logger.debug("Async

[GitHub] [geode] gesterzhou opened a new pull request, #7670: [Don't review]: GEODE-10290: GII requester should remove departed members

gesterzhou opened a new pull request, #7670: URL: https://github.com/apache/geode/pull/7670 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit

[GitHub] [geode] lgtm-com[bot] commented on pull request #7666: GEODE-10284: Add partition-listener option to gfsh create region command

lgtm-com[bot] commented on PR #7666: URL: https://github.com/apache/geode/pull/7666#issuecomment-1121668439 LGTM pull request analysis was skipped for d2e5ed404c26c7cba5f50414c73281c27dfb7a94 by [onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future commits will

[GitHub] [geode] rhoughton-pivot opened a new pull request, #7669: wip - codeql instead of lgtm

rhoughton-pivot opened a new pull request, #7669: URL: https://github.com/apache/geode/pull/7669 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest

[GitHub] [geode] jinmeiliao commented on pull request #7659: GEODE-10282: Migrate from springfox to springdoc to avoid swagger CVE.

jinmeiliao commented on PR #7659: URL: https://github.com/apache/geode/pull/7659#issuecomment-1121677376 we have a go client that is a consumer of the swagger doc to issue management rest api command and parse it's result. This will break that tool. I know it is out of the scope of this

[GitHub] [geode] lgtm-com[bot] commented on pull request #7666: GEODE-10284: Add partition-listener option to gfsh create region command

lgtm-com[bot] commented on PR #7666: URL: https://github.com/apache/geode/pull/7666#issuecomment-1121894560 LGTM pull request analysis was skipped for a8790f9d66b669106554e54b6904b42695ff44cc by [jdeppe-pivotal](https://github.com/jdeppe-pivotal). Analysis of future commits will happen as

[GitHub] [geode] jdeppe-pivotal opened a new pull request, #7671: GEODE-10284: Add partition-listener option to gfsh create region command (#7666)

jdeppe-pivotal opened a new pull request, #7671: URL: https://github.com/apache/geode/pull/7671 * Update documentation Co-authored-by: Dave Barnes (cherry picked from commit d4b80d27277d3eda22f692cf95d95026096470d5) ### For all changes: - [ ] Is there

[GitHub] [geode] lgtm-com[bot] commented on pull request #7671: GEODE-10284: Add partition-listener option to gfsh create region command (#7666)

lgtm-com[bot] commented on PR #7671: URL: https://github.com/apache/geode/pull/7671#issuecomment-1121945899 LGTM pull request analysis was skipped for 866f459e4e8939af312700705f17550e59a5ace5 by [onichols-pivotal](https://github.com/onichols-pivotal). Analysis of future commits will

[GitHub] [geode-native] moleske opened a new pull request, #966: GEODE-10291: Compile on ubuntu jammy (gcc/g++ 11.2.0)

moleske opened a new pull request, #966: URL: https://github.com/apache/geode-native/pull/966 Initially failed to compile because it could not find `sleep_for` (was undefined) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [geode-native] moleske opened a new pull request, #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI

moleske opened a new pull request, #968: URL: https://github.com/apache/geode-native/pull/968 I don't have ami credentials nor concourse credentials to test any of this, so I will need some help if this should be wanted in CI -- This is an automated message from the Apache Git Service.

[GitHub] [geode-native] moleske opened a new pull request, #967: GEODE-10292: Bump to boost 1.79.0

moleske opened a new pull request, #967: URL: https://github.com/apache/geode-native/pull/967 Initially complained that it did not know what `boost::filesystem::ofstream` before adding the header file -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [geode] jdeppe-pivotal merged pull request #7666: GEODE-10284: Add partition-listener option to gfsh create region command

jdeppe-pivotal merged PR #7666: URL: https://github.com/apache/geode/pull/7666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: