[GitHub] [geode] albertogpz merged pull request #7854: GEODE-10420: Finish distribute() work if interrupted

2022-09-12 Thread GitBox


albertogpz merged PR #7854:
URL: https://github.com/apache/geode/pull/7854


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] jvarenina commented on pull request #7854: GEODE-10420: Finish distribute() work if interrupted

2022-09-12 Thread GitBox


jvarenina commented on PR #7854:
URL: https://github.com/apache/geode/pull/7854#issuecomment-1243568103

   Looks good to me! No comments from my side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode-native] gaussianrecurrence opened a new pull request, #984: GEODE-10414: Implement Region::putIfAbsent method

2022-09-12 Thread GitBox


gaussianrecurrence opened a new pull request, #984:
URL: https://github.com/apache/geode-native/pull/984

   - Moved PUT actions from LocalRegion into its own modules.
   - Added PutIfAbsent action.
   - Added the necessary scaffolding for put requests to return a value.
   - Moved TcrMessagePut implementation into its own file. Now this message
 type accepts an operation as input.
   - Moved TcrMessageDestroy implementation into its own file. Now this
 message accepts an operation as input.
   - Also, updated TcrMessageDestroy operation format so it uses a byte
 part instead of an object.
   - Added putIfAbsent method to the Region interface and its
 implementations both for LocalRegion and ThinClientRegion.
   - Modified LocalRegion and ThinClientRegion to comply with the above
 code changes.
   - Modified PUT's old value parsing to handle null pointer.
   - Also replaced Cacheable type by Serializable in some places in order
 in order to take advantage of fast-forward definition.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] albertogpz opened a new pull request, #7854: GEODE-10420: Finish distribute() work if interrupted

2022-09-12 Thread GitBox


albertogpz opened a new pull request, #7854:
URL: https://github.com/apache/geode/pull/7854

   It is possible that an event of which a gateway sender is to be notified is 
lost if during the process the thread is interrupted.
   
   The reason is that the distribute() method
   in the AbstractGatewaySender when it catches the
   InterruptedException at some point, just returns, but does not put the event 
in the queue and neither
   drops it.
   
   The fix consists of handling the event correctly
   (put it in the queue or drop it) if the InterruptedException is caught but 
when the method returns set again
   the interrupt flag so that the caller is aware.
   
   
   
   
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] albertogpz closed pull request #7852: Finish distribute() work if interrupted

2022-09-12 Thread GitBox


albertogpz closed pull request #7852: Finish distribute() work if interrupted
URL: https://github.com/apache/geode/pull/7852


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] albertogpz merged pull request #7839: GEODE-10409: Fix rebalance load model missing collocated regions at s…

2022-09-12 Thread GitBox


albertogpz merged PR #7839:
URL: https://github.com/apache/geode/pull/7839


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] mkevo merged pull request #7853: GEODE-9484: Improve sending message to multy destinations (#7664)

2022-09-12 Thread GitBox


mkevo merged PR #7853:
URL: https://github.com/apache/geode/pull/7853


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] mkevo opened a new pull request, #7853: GEODE-9484: Improve sending message to multy destinations (#7664)

2022-09-12 Thread GitBox


mkevo opened a new pull request, #7853:
URL: https://github.com/apache/geode/pull/7853

   
   
   
   
   
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [geode] albertogpz opened a new pull request, #7852: Finish distribute() work if interrupted

2022-09-12 Thread GitBox


albertogpz opened a new pull request, #7852:
URL: https://github.com/apache/geode/pull/7852

   
   
   
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org