Merged with #372
[ Full content available at: https://github.com/apache/geode-native/pull/371 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/371 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/372 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
What this is doing is trying to avoid a lot of unnecessary padding that can
bloat the size of you objects in memory. The order is important because certain
types will have to pad out to fix the alignment types. For example, I can't
have an int that starts after a single boolean without padding
What exactly does this do? It looks like you've swapped around initialization
order and perhaps declaration order of a bunch of member variables in several
classes. I'm familiar with having to do this quite often to get rid of
compiler warnings when using gcc, but this is Clang and referring
[ Full content available at: https://github.com/apache/geode-native/pull/371 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/370 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Oh, no it is worse. There was a directory, deleted by this, called `fwk` that
linked to this library. This library was always named `framework` but was a
transitive dependency through `fwk`. The `framework` library is in a directory
called, wait for it "fwklib".
[ Full content available
unfortunate that the comment made this wrap
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
excellent rename(s)
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dhemery ]
[ Full content available at: https://github.com/apache/geode/pull/2579 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I'm fine with this change, but I do wonder if there is simpler way to do this
in gradle - I think the exclude can take a closure, so maybe something like
this would work?
```
exclude {it.path.contains('/out/') && !it.path.contains('/ci'}
```
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2577 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2574 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Removes unused sources.
[ Full content available at: https://github.com/apache/geode-native/pull/370 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Is this worth some discussion on the `dev` list? I would think that any pre
`1.8` or `1.9` version of Geode shouldn't be expected to support Java 9+. Even
if this is all it takes to pass the tests as they currently stand, it feels
like a suckerpunch waiting to happen to run tests that aren't
Eh, I would rather find a way to keep the build file simple. Instead of
writing gradle code to work around this, how `bout changing the file names...?
[ Full content available at: https://github.com/apache/geode/pull/2548 ]
This message was relayed via gitbox.apache.org for
Well that’s just downright a big in Gradle then. Any open tickets on the issue?
[ Full content available at: https://github.com/apache/geode/pull/2548 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
19 matches
Mail list logo
