> Descriptive text looks fine. Alerts about updating the corresponding user
> guide passages may be helpful, but one wonders if they're truly necessary.
> Shouldn't developers _always_ check behavioral changes against the
> documentation? Never mind, silly question :)
I agree in an ideal world
This is the same PR as #3935, except that the FileDescriptorMetrics binder
tests are ignored on Windows. @kirklund @demery-pivotal @mhansonp
[ Full content available at: https://github.com/apache/geode/pull/3938 ]
This message was relayed via gitbox.apache.org for
Add the following Micrometer binders:
- JvmGcMetrics
- ProcessorMetrics
- JvmThreadMetrics
- UptimeMetrics
- FileDescriptorMetrics
Ignore FileDescriptorMetrics binder tests on Windows
Co-authored-by: Aaron Lindsey
Co-authored-by: Kirk Lund
Thank you for submitting a contribution to Apache
@bschuchardt (Not sure if my editing made this more readable or not) I'm
actually a little worried about merging this change in. Without this change,
LynnG encountered a failure which I think might occur more if we merge this in.
LynnG's analysis:
In this run we are expecting
@bschuchardt I'm actually a little worried about merging this change in.
Without this change, LynnG encountered a failure which I think might occur more
if we merge this in.
In this run we are expecting ForcedDisconnects, but they don't occur until
after the hang is declared.
The difference
@bschuchardt I'm actually a little worried about merging this change in.
Without this change, LynnG encountered a failure which I think might occur more
if we merge this in.
In this run we are expecting ForcedDisconnects, but they don't occur until
after the hang is declared.
The difference
[ pull request closed by mhansonp ]
[ Full content available at: https://github.com/apache/geode/pull/3915 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
My bad. :(
Thanks,
Mark
[ Full content available at: https://github.com/apache/geode/pull/3935 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
You can also filter Put and Get benchmarks this way:
--tests *GetBenchmark --tests *PutBenchmark
[ Full content available at: https://github.com/apache/geode/pull/3931 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
My bad. :(
Thanks,
Mark
> On Aug 15, 2019, at 2:56 PM, M. Oleske wrote:
>
> It may have been good to let the acceptance test and distributed test finish
> (especially since there was a new acceptance test)
>
> —
> You are receiving this because you modified the open/close state.
> Reply to
I think just checking that `get_addr()` is not `nullptr` should suffice.
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This pull request **introduces 3 alerts** and **fixes 4** when merging
5370329c81dcddd26ecfff3d68583d6e768b82fa into
86fd74db98b5dff0e92ea4985651f3955c1a3420 - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-d87bd3bb50d8ac1ee1c63bf986d3ff0b6b44e505)
**new alerts:**
* 3 for
[ pull request closed by mhansonp ]
[ Full content available at: https://github.com/apache/geode/pull/3935 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
Add the following Micrometer binders:
- JvmGcMetrics
- ProcessorMetrics
- JvmThreadMetrics
- UptimeMetrics
- FileDescriptorMetrics
Co-authored-by: Aaron Lindsey
Co-authored-by: Kirk Lund
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the
[ Full content available at: https://github.com/apache/geode/pull/3934 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Not sure how those made their way into these commits, I'll remove them
[ Full content available at: https://github.com/apache/geode/pull/3932 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Same as before: we need to remove the ` System.out.println` call.
[ Full content available at: https://github.com/apache/geode/pull/3932 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Same as before: we need to remove the ` System.out.println` call.
[ Full content available at: https://github.com/apache/geode/pull/3932 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Same as before: we need to remove the ` System.out.println` call.
[ Full content available at: https://github.com/apache/geode/pull/3932 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Same as before: we need to remove the ` System.out.println` call.
[ Full content available at: https://github.com/apache/geode/pull/3932 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has
Well, this is in the else clause - we we know that newVersion <=
bitSetVersion+bitSet.size(). But maybe it would have been better to use
Math.toIntExact here to validate that.
[ Full content available at: https://github.com/apache/geode/pull/3922 ]
This message was relayed via gitbox.apache.org
larger
[ Full content available at: https://github.com/apache/geode/pull/3922 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
typo `maxmimumClearBit`
[ Full content available at: https://github.com/apache/geode/pull/3922 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Sorry for dumb questions, but is this cast safe? Is it possible newVersion -
bitSetVersion could be > Integer.MAX_VALUE e.g. if newVersion were
Long.MAX_VALUE and bitSetVersion were 1, or do we know contextually that is not
possible here?
[ Full content available at:
* add tasks that run benchmark with SSL
* pass option to run benchmark script
Signed-off-by: Murtuza Boxwala
* create cluster for SSL with a different cluster tag
* filter the tests run with SSL
* run the SSL and non-SSL tasks in parallel
Thank you for submitting a contribution to Apache
This pull request **introduces 1 alert** and **fixes 1** when merging
51e25b17f55d107901c434449e180ab17a69c24d into
6f4bbbd96bcecdb82cf7753ce1dae9fa6baebf9b - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-5b70645175cd713c75738f8564fea692ad6ee9b9)
**new alerts:**
* 1 for
This is modified, because for IPV6, where ever method get_ip_address() is
called, error is reported, and get_addr() must be used. I added this check, to
verify is hostname resolved.
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/3908 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/3922 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is where I would just put the host adder into the vector so there is no
question of ownership later.
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Comment not valid anymore.
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Can we create a common method so we don't have duplicate IPv4 and IPv6 code in
multiple places?
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Perhaps add a `void writeBytes(const std::vector& bytes)` method to
DataOutput?
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why not make the caller send this object the vector? Then the ambiguity of the
`hostAddrLocalMem` check goes away. The owner is always the caller making the
conversion to a vector.
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via
Doesn't ACE has some encapsulation for host addr, not that I won't to increase
our use of ACE but better that then our own invention right now?
[ Full content available at: https://github.com/apache/geode-native/pull/510 ]
This message was relayed via gitbox.apache.org for
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
add unit test coverage for this method to RegionConfigRealizer. It would be
good for that method to verify that this method does the right thing for every
RegionType and that the attributes we support make it to the RegionFactory.
[ Full content available at:
[ pull request closed by jujoramos ]
[ Full content available at: https://github.com/apache/geode/pull/3897 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Technically (at least considering shell semantics) `~foo` is legitimate (it
expands to the home directory of the `foo` user if that user exists) but I
don't think we should attempt to expand that.
[ Full content available at: https://github.com/apache/geode/pull/3927 ]
This message was relayed
41 matches
Mail list logo
