[GitHub] [geode] agingade commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417710113 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClearPartitionedRegion.java ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache

[GitHub] [geode] agingade commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417709848 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClearPartitionedRegion.java ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache

[GitHub] [geode] agingade commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417709662 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClearPartitionedRegion.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache

[GitHub] [geode] agingade commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417706786 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClearPartitionedRegion.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache

[GitHub] [geode] agingade commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417692159 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/ReplicateCacheListenerDistributedTest.java ## @@ -302,4 +349,64 @@ public void

[GitHub] [geode] agingade commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

agingade commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417691691 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/ReplicateCacheListenerDistributedTest.java ## @@ -302,4 +349,64 @@ public void

[GitHub] [geode] onichols-pivotal commented on pull request #4357: DO NOT REVIEW: Parallel GW sender queue restore

onichols-pivotal commented on pull request #4357: URL: https://github.com/apache/geode/pull/4357#issuecomment-621521546 This PR appears to be abandoned. This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode] jchen21 commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

jchen21 commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r417655263 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java ## @@ -521,12 +521,12 @@ void create(InternalCache

[GitHub] [geode] jdeppe-pivotal edited a comment on pull request #5015: GEODE-8036: Redis - Close Zombie TCP Client Connections

jdeppe-pivotal edited a comment on pull request #5015: URL: https://github.com/apache/geode/pull/5015#issuecomment-621504482 I'm not sure whether this was meant to solve GEODE-7998, but here is a test that reproduces the original issue: ```java @Test public void

[GitHub] [geode] jdeppe-pivotal commented on pull request #5015: GEODE-8036: Redis - Close Zombie TCP Client Connections

jdeppe-pivotal commented on pull request #5015: URL: https://github.com/apache/geode/pull/5015#issuecomment-621504482 I'm not sure whether this was meant to solve GEODE-7998, but here is a test that reproduces the original issue: ``` @Test public void

[GitHub] [geode] jchen21 commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

jchen21 commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r417651574 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java ## @@ -1086,6 +1088,32 @@ public static GemFireCacheImpl

[GitHub] [geode] jchen21 commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

jchen21 commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r417650744 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java ## @@ -1086,6 +1088,32 @@ public static GemFireCacheImpl

[GitHub] [geode] boglesby commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r417646301 ## File path: geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache8_0.dtd ## @@ -675,6 +675,7 @@ As of 6.5 roll-oplogs is deprecated. Use

[GitHub] [geode] moleske commented on pull request #5022: GEODE:8042- Create Integrated Distributed/HA test for Redis Module/Sp…

moleske commented on pull request #5022: URL: https://github.com/apache/geode/pull/5022#issuecomment-621486338 > Note: currently intended only for internal team review @jhutchison - GitHub has [draft PRs](https://github.blog/2019-02-14-introducing-draft-pull-requests/), which can

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5022: GEODE:8042- Create Integrated Distributed/HA test for Redis Module/Sp…

sabbeyPivotal commented on a change in pull request #5022: URL: https://github.com/apache/geode/pull/5022#discussion_r417631468 ## File path: geode-redis/src/distributedTest/resources/org/apache/geode/redis/springRedisTestApplication/templates/layout.html ## @@ -0,0 +1,146 @@

[GitHub] [geode] yozaner1324 opened a new pull request #5024: GEODE-8044 - Renamed geode-module to geode-common-services.

yozaner1324 opened a new pull request #5024: URL: https://github.com/apache/geode/pull/5024 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] metatype commented on pull request #5021: GEODE-8037 - Introduce geode-bootstrapping sub-project and create BootstrappingService interface.

metatype commented on pull request #5021: URL: https://github.com/apache/geode/pull/5021#issuecomment-621425929 > > Would it make sense to have an RFC and/or discuss thread to share your ideas about this new submodule? > >

[GitHub] [geode] yozaner1324 opened a new pull request #5023: GEODE-8041 - Introduce geode-uber-management sub-project and create ManagementService interface.

yozaner1324 opened a new pull request #5023: URL: https://github.com/apache/geode/pull/5023 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] kohlmu-pivotal commented on pull request #5021: GEODE-8037 - Introduce geode-bootstrapping sub-project and create BootstrappingService interface.

kohlmu-pivotal commented on pull request #5021: URL: https://github.com/apache/geode/pull/5021#issuecomment-621383545 > Would it make sense to have an RFC and/or discuss thread to share your ideas about this new submodule?

[GitHub] [geode] jhutchison commented on pull request #5022: GEODE:8042- Create Integrated Distributed/HA test for Redis Module/Sp…

jhutchison commented on pull request #5022: URL: https://github.com/apache/geode/pull/5022#issuecomment-621378896 Note: currently intended only for internal team review-- PLEASE DO NOT MERGE UNTIL ADDITIONAL NOTE IS ENTERED CONFIRMING OK TO MERGE-- thanks :) -J

[GitHub] [geode] jhutchison opened a new pull request #5022: GEODE:8042- Create Integrated Distributed/HA test for Redis Module/Sp…

jhutchison opened a new pull request #5022: URL: https://github.com/apache/geode/pull/5022 …ring Session Authored-by: Jens Deppe Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] [geode] BenjaminPerryRoss commented on a change in pull request #4818: GEODE-7667: Add a 'clear' gfsh command for PR and RR clear

BenjaminPerryRoss commented on a change in pull request #4818: URL: https://github.com/apache/geode/pull/4818#discussion_r417510262 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache30/RegionReliabilityTestCase.java ## @@ -1341,7 +1341,7 @@ public void

[GitHub] [geode] BenjaminPerryRoss commented on a change in pull request #4818: GEODE-7667: Add a 'clear' gfsh command for PR and RR clear

BenjaminPerryRoss commented on a change in pull request #4818: URL: https://github.com/apache/geode/pull/4818#discussion_r417509690 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/commands/ClearCommandTest.java ## @@ -0,0 +1,93 @@ +package

[GitHub] [geode] BenjaminPerryRoss commented on a change in pull request #4818: GEODE-7667: Add a 'clear' gfsh command for PR and RR clear

BenjaminPerryRoss commented on a change in pull request #4818: URL: https://github.com/apache/geode/pull/4818#discussion_r417509072 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/commands/ClearCommandTest.java ## @@ -0,0 +1,93 @@ +package

[GitHub] [geode] kirklund commented on pull request #5011: GEODE-8032: Fix unit test and reclassify some tests as integration tests

kirklund commented on pull request #5011: URL: https://github.com/apache/geode/pull/5011#issuecomment-621370295 DistributedTest has an unrelated failure: org.apache.geode.distributed.internal.deadlock.GemFireDeadlockDetectorDUnitTest > testDistributedDeadlockWithDLock FAILED

[GitHub] [geode] metatype commented on pull request #5021: GEODE-8037 - Introduce geode-bootstrapping sub-project and create BootstrappingService interface.

metatype commented on pull request #5021: URL: https://github.com/apache/geode/pull/5021#issuecomment-621360309 Would it make sense to have an RFC and/or discuss thread to share your ideas about this new submodule? This is

[GitHub] [geode] yozaner1324 opened a new pull request #5021: GEODE-8037 - Introduce geode-bootstrapping sub-project and create BootstrappingService interface.

yozaner1324 opened a new pull request #5021: URL: https://github.com/apache/geode/pull/5021 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] yozaner1324 opened a new pull request #5020: GEODE-8033 - Create geode-module sub-project and ModuleService interface.

yozaner1324 opened a new pull request #5020: URL: https://github.com/apache/geode/pull/5020 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] prettyClouds opened a new pull request #5019: Synchronized deltas

prettyClouds opened a new pull request #5019: URL: https://github.com/apache/geode/pull/5019 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] kirklund commented on pull request #5011: GEODE-8032: Fix unit test and reclassify some tests as integration tests

kirklund commented on pull request #5011: URL: https://github.com/apache/geode/pull/5011#issuecomment-621343027 Backing out the changes to BootstrappingFunction restores UpgradeTest to GREEN. I have filed https://issues.apache.org/jira/browse/GEODE-8040 and renamed/moved

[GitHub] [geode] metatype commented on pull request #5018: GEODE-8039: update incorrect versions in LICENSE

metatype commented on pull request #5018: URL: https://github.com/apache/geode/pull/5018#issuecomment-621328260 > It seems that anything we distribute that is licensed under Apache 2.0 License does not need to be called out. However, I found 3 jars that will be in the 1.13 release that

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r417370511 ## File path: geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache8_0.dtd ## @@ -675,6 +675,7 @@ As of 6.5 roll-oplogs is deprecated.

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r417369529 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -1282,22 +1277,90 @@ public

[GitHub] [geode] albertogpz commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-621255116 > If I do this: > > * start site 1 with a sender with batch size = 5 > > * do a transaction with 1 customer and 10 orders > > * don't start site

[GitHub] [geode] prettyClouds commented on pull request #4984: Refactor: Split SetsIntegrationTest into multiple files

prettyClouds commented on pull request #4984: URL: https://github.com/apache/geode/pull/4984#issuecomment-621239878 @jdeppe-pivotal @dschneider-pivotal, I finally got this passing. Can you please take a look at this before it gets stale. merging in changes to the old SetsIntegrationTest

[GitHub] [geode] jujoramos commented on a change in pull request #5004: GEODE-7954: restore redundancy and status redundancy gfsh commands

jujoramos commented on a change in pull request #5004: URL: https://github.com/apache/geode/pull/5004#discussion_r417251767 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/functions/RedundancyCommandFunctionTest.java ## @@ -0,0 +1,137 @@ +/* +

[GitHub] [geode-native] jvarenina commented on a change in pull request #593: GEODE-7944: Fix for QueueConnectionRequest message

jvarenina commented on a change in pull request #593: URL: https://github.com/apache/geode-native/pull/593#discussion_r417243262 ## File path: cppcache/src/QueueConnectionRequest.cpp ## @@ -28,10 +28,10 @@ void QueueConnectionRequest::toData(DataOutput& output) const {

[GitHub] [geode] jujoramos commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

jujoramos commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r417216163 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/ReplicateCacheListenerDistributedTest.java ## @@ -302,4 +349,64 @@ public void