[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r460353365 ## File path: cppcache/src/ExceptionTypes.cpp ## @@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-663787286 This pull request **introduces 2 alerts** and **fixes 2** when merging b22c6e32bb77f0fee4f8c0ac2183f7b86667fc5d into 067194e8f82414b6103c4335beb6567947edcfbc - [view on

[GitHub] [geode] lgtm-com[bot] commented on pull request #5400: GEODE-7864: Fix several LGTM warnings

lgtm-com[bot] commented on pull request #5400: URL: https://github.com/apache/geode/pull/5400#issuecomment-663777444 This pull request **fixes 7 alerts** when merging 0418008cc33c2e351371088ad78b447d0e84da75 into 067194e8f82414b6103c4335beb6567947edcfbc - [view on

[GitHub] [geode] DonalEvans opened a new pull request #5400: GEODE-7864: Fix several LGTM warnings

DonalEvans opened a new pull request #5400: URL: https://github.com/apache/geode/pull/5400 - This commit addresses language-features, logic, useless-code and readability warnings - The change to CompactRangeIndex may be fixing a bug/incorrectness in the code Authored-by:

[GitHub] [geode] DonalEvans closed pull request #5346: GEODE-7864: Fix dereferenced-value-may-be-null alerts

DonalEvans closed pull request #5346: URL: https://github.com/apache/geode/pull/5346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] dschneider-pivotal merged pull request #5349: GEODE-8333: Fix PUBSUB hang

dschneider-pivotal merged pull request #5349: URL: https://github.com/apache/geode/pull/5349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal commented on pull request #5349: GEODE-8333: Fix PUBSUB hang

dschneider-pivotal commented on pull request #5349: URL: https://github.com/apache/geode/pull/5349#issuecomment-663750841 the dunit failure is GEODE-7710 and unrelated to this pull request This is an automated message from

[GitHub] [geode] Bill commented on a change in pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

Bill commented on a change in pull request #5363: URL: https://github.com/apache/geode/pull/5363#discussion_r460299361 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketUtils.java ## @@ -89,6 +89,10 @@ public static boolean close(final ServerSocket

[GitHub] [geode] Bill commented on a change in pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

Bill commented on a change in pull request #5363: URL: https://github.com/apache/geode/pull/5363#discussion_r460298986 ## File path: geode-core/src/main/java/org/apache/geode/internal/tcp/MsgReader.java ## @@ -14,70 +14,65 @@ */ package org.apache.geode.internal.tcp;

[GitHub] [geode] Bill commented on a change in pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

Bill commented on a change in pull request #5363: URL: https://github.com/apache/geode/pull/5363#discussion_r460299130 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketUtilsJUnitTest.java ## @@ -88,4 +95,86 @@ public void

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5349: GEODE-8333: Fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5349: URL: https://github.com/apache/geode/pull/5349#discussion_r460251331 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/pubsub/PublishExecutor.java ## @@ -27,12 +30,34 @@

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5349: GEODE-8333: Fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5349: URL: https://github.com/apache/geode/pull/5349#discussion_r460243756 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -113,17 +114,19 @@ public

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5349: GEODE-8333: Fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5349: URL: https://github.com/apache/geode/pull/5349#discussion_r460243756 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -113,17 +114,19 @@ public

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5349: GEODE-8333: Fix PUBSUB hang

jdeppe-pivotal commented on a change in pull request #5349: URL: https://github.com/apache/geode/pull/5349#discussion_r460228306 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/pubsub/PublishExecutor.java ## @@ -27,12 +30,34 @@ @Override

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5349: GEODE-8333: Fix PUBSUB hang

dschneider-pivotal commented on a change in pull request #5349: URL: https://github.com/apache/geode/pull/5349#discussion_r460163178 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -191,38 +199,121 @@ public

[GitHub] [geode] ringles commented on a change in pull request #5349: GEODE-8333: Fix PUBSUB hang

ringles commented on a change in pull request #5349: URL: https://github.com/apache/geode/pull/5349#discussion_r460149939 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -191,38 +199,121 @@ public void