[GitHub] [geode] sabbeyPivotal closed pull request #5421: Pr2

2020-08-03 Thread GitBox
sabbeyPivotal closed pull request #5421: URL: https://github.com/apache/geode/pull/5421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] sabbeyPivotal opened a new pull request #5421: Pr2

2020-08-03 Thread GitBox
sabbeyPivotal opened a new pull request #5421: URL: https://github.com/apache/geode/pull/5421 test456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode] dschneider-pivotal merged pull request #5419: GEODE-6564: fix entryExpiryTasks leak

2020-08-03 Thread GitBox
dschneider-pivotal merged pull request #5419: URL: https://github.com/apache/geode/pull/5419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464666362 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464666188 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665951 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-03 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668245249 This pull request **introduces 2 alerts** and **fixes 2** when merging 373fdda56c7adb155d9255e2f96eb96993110467 into 54421c4cd5ddde9e459f544fef9f27b44fa1ab6c - [view on

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665517 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464665333 ## File path: ci/pipelines/shared/jinja.variables.yml ## @@ -140,6 +140,19 @@ tests: PLATFORM: linux RAM: '210' name: Upgrade +-

[GitHub] [geode] bschuchardt merged pull request #5413: GEODE-8389: reconnect attempt fails due to distribution configuration…

2020-08-03 Thread GitBox
bschuchardt merged pull request #5413: URL: https://github.com/apache/geode/pull/5413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464647336 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464646511 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464644167 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] dschneider-pivotal commented on pull request #5419: GEODE-6564: fix entryExpiryTasks leak

2020-08-03 Thread GitBox
dschneider-pivotal commented on pull request #5419: URL: https://github.com/apache/geode/pull/5419#issuecomment-668226584 The dunit failure is the known issue: GEODE-7710 This is an automated message from the Apache Git

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
onichols-pivotal commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464644167 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
rhoughton-pivot commented on a change in pull request #5416: URL: https://github.com/apache/geode/pull/5416#discussion_r464641006 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -0,0 +1,51 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [geode] BenjaminPerryRoss commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox
BenjaminPerryRoss commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r464609432 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java ## @@ -274,7 +278,14 @@ "Current number of

[GitHub] [geode] BenjaminPerryRoss commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox
BenjaminPerryRoss commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r464609432 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java ## @@ -274,7 +278,14 @@ "Current number of

[GitHub] [geode] gesterzhou commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox
gesterzhou commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r464583502 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java ## @@ -274,7 +278,14 @@ "Current number of regions

[GitHub] [geode] sabbeyPivotal commented on pull request #5416: GEODE-8382: Run Redis tests against Redis API for Geode

2020-08-03 Thread GitBox
sabbeyPivotal commented on pull request #5416: URL: https://github.com/apache/geode/pull/5416#issuecomment-668168119 @smgoller @rhoughton-pivot @onichols-pivotal @dickcav This is an automated message from the Apache Git

[GitHub] [geode] gesterzhou commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox
gesterzhou commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r464581367 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/CachePerfStats.java ## @@ -274,7 +278,14 @@ "Current number of regions

[GitHub] [geode] gesterzhou commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-03 Thread GitBox
gesterzhou commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r464551192 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionMap.java ## @@ -344,7 +344,12 @@ void incClearCount(LocalRegion

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-03 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-668133588 This pull request **introduces 2 alerts** and **fixes 2** when merging 1e2455c497ed45f195c5b2c4f7b65e08f362d3ca into 54421c4cd5ddde9e459f544fef9f27b44fa1ab6c - [view on

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5420: GEODE-8333: fix pubsub hang

2020-08-03 Thread GitBox
jdeppe-pivotal opened a new pull request #5420: URL: https://github.com/apache/geode/pull/5420 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] dschneider-pivotal opened a new pull request #5419: GEODE-6564: fix entryExpiryTasks leak

2020-08-03 Thread GitBox
dschneider-pivotal opened a new pull request #5419: URL: https://github.com/apache/geode/pull/5419 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] mkevo commented on a change in pull request #5397: GEODE-8293: fix decrementing activeCQCount

2020-08-03 Thread GitBox
mkevo commented on a change in pull request #5397: URL: https://github.com/apache/geode/pull/5397#discussion_r464297701 ## File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java ## @@ -367,10 +367,12 @@ public void close(boolean