[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466751787 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466751011 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466748307 ## File path: cppcache/src/TcpConn.hpp ## @@ -65,75 +62,33 @@ class APACHE_GEODE_EXPORT TcpConn : public Connector { virtual void

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466748099 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pdxcodemonkey commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466728135 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode] dschneider-pivotal opened a new pull request #5431: change memberDeparted to disconnect the connection

2020-08-06 Thread GitBox
dschneider-pivotal opened a new pull request #5431: URL: https://github.com/apache/geode/pull/5431 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] bschuchardt merged pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()

2020-08-06 Thread GitBox
bschuchardt merged pull request #5422: URL: https://github.com/apache/geode/pull/5422 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] Bill commented on a change in pull request #5422: GEODE-6950: hot loop in PrimaryHandler.processRequest()

2020-08-06 Thread GitBox
Bill commented on a change in pull request #5422: URL: https://github.com/apache/geode/pull/5422#discussion_r466543551 ## File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/locator/PrimaryHandler.java ## @@ -39,9 +39,17 @@

[GitHub] [geode] agingade commented on a change in pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-06 Thread GitBox
agingade commented on a change in pull request #5424: URL: https://github.com/apache/geode/pull/5424#discussion_r466584837 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache30/ClientServerCacheOperationDUnitTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed

[GitHub] [geode] jivthesh opened a new pull request #5430: added code of conduct to project

2020-08-06 Thread GitBox
jivthesh opened a new pull request #5430: URL: https://github.com/apache/geode/pull/5430 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-06 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r466542979 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBeanBridge.java ## @@ -334,4 +334,8 @@ public boolean

[GitHub] [geode] bschuchardt merged pull request #5428: GEODE-8407: MergeLogFiles fails to include files with the same name b…

2020-08-06 Thread GitBox
bschuchardt merged pull request #5428: URL: https://github.com/apache/geode/pull/5428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-06 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-669938261 With the new integration test it is possible to reproduce the problem and ensure it is solved. These two logs messages can be found on test log: ```

[GitHub] [geode] lgtm-com[bot] commented on pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-06 Thread GitBox
lgtm-com[bot] commented on pull request #5348: URL: https://github.com/apache/geode/pull/5348#issuecomment-669908975 This pull request **introduces 1 alert** when merging 3f749fa776d4f79a637e1851a8c23ceb3eec2565 into eb8668ad7caa6e20d9be242ad719e173ebf244d8 - [view on

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-06 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r466370988 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartGatewaySenderCommand.java ## @@ -155,4 +160,38 @@ public