[GitHub] [geode] DonalEvans commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-12 Thread GitBox
DonalEvans commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r469611803 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java ## @@ -378,8 +378,11 @@ void doClear(RegionEventImpl

[GitHub] [geode] Bill merged pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

2020-08-12 Thread GitBox
Bill merged pull request #5409: URL: https://github.com/apache/geode/pull/5409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [geode] mhansonp merged pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp merged pull request #5447: URL: https://github.com/apache/geode/pull/5447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [geode] jchen21 commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
jchen21 commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469584716 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java ## @@ -497,7 +497,7 @@ public void run() {

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #134: Re-submit: allow other AMI purposes to be launched by benchmarks launch_cluster

2020-08-12 Thread GitBox
rhoughton-pivot opened a new pull request #134: URL: https://github.com/apache/geode-benchmarks/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-12 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r469576684 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-12 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r469576129 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] kirklund commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-08-12 Thread GitBox
kirklund commented on pull request #5382: URL: https://github.com/apache/geode/pull/5382#issuecomment-673128651 I don't have time for this PR. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [geode] kirklund closed pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-08-12 Thread GitBox
kirklund closed pull request #5382: URL: https://github.com/apache/geode/pull/5382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [geode] mhansonp closed pull request #5448: Changes to help reduce the occurence of GEODE-8422 for support 1.13

2020-08-12 Thread GitBox
mhansonp closed pull request #5448: URL: https://github.com/apache/geode/pull/5448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [geode] kirklund opened a new pull request #5451: DRAFT: GEODE-8425: Add new handling netsearch statistics

2020-08-12 Thread GitBox
kirklund opened a new pull request #5451: URL: https://github.com/apache/geode/pull/5451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [geode] mhansonp commented on pull request #5448: Changes to help reduce the occurence of GEODE-8422 for support 1.13

2020-08-12 Thread GitBox
mhansonp commented on pull request #5448: URL: https://github.com/apache/geode/pull/5448#issuecomment-673128283 Unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554888 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.internal.ca

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554313 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.internal.ca

[GitHub] [geode] sabbeyPivotal opened a new pull request #5450: GEODE-8428: Update geode-redis README

2020-08-12 Thread GitBox
sabbeyPivotal opened a new pull request #5450: URL: https://github.com/apache/geode/pull/5450 Update geode-redis README with a short explanation of how to run a Geode server that accepts Redis commands. This is an automated

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469538956 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.internal.ca

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
onichols-pivotal commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469534578 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.int

[GitHub] [geode] DonalEvans commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
DonalEvans commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469471781 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package org.apache.geode.internal.

[GitHub] [geode-native] moleske edited a comment on pull request #632: Enforce warning no-shorten-64-to-32

2020-08-12 Thread GitBox
moleske edited a comment on pull request #632: URL: https://github.com/apache/geode-native/pull/632#issuecomment-672965675 > Looks like it got fixed along the way! It's nice when that happens! Only wish I could give the right people credit! -

[GitHub] [geode-benchmarks] rhoughton-pivot merged pull request #133: Revert "allow AMI picking with arbitrary username accounts"

2020-08-12 Thread GitBox
rhoughton-pivot merged pull request #133: URL: https://github.com/apache/geode-benchmarks/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #133: Revert "allow AMI picking with arbitrary username accounts"

2020-08-12 Thread GitBox
rhoughton-pivot opened a new pull request #133: URL: https://github.com/apache/geode-benchmarks/pull/133 Reverts apache/geode-benchmarks#132 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [geode-benchmarks] rhoughton-pivot merged pull request #132: allow AMI picking with arbitrary username accounts

2020-08-12 Thread GitBox
rhoughton-pivot merged pull request #132: URL: https://github.com/apache/geode-benchmarks/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode-native] moleske commented on pull request #632: Enforce warning no-shorten-64-to-32

2020-08-12 Thread GitBox
moleske commented on pull request #632: URL: https://github.com/apache/geode-native/pull/632#issuecomment-672965675 > Looks like it got fixed along the way! It's nice when that happens! Only wish I could give the right people credit!

[GitHub] [geode] dschneider-pivotal merged pull request #5449: GEODE-8423: Updates Redis API for Geode docs 1.13

2020-08-12 Thread GitBox
dschneider-pivotal merged pull request #5449: URL: https://github.com/apache/geode/pull/5449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-12 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r469063060 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148 @