[GitHub] [geode] onichols-pivotal opened a new pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-17 Thread GitBox
onichols-pivotal opened a new pull request #5462: URL: https://github.com/apache/geode/pull/5462 This used to work but was broken recently by changes to rely exclusively on product version. Although Geode releases were never impacted, loss of this feature causes quite a headache for

[GitHub] [geode] onichols-pivotal merged pull request #5461: Revert "GEODE-8432: use regionPath directly instead of getRegion when…

2020-08-17 Thread GitBox
onichols-pivotal merged pull request #5461: URL: https://github.com/apache/geode/pull/5461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] gesterzhou opened a new pull request #5461: Revert "GEODE-8432: use regionPath directly instead of getRegion when…

2020-08-17 Thread GitBox
gesterzhou opened a new pull request #5461: URL: https://github.com/apache/geode/pull/5461 … put eve… (#5459)" This reverts commit 8021084e4fdb4e03ef8495a190cc1618a6db67ba. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-17 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r471800583 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-17 Thread GitBox
onichols-pivotal commented on a change in pull request #5458: URL: https://github.com/apache/geode/pull/5458#discussion_r471786376 ## File path: ci/images/google-geode-builder/scripts/setup.sh ## @@ -57,7 +59,9 @@ DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-17 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5458: URL: https://github.com/apache/geode/pull/5458#discussion_r471726677 ## File path: ci/images/test-container/Dockerfile ## @@ -48,6 +50,10 @@ RUN apt-get update \ && apt-get install -y --no-install-recommends \

[GitHub] [geode-native] mmartell opened a new pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-17 Thread GitBox
mmartell opened a new pull request #634: URL: https://github.com/apache/geode-native/pull/634 This adds a new .NET API to the nativeclient to support SNI. Notes: - This ticket usurps GEODE-8156. Since we need the new SetSniProxy API to run the test, we'll use this GEODE-8398 f

[GitHub] [geode-native] pdxcodemonkey merged pull request #632: GEODE-8426: Enforce warning no-shorten-64-to-32

2020-08-17 Thread GitBox
pdxcodemonkey merged pull request #632: URL: https://github.com/apache/geode-native/pull/632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] mivanac opened a new pull request #5460: GEODE-8433: added inheritance of off-heap attribute

2020-08-17 Thread GitBox
mivanac opened a new pull request #5460: URL: https://github.com/apache/geode/pull/5460 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all change

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-17 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-674947497 Hi @moleske @echobravopapa @pivotal-jbarrett , is there anything else missing to approve this PR? This is

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-17 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-674786552 > Hello @mkevo , > > I've manually copied and executed the test `OfflineDiskStoreCommandsDUnitTest.testThreadHangWithOfflineDiskStoreCommands()` locally on the current `devel