gesterzhou commented on a change in pull request #5492:
URL: https://github.com/apache/geode/pull/5492#discussion_r481718727
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##
@@ -755,12 +755,16 @@ public bool
gesterzhou commented on a change in pull request #5492:
URL: https://github.com/apache/geode/pull/5492#discussion_r481718201
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##
@@ -755,12 +755,16 @@ public bool
moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r481562738
##
File path: tests/cpp/security/XmlAuthzCredentialGenerator.hpp
##
@@ -55,7 +55,7 @@ const opCodeList::value_type QArr[] = {OP_QUERY,
OP_REGISTER_CQ}
moleske commented on pull request #647:
URL: https://github.com/apache/geode-native/pull/647#issuecomment-685231238
> I think geode-native is sorely lacking in documentation on how to use the
new test frameworks
For this PR, I think just a one liner mentioning they exist is a good
mmartell commented on pull request #647:
URL: https://github.com/apache/geode-native/pull/647#issuecomment-685222727
> I'm excited about this! It seems like there is a new category of
`acceptance-test`. There should be an update to CONTRIBUTING.md to make sure
that contributors run tests i
moleske edited a comment on pull request #647:
URL: https://github.com/apache/geode-native/pull/647#issuecomment-685198557
I'm excited about this! It seems like there is a new category of
`acceptance-test`. There should be an update to CONTRIBUTING.md to make sure
that contributors run t
moleske commented on pull request #647:
URL: https://github.com/apache/geode-native/pull/647#issuecomment-685198557
I'm excited about this! It seems like there is a new category of
`acceptance-test`. Not sure when difference between integration and acceptance
is (I think it is just does
mhansonp commented on a change in pull request #5436:
URL: https://github.com/apache/geode/pull/5436#discussion_r481498899
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java
##
@@ -0,0 +1,374 @@
+/*
+ * Li
mhansonp commented on a change in pull request #5436:
URL: https://github.com/apache/geode/pull/5436#discussion_r481498183
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java
##
@@ -0,0 +1,374 @@
+/*
+ * Li
mhansonp commented on a change in pull request #5436:
URL: https://github.com/apache/geode/pull/5436#discussion_r481498183
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java
##
@@ -0,0 +1,374 @@
+/*
+ * Li
mhansonp commented on pull request #5436:
URL: https://github.com/apache/geode/pull/5436#issuecomment-685193313
I made some updates on mhansonp minorcleanup to resolve warnings.
This is an automated message from the Apache Gi
mmartell opened a new pull request #647:
URL: https://github.com/apache/geode-native/pull/647
This PR cleans up our docker based SNITests. In particular:
- SNITests are now enabled during cmake configuration based on whether
docker and docker-compose are installed.
- SNITests have
moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359
##
File path: cppcache/integration-test/fw_dunit.cpp
##
@@ -71,10 +71,10 @@ using
apache::geode::client::testframework::BBNamingContextServer;
#defin
moleske commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359
##
File path: cppcache/integration-test/fw_dunit.cpp
##
@@ -71,10 +71,10 @@ using
apache::geode::client::testframework::BBNamingContextServer;
#defin
boglesby opened a new pull request #5494:
URL: https://github.com/apache/geode/pull/5494
…handle exceptions
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken
pivotal-jbarrett commented on a change in pull request #645:
URL: https://github.com/apache/geode-native/pull/645#discussion_r481354457
##
File path: cppcache/benchmark/GeodeLoggingBM.cpp
##
@@ -106,13 +106,13 @@ void GeodeLogToFile(benchmark::State& state) {
}
}
-auto Lo
demery-pivotal opened a new pull request #5493:
URL: https://github.com/apache/geode/pull/5493
Removed the following unused methods:
- getRandomAvailableTCPPortRange(int)
- getRandomAvailableTCPPorts(int,bool)
- getRandomAvailableTCPPortRangeKeepers(int)
- getRandomAvailableTCPPo
demery-pivotal closed pull request #5471:
URL: https://github.com/apache/geode/pull/5471
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
agingade commented on a change in pull request #5492:
URL: https://github.com/apache/geode/pull/5492#discussion_r481287853
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##
@@ -755,12 +755,16 @@ public boolea
bschuchardt closed pull request #5363:
URL: https://github.com/apache/geode/pull/5363
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
bschuchardt merged pull request #5490:
URL: https://github.com/apache/geode/pull/5490
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
mkevo merged pull request #5476:
URL: https://github.com/apache/geode/pull/5476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
22 matches
Mail list logo
