[GitHub] [geode] jchen21 merged pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-11 Thread GitBox
jchen21 merged pull request #5503: URL: https://github.com/apache/geode/pull/5503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] sabbeyPivotal opened a new pull request #5508: GEODE-8490: Docker containers are not properly cleaned up after native Redis acceptance tests

2020-09-11 Thread GitBox
sabbeyPivotal opened a new pull request #5508: URL: https://github.com/apache/geode/pull/5508 - Created a test rule (NativeRedisTestRule) to properly close and clean up all Docker containers created by the native Redis acceptance tests

[GitHub] [geode] jchen21 commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-11 Thread GitBox
jchen21 commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487218213 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode-native] echobravopapa commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-11 Thread GitBox
echobravopapa commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r487163729 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); }

[GitHub] [geode] jinmeiliao opened a new pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-11 Thread GitBox
jinmeiliao opened a new pull request #5507: URL: https://github.com/apache/geode/pull/5507 …or jackson json annotations * null value fields are serialized as well * move QueryResultFormatterTest to core This is an

[GitHub] [geode] agingade commented on a change in pull request #5397: GEODE-8293: fix decrementing activeCQCount

2020-09-11 Thread GitBox
agingade commented on a change in pull request #5397: URL: https://github.com/apache/geode/pull/5397#discussion_r487138399 ## File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java ## @@ -367,10 +367,12 @@ public void close(boolean

[GitHub] [geode] agingade commented on a change in pull request #5397: GEODE-8293: fix decrementing activeCQCount

2020-09-11 Thread GitBox
agingade commented on a change in pull request #5397: URL: https://github.com/apache/geode/pull/5397#discussion_r487137679 ## File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java ## @@ -367,10 +367,12 @@ public void close(boolean

[GitHub] [geode] agingade commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-11 Thread GitBox
agingade commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487130937 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode] albertogpz commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-09-11 Thread GitBox
albertogpz commented on a change in pull request #5486: URL: https://github.com/apache/geode/pull/5486#discussion_r486970934 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1138,7 +1153,7 @@ int

[GitHub] [geode] albertogpz commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-09-11 Thread GitBox
albertogpz commented on a change in pull request #5486: URL: https://github.com/apache/geode/pull/5486#discussion_r486970379 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode-native] alb3rtobr commented on pull request #648: GEODE-8480: Add txmanager check in tx example

2020-09-11 Thread GitBox
alb3rtobr commented on pull request #648: URL: https://github.com/apache/geode-native/pull/648#issuecomment-690971310 I was running a test consisting on killing a Geode server while a C++ client with several threads was executing transactions. I observed that most of the times, the client