[GitHub] [geode] onichols-pivotal merged pull request #5502: add 1.13.0 to old versions and set as Benchmarks baseline on develop

onichols-pivotal merged pull request #5502: URL: https://github.com/apache/geode/pull/5502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] Bill commented on pull request #5502: add 1.13.0 to old versions and set as Benchmarks baseline on develop

Bill commented on pull request #5502: URL: https://github.com/apache/geode/pull/5502#issuecomment-692404304 @jinmeiliao told me that management rest service is started by default in version 1.13.0, in earlier versions no rest service is started by default. So with her approval, and

[GitHub] [geode-native] echobravopapa commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

echobravopapa commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r488291301 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); }

[GitHub] [geode] Bill edited a comment on pull request #5502: add 1.13.0 to old versions and set as Benchmarks baseline on develop

Bill edited a comment on pull request #5502: URL: https://github.com/apache/geode/pull/5502#issuecomment-690783716 I've added @bschuchardt and @jinmeiliao as a reviewers since I want to be sure I'm not masking an actual problem by turning off the HTTP service in the WAN and Lucene rolling

[GitHub] [geode] sabbeyPivotal opened a new pull request #5511: GEODE-8493: Redis idle clients can cause server stuck thread warning

sabbeyPivotal opened a new pull request #5511: URL: https://github.com/apache/geode/pull/5511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

sabbeyPivotal commented on a change in pull request #5510: URL: https://github.com/apache/geode/pull/5510#discussion_r488191271 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java ## @@ -177,6 +177,10 @@ public void removeClient() {

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

dschneider-pivotal commented on a change in pull request #5510: URL: https://github.com/apache/geode/pull/5510#discussion_r488188475 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java ## @@ -177,6 +177,10 @@ public void removeClient() {

[GitHub] [geode] sabbeyPivotal opened a new pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

sabbeyPivotal opened a new pull request #5510: URL: https://github.com/apache/geode/pull/5510 When running a long running app, we noticed that our "clients" statistic was negative. It should always be greater than or equal to 0. It seems like the call to decrement the number of

[GitHub] [geode-native] mreddington commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

mreddington commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r488181280 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); } +#if

[GitHub] [geode-native] dgkimura commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

dgkimura commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r488167540 ## File path: cppcache/benchmark/GeodeLoggingBM.cpp ## @@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash; const int

[GitHub] [geode] DonalEvans commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

DonalEvans commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r488130840 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -1646,6 +1646,20 @@ public static void

[GitHub] [geode] dschneider-pivotal merged pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees

dschneider-pivotal merged pull request #5505: URL: https://github.com/apache/geode/pull/5505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal merged pull request #5508: GEODE-8490: Docker containers are not properly cleaned up after native Redis acceptance tests

jdeppe-pivotal merged pull request #5508: URL: https://github.com/apache/geode/pull/5508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] moleske commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test

moleske commented on a change in pull request #649: URL: https://github.com/apache/geode-native/pull/649#discussion_r488065099 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -52,6 +52,8 @@ class SNITest : public ::testing::Test { ~SNITest() override = default;

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r488063324 ## File path: cppcache/benchmark/GeodeLoggingBM.cpp ## @@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash; const int

[GitHub] [geode-native] moleske commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

moleske commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-692164352 @echobravopapa as mentioned in the initial blurb up top, I do not have easy access to a useful windows machine to debug, but the PR was generally working. In that blurb, I

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r488052139 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

gesterzhou commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r488039326 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode] sabbeyPivotal commented on pull request #5508: GEODE-8490: Docker containers are not properly cleaned up after native Redis acceptance tests

sabbeyPivotal commented on pull request #5508: URL: https://github.com/apache/geode/pull/5508#issuecomment-692050033 Distributed test failure is unrelated to this PR. This is an automated message from the Apache Git Service.